From: maciozo <maciozo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: ltfs-2.4.6.1
Date: Sun, 16 Jun 2024 22:56:30 +0200 [thread overview]
Message-ID: <20240616205630.7157C2BC64@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50845@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]
New comment by maciozo on void-packages repository
https://github.com/void-linux/void-packages/pull/50845#issuecomment-2171875052
Comment:
Thank you so much for your help so far on this, @classabbyamp.
I tried applying the patch you suggested on IRC (https://github.com/LinearTapeFileSystem/ltfs/commit/2db929b5fc641fbeccb06ba38b3c7e3d4f25a86c).
It no longer works with the current `configure.ac`, so I modified it slightly:
```patch
--- a/configure.ac 2024-06-16 21:48:51.744301806 +0100
+++ b/configure.ac 2024-06-16 21:49:23.842374377 +0100
@@ -337,8 +337,8 @@
dnl
dnl Check for ICU
dnl
-ICU_MODULE_CFLAGS="`icu-config --cppflags 2> /dev/null`";
-ICU_MODULE_LIBS="`icu-config --ldflags 2> /dev/null`";
+ICU_MODULE_CFLAGS="`pkg-config --cflags icu-i18n 2> /dev/null`";
+ICU_MODULE_LIBS="`pkg-config --libs icu-i18n 2> /dev/null`";
if test -z "$ICU_MODULE_LIBS"
then
PKG_CHECK_MODULES([ICU_MODULE], [icu >= 0.21])
@@ -352,16 +352,9 @@
)
AC_MSG_RESULT([$icu_6x])
-if test "x${icu_6x}" = "xyes"
-then
- AC_MSG_CHECKING(for ICU version)
- ICU_MODULE_VERSION="`icu-config --version 2> /dev/null`";
- if test "${ICU_MODULE_VERSION%%.*}" -ge "60"
- then
- AM_EXTRA_CPPFLAGS="${AM_EXTRA_CPPFLAGS} -D ICU6x"
- fi
- AC_MSG_RESULT([$ICU_MODULE_VERSION])
-fi
+AC_MSG_CHECKING(for ICU version)
+ICU_MODULE_VERSION="`pkg-config --modversion icu-i18n 2> /dev/null`";
+AC_MSG_RESULT([$ICU_MODULE_VERSION])
dnl
dnl Check for SNMP
```
Unfortunately, this still results in the same error.
I did also try without removing the whole `if` statement around the assignment of `ICU_MODULE_VERSION`, but the result was the same.
Would it be possible to make it so that this package gets built in qemu, rather than cross-compiling?
It might just be a simpler way out.
next prev parent reply other threads:[~2024-06-16 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 2:39 [PR PATCH] " maciozo
2024-06-16 14:23 ` [PR PATCH] [Updated] " maciozo
2024-06-16 14:26 ` maciozo
2024-06-16 14:43 ` maciozo
2024-06-16 14:43 ` maciozo
2024-06-16 20:56 ` maciozo [this message]
2024-06-16 21:01 ` classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240616205630.7157C2BC64@inbox.vuxu.org \
--to=maciozo@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).