Re: [PR PATCH] [Updated] New package: liquidctl-1.13.0

[gmbeard <gmbeard@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

There is an updated pull request by gmbeard against master on the void-packages repository

https://github.com/gmbeard/void-packages liquidctl
https://github.com/void-linux/void-packages/pull/49314

New package: liquidctl-1.13.0
Cross-platform tool and drivers for liquid coolers and other devices

<https://github.com/liquidctl/liquidctl>

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

This PR also contains the following new dependency packages, which I'm happy to maintain:
- `python3-hidapi`
- `python3-colorlog`

`python3-hidapi` is marked as conflicting with `python3-hid` due to an unfortunate namespace conflict (<https://github.com/qmk/qmk_cli/issues/82>)


A patch file from https://github.com/void-linux/void-packages/pull/49314.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liquidctl-49314.patch --]
[-- Type: text/x-diff, Size: 5018 bytes --]

From 4cc24b5e14f803391fbb2b9561317a03ee08f087 Mon Sep 17 00:00:00 2001
From: Greg Beard <gmbeard@googlemail.com>
Date: Sat, 16 Mar 2024 08:58:15 +0000
Subject: [PATCH 1/2] New package: python3-hidapi-0.14.0

---
 srcpkgs/python3-hidapi/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-hidapi/template

diff --git a/srcpkgs/python3-hidapi/template b/srcpkgs/python3-hidapi/template
new file mode 100644
index 00000000000000..9de2885b7043fd
--- /dev/null
+++ b/srcpkgs/python3-hidapi/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-hidapi'
+pkgname=python3-hidapi
+version=0.14.0
+revision=1
+build_style=python3-module
+make_build_args="--with-system-hidapi"
+make_check_args="--with-system-hidapi"
+make_install_args="--with-system-hidapi"
+hostmakedepends="hidapi-devel python3-Cython0.29 python3-setuptools python3-wheel"
+makedepends="hidapi-devel libusb-devel python3-devel eudev-libudev-devel"
+depends="libusb hidapi"
+short_desc="Cython interface to HIDAPI library"
+maintainer="Greg Beard <gmbeard@googlemail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/trezor/cython-hidapi"
+distfiles="${homepage}/archive/refs/tags/${version}.tar.gz"
+checksum=211b0cb99b1f9724f3d1b09d198d764b7eca77514ae86584e3f3ce872aefff51
+conflicts="python3-hid>=0"

From c5822fc5c5b6c3e9031b53c054146d2582d5e22b Mon Sep 17 00:00:00 2001
From: Greg Beard <gmbeard@googlemail.com>
Date: Sat, 16 Mar 2024 08:59:18 +0000
Subject: [PATCH 2/2] New package: liquidctl-1.13.0

---
 .../patches/0001-fix-broken-test.patch        | 38 +++++++++++++++++++
 srcpkgs/liquidctl/template                    | 26 +++++++++++++
 2 files changed, 64 insertions(+)
 create mode 100644 srcpkgs/liquidctl/patches/0001-fix-broken-test.patch
 create mode 100644 srcpkgs/liquidctl/template

diff --git a/srcpkgs/liquidctl/patches/0001-fix-broken-test.patch b/srcpkgs/liquidctl/patches/0001-fix-broken-test.patch
new file mode 100644
index 00000000000000..a03bdc858c7bf6
--- /dev/null
+++ b/srcpkgs/liquidctl/patches/0001-fix-broken-test.patch
@@ -0,0 +1,38 @@
+From c50afa4e610bd2e268e85c347e2644794c817a78 Mon Sep 17 00:00:00 2001
+From: Jonas Malaco <jonas@protocubo.io>
+Date: Thu, 11 Jan 2024 12:58:52 -0300
+Subject: [PATCH] kraken3: split smoke tests and disable GIF part due to #661
+
+---
+ tests/test_kraken3.py | 11 ++++++++++-
+ 1 file changed, 10 insertions(+), 1 deletion(-)
+
+diff --git a/tests/test_kraken3.py b/tests/test_kraken3.py
+index 5feb31a6..4c8aaa2b 100644
+--- a/tests/test_kraken3.py
++++ b/tests/test_kraken3.py
+@@ -539,13 +539,22 @@ def test_krakenz3_not_totally_broken(mock_krakenz3):
+     mock_krakenz3.set_speed_profile(channel="fan", profile=iter([(20, 20), (30, 50), (40, 100)]))
+     mock_krakenz3.set_fixed_speed(channel="pump", duty=50)
+ 
+-    # set_screen should be the last set of functions called
++
++def test_krakenz3_screen_not_totally_broken(mock_krakenz3):
++    """Reasonable example calls to untested APIs do not raise exceptions."""
++    mock_krakenz3.initialize()
+     mock_krakenz3.set_screen("lcd", "liquid", None)
+     mock_krakenz3.set_screen("lcd", "brightness", "60")
+     mock_krakenz3.set_screen("lcd", "orientation", "90")
+     mock_krakenz3.set_screen(
+         "lcd", "static", os.path.join(os.path.dirname(os.path.abspath(__file__)), "yellow.jpg")
+     )
++
++
++@pytest.mark.skip("Currently broken with pillow >= 10.2.0 (see #661)")
++def test_krakenz3_screen_not_totally_broken_part2(mock_krakenz3):
++    """Reasonable example calls to untested APIs do not raise exceptions."""
++    mock_krakenz3.initialize()
+     mock_krakenz3.set_screen(
+         "lcd", "gif", os.path.join(os.path.dirname(os.path.abspath(__file__)), "rgb.gif")
+     )
+
diff --git a/srcpkgs/liquidctl/template b/srcpkgs/liquidctl/template
new file mode 100644
index 00000000000000..11e797c145f2a2
--- /dev/null
+++ b/srcpkgs/liquidctl/template
@@ -0,0 +1,26 @@
+# Template file for 'liquidctl'
+pkgname=liquidctl
+version=1.13.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-wheel python3-setuptools_scm"
+depends="hidapi libusb python3-Pillow python3-crcmod python3-docopt python3-smbus
+python3-usb python3-hidapi python3-colorlog"
+checkdepends="python3-pytest ${depends}"
+short_desc="Cross-platform tool and drivers for liquid coolers and other devices"
+maintainer="Greg Beard <gmbeard@googlemail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/liquidctl/liquidctl"
+distfiles="${homepage}/releases/download/v${version}/liquidctl-${version}.tar.gz"
+checksum=ee17241689c0bf3de43cf4d97822e344f5b57513d16dd160e37fa0e389a158c7
+
+post_install() {
+	vman liquidctl.8
+	for d in $(find docs -maxdepth 1 -type f -name '*.md'); do
+		vinstall "${d}" 644 "/usr/share/doc/${pkgname}"
+	done
+	for d in $(find docs/linux -maxdepth 1 -type f -name '*.md'); do
+		vinstall "${d}" 644 "/usr/share/doc/${pkgname}/linux"
+	done
+	vinstall extra/linux/71-liquidctl.rules 644 /usr/lib/udev/rules.d
+}