Github messages for voidlinux
 help / color / mirror / Atom feed
From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: libcurl-devel should depend on libunistring-devel for static linking
Date: Tue, 25 Jun 2024 05:28:21 +0200	[thread overview]
Message-ID: <20240625032821.EB3C6262B7@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50980@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/issues/50980#issuecomment-2187869747

Comment:
> Cool. The package dependency part remains.

`libcurl-devel` should not pull in `libunistring-devel` because libcurl does not depend on libunistring (static or not).
It is `libidn2-devel` that statically depends on `libunistring-devel`. (so the `depends=` would be added to `libidn2-devel`)

Also, in general we don't list static linking dependencies in packages with some exceptions (e.g. glib for qemu-user-static or incidentally because the dependencies headers are included in public headers). Not sure if curl is an exception though.

If so, the fix for that would be adding libunistring-devel to here: https://github.com/void-linux/void-packages/blob/master/srcpkgs/libidn2/template#L17

  parent reply	other threads:[~2024-06-25  3:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  2:04 [ISSUE] " MoSal
2024-06-25  2:25 ` oreo639
2024-06-25  2:32 ` MoSal
2024-06-25  3:10 ` oreo639
2024-06-25  3:13 ` oreo639
2024-06-25  3:15 ` oreo639
2024-06-25  3:19 ` oreo639
2024-06-25  3:19 ` oreo639
2024-06-25  3:20 ` oreo639
2024-06-25  3:22 ` MoSal
2024-06-25  3:23 ` oreo639
2024-06-25  3:23 ` oreo639
2024-06-25  3:24 ` oreo639
2024-06-25  3:24 ` oreo639
2024-06-25  3:27 ` oreo639
2024-06-25  3:27 ` oreo639
2024-06-25  3:27 ` oreo639
2024-06-25  3:28 ` oreo639 [this message]
2024-06-25  3:29 ` oreo639
2024-06-25  3:29 ` oreo639
2024-06-25  3:29 ` MoSal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625032821.EB3C6262B7@inbox.vuxu.org \
    --to=oreo639@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).