From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] ergo: update to 2.13.1, rename from oragono.
Date: Tue, 25 Jun 2024 14:31:00 +0200 [thread overview]
Message-ID: <20240625123100.D379A2648B@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45805@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/45805#discussion_r1652719441
Comment:
Isn't this going to result in a broken default configuration? There are no certificates installed in `/var/lib/ergo`. If so, I recommend dropping this patch entirely and shipping this as an example only. Alternatively, modify the configuration to disable TLS in the default, and let users configure it.
next prev parent reply other threads:[~2024-06-25 12:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 23:53 [PR PATCH] ergo: update to 2.11.1, " chilledfrogs
2023-11-27 1:46 ` github-actions
2023-11-30 21:08 ` chilledfrogs
2024-03-01 1:46 ` github-actions
2024-03-01 11:52 ` [PR PATCH] [Updated] " chilledfrogs
2024-04-07 22:17 ` chilledfrogs
2024-05-06 21:29 ` [PR PATCH] [Updated] ergo: update to 2.13.0, " chilledfrogs
2024-06-22 0:31 ` [PR REVIEW] ergo: update to 2.13.1, " classabbyamp
2024-06-22 21:17 ` [PR PATCH] [Updated] " chilledfrogs
2024-06-25 12:31 ` [PR REVIEW] " ahesford
2024-06-25 12:31 ` ahesford
2024-06-25 12:31 ` ahesford [this message]
2024-06-25 12:31 ` ahesford
2024-06-26 7:14 ` chilledfrogs
2024-06-26 10:42 ` [PR REVIEW] oragono: rename to ergo, update to 2.13.1 ahesford
2024-06-27 18:20 ` [PR PATCH] [Updated] " chilledfrogs
2024-06-27 18:23 ` chilledfrogs
2024-06-27 18:30 ` [PR REVIEW] " classabbyamp
2024-06-27 18:31 ` classabbyamp
2024-06-27 18:34 ` classabbyamp
2024-06-27 18:39 ` classabbyamp
2024-06-27 18:39 ` classabbyamp
2024-06-28 21:29 ` chilledfrogs
2024-06-28 21:30 ` chilledfrogs
2024-06-28 21:37 ` classabbyamp
2024-06-28 21:40 ` ahesford
2024-06-28 23:01 ` [PR PATCH] [Updated] " chilledfrogs
2024-06-28 23:03 ` chilledfrogs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625123100.D379A2648B@inbox.vuxu.org \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).