[PR PATCH] gnome-online-accounts: add libadwaita-devel to subpkg's depends

[PR PATCH] gnome-online-accounts: add libadwaita-devel to subpkg's depends

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

There is a new pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages gnome-online-accounts
https://github.com/void-linux/void-packages/pull/51011

gnome-online-accounts: add libadwaita-devel to subpkg's depends
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86-64)

A patch file from https://github.com/void-linux/void-packages/pull/51011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-online-accounts-51011.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]

From 8f9fd5a52a2a6ab86edb8beb453200b3377be8f2 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Wed, 26 Jun 2024 12:58:28 +0300
Subject: [PATCH] gnome-online-accounts: add libadwaita-devel to subpkg's
 depends

---
 srcpkgs/gnome-online-accounts/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-online-accounts/template b/srcpkgs/gnome-online-accounts/template
index d5f2036fb6d38c..cb2c235f79fe6e 100644
--- a/srcpkgs/gnome-online-accounts/template
+++ b/srcpkgs/gnome-online-accounts/template
@@ -1,7 +1,7 @@
 # Template file for 'gnome-online-accounts'
 pkgname=gnome-online-accounts
 version=3.50.2
-revision=1
+revision=2
 build_style=meson
 build_helper="gir"
 configure_args="$(vopt_bool gir introspection) $(vopt_bool gir vapi)
@@ -24,7 +24,7 @@ build_options="gir"
 build_options_default="gir"
 
 gnome-online-accounts-devel_package() {
-	depends="gtk4-devel ${sourcepkg}>=${version}_${revision}"
+	depends="libadwaita-devel ${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: gnome-online-accounts: add libadwaita-devel to subpkg's depends

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/51011#issuecomment-2191326057

Comment:
Why, if you don't mind me asking?
gtk4-devel is required because it is included in public goa-devel headers, but I can't find `adw-*.h`/`adwaita.h` being included in public headers?

Re: gnome-online-accounts: add libadwaita-devel to subpkg's depends

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/51011#issuecomment-2191331735

Comment:
`Requires: goa-1.0, gtk4, libadwaita-1` in  `goa-backend-1.0.pc`

Re: gnome-online-accounts: add libadwaita-devel to subpkg's depends

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/51011#issuecomment-2191333203

Comment:
Thanks.

Re: [PR PATCH] [Merged]: gnome-online-accounts: add libadwaita-devel to subpkg's depends

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There's a merged pull request on the void-packages repository

gnome-online-accounts: add libadwaita-devel to subpkg's depends
https://github.com/void-linux/void-packages/pull/51011

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86-64)