From: Calandracas606 <Calandracas606@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] apparmor: fix build on musl, enable python on cross-compile
Date: Fri, 28 Jun 2024 00:47:48 +0200 [thread overview]
Message-ID: <20240627224748.92DD322D9E@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-51024@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
New review comment by Calandracas606 on void-packages repository
https://github.com/void-linux/void-packages/pull/51024#discussion_r1657895782
Comment:
> 1. this should probably be `-D_FILE_OFFSET_BITS=64 -DLARGEFILE_SOURCE=1`
I don't think so. In <sys/types.h>, `off64_t` is behind `#if defined(_LARGEFILE64_SOURCE)`
next prev parent reply other threads:[~2024-06-27 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 12:57 [PR PATCH] apparmor: fix build on musl Calandracas606
2024-06-27 13:09 ` [PR PATCH] [Updated] " Calandracas606
2024-06-27 13:31 ` [PR PATCH] [Updated] apparmor: fix build on musl, enable python on cross-compile Calandracas606
2024-06-27 13:46 ` Calandracas606
2024-06-27 13:52 ` Calandracas606
2024-06-27 14:16 ` Calandracas606
2024-06-27 14:17 ` Calandracas606
2024-06-27 22:31 ` [PR REVIEW] " classabbyamp
2024-06-27 22:32 ` classabbyamp
2024-06-27 22:47 ` Calandracas606 [this message]
2024-06-28 2:42 ` [PR PATCH] [Updated] " Calandracas606
2024-06-28 2:57 ` Calandracas606
2024-06-28 3:00 ` Calandracas606
2024-07-02 6:52 ` [PR PATCH] [Closed]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627224748.92DD322D9E@inbox.vuxu.org \
--to=calandracas606@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).