Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] alot: update to 0.10.
@ 2024-06-28  5:49 Vinfall
  2024-06-28  5:57 ` Vinfall
  2024-06-28 12:05 ` [PR PATCH] [Merged]: " sgn
  0 siblings, 2 replies; 3+ messages in thread
From: Vinfall @ 2024-06-28  5:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]

There is a new pull request by Vinfall against master on the void-packages repository

https://github.com/Vinfall/void-packages alot-update
https://github.com/void-linux/void-packages/pull/51031

alot: update to 0.10.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

I did not test sending email as I use alot as a read-only notmuch email reader.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - armv7l-musl (crossbuild)

A few notes:
- Old patch is removed as 0.10 already contains the changes
- New `hostmakedepends` are required to build docs, `depends` updated as per [0.10 release note](https://github.com/pazz/alot/releases/tag/0.10)

A patch file from https://github.com/void-linux/void-packages/pull/51031.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-alot-update-51031.patch --]
[-- Type: text/x-diff, Size: 4277 bytes --]

From 46642fdeeb9123a894df864c8fa1230620ce74a1 Mon Sep 17 00:00:00 2001
From: Vinfall <neptuniahuai0tc@riseup.net>
Date: Fri, 28 Jun 2024 13:41:54 +0800
Subject: [PATCH] alot: update to 0.10.

---
 ...ix-mailcap-rendering-no-content-type.patch | 65 -------------------
 srcpkgs/alot/template                         | 10 +--
 2 files changed, 5 insertions(+), 70 deletions(-)
 delete mode 100644 srcpkgs/alot/patches/fix-mailcap-rendering-no-content-type.patch

diff --git a/srcpkgs/alot/patches/fix-mailcap-rendering-no-content-type.patch b/srcpkgs/alot/patches/fix-mailcap-rendering-no-content-type.patch
deleted file mode 100644
index e1aec812a58c50..00000000000000
--- a/srcpkgs/alot/patches/fix-mailcap-rendering-no-content-type.patch
+++ /dev/null
@@ -1,65 +0,0 @@
-From 0339a33818adc6fc33e83336f9eea289d5e7e893 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?M=C4=81rti=C5=86=C5=A1=20Ma=C4=8Ds?= <martins.macs@bi.lv>
-Date: Tue, 19 May 2020 13:48:17 +0300
-Subject: [PATCH] Fix mailcap rendering for e-mails without `Content-Type`
- header
-
-`get_params()` returns `None` when the header is missing. Use `failobj`
-argument to mitigate that.
-
-Fixes #1512
----
- alot/db/utils.py            |  2 +-
- tests/db/test_utils.py      | 10 ++++++++++
- tests/static/mail/basic.eml |  5 +++++
- 3 files changed, 16 insertions(+), 1 deletion(-)
- create mode 100644 tests/static/mail/basic.eml
-
-diff --git a/alot/db/utils.py b/alot/db/utils.py
-index 27c85942..e55768b1 100644
---- a/alot/db/utils.py
-+++ b/alot/db/utils.py
-@@ -365,7 +365,7 @@ def render_part(part, field_key='copiousoutput'):
-             stdin = raw_payload
- 
-         # read parameter, create handler command
--        parms = tuple('='.join(p) for p in part.get_params())
-+        parms = tuple('='.join(p) for p in part.get_params(failobj=[]))
- 
-         # create and call external command
-         cmd = mailcap.subst(entry['view'], ctype,
-diff --git a/tests/db/test_utils.py b/tests/db/test_utils.py
-index 36ce77cf..40c2fb91 100644
---- a/tests/db/test_utils.py
-+++ b/tests/db/test_utils.py
-@@ -762,6 +762,16 @@ class TestExtractBodyPart(unittest.TestCase):
- 
-         self.assertEqual(actual, expected)
- 
-+    @mock.patch('alot.db.utils.settings.mailcap_find_match',
-+                mock.Mock(return_value=(None, {'view': 'cat'})))
-+    def test_plaintext_mailcap_wo_content_type(self):
-+        with open('tests/static/mail/basic.eml') as fp:
-+            mail = email.message_from_file(fp,
-+                    _class=email.message.EmailMessage)
-+        body_part = utils.get_body_part(mail)
-+        actual = utils.extract_body_part(body_part)
-+        expected = 'test body\n'
-+        self.assertEqual(actual, expected)
- 
- class TestRemoveCte(unittest.TestCase):
- 
-diff --git a/tests/static/mail/basic.eml b/tests/static/mail/basic.eml
-new file mode 100644
-index 00000000..95f15693
---- /dev/null
-+++ b/tests/static/mail/basic.eml
-@@ -0,0 +1,5 @@
-+From: me@localhost
-+To: you@localhost
-+Subject: test subject
-+
-+test body
--- 
-2.29.2
-
diff --git a/srcpkgs/alot/template b/srcpkgs/alot/template
index 8538b71ad3f194..1eb596387e3260 100644
--- a/srcpkgs/alot/template
+++ b/srcpkgs/alot/template
@@ -1,10 +1,10 @@
 # Template file for 'alot'
 pkgname=alot
-version=0.9.1
-revision=8
+version=0.10
+revision=1
 build_style=python3-module
-hostmakedepends="python3-setuptools python3-Sphinx"
-depends="python3-setuptools python3-Twisted notmuch-python3 python3-configobj
+hostmakedepends="python3-setuptools python3-Sphinx python3-notmuch2 python3-cffi"
+depends="python3-setuptools python3-Twisted python3-notmuch2 python3-configobj
  gpgme-python3 python3-magic python3-urwidtrees"
 checkdepends="$depends gnupg2 procps-ng python3-pytest"
 short_desc="Terminal-based mail user agent based on the notmuch mail indexer"
@@ -12,7 +12,7 @@ maintainer="Felix Van der Jeugt <felix.vanderjeugt@posteo.net>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/pazz/alot"
 distfiles="https://github.com/pazz/${pkgname}/archive/${version}.tar.gz"
-checksum=ee2c1ab1b43d022a8fe2078820ed57d8d72aec260a7d750776dac4ee841d1de4
+checksum=71f382aa751fb90fde1a06a0a4ba43628ee6aa6d41b5cd53c8701fd7c5ab6e6e
 
 do_check() {
 	pytest3 -k 'not test_no_spawn_no_stdin_attached'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: alot: update to 0.10.
  2024-06-28  5:49 [PR PATCH] alot: update to 0.10 Vinfall
@ 2024-06-28  5:57 ` Vinfall
  2024-06-28 12:05 ` [PR PATCH] [Merged]: " sgn
  1 sibling, 0 replies; 3+ messages in thread
From: Vinfall @ 2024-06-28  5:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51031#issuecomment-2196196623

Comment:
These should be safe to ignore (0.10 is released in 2021 and no newer tagged release since then), I'm not quite familiar with pytest. How am I supposed to ignore the warning?
```python
/usr/lib/python3.12/site-packages/notmuch2/_database.py:160: NoConfigError

alot/db/utils.py:15
  /builddir/alot-0.10/alot/db/utils.py:15: DeprecationWarning: The mailcap module is deprecated and will be removed in Python 3.13. See the mimetypes module for an alternative.
    import mailcap
````

I have no idea on `alot/db/manager.py:94: DatabaseLockedError` and other warnings.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: alot: update to 0.10.
  2024-06-28  5:49 [PR PATCH] alot: update to 0.10 Vinfall
  2024-06-28  5:57 ` Vinfall
@ 2024-06-28 12:05 ` sgn
  1 sibling, 0 replies; 3+ messages in thread
From: sgn @ 2024-06-28 12:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

There's a merged pull request on the void-packages repository

alot: update to 0.10.
https://github.com/void-linux/void-packages/pull/51031

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

I did not test sending email as I use alot as a read-only notmuch email reader.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - armv7l-musl (crossbuild)

A few notes:
- Old patch is removed as 0.10 already contains the changes
- New `hostmakedepends` are required to build docs, `depends` updated as per [0.10 release note](https://github.com/pazz/alot/releases/tag/0.10)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-28 12:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-28  5:49 [PR PATCH] alot: update to 0.10 Vinfall
2024-06-28  5:57 ` Vinfall
2024-06-28 12:05 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).