[PR PATCH] New package: golang-migrate-4.17.1

[PR PATCH] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

There is a new pull request by lpww against master on the void-packages repository

https://github.com/lpww/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/51014

New package: golang-migrate-4.17.1
### Description
This pr adds a new package, `golang-migrate v4.17.1`. It builds upon a [previous pull request](https://github.com/void-linux/void-packages/pull/30634) that works but was never merged. I just updated the version, checksum, and maintainer.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**


A patch file from https://github.com/void-linux/void-packages/pull/51014.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-51014.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]

From 3ebd5fc4275538d2ef48e80066d6d3cd70d5d0fc Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@nearform.com>
Date: Wed, 26 Jun 2024 13:18:18 +0100
Subject: [PATCH] New package: golang-migrate-4.17.1

---
 srcpkgs/golang-migrate/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 00000000000000..0ebaa01285e22b
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,22 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.17.1
+revision=1
+wrksrc="migrate-${version}"
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Thomas Treffry <t.treffry@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="59a92e27d58f22ce3270086d385b3548a2a44e09f91b0eda3e245f94bcf8f081"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+	vbin migrate
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1659767703

Comment:
It does build as intended without that line as well, so it should be dropped.

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by lpww on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1675457348

Comment:
Sorry, I'm just seeing this comment. Thanks for the feedback, I will test it and update the pr!

Re: [PR PATCH] [Updated] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

There is an updated pull request by lpww against master on the void-packages repository

https://github.com/lpww/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/51014

New package: golang-migrate-4.17.1
### Description
This pr adds a new package, `golang-migrate v4.17.1`. It builds upon a [previous pull request](https://github.com/void-linux/void-packages/pull/30634) that works but was never merged. I just updated the version, checksum, and maintainer.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**


A patch file from https://github.com/void-linux/void-packages/pull/51014.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-51014.patch --]
[-- Type: text/x-diff, Size: 1174 bytes --]

From aedcfb9cc1aecb44745c9331a2f3494f696a406c Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@nearform.com>
Date: Wed, 26 Jun 2024 13:18:18 +0100
Subject: [PATCH] New package: golang-migrate-4.17.1

---
 srcpkgs/golang-migrate/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 00000000000000..59c2a932b14800
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,21 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.17.1
+revision=1
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Thomas Treffry <t.treffry@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="59a92e27d58f22ce3270086d385b3548a2a44e09f91b0eda3e245f94bcf8f081"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+	vbin migrate
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by lpww on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1675476253

Comment:
@Bnyro I've updated the pr to remove the `wrksrc` field. Please re-review this when you get a chance 

Re: New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by lpww on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#issuecomment-2235902360

Comment:
@classabbyamp Please may you give this a maintainer review when you have a chance?

Re: New package: golang-migrate-4.17.1

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#issuecomment-2418334618

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by lpww on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#issuecomment-2422204830

Comment:
Bumping to prevent this relevant pr from being closed

Re: [PR PATCH] [Updated] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

There is an updated pull request by lpww against master on the void-packages repository

https://github.com/lpww/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/51014

New package: golang-migrate-4.17.1
### Description
This pr adds a new package, `golang-migrate v4.17.1`. It builds upon a [previous pull request](https://github.com/void-linux/void-packages/pull/30634) that works but was never merged. I just updated the version, checksum, and maintainer.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**


A patch file from https://github.com/void-linux/void-packages/pull/51014.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-51014.patch --]
[-- Type: text/x-diff, Size: 1174 bytes --]

From aedcfb9cc1aecb44745c9331a2f3494f696a406c Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@nearform.com>
Date: Wed, 26 Jun 2024 13:18:18 +0100
Subject: [PATCH] New package: golang-migrate-4.17.1

---
 srcpkgs/golang-migrate/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 00000000000000..59c2a932b14800
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,21 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.17.1
+revision=1
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Thomas Treffry <t.treffry@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="59a92e27d58f22ce3270086d385b3548a2a44e09f91b0eda3e245f94bcf8f081"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+	vbin migrate
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1819529250

Comment:
don't use the makefile, emulate it with these variables: https://github.com/void-linux/void-packages/blob/master/Manual.md#go-packages

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1819531474

Comment:
per [guidelines](https://github.com/void-linux/void-packages/blob/master/Manual.md#programs), use the repo name, `migrate`

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1819531794

Comment:
```suggestion
post_install() {
```

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by lpww on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1826024892

Comment:
My bad! I will update this

Re: [PR PATCH] [Updated] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

There is an updated pull request by lpww against master on the void-packages repository

https://github.com/lpww/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/51014

New package: golang-migrate-4.17.1
### Description
This pr adds a new package, `golang-migrate v4.17.1`. It builds upon a [previous pull request](https://github.com/void-linux/void-packages/pull/30634) that works but was never merged. I just updated the version, checksum, and maintainer.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**


A patch file from https://github.com/void-linux/void-packages/pull/51014.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-51014.patch --]
[-- Type: text/x-diff, Size: 2536 bytes --]

From aedcfb9cc1aecb44745c9331a2f3494f696a406c Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@nearform.com>
Date: Wed, 26 Jun 2024 13:18:18 +0100
Subject: [PATCH 1/2] New package: golang-migrate-4.17.1

---
 srcpkgs/golang-migrate/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 00000000000000..59c2a932b14800
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,21 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.17.1
+revision=1
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Thomas Treffry <t.treffry@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="59a92e27d58f22ce3270086d385b3548a2a44e09f91b0eda3e245f94bcf8f081"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+	vbin migrate
+	vlicense LICENSE
+}

From 14a59fd432a4649a742a119e1bba8944e8ca9c33 Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@yld.io>
Date: Fri, 1 Nov 2024 17:10:16 +0000
Subject: [PATCH 2/2] chore: renmae golang-migrate to migrate and update to
 v4.18.1

---
 srcpkgs/{golang-migrate => migrate}/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
 rename srcpkgs/{golang-migrate => migrate}/template (74%)

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/migrate/template
similarity index 74%
rename from srcpkgs/golang-migrate/template
rename to srcpkgs/migrate/template
index 59c2a932b14800..f12b1a1e41fa1e 100644
--- a/srcpkgs/golang-migrate/template
+++ b/srcpkgs/migrate/template
@@ -1,6 +1,6 @@
-# Template file for 'golang-migrate'
-pkgname=golang-migrate
-version=4.17.1
+# Template file for 'migrate'
+pkgname=migrate
+version=4.18.1
 revision=1
 build_style=go
 go_import_path="github.com/golang-migrate/migrate/v4"
@@ -9,7 +9,7 @@ maintainer="Thomas Treffry <t.treffry@gmail.com>"
 license="MIT"
 homepage="https://github.com/golang-migrate/migrate"
 distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
-checksum="59a92e27d58f22ce3270086d385b3548a2a44e09f91b0eda3e245f94bcf8f081"
+checksum="06cb38c81f0152670c730e906a27f49b353958fe90dcdf9f90f318785c19977f"
 
 do_build() {
 	VERSION="$version" make build

Re: [PR PATCH] [Updated] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

There is an updated pull request by lpww against master on the void-packages repository

https://github.com/lpww/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/51014

New package: golang-migrate-4.17.1
### Description
This pr adds a new package, `golang-migrate v4.17.1`. It builds upon a [previous pull request](https://github.com/void-linux/void-packages/pull/30634) that works but was never merged. I just updated the version, checksum, and maintainer.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**


A patch file from https://github.com/void-linux/void-packages/pull/51014.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-51014.patch --]
[-- Type: text/x-diff, Size: 3677 bytes --]

From aedcfb9cc1aecb44745c9331a2f3494f696a406c Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@nearform.com>
Date: Wed, 26 Jun 2024 13:18:18 +0100
Subject: [PATCH 1/3] New package: golang-migrate-4.17.1

---
 srcpkgs/golang-migrate/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 00000000000000..59c2a932b14800
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,21 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.17.1
+revision=1
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Thomas Treffry <t.treffry@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="59a92e27d58f22ce3270086d385b3548a2a44e09f91b0eda3e245f94bcf8f081"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+	vbin migrate
+	vlicense LICENSE
+}

From 14a59fd432a4649a742a119e1bba8944e8ca9c33 Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@yld.io>
Date: Fri, 1 Nov 2024 17:10:16 +0000
Subject: [PATCH 2/3] chore: renmae golang-migrate to migrate and update to
 v4.18.1

---
 srcpkgs/{golang-migrate => migrate}/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
 rename srcpkgs/{golang-migrate => migrate}/template (74%)

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/migrate/template
similarity index 74%
rename from srcpkgs/golang-migrate/template
rename to srcpkgs/migrate/template
index 59c2a932b14800..f12b1a1e41fa1e 100644
--- a/srcpkgs/golang-migrate/template
+++ b/srcpkgs/migrate/template
@@ -1,6 +1,6 @@
-# Template file for 'golang-migrate'
-pkgname=golang-migrate
-version=4.17.1
+# Template file for 'migrate'
+pkgname=migrate
+version=4.18.1
 revision=1
 build_style=go
 go_import_path="github.com/golang-migrate/migrate/v4"
@@ -9,7 +9,7 @@ maintainer="Thomas Treffry <t.treffry@gmail.com>"
 license="MIT"
 homepage="https://github.com/golang-migrate/migrate"
 distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
-checksum="59a92e27d58f22ce3270086d385b3548a2a44e09f91b0eda3e245f94bcf8f081"
+checksum="06cb38c81f0152670c730e906a27f49b353958fe90dcdf9f90f318785c19977f"
 
 do_build() {
 	VERSION="$version" make build

From cb234530fa041f6cc1b030b6df67281a7fa25dc3 Mon Sep 17 00:00:00 2001
From: thomas <thomas.treffry@yld.io>
Date: Fri, 1 Nov 2024 17:28:31 +0000
Subject: [PATCH 3/3] refactor: use go build style template

---
 srcpkgs/migrate/template | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/migrate/template b/srcpkgs/migrate/template
index f12b1a1e41fa1e..56430bcc4e0c30 100644
--- a/srcpkgs/migrate/template
+++ b/srcpkgs/migrate/template
@@ -4,6 +4,8 @@ version=4.18.1
 revision=1
 build_style=go
 go_import_path="github.com/golang-migrate/migrate/v4"
+go_package="./cmd/migrate"
+go_ldflags="-X main.Version=${version}"
 short_desc="Database migrations CLI written in Golang"
 maintainer="Thomas Treffry <t.treffry@gmail.com>"
 license="MIT"
@@ -11,11 +13,6 @@ homepage="https://github.com/golang-migrate/migrate"
 distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
 checksum="06cb38c81f0152670c730e906a27f49b353958fe90dcdf9f90f318785c19977f"
 
-do_build() {
-	VERSION="$version" make build
-}
-
-do_install() {
-	vbin migrate
+post_install() {
 	vlicense LICENSE
 }

Re: [PR REVIEW] New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by lpww on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#discussion_r1826104592

Comment:
Thanks for the feedback! I have refactored the template to make use of the go package options

Re: New package: golang-migrate-4.17.1

[lpww]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by lpww on void-packages repository

https://github.com/void-linux/void-packages/pull/51014#issuecomment-2452290110

Comment:
@classabbyamp Thanks for taking the time to review this pr. I have addressed your comments and also updated the template to use the latest version of `golang-migrate`!