* [PR PATCH] python3-pylast: update to 5.3.0.
@ 2024-06-24 11:11 Vinfall
2024-07-01 15:20 ` [PR REVIEW] " ahesford
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Vinfall @ 2024-06-24 11:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]
There is a new pull request by Vinfall against master on the void-packages repository
https://github.com/Vinfall/void-packages python3-pylast-update
https://github.com/void-linux/void-packages/pull/50963
python3-pylast: update to 5.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
Basically a revival of #43161, but I did check https://github.com/pylast/pylast/blob/main/pyproject.toml a bit to make sure the deps are still in line with current version.
A patch file from https://github.com/void-linux/void-packages/pull/50963.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pylast-update-50963.patch --]
[-- Type: text/x-diff, Size: 1434 bytes --]
From f026da6950cb05c66c69a0591ea568b2e79abf08 Mon Sep 17 00:00:00 2001
From: Vinfall <neptuniahuai0tc@riseup.net>
Date: Mon, 24 Jun 2024 19:07:55 +0800
Subject: [PATCH] python3-pylast: update to 5.3.0.
---
srcpkgs/python3-pylast/template | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/srcpkgs/python3-pylast/template b/srcpkgs/python3-pylast/template
index 6a3afd557bdb7b..606eb91dc40abd 100644
--- a/srcpkgs/python3-pylast/template
+++ b/srcpkgs/python3-pylast/template
@@ -1,14 +1,15 @@
# Template file for 'python3-pylast'
pkgname=python3-pylast
-version=4.1.0
-revision=6
-build_style=python3-module
-hostmakedepends="python3-setuptools_scm"
-depends="python3-setuptools"
+version=5.3.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="hatchling hatch-vcs"
+depends="python3-httpx"
+checkdepends="python3-pytest python3-flaky ${depends}"
short_desc="Python3 interface to last.fm and libre.fm"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Apache-2.0"
homepage="https://github.com/pylast/pylast"
distfiles="${PYPI_SITE}/p/pylast/pylast-${version}.tar.gz"
-checksum=ad084aec1bf7e307bc42d7cc1a003851f5bee1ad24fb697a9fdc300bbfe63932
-make_check=no # The 'pylast' distribution was not found and is required by the application
+checksum=637943b1b0e6045dd85ed7389db6071a1fea45cc7ff90dc6126fd509ca6fae2f
+make_check=no # Unable to determine tests for PEP517 Python templates
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] python3-pylast: update to 5.3.0.
2024-06-24 11:11 [PR PATCH] python3-pylast: update to 5.3.0 Vinfall
@ 2024-07-01 15:20 ` ahesford
2024-07-02 2:12 ` Vinfall
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2024-07-01 15:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/50963#discussion_r1661213238
Comment:
Most tests are skipped because pylast credentials are not available, but a few unicode tests run just fine.
```suggestion
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] python3-pylast: update to 5.3.0.
2024-06-24 11:11 [PR PATCH] python3-pylast: update to 5.3.0 Vinfall
2024-07-01 15:20 ` [PR REVIEW] " ahesford
@ 2024-07-02 2:12 ` Vinfall
2024-07-02 2:12 ` [PR PATCH] [Updated] " Vinfall
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Vinfall @ 2024-07-02 2:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 3703 bytes --]
New review comment by Vinfall on void-packages repository
https://github.com/void-linux/void-packages/pull/50963#discussion_r1661725338
Comment:
Looks like xbps is smart enough to detect pytest automatically. I hope this would just suffice.
<details><summary>Test log</summary>
<p>
```sh
$ ./xbps-src check ${PKG_CHK}
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://repo-default.voidlinux.org/current/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> python3-pylast-5.3.0_1: removing autodeps, please wait...
=> python3-pylast-5.3.0_1: building with [python3-pep517] [python3] for x86_64...
[host] hatchling-1.22.3_1: found (https://repo-default.voidlinux.org/current)
[host] hatch-vcs-0.4.0_1: found (https://repo-default.voidlinux.org/current)
[host] python3-build-1.2.1_1: found (https://repo-default.voidlinux.org/current)
[host] python3-installer-0.7.0_2: found (https://repo-default.voidlinux.org/current)
[check] python3-pytest-7.4.3_1: found (https://repo-default.voidlinux.org/current)
[check] python3-flaky-3.8.1_1: found (https://repo-default.voidlinux.org/current)
[check] python3-httpx-0.27.0_1: found (https://repo-default.voidlinux.org/current)
[runtime] python3-httpx-0.27.0_1: found (https://repo-default.voidlinux.org/current)
=> python3-pylast-5.3.0_1: installing host dependencies: hatchling-1.22.3_1 hatch-vcs-0.4.0_1 python3-build-1.2.1_1 python3-installer-0.7.0_2 python3-pytest-7.4.3_1 python3-flaky-3.8.1_1 python3-httpx-0.27.0_1 ...
=> python3-pylast-5.3.0_1: running do_check ...
============================= test session starts ==============================
platform linux -- Python 3.12.4, pytest-7.4.3, pluggy-1.3.0
rootdir: /builddir/python3-pylast-5.3.0
configfile: pytest.ini
plugins: anyio-4.3.0, flaky-3.8.1
collected 141 items
tests/test_album.py sssssssssss [ 7%]
tests/test_artist.py sssssssssssssssssssssss [ 24%]
tests/test_country.py ss [ 25%]
tests/test_library.py sssss [ 29%]
tests/test_librefm.py ss [ 30%]
tests/test_network.py ssssssssssssssssssssssssssssss [ 51%]
tests/test_tag.py ssss [ 54%]
tests/test_track.py sssssssssssssssssss [ 68%]
tests/test_user.py ssssssssssssssssssssssssssssssssssss [ 93%]
tests/unicode_test.py ......... [100%]
======================== 9 passed, 132 skipped in 0.27s ========================
```
</p>
</details>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] python3-pylast: update to 5.3.0.
2024-06-24 11:11 [PR PATCH] python3-pylast: update to 5.3.0 Vinfall
2024-07-01 15:20 ` [PR REVIEW] " ahesford
2024-07-02 2:12 ` Vinfall
@ 2024-07-02 2:12 ` Vinfall
2024-07-02 2:16 ` [PR REVIEW] " Vinfall
2024-07-02 2:31 ` [PR PATCH] [Merged]: " ahesford
4 siblings, 0 replies; 6+ messages in thread
From: Vinfall @ 2024-07-02 2:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
There is an updated pull request by Vinfall against master on the void-packages repository
https://github.com/Vinfall/void-packages python3-pylast-update
https://github.com/void-linux/void-packages/pull/50963
python3-pylast: update to 5.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
Basically a revival of #43161, but I did check https://github.com/pylast/pylast/blob/main/pyproject.toml a bit to make sure the deps are still in line with current version.
A patch file from https://github.com/void-linux/void-packages/pull/50963.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pylast-update-50963.patch --]
[-- Type: text/x-diff, Size: 1362 bytes --]
From cc63b9bdd554ab66aa92d9b585dae8b372da44f3 Mon Sep 17 00:00:00 2001
From: Vinfall <neptuniahuai0tc@riseup.net>
Date: Mon, 24 Jun 2024 19:07:55 +0800
Subject: [PATCH] python3-pylast: update to 5.3.0.
---
srcpkgs/python3-pylast/template | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/srcpkgs/python3-pylast/template b/srcpkgs/python3-pylast/template
index 6a3afd557bdb7b..d8ca9697b29d48 100644
--- a/srcpkgs/python3-pylast/template
+++ b/srcpkgs/python3-pylast/template
@@ -1,14 +1,14 @@
# Template file for 'python3-pylast'
pkgname=python3-pylast
-version=4.1.0
-revision=6
-build_style=python3-module
-hostmakedepends="python3-setuptools_scm"
-depends="python3-setuptools"
+version=5.3.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="hatchling hatch-vcs"
+depends="python3-httpx"
+checkdepends="python3-pytest python3-flaky ${depends}"
short_desc="Python3 interface to last.fm and libre.fm"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Apache-2.0"
homepage="https://github.com/pylast/pylast"
distfiles="${PYPI_SITE}/p/pylast/pylast-${version}.tar.gz"
-checksum=ad084aec1bf7e307bc42d7cc1a003851f5bee1ad24fb697a9fdc300bbfe63932
-make_check=no # The 'pylast' distribution was not found and is required by the application
+checksum=637943b1b0e6045dd85ed7389db6071a1fea45cc7ff90dc6126fd509ca6fae2f
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] python3-pylast: update to 5.3.0.
2024-06-24 11:11 [PR PATCH] python3-pylast: update to 5.3.0 Vinfall
` (2 preceding siblings ...)
2024-07-02 2:12 ` [PR PATCH] [Updated] " Vinfall
@ 2024-07-02 2:16 ` Vinfall
2024-07-02 2:31 ` [PR PATCH] [Merged]: " ahesford
4 siblings, 0 replies; 6+ messages in thread
From: Vinfall @ 2024-07-02 2:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New review comment by Vinfall on void-packages repository
https://github.com/void-linux/void-packages/pull/50963#discussion_r1661727443
Comment:
Glad that CI is happy with it as honestly I don't know how to write checks in template.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: python3-pylast: update to 5.3.0.
2024-06-24 11:11 [PR PATCH] python3-pylast: update to 5.3.0 Vinfall
` (3 preceding siblings ...)
2024-07-02 2:16 ` [PR REVIEW] " Vinfall
@ 2024-07-02 2:31 ` ahesford
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2024-07-02 2:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
There's a merged pull request on the void-packages repository
python3-pylast: update to 5.3.0.
https://github.com/void-linux/void-packages/pull/50963
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
Basically a revival of #43161, but I did check https://github.com/pylast/pylast/blob/main/pyproject.toml a bit to make sure the deps are still in line with current version.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-02 2:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-24 11:11 [PR PATCH] python3-pylast: update to 5.3.0 Vinfall
2024-07-01 15:20 ` [PR REVIEW] " ahesford
2024-07-02 2:12 ` Vinfall
2024-07-02 2:12 ` [PR PATCH] [Updated] " Vinfall
2024-07-02 2:16 ` [PR REVIEW] " Vinfall
2024-07-02 2:31 ` [PR PATCH] [Merged]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).