[PR PATCH] Inital commit for goldendict-ng

[PR PATCH] Inital commit for goldendict-ng

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

There is a new pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

Inital commit for goldendict-ng
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1393 bytes --]

From ebd02da9d12bd4b9fbe6f035d05ff5256f5fd359 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] inital commit for goldendict-ng

---
 srcpkgs/goldendict-ng/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..2a5160170a7515
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,16 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=LiXia.240505.ecd1138c1.5.0
+revision=1
+build_style=cmake
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="A feature-rich dictionary lookup program"
+maintainer="RandallFlagg <O@G>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/heads/master.zip"
+checksum=de49fbb52c322e5a781ec5398e3f176fb7ac258436fb4693bb64a55bdb964ff0
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict.png
+}

Re: Inital commit for goldendict-ng

[abenson]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#issuecomment-2201591230

Comment:
Please use the [established conventions](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes) for the commit message.

Re: [PR REVIEW] Inital commit for goldendict-ng

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1661683615

Comment:
use a real email

Re: [PR REVIEW] Inital commit for goldendict-ng

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1661683812

Comment:
that's not the proper version, use something like `24.05.05`for https://github.com/xiaoyifang/goldendict-ng/releases/tag/v24.05.05-LiXia.ecd1138c

Re: [PR REVIEW] Inital commit for goldendict-ng

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1661685233

Comment:
don't use master, that's not the same as the version you specified, and will change.

Re: [PR PATCH] [Updated] Inital commit for goldendict-ng

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

Inital commit for goldendict-ng
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 3086 bytes --]

From ebd02da9d12bd4b9fbe6f035d05ff5256f5fd359 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH 1/2] inital commit for goldendict-ng

---
 srcpkgs/goldendict-ng/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..2a5160170a7515
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,16 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=LiXia.240505.ecd1138c1.5.0
+revision=1
+build_style=cmake
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="A feature-rich dictionary lookup program"
+maintainer="RandallFlagg <O@G>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/heads/master.zip"
+checksum=de49fbb52c322e5a781ec5398e3f176fb7ac258436fb4693bb64a55bdb964ff0
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict.png
+}

From ec447586136a58842ee94af26cd9bd7653978509 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 14:06:48 +0300
Subject: [PATCH 2/2] Fixed template file with lint errors

---
 srcpkgs/goldendict-ng/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
index 2a5160170a7515..ef6a903b9b8bf1 100644
--- a/srcpkgs/goldendict-ng/template
+++ b/srcpkgs/goldendict-ng/template
@@ -1,15 +1,16 @@
 # Template file for 'goldendict-ng'
 pkgname=goldendict-ng
-version=LiXia.240505.ecd1138c1.5.0
+version=LiXia.240505
 revision=1
+archs="x86_64"
 build_style=cmake
 makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
-short_desc="A feature-rich dictionary lookup program"
-maintainer="RandallFlagg <O@G>"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://xiaoyifang.github.io/goldendict-ng/"
-distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/heads/master.zip"
-checksum=de49fbb52c322e5a781ec5398e3f176fb7ac258436fb4693bb64a55bdb964ff0
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v24.05.05-LiXia.ecd1138c.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
 
 post_install() {
 	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict.png

Re: [PR PATCH] [Updated] New package: goldendict-ng-LiXia.240505

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-LiXia.240505
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 3111 bytes --]

From ebd02da9d12bd4b9fbe6f035d05ff5256f5fd359 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH 1/2] inital commit for goldendict-ng

---
 srcpkgs/goldendict-ng/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..2a5160170a7515
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,16 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=LiXia.240505.ecd1138c1.5.0
+revision=1
+build_style=cmake
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="A feature-rich dictionary lookup program"
+maintainer="RandallFlagg <O@G>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/heads/master.zip"
+checksum=de49fbb52c322e5a781ec5398e3f176fb7ac258436fb4693bb64a55bdb964ff0
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict.png
+}

From e9c50f8c2c0ba02e9ee23fadd6937842bd057179 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 14:06:48 +0300
Subject: [PATCH 2/2] goldendict-ng: Fixed template file corresponding lint
 errors

---
 srcpkgs/goldendict-ng/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
index 2a5160170a7515..ef6a903b9b8bf1 100644
--- a/srcpkgs/goldendict-ng/template
+++ b/srcpkgs/goldendict-ng/template
@@ -1,15 +1,16 @@
 # Template file for 'goldendict-ng'
 pkgname=goldendict-ng
-version=LiXia.240505.ecd1138c1.5.0
+version=LiXia.240505
 revision=1
+archs="x86_64"
 build_style=cmake
 makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
-short_desc="A feature-rich dictionary lookup program"
-maintainer="RandallFlagg <O@G>"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://xiaoyifang.github.io/goldendict-ng/"
-distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/heads/master.zip"
-checksum=de49fbb52c322e5a781ec5398e3f176fb7ac258436fb4693bb64a55bdb964ff0
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v24.05.05-LiXia.ecd1138c.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
 
 post_install() {
 	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict.png

Re: [PR PATCH] [Updated] New package: goldendict-ng-LiXia.240505

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-LiXia.240505
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1476 bytes --]

From a199389169c10fd4dfc2e74d46a4d854cf880880 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..3bf6bf650e4163
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,18 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v24.05.05-LiXia.ecd1138c.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: [PR PATCH] [Updated] New package: goldendict-ng-LiXia.240505

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-LiXia.240505
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1476 bytes --]

From a49bde13c388a7edba97079ef57232d198be0401 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..3bf6bf650e4163
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,18 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v24.05.05-LiXia.ecd1138c.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#issuecomment-2208422801

Comment:
@classabbyamp can you activate the workflow?

Re: [PR PATCH] [Updated] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-24.05.05
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1509 bytes --]

From f3e864ed3eeb45cd56c8d5e9056b2b42e20f3e10 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..8f9f966ba447c8
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,19 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+version_name=LiXia.ecd1138c
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${version_name}.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#issuecomment-2209604320

Comment:
Is there a way I can run the linter on my local machine?

Re: [PR PATCH] [Updated] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-24.05.05
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1509 bytes --]

From 055da7602060e6d9ddb11286233e829da9bc05fb Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..43855479583d0c
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,19 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+version_name=LiXia.ecd1138c
+archs="x86_64"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${version_name}.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#issuecomment-2209628666

Comment:
xlint in the xtools package

Re: [PR PATCH] [Updated] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-24.05.05
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1509 bytes --]

From 31c2f786b78a63bb89828703670b069127080912 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..e9302507d4a910
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,19 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${version_name}.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+version_name=LiXia.ecd1138c
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666118258

Comment:
why only x86_64?

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666118205

Comment:
wrap at 80 chars (and indent following lines with a single space)

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666118319

Comment:
```suggestion
_version_name=LiXia.ecd1138c
```

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666874387

Comment:
I don't have an option to test other archs. If there is an EASY way to do it I will be happy to do it. I wanted to start with something and to add when there will be a deamend or when I have the option.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666874492

Comment:
Done. But why 80 chars? Most if not all screens today have support for much more.

Re: [PR PATCH] [Updated] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-24.05.05
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1523 bytes --]

From 78d19ce74fecbd6fcb65df249077749120cf875a Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..7d4b9228c8f259
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,23 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel
+ qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite
+ qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel
+ hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel
+ libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${_version_name}.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+_version_name=LiXia.ecd1138c
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666972137

Comment:
because that's the convention we follow:

> Most of the lines should be kept under 80 columns

https://github.com/void-linux/void-packages/blob/master/Manual.md#introduction

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666972968

Comment:
doesn't matter, archs= should only be used if something absolutely won't work. 

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1666972968

Comment:
doesn't matter, archs= should only be used if something absolutely won't work.

the readme has instructions for how to build for alternate libcs and architectures

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1672427971

Comment:
_version_name cannot come after distfiles. It is used by distfiles and the build fails a it is not decalred if it comes after.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1672427971

Comment:
_version_name cannot come after distfiles. It is used by distfiles and the build fails a it is not decalred before usage.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1672440366

Comment:
i never said it had to, it should start with a _ as it's a custom variable 

Re: [PR PATCH] [Updated] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-24.05.05
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1525 bytes --]

From b7b6be775ae7255892e267c7aab5781a72f07cff Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..f6d2d1ff625a3f
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,23 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+_version_name=LiXia.ecd1138c
+# archs="x86_64"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel
+ qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite
+ qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel
+ hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel
+ libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${_version_name}.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: [PR PATCH] [Updated] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-24.05.05
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1524 bytes --]

From b999ecea294b1c64f0e63d537424bf156458d49d Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..54b47c9d527e03
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,23 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+_version_name=LiXia.ecd1138c
+archs="x86_64*"
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel
+ qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite
+ qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel
+ hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel
+ libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${_version_name}.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+
+post_install() {
+	chmod 644 ${DESTDIR}/usr/share/pixmaps/goldendict-ng.png
+}

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1672778564

Comment:
**For i686 I got:** Package 'qt6-webengine-devel-6.7.2_1' not found in repository pool.
**For aarch* I got:** ERROR Failed to execute command /void-packages/xbps-src (Exec format error).

Do I need to do anything else?

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1672784123

Comment:
sounds like you tried to do a native build on aarch64, you want to do cross build

i686 doesn't need to be explicitly removed because the inability to build a dependency will exclude it on that arch

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1673664663

Comment:
I ran the following command after running the bootstrap which is the similar to what I did for MUSL:
`./xbps-src -A aarch64 pkg goldendict-ng`

The bootstrap command ended with the same error.

What should I do different? Can you point me to the right documentation?

I am looking currentlly at this documents:
https://github.com/void-linux/void-packages/blob/master/Manual.md
https://github.com/void-linux/void-packages?tab=readme-ov-file

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1673664663

Comment:
I ran the following command after running the bootstrap which is similar to what I did for MUSL:
`./xbps-src -A aarch64 pkg goldendict-ng`

The bootstrap command ended with the same error.

What should I do different? Can you point me to the right documentation?

I am looking currentlly at this documents:
https://github.com/void-linux/void-packages/blob/master/Manual.md
https://github.com/void-linux/void-packages?tab=readme-ov-file
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1673927922

Comment:
you want -a, which sets the target arch. -A sets the host arch

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1675663647

Comment:
Also arm not relevant. Some parts of the QT6 package are missing also there:

> CMake Error at /usr/aarch64-linux-gnu/usr/lib/cmake/Qt6/QtPublicDependencyHelpers.cmake:216 (find_package):
>   Could not find a package configuration file provided by "Qt6HostInfo" with
>   any of the following names:
> 
>     Qt6HostInfoConfig.cmake
>     qt6hostinfo-config.cmake
> 
>   Add the installation prefix of "Qt6HostInfo" to CMAKE_PREFIX_PATH or set
>   "Qt6HostInfo_DIR" to a directory containing one of the above files.  If
>   "Qt6HostInfo" provides a separate development package or SDK, be sure it
>   has been installed.
> Call Stack (most recent call first):
>   /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6/Qt6Dependencies.cmake:14 (_qt_internal_find_host_info_package)
>   /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6/Qt6Config.cmake:134 (include)
>   CMakeLists.txt:46 (find_package)
> 
> 
> CMake Error at CMakeLists.txt:46 (find_package):
>   Found package configuration file:
> 
>     /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6/Qt6Config.cmake
> 
>   but it set Qt6_FOUND to FALSE so package "Qt6" is considered to be NOT
>   FOUND.
> 
> 
> -- Configuring incomplete, errors occurred!
> => ERROR: goldendict-ng-24.05.05_1: do_configure: 'CFLAGS="-DNDEBUG ${CFLAGS/ -pipe / }" CXXFLAGS="-DNDEBUG ${CXXFLAGS/ -pipe / }" cmake ${cmake_args} ${configure_args} ${LIBS:+-DCMAKE_C_STANDARD_LIBRARIES="$LIBS"} ${LIBS:+-DCMAKE_CXX_STANDARD_LIBRARIES="$LIBS"} ${wrksrc}/${build_wrksrc}' exited with 1
> => ERROR:   in do_configure() at common/build-style/cmake.sh:77

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1675667799

Comment:
Do I need to do anything else regarding the platforms testing?

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1675968719

Comment:
> Some parts of the QT6 package are missing also there

that means you're missing a hostmakedepend/makedepend, you can use xlocate to find the cmake file it wants

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676924437

Comment:
After adding the missing package to makedepends the foloowing message is shown:

> ERROR: goldendict-ng-24.05.05_1: this package cannot be built for aarch64.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676924437

Comment:
After adding the missing package to makedepends the folowing message is shown (same for aarch64-musl):

> ERROR: goldendict-ng-24.05.05_1: this package cannot be built for aarch64.

Do I need to do anything else?

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676935465

Comment:
remove the archs= line

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676961599

Comment:
You are right. I forgot I re-added it. I get the same error as before after adding the qt6-base package to makedepends and also tried to add it to hostdepends.

> CMake Error at /usr/aarch64-linux-gnu/usr/lib/cmake/Qt6/QtPublicDependencyHelpers.cmake:216 (find_package):
>   Could not find a package configuration file provided by "Qt6HostInfo" with
>   any of the following names:
> 
>     Qt6HostInfoConfig.cmake
>     qt6hostinfo-config.cmake
> 
>   Add the installation prefix of "Qt6HostInfo" to CMAKE_PREFIX_PATH or set
>   "Qt6HostInfo_DIR" to a directory containing one of the above files.  If
>   "Qt6HostInfo" provides a separate development package or SDK, be sure it
>   has been installed.
> Call Stack (most recent call first):
>   /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6/Qt6Dependencies.cmake:14 (_qt_internal_find_host_info_package)
>   /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6/Qt6Config.cmake:134 (include)
>   CMakeLists.txt:46 (find_package)
> 
> 
> CMake Error at CMakeLists.txt:46 (find_package):
>   Found package configuration file:
> 
>     /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6/Qt6Config.cmake
> 
>   but it set Qt6_FOUND to FALSE so package "Qt6" is considered to be NOT
>   FOUND.
> 
> 
> -- Configuring incomplete, errors occurred!
> => ERROR: goldendict-ng-24.05.05_1: do_configure: 'CFLAGS="-DNDEBUG ${CFLAGS/ -pipe / }" CXXFLAGS="-DNDEBUG ${CXXFLAGS/ -pipe / }" cmake ${cmake_args} ${configure_args} ${LIBS:+-DCMAKE_C_STANDARD_LIBRARIES="$LIBS"} ${LIBS:+-DCMAKE_CXX_STANDARD_LIBRARIES="$LIBS"} ${wrksrc}/${build_wrksrc}' exited with 1
> => ERROR:   in do_configure() at common/build-style/cmake.sh:77

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[shenlebantongying]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by shenlebantongying on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676962389

Comment:
I think `qt6-network(-devel)` is needed? The qt6-base package seems splitted in voidlinux.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676964993

Comment:
Not clear why I would want to add that package, but after adding it to the makedepends I get the following error:

> => ERROR: goldendict-ng-24.05.05_1: target dependency 'qt6-network-devel' does not exist!

I add add it also to the hostdepends I get the same error as before. If I add only to host depends I also get the same error as before.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676964993

Comment:
Not clear why I would want to add that package, but after adding it to the _makedepends_ I get the following error:

> => ERROR: goldendict-ng-24.05.05_1: target dependency 'qt6-network-devel' does not exist!

If I add it also to the _hostdepends_ I get the same error as before. If I add only to _hostdepends_ I also get the same error as before.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[shenlebantongying]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New review comment by shenlebantongying on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676966641

Comment:
I don't have void installed now, but the `makedepends` of others software is just `qt6-netowrk`? I don't really know.
https://github.com/search?q=repo%3Avoid-linux%2Fvoid-packages%20qt6-network&type=code

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[shenlebantongying]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

New review comment by shenlebantongying on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676966641

Comment:
I don't have void installed now, but the `makedepends` of others software is just `qt6-netowrk`?
https://github.com/search?q=repo%3Avoid-linux%2Fvoid-packages%20qt6-network&type=code

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[shenlebantongying]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New review comment by shenlebantongying on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676973026

Comment:
> Not clear why I would want to add that package,

To fix this error

>  Could not find a package configuration file provided by "Qt6HostInfo" with

I don't know the exact package name, something qt network.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676974415

Comment:
```
$ xlocate Qt6HostInfo
qt6-base-6.7.2_1  /usr/lib/cmake/Qt6HostInfo/Qt6HostInfoConfig.cmake
```

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676974415

Comment:
```
$ xlocate Qt6HostInfo
qt6-base-6.7.2_1  /usr/lib/cmake/Qt6HostInfo/Qt6HostInfoConfig.cmake
```
so makedepends qt6-base

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by RandallFlagg on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676975353

Comment:
Did that already here:
https://github.com/void-linux/void-packages/pull/51071#discussion_r1676961599

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[shenlebantongying]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by shenlebantongying on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676976886

Comment:
Push your current package maybe?

Re: [PR PATCH] [Updated] New package: goldendict-ng-24.05.05

[RandallFlagg]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by RandallFlagg against master on the void-packages repository

https://github.com/my-void-linux/void-packages golden-dict-ng
https://github.com/void-linux/void-packages/pull/51071

New package: goldendict-ng-24.05.05
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) 
x86_64-glibc
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/51071.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golden-dict-ng-51071.patch --]
[-- Type: text/x-diff, Size: 1517 bytes --]

From f2a4da2d5bd08f46f5948cfdc15c10e0fb83edb8 Mon Sep 17 00:00:00 2001
From: Randall Flagg <O@G>
Date: Tue, 2 Jul 2024 03:54:29 +0300
Subject: [PATCH] New package: goldendict-ng-24.05.05

---
 srcpkgs/goldendict-ng/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/goldendict-ng/template

diff --git a/srcpkgs/goldendict-ng/template b/srcpkgs/goldendict-ng/template
new file mode 100644
index 00000000000000..20b9bee64b0f98
--- /dev/null
+++ b/srcpkgs/goldendict-ng/template
@@ -0,0 +1,22 @@
+# Template file for 'goldendict-ng'
+pkgname=goldendict-ng
+version=24.05.05
+revision=1
+_version_name=LiXia.ecd1138c
+build_style=cmake
+configure_args="-DUSE_ALTERNATIVE_NAME=ON"
+makedepends="qt6-base qt6-speech-devel qt6-svg-devel qt6-qt5compat-devel qt6-base-devel
+ qt6-webengine-devel qt6-multimedia-devel qt6-speech-plugin-flite
+ qt6-speech-plugin-mock qt6-speech-plugin-speechd pkg-config ffmpeg-devel
+ hunspell-devel opencc-devel libvorbis-devel xapian-core-devel libeb-devel
+ libzim-devel qt6-tools-devel"
+short_desc="Feature-rich dictionary lookup program"
+maintainer="RandallFlagg <ykpui@hotmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://xiaoyifang.github.io/goldendict-ng/"
+distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${_version_name}.tar.gz"
+checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
+
+post_install() {
+	chmod 644 "${DESTDIR}/usr/share/pixmaps/goldendict-ng.png"
+}

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1676983375

Comment:
pkg-config should be hostmakedepends, probably also need qt6-tools in hostmakedepends

Re: New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#issuecomment-2250012970

Comment:
Hi!

I'm trying to cross-build the package for aarch64 and I'm able to get past the Qt6HostInfo error message (now it gets detected automatically, but you can also pass `-DQt6HostInfo_DIR=/usr/aarch64-linux-gnu/usr/lib/cmake/Qt6HostInfo` to cmake. However, the following error message pops up:

`/usr/aarch64-linux-gnu/usr/lib64/qt6/libexec/qmlimportscanner: /usr/aarch64-linux-gnu/usr/lib64/qt6/libexec/qmlimportscanner: cannot execute binary file
CMake Error at /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6Qml/Qt6QmlMacros.cmake:3361 (message):
  Failed to scan target goldendict-ng for QML imports: 126
Call Stack (most recent call first):
  /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6Qml/Qt6QmlMacros.cmake:3403 (_qt_internal_scan_qml_imports)
  /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:678 (qt6_import_qml_plugins)
  /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:678 (cmake_language)
  /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:774 (_qt_internal_finalize_executable)
  /usr/aarch64-linux-gnu/usr/lib64/cmake/Qt6Core/Qt6CoreMacros.cmake:590:EVAL:1 (qt6_finalize_target)
  CMakeLists.txt:DEFERRED`

Running _file_ on the aforementioned binary reveals the following:
`masterdir-x86_64/usr/aarch64-linux-gnu/usr/lib64/qt6/libexec/qmlimportscanner: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, BuildID[sha1]=35f93a674a89578308260dfaf9839cb6816dce9d, for GNU/Linux 3.7.0, stripped
`

I believe [qt6-declarative-tools](https://github.com/void-linux/void-packages/blob/master/srcpkgs/qt6-declarative/template) may be relevant here. Perhaps somebody will have a clue what's going on here and whether and how this could be fixed.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[mvf]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694225452

Comment:
```suggestion
archs="x86_64* aarch64*"
_version_name=LiXia.ecd1138c
```
Other arches are out due to `qt6-webengine` dependency.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[mvf]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694230628

Comment:
```suggestion
configure_args="-DUSE_ALTERNATIVE_NAME=ON -DUSE_SYSTEM_FMT=ON"
hostmakedepends="pkg-config qt6-declarative-host-tools qt6-tools"
makedepends="ffmpeg-devel fmt-devel hunspell-devel libeb-devel libvorbis-devel
 libzim-devel opencc-devel qt6-base-devel qt6-declarative-devel
 qt6-multimedia-devel qt6-qt5compat-devel qt6-svg-devel qt6-webengine-devel
 xapian-core-devel"
depends="qt6-svg"
```
- Use `fmt` library from the repos
- Move `pkg-config` to `hostmakedepends`
- Install required `qt6-*tools`, but only for the host, to avoid `Exec format error`
- Explicit `qt6-svg` dependency needed, or most icons are missing from the UI

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694254219

Comment:
this does not need to be explicit, xbps-src will prevent build due to not being able to build qt6-webengine

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694259658

Comment:
Maybe I'm overseeing something but I don't see Text-to-speech makedepends here. So I guess we either have to go with:
1) configure_args+=" -DWITH_TTS=OFF"
or
2) makedepends+=" qt6-speech-devel qt6-speech-plugin-flite qt6-speech-plugin-mock
 qt6-speech-plugin-speechd"

Either way, cross-compilation for aarch64 works!

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694260444

Comment:
Also, post_install thing seems redundant as the pixmap is 644 already :
`-rw-r--r--  0 0      0       22251 Jul 23 21:42 ./usr/share/pixmaps/goldendict-ng.png
`

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[mvf]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694262702

Comment:
You're right, pasted this from a build where I had disabled the speech stuff. Couldn't get it to work, even after installing the plugins (which would probably also need to go into `depends`). Upstream disabled TTS later by default (xiaoyifang/goldendict-ng#1414, [change](https://github.com/xiaoyifang/goldendict-ng/commit/bd194c0fbd268ae0498b824be0a570d7c30843fc)). We should probably go with `-DWITH_TTS=OFF`.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[mvf]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694263393

Comment:
Really? AFAIK either `archs` or `broken` is needed, otherwise CI will fail with `failed to install target dependencies!`, as seen in the `i686` build in this PR. I don't think `broken` should propagate, so I went with `arch`s.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694264489

Comment:
@mvf by the way, are you sure `depends="qt6-svg"` is required? I just built the package with this commented out and no icons are missing from my UI.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694264489

Comment:
@mvf by the way, are you sure `depends="qt6-svg"` is required? I just built the package with this commented out and no icons are missing from my UI.

EDIT: sorry, xbps-query shows me I already have it installed :D

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694265191

Comment:
well, even if it doesn't work, an arch restriction is the wrong solution, as it's not inherent to architectures but instead host/target wordsize:

https://github.com/void-linux/void-packages/blob/48ef82c9046ec34aa354bc669d919d52e50dd507/srcpkgs/kontact/template#L22-L24

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[mvf]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694279694

Comment:
OK, so the sentiment is that `broken` *should* propagate. Let's go with that then.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[mvf]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694279852

Comment:
@slymattz Yeah, `qt6-svg` is a sneaky dep. I only caught this because I already knew from another package. If you want to try for yourself, you can put a file with `ignorepkg=qt6-svg` into `/etc/xbps.d`, uninstall `qt6-svg` and enjoy the broken UI. :sweat_smile:

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694297671

Comment:
I took the liberty of taking the fixes/suggestions above and putting them into a template for review purposes. Good news is it builds for x86_64 and cross-builds for x86_64-musl, aarch64 and aarch64-musl just fine.

```
# Template file for 'goldendict-ng'
pkgname=goldendict-ng
version=24.05.05
revision=1
_version_name=LiXia.ecd1138c
build_style=cmake
configure_args="-DUSE_ALTERNATIVE_NAME=ON -DUSE_SYSTEM_FMT=ON -DWITH_TTS=OFF"
hostmakedepends="pkg-config qt6-declarative-host-tools qt6-tools"
makedepends="ffmpeg-devel fmt-devel hunspell-devel libeb-devel libvorbis-devel
 libzim-devel opencc-devel qt6-base-devel qt6-declarative-devel
 qt6-multimedia-devel qt6-qt5compat-devel qt6-svg-devel qt6-webengine-devel
 xapian-core-devel"
depends="qt6-svg"
short_desc="Feature-rich dictionary lookup program (goldendict fork)"
maintainer="RandallFlagg <ykpui@hotmail.com>"
license="GPL-3.0-or-later"
homepage="https://xiaoyifang.github.io/goldendict-ng/"
distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${_version_name}.tar.gz"
checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
```

There's only one problem I experience with the build but it might be upstream-related. So, I haven't been able to get ffmpeg backend to work, be it with ffmpeg installed on my machine or not. For me, it is only Qt Multimedia or an external program like vlc that makes the audio work.

@mvf - may I ask you to check whether ffmpeg works for you?

With the ffmpeg backend on and goldendict-ng opened in a console session, I get:

> QIODevice::seek (QIODevice): Cannot call seek on a sequential device
open link url: QUrl("gdau://dc14cdf10c4508af380f2ac5c43c0a0f/MOVIE.mp3")
getResource: "gdau://dc14cdf10c4508af380f2ac5c43c0a0f/MOVIE.mp3"
scheme: "gdau"
host: "dc14cdf10c4508af380f2ac5c43c0a0f"
Codec open: MP3 (MPEG audio layer 3): channels: 1, rate: 22050, format: fltp

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[mvf]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694589721

Comment:
@slymattz FFmpeg works for me. Console output is the same, including the `Cannot call seek` error. In `pavucontrol`'s `Playback` tab, I can see either backend opening a `QtmPulseStream` channel. Qt Multimedia kills it immediately after playback, for FFmpeg it sticks around and is replaced in subsequent playbacks.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694960463

Comment:
Then it's probably my setup then. I see a lot of recent revbumps and rebuilds for ffmpeg6 anyway. Does that mean that this change should also be reflected here (ffmpeg-devel6 in place of ffmpeg-devel) (ping @classabbyamp)?

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1695268570

Comment:
yes, all new packages should use ffmpeg6

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 2099 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1694297671

Comment:
I took the liberty of taking the fixes/suggestions above and putting them into a template for review purposes. Good news is it builds for x86_64 and cross-builds for x86_64-musl, aarch64 and aarch64-musl just fine.

```
# Template file for 'goldendict-ng'
pkgname=goldendict-ng
version=24.05.05
revision=1
_version_name=LiXia.ecd1138c
build_style=cmake
configure_args="-DUSE_ALTERNATIVE_NAME=ON -DUSE_SYSTEM_FMT=ON -DWITH_TTS=OFF"
hostmakedepends="pkg-config qt6-declarative-host-tools qt6-tools"
makedepends="ffmpeg6-devel fmt-devel hunspell-devel libeb-devel libvorbis-devel
 libzim-devel opencc-devel qt6-base-devel qt6-declarative-devel
 qt6-multimedia-devel qt6-qt5compat-devel qt6-svg-devel qt6-webengine-devel
 xapian-core-devel"
depends="qt6-svg"
short_desc="Feature-rich dictionary lookup program (goldendict fork)"
maintainer="RandallFlagg <ykpui@hotmail.com>"
license="GPL-3.0-or-later"
homepage="https://xiaoyifang.github.io/goldendict-ng/"
distfiles="https://github.com/xiaoyifang/goldendict-ng/archive/refs/tags/v${version}-${_version_name}.tar.gz"
checksum=e7cf55fef4ddf00d87b4e54489ec33a605b1d5634d0b7c46ddcdd261c3113790
```

There's only one problem I experience with the build but it might be upstream-related. So, I haven't been able to get ffmpeg backend to work, be it with ffmpeg installed on my machine or not. For me, it is only Qt Multimedia or an external program like vlc that makes the audio work.

@mvf - may I ask you to check whether ffmpeg works for you?

With the ffmpeg backend on and goldendict-ng opened in a console session, I get:

> QIODevice::seek (QIODevice): Cannot call seek on a sequential device
open link url: QUrl("gdau://dc14cdf10c4508af380f2ac5c43c0a0f/MOVIE.mp3")
getResource: "gdau://dc14cdf10c4508af380f2ac5c43c0a0f/MOVIE.mp3"
scheme: "gdau"
host: "dc14cdf10c4508af380f2ac5c43c0a0f"
Codec open: MP3 (MPEG audio layer 3): channels: 1, rate: 22050, format: fltp

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1695376638

Comment:
OK. So the change is now reflected in https://github.com/void-linux/void-packages/pull/51071#discussion_r1694297671 @RandallFlagg let me ask you since you're the OP, are you still interested in pushing updates to this PR and maintaining the package in the future?

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1695376638

Comment:
OK. So the change is now reflected in https://github.com/void-linux/void-packages/pull/51071#discussion_r1694297671 @RandallFlagg let me ask you since you're the OP, are you still interested in pushing updates to this PR and maintaining the package in the future or would you rather delegate it to someone else?

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1700142047

Comment:
OP hasn't contributed in this PR for 3 weeks now and it seems to me they might've lost interest in potentially maintaining this package. If this is really the case, @mvf would you be willing to take over? I would also love to see this package merged.

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1702150539

Comment:
@classabbyamp

Like I wrote above, OP hasn't contributed to this PR in 3 weeks already and I doubt they want to maintain this package. We've already figured out a template that cross-builds for aarch64 and aarch64-musl and my question is - do we have to wait it out until this PR becomes stale or is there a possibility to consider a commit from my fork as we speak? I don't distrohop so keeping the package up-to-date shouldn't be a problem for me. Here's [my commit](https://github.com/void-linux/void-packages/compare/master...slymattz:void-packages:goldendict-ng-24.05.05)

Re: [PR REVIEW] New package: goldendict-ng-24.05.05

[slymattz]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New review comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#discussion_r1704171763

Comment:
I added the missing bit with broken host-target wordsizes to exclude the architectures which do not have qt6 webengine, as suggested by abby.

Re: New package: goldendict-ng-24.05.05

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/51071#issuecomment-2453702587

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.