Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [RFC] add sse flags to i686 profile
@ 2024-07-18 19:35 Calandracas606
  2024-07-18 19:39 ` [PR REVIEW] " Calandracas606
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: Calandracas606 @ 2024-07-18 19:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

There is a new pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages i686-sse2
https://github.com/void-linux/void-packages/pull/51333

[RFC] add sse flags to i686 profile
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

I don't actually have any i686 hardware to test with, but I've built a few packages without issues.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

There are several packages which require sse2 and fpmath flags to be added manually.

The void documentation quite clearly states that pentium 4 (sse2) is the base system requirements: https://docs.voidlinux.org/installation/index.html#base-system-requirements

If the base requirements are pentium4, we could alternately set gcc's `-march=pentium4` flag


A patch file from https://github.com/void-linux/void-packages/pull/51333.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i686-sse2-51333.patch --]
[-- Type: text/x-diff, Size: 2392 bytes --]

From 050c4c8f57bf18f98d9351c8da6f491fc789426d Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Thu, 18 Jul 2024 15:30:15 -0400
Subject: [PATCH] add sse flags to i686 profile

---
 common/build-profiles/i686-musl.sh | 2 +-
 common/build-profiles/i686.sh      | 2 +-
 common/cross-profiles/i686-musl.sh | 2 +-
 common/cross-profiles/i686.sh      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/common/build-profiles/i686-musl.sh b/common/build-profiles/i686-musl.sh
index a607ef619e7915..824ff11631f110 100644
--- a/common/build-profiles/i686-musl.sh
+++ b/common/build-profiles/i686-musl.sh
@@ -1,4 +1,4 @@
-XBPS_TARGET_CFLAGS="-mtune=i686"
+XBPS_TARGET_CFLAGS="-mtune=i686 -msse -msse2 -mfpmath=sse"
 XBPS_TARGET_CXXFLAGS="$XBPS_TARGET_CFLAGS"
 XBPS_TARGET_FFLAGS="$XBPS_TARGET_CFLAGS"
 XBPS_TRIPLET="i686-linux-musl"
diff --git a/common/build-profiles/i686.sh b/common/build-profiles/i686.sh
index ac69fb0c519d38..8b974fd9f79e86 100644
--- a/common/build-profiles/i686.sh
+++ b/common/build-profiles/i686.sh
@@ -1,4 +1,4 @@
-XBPS_TARGET_CFLAGS="-mtune=i686"
+XBPS_TARGET_CFLAGS="-mtune=i686 -msse -msse2 -mfpmath=sse"
 XBPS_TARGET_CXXFLAGS="$XBPS_TARGET_CFLAGS"
 XBPS_TARGET_FFLAGS="$XBPS_TARGET_CFLAGS"
 XBPS_TRIPLET="i686-pc-linux-gnu"
diff --git a/common/cross-profiles/i686-musl.sh b/common/cross-profiles/i686-musl.sh
index c1cdf60f5ebb8e..185065dd87d23a 100644
--- a/common/cross-profiles/i686-musl.sh
+++ b/common/cross-profiles/i686-musl.sh
@@ -3,7 +3,7 @@
 XBPS_TARGET_MACHINE="i686-musl"
 XBPS_TARGET_QEMU_MACHINE="i386"
 XBPS_CROSS_TRIPLET="i686-linux-musl"
-XBPS_CROSS_CFLAGS="-march=i686"
+XBPS_CROSS_CFLAGS="-march=i686 -msse -msse2 -mfpmath=sse"
 XBPS_CROSS_CXXFLAGS="$XBPS_CROSS_CFLAGS"
 XBPS_CROSS_FFLAGS="$XBPS_CROSS_CFLAGS"
 XBPS_CROSS_RUSTFLAGS="--sysroot=${XBPS_CROSS_BASE}/usr"
diff --git a/common/cross-profiles/i686.sh b/common/cross-profiles/i686.sh
index 16f44013ab7610..5313d260b11f62 100644
--- a/common/cross-profiles/i686.sh
+++ b/common/cross-profiles/i686.sh
@@ -3,7 +3,7 @@
 XBPS_TARGET_MACHINE="i686"
 XBPS_TARGET_QEMU_MACHINE="i386"
 XBPS_CROSS_TRIPLET="i686-pc-linux-gnu"
-XBPS_CROSS_CFLAGS="-march=i686"
+XBPS_CROSS_CFLAGS="-march=i686 -msse -msse2 -mfpmath=sse"
 XBPS_CROSS_CXXFLAGS="$XBPS_CROSS_CFLAGS"
 XBPS_CROSS_FFLAGS="$XBPS_CROSS_CFLAGS"
 XBPS_CROSS_RUSTFLAGS="--sysroot=${XBPS_CROSS_BASE}/usr"

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2025-02-04  1:57 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-18 19:35 [PR PATCH] [RFC] add sse flags to i686 profile Calandracas606
2024-07-18 19:39 ` [PR REVIEW] " Calandracas606
2024-07-18 19:39 ` Calandracas606
2024-07-20  4:31 ` classabbyamp
2024-07-20 23:01 ` tornaria
2024-07-21  1:46 ` sgn
2024-07-21  1:54 ` classabbyamp
2024-07-22  9:28 ` jhe2
2024-07-22 11:01 ` leahneukirchen
2024-07-22 12:21 ` jhe2
2024-07-22 12:41 ` leahneukirchen
2024-07-22 13:11 ` jhe2
2024-10-21  2:01 ` github-actions
2024-10-21 12:37 ` Calandracas606
2025-01-21  1:57 ` github-actions
2025-02-04  1:57 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).