[PR PATCH] zls: link against system libc

[PR PATCH] zls: link against system libc

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is a new pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages zls-libc
https://github.com/void-linux/void-packages/pull/51394

zls: link against system libc
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51394.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zls-libc-51394.patch --]
[-- Type: text/x-diff, Size: 1389 bytes --]

From 3970d2457a74b55a820b12481957dda2548a6690 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Tue, 23 Jul 2024 00:17:32 +0200
Subject: [PATCH] zls: link against system libc

---
 srcpkgs/zls/patches/link-libc.patch | 12 ++++++++++++
 srcpkgs/zls/template                |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/zls/patches/link-libc.patch

diff --git a/srcpkgs/zls/patches/link-libc.patch b/srcpkgs/zls/patches/link-libc.patch
new file mode 100644
index 00000000000000..d305ddd4ef6f24
--- /dev/null
+++ b/srcpkgs/zls/patches/link-libc.patch
@@ -0,0 +1,12 @@
+diff --git a/build.zig b/build.zig
+index 07c35fd..3e875d3 100644
+--- a/build.zig
++++ b/build.zig
+@@ -176,6 +176,7 @@ pub fn build(b: *Build) !void {
+         .use_lld = use_llvm,
+     });
+     exe.pie = pie;
++    exe.linkLibC();
+     exe.root_module.addImport("exe_options", exe_options_module);
+     exe.root_module.addImport("tracy", tracy_module);
+     exe.root_module.addImport("diffz", diffz_module);
diff --git a/srcpkgs/zls/template b/srcpkgs/zls/template
index 887475ed8d2eab..93a2aa83c56d80 100644
--- a/srcpkgs/zls/template
+++ b/srcpkgs/zls/template
@@ -1,7 +1,7 @@
 # Template file for 'zls'
 pkgname=zls
 version=0.13.0
-revision=1
+revision=2
 build_style=zig-build
 configure_args="-Dpie"
 short_desc="Zig language server"

Re: [PR PATCH] [Updated] zls: link against system libc

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

There is an updated pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages zls-libc
https://github.com/void-linux/void-packages/pull/51394

zls: link against system libc
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51394.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zls-libc-51394.patch --]
[-- Type: text/x-diff, Size: 1421 bytes --]

From 712892e5e47d3112e0a8ec2f5213043b5030cda8 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Tue, 23 Jul 2024 00:17:32 +0200
Subject: [PATCH] zls: link against system libc

---
 srcpkgs/zls/patches/link-libc.patch | 12 ++++++++++++
 srcpkgs/zls/template                |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/zls/patches/link-libc.patch

diff --git a/srcpkgs/zls/patches/link-libc.patch b/srcpkgs/zls/patches/link-libc.patch
new file mode 100644
index 00000000000000..d792ea9040fa6c
--- /dev/null
+++ b/srcpkgs/zls/patches/link-libc.patch
@@ -0,0 +1,12 @@
+diff --git a/build.zig b/build.zig
+index 07c35fd..f141338 100644
+--- a/build.zig
++++ b/build.zig
+@@ -181,6 +181,7 @@ pub fn build(b: *Build) !void {
+     exe.root_module.addImport("diffz", diffz_module);
+     exe.root_module.addImport("known-folders", known_folders_module);
+     exe.root_module.addImport("zls", zls_module);
++    exe.linkLibC();
+     b.installArtifact(exe);
+ 
+     const test_step = b.step("test", "Run all the tests");
diff --git a/srcpkgs/zls/template b/srcpkgs/zls/template
index 887475ed8d2eab..93a2aa83c56d80 100644
--- a/srcpkgs/zls/template
+++ b/srcpkgs/zls/template
@@ -1,7 +1,7 @@
 # Template file for 'zls'
 pkgname=zls
 version=0.13.0
-revision=1
+revision=2
 build_style=zig-build
 configure_args="-Dpie"
 short_desc="Zig language server"

Re: [PR PATCH] [Updated] zls: link against system libc

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

There is an updated pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages zls-libc
https://github.com/void-linux/void-packages/pull/51394

zls: link against system libc
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51394.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zls-libc-51394.patch --]
[-- Type: text/x-diff, Size: 1498 bytes --]

From 87e5470f5c10a1877e8a52b56bb029fa1a41a5e4 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Tue, 23 Jul 2024 00:17:32 +0200
Subject: [PATCH] zls: link against system libc

---
 srcpkgs/zls/patches/link-libc.patch | 15 +++++++++++++++
 srcpkgs/zls/template                |  2 +-
 2 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/zls/patches/link-libc.patch

diff --git a/srcpkgs/zls/patches/link-libc.patch b/srcpkgs/zls/patches/link-libc.patch
new file mode 100644
index 00000000000000..9cc8b53da6d921
--- /dev/null
+++ b/srcpkgs/zls/patches/link-libc.patch
@@ -0,0 +1,15 @@
+diff --git a/build.zig b/build.zig
+index 07c35fd..13b6f69 100644
+--- a/build.zig
++++ b/build.zig
+@@ -174,8 +174,10 @@ pub fn build(b: *Build) !void {
+         .pic = pie,
+         .use_llvm = use_llvm,
+         .use_lld = use_llvm,
++        .linkage = std.builtin.LinkMode.dynamic,
+     });
+     exe.pie = pie;
++    exe.linkLibC();
+     exe.root_module.addImport("exe_options", exe_options_module);
+     exe.root_module.addImport("tracy", tracy_module);
+     exe.root_module.addImport("diffz", diffz_module);
diff --git a/srcpkgs/zls/template b/srcpkgs/zls/template
index 887475ed8d2eab..93a2aa83c56d80 100644
--- a/srcpkgs/zls/template
+++ b/srcpkgs/zls/template
@@ -1,7 +1,7 @@
 # Template file for 'zls'
 pkgname=zls
 version=0.13.0
-revision=1
+revision=2
 build_style=zig-build
 configure_args="-Dpie"
 short_desc="Zig language server"

Re: [PR PATCH] [Updated] zls: link against system libc

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

There is an updated pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages zls-libc
https://github.com/void-linux/void-packages/pull/51394

zls: link against system libc
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51394.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zls-libc-51394.patch --]
[-- Type: text/x-diff, Size: 1390 bytes --]

From 6f0e82451c7faab57c4674d7c92b5fb94267fa34 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Tue, 23 Jul 2024 00:17:32 +0200
Subject: [PATCH] zls: link against system libc

---
 srcpkgs/zls/patches/link-libc.patch | 13 +++++++++++++
 srcpkgs/zls/template                |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/zls/patches/link-libc.patch

diff --git a/srcpkgs/zls/patches/link-libc.patch b/srcpkgs/zls/patches/link-libc.patch
new file mode 100644
index 00000000000000..4b9820aac2c2d6
--- /dev/null
+++ b/srcpkgs/zls/patches/link-libc.patch
@@ -0,0 +1,13 @@
+diff --git a/build.zig b/build.zig
+index 07c35fd..6ab3786 100644
+--- a/build.zig
++++ b/build.zig
+@@ -174,6 +174,8 @@ pub fn build(b: *Build) !void {
+         .pic = pie,
+         .use_llvm = use_llvm,
+         .use_lld = use_llvm,
++        .link_libc = true,
++        .linkage = std.builtin.LinkMode.dynamic,
+     });
+     exe.pie = pie;
+     exe.root_module.addImport("exe_options", exe_options_module);
diff --git a/srcpkgs/zls/template b/srcpkgs/zls/template
index 887475ed8d2eab..93a2aa83c56d80 100644
--- a/srcpkgs/zls/template
+++ b/srcpkgs/zls/template
@@ -1,7 +1,7 @@
 # Template file for 'zls'
 pkgname=zls
 version=0.13.0
-revision=1
+revision=2
 build_style=zig-build
 configure_args="-Dpie"
 short_desc="Zig language server"

Re: [PR PATCH] [Closed]: zls: link against system libc

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

There's a closed pull request on the void-packages repository

zls: link against system libc
https://github.com/void-linux/void-packages/pull/51394

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: zls: link against system libc

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/51394#issuecomment-2245647282

Comment:
ZLS and similar programs apparently don't need a libc, zig can emit syscalls directly