* [PR PATCH] nodejs: update to 20.16.0.
@ 2024-07-30 19:31 leahneukirchen
2024-08-01 11:56 ` [PR PATCH] [Updated] " leahneukirchen
2024-08-01 12:04 ` [PR PATCH] [Merged]: " leahneukirchen
0 siblings, 2 replies; 3+ messages in thread
From: leahneukirchen @ 2024-07-30 19:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
There is a new pull request by leahneukirchen against master on the void-packages repository
https://github.com/leahneukirchen/void-packages node20
https://github.com/void-linux/void-packages/pull/51555
nodejs: update to 20.16.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
Closes #50485
A patch file from https://github.com/void-linux/void-packages/pull/51555.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-node20-51555.patch --]
[-- Type: text/x-diff, Size: 9179 bytes --]
From 58f15ba4e3b0b41a1f97ab1a6d531524fceb59da Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Thu, 23 May 2024 14:21:06 +0200
Subject: [PATCH 1/3] nodejs: update to 20.16.0.
---
srcpkgs/nodejs/patches/cross-aarch64.patch | 51 +++++-----------------
srcpkgs/nodejs/patches/python312.patch | 19 --------
srcpkgs/nodejs/template | 51 +++++++++++++++++++---
3 files changed, 56 insertions(+), 65 deletions(-)
delete mode 100644 srcpkgs/nodejs/patches/python312.patch
diff --git a/srcpkgs/nodejs/patches/cross-aarch64.patch b/srcpkgs/nodejs/patches/cross-aarch64.patch
index fa05cb15813e89..93f9a4cd235b11 100644
--- a/srcpkgs/nodejs/patches/cross-aarch64.patch
+++ b/srcpkgs/nodejs/patches/cross-aarch64.patch
@@ -1,43 +1,14 @@
-From 6bdf9dc3ec7dbff00acef081f4e3dd3e061fd744 Mon Sep 17 00:00:00 2001
-From: Ben Noordhuis <info@bnoordhuis.nl>
-Date: Tue, 6 Dec 2022 11:27:49 +0100
-Subject: [PATCH] build: fix arm64 cross-compilation
-
-Commit 938212f added -msign-return-address=all to _all_ cflags but that
-is wrong when cross-compiling, it should only be added to the target's
-cflags.
-
-Fixes: https://github.com/nodejs/node/issues/42888
----
- configure.py | 2 --
- node.gyp | 3 +++
- 2 files changed, 3 insertions(+), 2 deletions(-)
-
-diff --git a/configure.py b/configure.py
-index 40e0395e..9de3148f 100755
---- a/configure.py
-+++ b/configure.py
-@@ -1294,9 +1294,7 @@ def configure_node(o):
-
- o['variables']['want_separate_host_toolset'] = int(cross_compiling)
-
-- # Enable branch protection for arm64
- if target_arch == 'arm64':
-- o['cflags']+=['-msign-return-address=all']
- o['variables']['arm_fpu'] = options.arm_fpu or 'neon'
-
- if options.node_snapshot_main is not None:
diff --git a/node.gyp b/node.gyp
-index cf52281b..5218d941 100644
+index 5abbad6c6f..460e4f1a86 100644
--- a/node.gyp
+++ b/node.gyp
-@@ -112,6 +112,9 @@
- },
-
- 'conditions': [
-+ ['target_arch=="arm64"', {
-+ 'cflags': ['-msign-return-address=all'], # Pointer authentication.
-+ }],
- ['OS in "aix os400"', {
- 'ldflags': [
- '-Wl,-bnoerrmsg',
+@@ -417,6 +417,9 @@
+ [ 'node_shared=="true"', {
+ 'node_target_type%': 'shared_library',
+ 'conditions': [
++ ['target_arch=="arm64"', {
++ 'cflags': ['-msign-return-address=all'], # Pointer authentication.
++ }],
+ ['OS in "aix os400"', {
+ # For AIX, always generate static library first,
+ # It needs an extra step to generate exp and
diff --git a/srcpkgs/nodejs/patches/python312.patch b/srcpkgs/nodejs/patches/python312.patch
deleted file mode 100644
index b5f1d22877f7e4..00000000000000
--- a/srcpkgs/nodejs/patches/python312.patch
+++ /dev/null
@@ -1,19 +0,0 @@
---- ./configure.orig 2023-10-11 07:49:24.971659089 -0400
-+++ ./configure 2023-10-11 07:49:51.615780727 -0400
-@@ -4,6 +4,7 @@
- # Note that the mix of single and double quotes is intentional,
- # as is the fact that the ] goes on a new line.
- _=[ 'exec' '/bin/sh' '-c' '''
-+command -v python3.12 >/dev/null && exec python3.12 "$0" "$@"
- command -v python3.11 >/dev/null && exec python3.11 "$0" "$@"
- command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
- command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
-@@ -23,7 +24,7 @@
- from distutils.spawn import find_executable as which
-
- print('Node.js configure: Found Python {}.{}.{}...'.format(*sys.version_info))
--acceptable_pythons = ((3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6))
-+acceptable_pythons = ((3, 12), (3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6))
- if sys.version_info[:2] in acceptable_pythons:
- import configure
- else:
diff --git a/srcpkgs/nodejs/template b/srcpkgs/nodejs/template
index 33d4fd11ad8a9e..08ac9829f70384 100644
--- a/srcpkgs/nodejs/template
+++ b/srcpkgs/nodejs/template
@@ -1,11 +1,14 @@
# Template file for 'nodejs'
pkgname=nodejs
-version=18.19.1
+version=20.16.0
revision=1
hostmakedepends="which pkg-config python3-setuptools"
-_make_depends="zlib-devel $(vopt_if icu icu-devel)
- $(vopt_if ssl openssl-devel) $(vopt_if libuv libuv-devel)
- $(vopt_if nghttp2 nghttp2-devel) $(vopt_if cares c-ares-devel)
+_make_depends="zlib-devel \
+ $(vopt_if icu icu-devel) \
+ $(vopt_if ssl openssl-devel) \
+ $(vopt_if libuv libuv-devel) \
+ $(vopt_if nghttp2 nghttp2-devel) \
+ $(vopt_if cares c-ares-devel) \
$(vopt_if brotli brotli-devel)"
makedepends="${_make_depends}"
checkdepends="procps-ng iana-etc"
@@ -15,7 +18,7 @@ license="MIT"
homepage="https://nodejs.org/"
changelog="https://raw.githubusercontent.com/nodejs/node/main/doc/changelogs/CHANGELOG_V${version%%.*}.md"
distfiles="https://nodejs.org/dist/v${version}/node-v${version}.tar.xz"
-checksum=090f96a2ecde080b6b382c6d642bca5d0be4702a78cb555be7bf02b20bd16ded
+checksum=cd6c8fc3ff2606aadbc7155db6f7e77247d2d0065ac18e2f7f049095584b8b46
python_version=3
build_options="ssl libuv icu nghttp2 cares brotli"
@@ -96,7 +99,43 @@ do_build() {
}
do_check() {
- local CI_SKIP_TESTS="test-child-process-uid-gid.js,test-process-euid-egid.js,test-process-uid-gid.js,test-tls-session-cache.js,test-tls-getprotocol.js,test-tls-alert.js,test-tls-cli-min-version-1.1.js,test-tls-cli-max-version-1.1.js,test-tls-cli-min-version-1.2.js,test-tls-cli-max-version-1.2.js,test-tls-cli-min-version-1.3.js,test-tls-cli-max-version-1.3.js,test-tls-min-max-version.js,test-process-versions.js,test-strace-openat-openssl.js,test-crypto-dh.js,test-dgram-send-cb-quelches-error.js,test-https-agent-session-eviction.js"
+ local CI_SKIP_TESTS="test-crypto-dh.js,\
+test-child-process-uid-gid.js,\
+test-cluster-primary-error.js,\
+test-cluster-primary-kill.js,\
+test-dns.js,\
+test-http2-https-fallback.js,\
+test-http2-server-unknown-protocol.js,\
+test-https-client-checkServerIdentity.js,\
+test-https-strict.js,\
+test-process-euid-egid.js,\
+test-process-initgroups.js,\
+test-process-setgroups.js,\
+test-process-uid-gid.js,\
+test-tls-alert-handling.js,\
+test-tls-alpn-server-client.js,\
+test-tls-cert-regression.js,\
+test-tls-client-auth.js,\
+test-tls-client-getephemeralkeyinfo.js,\
+test-tls-client-mindhsize.js,\
+test-tls-client-renegotiation-13.js,\
+test-tls-client-verify.js,\
+test-tls-dhe.js,\
+test-tls-empty-sni-context.js,\
+test-tls-enable-trace-cli.js,\
+test-tls-enable-trace.js,\
+test-tls-getcipher.js,\
+test-tls-junk-closes-server.js,\
+test-tls-junk-server.js,\
+test-tls-multi-key.js,\
+test-tls-multiple-cas-as-string.js,\
+test-tls-peer-certificate-encoding.js,\
+test-tls-psk-circuit.js,\
+test-tls-server-verify.js,\
+test-tls-set-ciphers.js,\
+test-tls-sni-option.js,\
+test-tls-sni-server-client.js,\
+"
# https://github.com/nodejs/node/issues/50741
CI_SKIP_TESTS+=",test-dns-resolveany.js,test-dns-resolveany-bad-ancount.js"
From 25e7880917792654e59c551f77c8eab6bffec033 Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Thu, 23 May 2024 14:24:32 +0200
Subject: [PATCH 2/3] Rocket.Chat: rebuild for new nodejs version
---
srcpkgs/Rocket.Chat-Desktop/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/Rocket.Chat-Desktop/template b/srcpkgs/Rocket.Chat-Desktop/template
index d7ecb67b7473f3..d59851bc87f946 100644
--- a/srcpkgs/Rocket.Chat-Desktop/template
+++ b/srcpkgs/Rocket.Chat-Desktop/template
@@ -1,7 +1,7 @@
# Template file for 'Rocket.Chat-Desktop'
pkgname=Rocket.Chat-Desktop
version=3.8.7
-revision=2
+revision=3
_electron_ver=19
hostmakedepends="yarn nodejs python3 pkg-config app-builder"
makedepends="electron${_electron_ver} libvips-devel"
@@ -31,6 +31,7 @@ do_configure() {
do_build() {
export NODE_ENV=production
+ export NODE_OPTIONS=--openssl-legacy-provider
yarn build
yarn run electron-builder --linux --x64 --dir \
-c.electronDist=/usr/lib/electron${_electron_ver} \
From e80d37e24b52b29a40c9484fe955056c5272c2c9 Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Thu, 23 May 2024 14:26:40 +0200
Subject: [PATCH 3/3] Signal-Desktop: rebuild for new nodejs version
---
srcpkgs/Signal-Desktop/template | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index 1d433fa2c3515b..541febf3175bc8 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -1,7 +1,7 @@
# Template file for 'Signal-Desktop'
pkgname=Signal-Desktop
version=7.16.0
-revision=1
+revision=2
# Signal officially only supports x86_64
# x86_64-musl could potentially work based on the Alpine port:
# https://git.alpinelinux.org/aports/tree/testing/signal-desktop
@@ -21,9 +21,7 @@ post_extract() {
# git-lfs hook needs to be installed for one of the dependencies
git lfs install
- # FIXME: We currently don't have the latest Node so let's force Signal
- # to use what we have. This is very far from ideal.
- vsed 's/"node": ".*"/"node": ">=18.19.1"/' -i package.json
+ vsed 's/"node": ".*"/"node": ">=20.0.0"/' -i package.json
npm install -g yarn
# Dependencies have to be installed before applying patch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Updated] nodejs: update to 20.16.0.
2024-07-30 19:31 [PR PATCH] nodejs: update to 20.16.0 leahneukirchen
@ 2024-08-01 11:56 ` leahneukirchen
2024-08-01 12:04 ` [PR PATCH] [Merged]: " leahneukirchen
1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2024-08-01 11:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
There is an updated pull request by leahneukirchen against master on the void-packages repository
https://github.com/leahneukirchen/void-packages node20
https://github.com/void-linux/void-packages/pull/51555
nodejs: update to 20.16.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
Closes #50485
A patch file from https://github.com/void-linux/void-packages/pull/51555.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-node20-51555.patch --]
[-- Type: text/x-diff, Size: 9179 bytes --]
From 0d978980dc5da4b12446d5eea9a221d460146b28 Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Thu, 23 May 2024 14:21:06 +0200
Subject: [PATCH 1/3] nodejs: update to 20.16.0.
---
srcpkgs/nodejs/patches/cross-aarch64.patch | 51 +++++-----------------
srcpkgs/nodejs/patches/python312.patch | 19 --------
srcpkgs/nodejs/template | 51 +++++++++++++++++++---
3 files changed, 56 insertions(+), 65 deletions(-)
delete mode 100644 srcpkgs/nodejs/patches/python312.patch
diff --git a/srcpkgs/nodejs/patches/cross-aarch64.patch b/srcpkgs/nodejs/patches/cross-aarch64.patch
index fa05cb15813e89..93f9a4cd235b11 100644
--- a/srcpkgs/nodejs/patches/cross-aarch64.patch
+++ b/srcpkgs/nodejs/patches/cross-aarch64.patch
@@ -1,43 +1,14 @@
-From 6bdf9dc3ec7dbff00acef081f4e3dd3e061fd744 Mon Sep 17 00:00:00 2001
-From: Ben Noordhuis <info@bnoordhuis.nl>
-Date: Tue, 6 Dec 2022 11:27:49 +0100
-Subject: [PATCH] build: fix arm64 cross-compilation
-
-Commit 938212f added -msign-return-address=all to _all_ cflags but that
-is wrong when cross-compiling, it should only be added to the target's
-cflags.
-
-Fixes: https://github.com/nodejs/node/issues/42888
----
- configure.py | 2 --
- node.gyp | 3 +++
- 2 files changed, 3 insertions(+), 2 deletions(-)
-
-diff --git a/configure.py b/configure.py
-index 40e0395e..9de3148f 100755
---- a/configure.py
-+++ b/configure.py
-@@ -1294,9 +1294,7 @@ def configure_node(o):
-
- o['variables']['want_separate_host_toolset'] = int(cross_compiling)
-
-- # Enable branch protection for arm64
- if target_arch == 'arm64':
-- o['cflags']+=['-msign-return-address=all']
- o['variables']['arm_fpu'] = options.arm_fpu or 'neon'
-
- if options.node_snapshot_main is not None:
diff --git a/node.gyp b/node.gyp
-index cf52281b..5218d941 100644
+index 5abbad6c6f..460e4f1a86 100644
--- a/node.gyp
+++ b/node.gyp
-@@ -112,6 +112,9 @@
- },
-
- 'conditions': [
-+ ['target_arch=="arm64"', {
-+ 'cflags': ['-msign-return-address=all'], # Pointer authentication.
-+ }],
- ['OS in "aix os400"', {
- 'ldflags': [
- '-Wl,-bnoerrmsg',
+@@ -417,6 +417,9 @@
+ [ 'node_shared=="true"', {
+ 'node_target_type%': 'shared_library',
+ 'conditions': [
++ ['target_arch=="arm64"', {
++ 'cflags': ['-msign-return-address=all'], # Pointer authentication.
++ }],
+ ['OS in "aix os400"', {
+ # For AIX, always generate static library first,
+ # It needs an extra step to generate exp and
diff --git a/srcpkgs/nodejs/patches/python312.patch b/srcpkgs/nodejs/patches/python312.patch
deleted file mode 100644
index b5f1d22877f7e4..00000000000000
--- a/srcpkgs/nodejs/patches/python312.patch
+++ /dev/null
@@ -1,19 +0,0 @@
---- ./configure.orig 2023-10-11 07:49:24.971659089 -0400
-+++ ./configure 2023-10-11 07:49:51.615780727 -0400
-@@ -4,6 +4,7 @@
- # Note that the mix of single and double quotes is intentional,
- # as is the fact that the ] goes on a new line.
- _=[ 'exec' '/bin/sh' '-c' '''
-+command -v python3.12 >/dev/null && exec python3.12 "$0" "$@"
- command -v python3.11 >/dev/null && exec python3.11 "$0" "$@"
- command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
- command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
-@@ -23,7 +24,7 @@
- from distutils.spawn import find_executable as which
-
- print('Node.js configure: Found Python {}.{}.{}...'.format(*sys.version_info))
--acceptable_pythons = ((3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6))
-+acceptable_pythons = ((3, 12), (3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6))
- if sys.version_info[:2] in acceptable_pythons:
- import configure
- else:
diff --git a/srcpkgs/nodejs/template b/srcpkgs/nodejs/template
index 33d4fd11ad8a9e..08ac9829f70384 100644
--- a/srcpkgs/nodejs/template
+++ b/srcpkgs/nodejs/template
@@ -1,11 +1,14 @@
# Template file for 'nodejs'
pkgname=nodejs
-version=18.19.1
+version=20.16.0
revision=1
hostmakedepends="which pkg-config python3-setuptools"
-_make_depends="zlib-devel $(vopt_if icu icu-devel)
- $(vopt_if ssl openssl-devel) $(vopt_if libuv libuv-devel)
- $(vopt_if nghttp2 nghttp2-devel) $(vopt_if cares c-ares-devel)
+_make_depends="zlib-devel \
+ $(vopt_if icu icu-devel) \
+ $(vopt_if ssl openssl-devel) \
+ $(vopt_if libuv libuv-devel) \
+ $(vopt_if nghttp2 nghttp2-devel) \
+ $(vopt_if cares c-ares-devel) \
$(vopt_if brotli brotli-devel)"
makedepends="${_make_depends}"
checkdepends="procps-ng iana-etc"
@@ -15,7 +18,7 @@ license="MIT"
homepage="https://nodejs.org/"
changelog="https://raw.githubusercontent.com/nodejs/node/main/doc/changelogs/CHANGELOG_V${version%%.*}.md"
distfiles="https://nodejs.org/dist/v${version}/node-v${version}.tar.xz"
-checksum=090f96a2ecde080b6b382c6d642bca5d0be4702a78cb555be7bf02b20bd16ded
+checksum=cd6c8fc3ff2606aadbc7155db6f7e77247d2d0065ac18e2f7f049095584b8b46
python_version=3
build_options="ssl libuv icu nghttp2 cares brotli"
@@ -96,7 +99,43 @@ do_build() {
}
do_check() {
- local CI_SKIP_TESTS="test-child-process-uid-gid.js,test-process-euid-egid.js,test-process-uid-gid.js,test-tls-session-cache.js,test-tls-getprotocol.js,test-tls-alert.js,test-tls-cli-min-version-1.1.js,test-tls-cli-max-version-1.1.js,test-tls-cli-min-version-1.2.js,test-tls-cli-max-version-1.2.js,test-tls-cli-min-version-1.3.js,test-tls-cli-max-version-1.3.js,test-tls-min-max-version.js,test-process-versions.js,test-strace-openat-openssl.js,test-crypto-dh.js,test-dgram-send-cb-quelches-error.js,test-https-agent-session-eviction.js"
+ local CI_SKIP_TESTS="test-crypto-dh.js,\
+test-child-process-uid-gid.js,\
+test-cluster-primary-error.js,\
+test-cluster-primary-kill.js,\
+test-dns.js,\
+test-http2-https-fallback.js,\
+test-http2-server-unknown-protocol.js,\
+test-https-client-checkServerIdentity.js,\
+test-https-strict.js,\
+test-process-euid-egid.js,\
+test-process-initgroups.js,\
+test-process-setgroups.js,\
+test-process-uid-gid.js,\
+test-tls-alert-handling.js,\
+test-tls-alpn-server-client.js,\
+test-tls-cert-regression.js,\
+test-tls-client-auth.js,\
+test-tls-client-getephemeralkeyinfo.js,\
+test-tls-client-mindhsize.js,\
+test-tls-client-renegotiation-13.js,\
+test-tls-client-verify.js,\
+test-tls-dhe.js,\
+test-tls-empty-sni-context.js,\
+test-tls-enable-trace-cli.js,\
+test-tls-enable-trace.js,\
+test-tls-getcipher.js,\
+test-tls-junk-closes-server.js,\
+test-tls-junk-server.js,\
+test-tls-multi-key.js,\
+test-tls-multiple-cas-as-string.js,\
+test-tls-peer-certificate-encoding.js,\
+test-tls-psk-circuit.js,\
+test-tls-server-verify.js,\
+test-tls-set-ciphers.js,\
+test-tls-sni-option.js,\
+test-tls-sni-server-client.js,\
+"
# https://github.com/nodejs/node/issues/50741
CI_SKIP_TESTS+=",test-dns-resolveany.js,test-dns-resolveany-bad-ancount.js"
From 1614214816a196c792674422ea6bc5ab38d46a62 Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Thu, 23 May 2024 14:24:32 +0200
Subject: [PATCH 2/3] Rocket.Chat: rebuild for new nodejs version
---
srcpkgs/Rocket.Chat-Desktop/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/Rocket.Chat-Desktop/template b/srcpkgs/Rocket.Chat-Desktop/template
index d7ecb67b7473f3..d59851bc87f946 100644
--- a/srcpkgs/Rocket.Chat-Desktop/template
+++ b/srcpkgs/Rocket.Chat-Desktop/template
@@ -1,7 +1,7 @@
# Template file for 'Rocket.Chat-Desktop'
pkgname=Rocket.Chat-Desktop
version=3.8.7
-revision=2
+revision=3
_electron_ver=19
hostmakedepends="yarn nodejs python3 pkg-config app-builder"
makedepends="electron${_electron_ver} libvips-devel"
@@ -31,6 +31,7 @@ do_configure() {
do_build() {
export NODE_ENV=production
+ export NODE_OPTIONS=--openssl-legacy-provider
yarn build
yarn run electron-builder --linux --x64 --dir \
-c.electronDist=/usr/lib/electron${_electron_ver} \
From 62a30af8a71badd578073e64881a496f54ae1a5f Mon Sep 17 00:00:00 2001
From: Mihail Ivanchev <contact@ivanchev.net>
Date: Thu, 23 May 2024 14:26:40 +0200
Subject: [PATCH 3/3] Signal-Desktop: rebuild for new nodejs version
---
srcpkgs/Signal-Desktop/template | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index 1a02606df079e4..41dfceb629e17b 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -1,7 +1,7 @@
# Template file for 'Signal-Desktop'
pkgname=Signal-Desktop
version=7.17.0
-revision=1
+revision=2
# Signal officially only supports x86_64
# x86_64-musl could potentially work based on the Alpine port:
# https://git.alpinelinux.org/aports/tree/testing/signal-desktop
@@ -21,9 +21,7 @@ post_extract() {
# git-lfs hook needs to be installed for one of the dependencies
git lfs install
- # FIXME: We currently don't have the latest Node so let's force Signal
- # to use what we have. This is very far from ideal.
- vsed 's/"node": ".*"/"node": ">=18.19.1"/' -i package.json
+ vsed 's/"node": ".*"/"node": ">=20.0.0"/' -i package.json
npm install -g yarn
# Dependencies have to be installed before applying patch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Merged]: nodejs: update to 20.16.0.
2024-07-30 19:31 [PR PATCH] nodejs: update to 20.16.0 leahneukirchen
2024-08-01 11:56 ` [PR PATCH] [Updated] " leahneukirchen
@ 2024-08-01 12:04 ` leahneukirchen
1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2024-08-01 12:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There's a merged pull request on the void-packages repository
nodejs: update to 20.16.0.
https://github.com/void-linux/void-packages/pull/51555
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
Closes #50485
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-01 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-30 19:31 [PR PATCH] nodejs: update to 20.16.0 leahneukirchen
2024-08-01 11:56 ` [PR PATCH] [Updated] " leahneukirchen
2024-08-01 12:04 ` [PR PATCH] [Merged]: " leahneukirchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).