Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libcaca: update to 0.99.beta20
@ 2024-08-14 11:02 xeroxslayer
  2024-08-14 11:04 ` [PR REVIEW] " classabbyamp
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: xeroxslayer @ 2024-08-14 11:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

There is a new pull request by xeroxslayer against master on the void-packages repository

https://github.com/xeroxslayer/void-packages libcaca
https://github.com/void-linux/void-packages/pull/51843

libcaca: update to 0.99.beta20
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7
  - armv7l-musl

There is no need for the `vsed` part in `pre_configure()`, it has been corrected upstream.


A patch file from https://github.com/void-linux/void-packages/pull/51843.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcaca-51843.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

From 67e48605604f487d26cce870209be21d4f5bdf75 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Wed, 14 Aug 2024 12:59:04 +0200
Subject: [PATCH] libcaca: update to 0.99.beta20

---
 srcpkgs/libcaca/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/libcaca/template b/srcpkgs/libcaca/template
index 7f85192744dd86..895eec9c9d86fc 100644
--- a/srcpkgs/libcaca/template
+++ b/srcpkgs/libcaca/template
@@ -1,7 +1,7 @@
 # Template file for 'libcaca'
 pkgname=libcaca
-version=0.99.beta19
-revision=13
+version=0.99.beta20
+revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable x11)"
 hostmakedepends="libtool automake pkg-config"
@@ -11,17 +11,16 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="WTFPL"
 homepage="http://caca.zoy.org/wiki/libcaca"
 distfiles="https://github.com/cacalabs/libcaca/archive/v${version}.tar.gz"
-checksum=7ed29a00cc7f017424d8b2994f001f137ed5bc4441987b711d78c6734fdf3493
+checksum="3edb8763a8f888ed4d4b85b3a056e81c840d5d27f79bdebc0b991688b23084f2"
 
 build_options="x11 opengl"
 
 pre_configure() {
-	vsed -i -e 's,AM_CONFIG_HEADER,AC_CONFIG_HEADERS,' configure.ac
 	autoreconf -fi
 }
 
 post_install() {
-	rm ${DESTDIR}/usr/lib/*.la
+	rm -f ${DESTDIR}/usr/lib/*.la
 }
 
 libcaca-devel_package() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] libcaca: update to 0.99.beta20
  2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
@ 2024-08-14 11:04 ` classabbyamp
  2024-08-14 11:09 ` xeroxslayer
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-08-14 11:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51843#discussion_r1716730204

Comment:
don't use -f, it obscures useless removals

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] libcaca: update to 0.99.beta20
  2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
  2024-08-14 11:04 ` [PR REVIEW] " classabbyamp
@ 2024-08-14 11:09 ` xeroxslayer
  2024-08-14 11:11 ` [PR PATCH] [Updated] " xeroxslayer
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: xeroxslayer @ 2024-08-14 11:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/51843#discussion_r1716736765

Comment:
OK, will correct that.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] libcaca: update to 0.99.beta20
  2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
  2024-08-14 11:04 ` [PR REVIEW] " classabbyamp
  2024-08-14 11:09 ` xeroxslayer
@ 2024-08-14 11:11 ` xeroxslayer
  2024-08-15  3:42 ` classabbyamp
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: xeroxslayer @ 2024-08-14 11:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

There is an updated pull request by xeroxslayer against master on the void-packages repository

https://github.com/xeroxslayer/void-packages libcaca
https://github.com/void-linux/void-packages/pull/51843

libcaca: update to 0.99.beta20
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7
  - armv7l-musl

There is no need for the `vsed` part in `pre_configure()`, it has been corrected upstream.


A patch file from https://github.com/void-linux/void-packages/pull/51843.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcaca-51843.patch --]
[-- Type: text/x-diff, Size: 1929 bytes --]

From 67e48605604f487d26cce870209be21d4f5bdf75 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Wed, 14 Aug 2024 12:59:04 +0200
Subject: [PATCH 1/2] libcaca: update to 0.99.beta20

---
 srcpkgs/libcaca/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/libcaca/template b/srcpkgs/libcaca/template
index 7f85192744dd86..895eec9c9d86fc 100644
--- a/srcpkgs/libcaca/template
+++ b/srcpkgs/libcaca/template
@@ -1,7 +1,7 @@
 # Template file for 'libcaca'
 pkgname=libcaca
-version=0.99.beta19
-revision=13
+version=0.99.beta20
+revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable x11)"
 hostmakedepends="libtool automake pkg-config"
@@ -11,17 +11,16 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="WTFPL"
 homepage="http://caca.zoy.org/wiki/libcaca"
 distfiles="https://github.com/cacalabs/libcaca/archive/v${version}.tar.gz"
-checksum=7ed29a00cc7f017424d8b2994f001f137ed5bc4441987b711d78c6734fdf3493
+checksum="3edb8763a8f888ed4d4b85b3a056e81c840d5d27f79bdebc0b991688b23084f2"
 
 build_options="x11 opengl"
 
 pre_configure() {
-	vsed -i -e 's,AM_CONFIG_HEADER,AC_CONFIG_HEADERS,' configure.ac
 	autoreconf -fi
 }
 
 post_install() {
-	rm ${DESTDIR}/usr/lib/*.la
+	rm -f ${DESTDIR}/usr/lib/*.la
 }
 
 libcaca-devel_package() {

From 5154b83b4a7d59f2e4e31bbdff0a21d65552d06a Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Wed, 14 Aug 2024 13:11:06 +0200
Subject: [PATCH 2/2] libcaca: update to 0.99.beta20

---
 srcpkgs/libcaca/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/libcaca/template b/srcpkgs/libcaca/template
index 895eec9c9d86fc..c889b6a872c90b 100644
--- a/srcpkgs/libcaca/template
+++ b/srcpkgs/libcaca/template
@@ -20,7 +20,7 @@ pre_configure() {
 }
 
 post_install() {
-	rm -f ${DESTDIR}/usr/lib/*.la
+	rm ${DESTDIR}/usr/lib/*.la
 }
 
 libcaca-devel_package() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: libcaca: update to 0.99.beta20
  2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
                   ` (2 preceding siblings ...)
  2024-08-14 11:11 ` [PR PATCH] [Updated] " xeroxslayer
@ 2024-08-15  3:42 ` classabbyamp
  2024-08-15  7:21 ` [PR PATCH] [Updated] " xeroxslayer
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-08-15  3:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51843#issuecomment-2290504910

Comment:
squash commits please

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] libcaca: update to 0.99.beta20
  2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
                   ` (3 preceding siblings ...)
  2024-08-15  3:42 ` classabbyamp
@ 2024-08-15  7:21 ` xeroxslayer
  2024-08-15  7:22 ` xeroxslayer
  2024-08-15 11:31 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: xeroxslayer @ 2024-08-15  7:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is an updated pull request by xeroxslayer against master on the void-packages repository

https://github.com/xeroxslayer/void-packages libcaca
https://github.com/void-linux/void-packages/pull/51843

libcaca: update to 0.99.beta20
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7
  - armv7l-musl

There is no need for the `vsed` part in `pre_configure()`, it has been corrected upstream.


A patch file from https://github.com/void-linux/void-packages/pull/51843.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libcaca-51843.patch --]
[-- Type: text/x-diff, Size: 1262 bytes --]

From c59ded2e0ce31564845592fe6b67334b82a40669 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Wed, 14 Aug 2024 12:59:04 +0200
Subject: [PATCH] libcaca: update to 0.99.beta20

libcaca: update to 0.99.beta20

libcaca: update to 0.99.beta20
---
 srcpkgs/libcaca/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/libcaca/template b/srcpkgs/libcaca/template
index 7f85192744dd86..c889b6a872c90b 100644
--- a/srcpkgs/libcaca/template
+++ b/srcpkgs/libcaca/template
@@ -1,7 +1,7 @@
 # Template file for 'libcaca'
 pkgname=libcaca
-version=0.99.beta19
-revision=13
+version=0.99.beta20
+revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable x11)"
 hostmakedepends="libtool automake pkg-config"
@@ -11,12 +11,11 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="WTFPL"
 homepage="http://caca.zoy.org/wiki/libcaca"
 distfiles="https://github.com/cacalabs/libcaca/archive/v${version}.tar.gz"
-checksum=7ed29a00cc7f017424d8b2994f001f137ed5bc4441987b711d78c6734fdf3493
+checksum="3edb8763a8f888ed4d4b85b3a056e81c840d5d27f79bdebc0b991688b23084f2"
 
 build_options="x11 opengl"
 
 pre_configure() {
-	vsed -i -e 's,AM_CONFIG_HEADER,AC_CONFIG_HEADERS,' configure.ac
 	autoreconf -fi
 }
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: libcaca: update to 0.99.beta20
  2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
                   ` (4 preceding siblings ...)
  2024-08-15  7:21 ` [PR PATCH] [Updated] " xeroxslayer
@ 2024-08-15  7:22 ` xeroxslayer
  2024-08-15 11:31 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: xeroxslayer @ 2024-08-15  7:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/51843#issuecomment-2290806627

Comment:
Done.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: libcaca: update to 0.99.beta20
  2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
                   ` (5 preceding siblings ...)
  2024-08-15  7:22 ` xeroxslayer
@ 2024-08-15 11:31 ` classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-08-15 11:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

There's a merged pull request on the void-packages repository

libcaca: update to 0.99.beta20
https://github.com/void-linux/void-packages/pull/51843

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7
  - armv7l-musl

There is no need for the `vsed` part in `pre_configure()`, it has been corrected upstream.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-08-15 11:31 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-14 11:02 [PR PATCH] libcaca: update to 0.99.beta20 xeroxslayer
2024-08-14 11:04 ` [PR REVIEW] " classabbyamp
2024-08-14 11:09 ` xeroxslayer
2024-08-14 11:11 ` [PR PATCH] [Updated] " xeroxslayer
2024-08-15  3:42 ` classabbyamp
2024-08-15  7:21 ` [PR PATCH] [Updated] " xeroxslayer
2024-08-15  7:22 ` xeroxslayer
2024-08-15 11:31 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).