[PR PATCH] New package: neovide-0.13.3

[PR PATCH] New package: neovide-0.13.3

[hesam-init]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

There is a new pull request by hesam-init against master on the void-packages repository

https://github.com/void-land/void-packages neovide
https://github.com/void-linux/void-packages/pull/51601

New package: neovide-0.13.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51601.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-neovide-51601.patch --]
[-- Type: text/x-diff, Size: 1217 bytes --]

From 48ab01f7c58c3d5080ca0295173497963c266dfb Mon Sep 17 00:00:00 2001
From: hesam-init <hesam.init@gmail.com>
Date: Fri, 2 Aug 2024 09:35:41 +0330
Subject: [PATCH] New package: neovide-0.13.3

---
 srcpkgs/neovide/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/neovide/template

diff --git a/srcpkgs/neovide/template b/srcpkgs/neovide/template
new file mode 100644
index 00000000000000..05b94b64cb6645
--- /dev/null
+++ b/srcpkgs/neovide/template
@@ -0,0 +1,22 @@
+# Template file for 'neovide'
+pkgname=neovide
+version=0.13.3
+revision=1
+build_style=cargo
+hostmakedepends="fontconfig-devel freetype-devel libxkbcommon-devel"
+makedepends="python3"
+depends="neovim libxkbcommon-x11 libglvnd"
+short_desc="No Nonsense Neovim Client in Rust"
+maintainer="hesam-init <hesam.init@gmail.com>"
+license=MIT
+homepage=https://github.com/neovide/neovide
+distfiles="https://github.com/neovide/neovide/archive/refs/tags/${version}.tar.gz"
+checksum="21c8eaa53cf3290d2b1405c8cb2cde5f39bc14ef597b328e76f1789b0ef3539a"
+
+post_install() {
+	vmkdir usr/share/pixmaps
+
+	vcopy assets/neo* usr/share/pixmaps
+
+	vinstall assets/neovide.desktop 644 usr/share/applications
+}

Re: [PR PATCH] [Updated] New package: neovide-0.13.3

[hesam-init]

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

There is an updated pull request by hesam-init against master on the void-packages repository

https://github.com/void-land/void-packages neovide
https://github.com/void-linux/void-packages/pull/51601

New package: neovide-0.13.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51601.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-neovide-51601.patch --]
[-- Type: text/x-diff, Size: 2244 bytes --]

From 48ab01f7c58c3d5080ca0295173497963c266dfb Mon Sep 17 00:00:00 2001
From: hesam-init <hesam.init@gmail.com>
Date: Fri, 2 Aug 2024 09:35:41 +0330
Subject: [PATCH 1/2] New package: neovide-0.13.3

---
 srcpkgs/neovide/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/neovide/template

diff --git a/srcpkgs/neovide/template b/srcpkgs/neovide/template
new file mode 100644
index 00000000000000..05b94b64cb6645
--- /dev/null
+++ b/srcpkgs/neovide/template
@@ -0,0 +1,22 @@
+# Template file for 'neovide'
+pkgname=neovide
+version=0.13.3
+revision=1
+build_style=cargo
+hostmakedepends="fontconfig-devel freetype-devel libxkbcommon-devel"
+makedepends="python3"
+depends="neovim libxkbcommon-x11 libglvnd"
+short_desc="No Nonsense Neovim Client in Rust"
+maintainer="hesam-init <hesam.init@gmail.com>"
+license=MIT
+homepage=https://github.com/neovide/neovide
+distfiles="https://github.com/neovide/neovide/archive/refs/tags/${version}.tar.gz"
+checksum="21c8eaa53cf3290d2b1405c8cb2cde5f39bc14ef597b328e76f1789b0ef3539a"
+
+post_install() {
+	vmkdir usr/share/pixmaps
+
+	vcopy assets/neo* usr/share/pixmaps
+
+	vinstall assets/neovide.desktop 644 usr/share/applications
+}

From 751b4be4cbad4a4d649988470dcc471845106a09 Mon Sep 17 00:00:00 2001
From: hesam-init <hesam.init@gmail.com>
Date: Fri, 2 Aug 2024 09:44:26 +0330
Subject: [PATCH 2/2] neovide: fix license

---
 srcpkgs/neovide/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/neovide/template b/srcpkgs/neovide/template
index 05b94b64cb6645..5274653444c29b 100644
--- a/srcpkgs/neovide/template
+++ b/srcpkgs/neovide/template
@@ -8,7 +8,7 @@ makedepends="python3"
 depends="neovim libxkbcommon-x11 libglvnd"
 short_desc="No Nonsense Neovim Client in Rust"
 maintainer="hesam-init <hesam.init@gmail.com>"
-license=MIT
+license="MIT"
 homepage=https://github.com/neovide/neovide
 distfiles="https://github.com/neovide/neovide/archive/refs/tags/${version}.tar.gz"
 checksum="21c8eaa53cf3290d2b1405c8cb2cde5f39bc14ef597b328e76f1789b0ef3539a"
@@ -19,4 +19,6 @@ post_install() {
 	vcopy assets/neo* usr/share/pixmaps
 
 	vinstall assets/neovide.desktop 644 usr/share/applications
+
+	vlicense LICENSE
 }

Re: New package: neovide-0.13.3

[alexdaguy]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by alexdaguy on void-packages repository

https://github.com/void-linux/void-packages/pull/51601#issuecomment-2295190251

Comment:
I had to add `curl` to `hostmakedepends` to get it to build because of `rust-skia`

Re: [PR PATCH] [Closed]: New package: neovide-0.13.3

[void-land]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

There's a closed pull request on the void-packages repository

New package: neovide-0.13.3
https://github.com/void-linux/void-packages/pull/51601

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: New package: neovide-0.13.3

[sweiglbosker]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by sweiglbosker on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2936087157

Comment:
dropped in favor of https://github.com/void-linux/void-packages/pull/55149

Re: New package: neovide-0.13.3

[sweiglbosker]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by sweiglbosker on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2773134589

Comment:
bumping, I am still interested in seeing this packaged

Re: New package: neovide-0.13.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2771100205

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: neovide-0.13.3

[sweiglbosker]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by sweiglbosker on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2567107457

Comment:
Done. I am not sure how to approach musl support though, any direction is appreciated. 

Re: New package: neovide-0.13.3

[sweiglbosker]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by sweiglbosker on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2557995599

Comment:
its actually in `makedepends` right now, will make change shortly. Even if the benefit is only semantic it seems like a good idea.

Re: New package: neovide-0.13.3

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2557799695

Comment:
> neovim dependency (needed for cargo test, to pass workflow checks) increases build time by a ton.
>
You're referring to the rust crate for NeoVim? The NeoVim Void Linux package shouldn't be compiled if your branch is up to date with the Void Linux master branch. (You probably added the dependency to `checkdepends`?)

If possible, tests should be enabled.

Re: New package: neovide-0.13.3

[sweiglbosker]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by sweiglbosker on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2557623192

Comment:
this should be fixed, but ive noticed that adding the `neovim` dependency (needed for cargo test, to pass workflow checks) increases build time by a ton. will this be a problem?

Re: New package: neovide-0.13.3

[sweiglbosker]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

New comment by sweiglbosker on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2557623192

Comment:
this should be fixed, but ive noticed that adding the `neovide` dependency (needed for cargo test, to pass workflow checks) increases build time by a ton. will this be a problem?

Re: New package: neovide-0.13.3

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/53515#issuecomment-2555790036

Comment:
This seems to miss the desktop entry I assume? Ref https://github.com/void-linux/void-packages/pull/51601/files