Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] oils: renamed old names
@ 2024-08-24  4:58 bugcrazy
  2024-08-24  5:17 ` [PR PATCH] [Updated] " bugcrazy
                   ` (23 more replies)
  0 siblings, 24 replies; 25+ messages in thread
From: bugcrazy @ 2024-08-24  4:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

There is a new pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-21
https://github.com/void-linux/void-packages/pull/51964

oils: renamed old names
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51964.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-21-51964.patch --]
[-- Type: text/x-diff, Size: 1404 bytes --]

From d4555c5dc8981ed5fb92e62c0efb88d7e04f2190 Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Fri, 23 Aug 2024 19:24:40 -0300
Subject: [PATCH] oils: renamed old names

---
 srcpkgs/{oil => oils}/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
 rename srcpkgs/{oil => oils}/template (83%)

diff --git a/srcpkgs/oil/template b/srcpkgs/oils/template
similarity index 83%
rename from srcpkgs/oil/template
rename to srcpkgs/oils/template
index c1a9bd148a279d..252b161fa7fadc 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oils/template
@@ -1,5 +1,5 @@
-# Template file for 'oil'
-pkgname=oil
+# Template file for 'oils'
+pkgname=oils
 version=0.22.0
 revision=1
 build_style=configure
@@ -12,7 +12,8 @@ license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="https://www.oilshell.org/download/oil-${version}.tar.xz"
 checksum=452e7fd428b686aa752cfeb9be2b94f9fcf7ba9ab22e0ae570a87cdcf782242e
-register_shell="/usr/bin/osh /usr/bin/oil"
+replaces="oil<=0.23.0"
+register_shell="/usr/bin/osh /usr/bin/ysh"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -28,8 +29,8 @@ do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
 	vman doc/osh.1
-	# Symlink osh, oil to oil.ovm.
+	# Symlink osh, ysh to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oil
+	ln -s oil.ovm ysh
 }

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
@ 2024-08-24  5:17 ` bugcrazy
  2024-08-24  5:48 ` [PR REVIEW] " classabbyamp
                   ` (22 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-08-24  5:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-21
https://github.com/void-linux/void-packages/pull/51964

oils: renamed old names
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51964.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-21-51964.patch --]
[-- Type: text/x-diff, Size: 1632 bytes --]

From aec6387f8338f660dfabd478a0c30b3eafb86adc Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Sat, 24 Aug 2024 02:20:54 -0300
Subject: [PATCH] oils: renamed old names

---
 srcpkgs/{oil => oils}/template | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
 rename srcpkgs/{oil => oils}/template (79%)

diff --git a/srcpkgs/oil/template b/srcpkgs/oils/template
similarity index 79%
rename from srcpkgs/oil/template
rename to srcpkgs/oils/template
index c1a9bd148a279d..f6c2d61c3acc17 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oils/template
@@ -1,18 +1,19 @@
-# Template file for 'oil'
-pkgname=oil
+# Template file for 'oils'
+pkgname=oils
 version=0.22.0
 revision=1
 build_style=configure
 configure_args="--prefix=/usr"
 hostmakedepends="$(vopt_if readline readline-devel)"
 makedepends="$hostmakedepends"
-short_desc="Oil, a new unix shell"
+short_desc="Oils, a new unix shell"
 maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
 license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="https://www.oilshell.org/download/oil-${version}.tar.xz"
 checksum=452e7fd428b686aa752cfeb9be2b94f9fcf7ba9ab22e0ae570a87cdcf782242e
-register_shell="/usr/bin/osh /usr/bin/oil"
+replaces="oil<=0.23.0"
+register_shell="/usr/bin/osh /usr/bin/ysh"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -28,8 +29,8 @@ do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
 	vman doc/osh.1
-	# Symlink osh, oil to oil.ovm.
+	# Symlink osh, ysh to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oil
+	ln -s oil.ovm ysh
 }

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
  2024-08-24  5:17 ` [PR PATCH] [Updated] " bugcrazy
@ 2024-08-24  5:48 ` classabbyamp
  2024-08-24 14:35 ` ahesford
                   ` (21 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: classabbyamp @ 2024-08-24  5:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#discussion_r1729776507

Comment:
should be a transitional subpackage not replaces

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
  2024-08-24  5:17 ` [PR PATCH] [Updated] " bugcrazy
  2024-08-24  5:48 ` [PR REVIEW] " classabbyamp
@ 2024-08-24 14:35 ` ahesford
  2024-08-24 17:32 ` bugcrazy
                   ` (20 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: ahesford @ 2024-08-24 14:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#discussion_r1730008026

Comment:
I think both replace and a transitional subpackage are appropriate here.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (2 preceding siblings ...)
  2024-08-24 14:35 ` ahesford
@ 2024-08-24 17:32 ` bugcrazy
  2024-08-24 17:41 ` classabbyamp
                   ` (19 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-08-24 17:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#discussion_r1730047856

Comment:
I consider it more appropriate to replace, than transitional subpackage, only the names were changed, it is still the same model.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (3 preceding siblings ...)
  2024-08-24 17:32 ` bugcrazy
@ 2024-08-24 17:41 ` classabbyamp
  2024-08-25 14:57 ` [PR PATCH] [Updated] " bugcrazy
                   ` (18 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: classabbyamp @ 2024-08-24 17:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#discussion_r1730049204

Comment:
without the transitional package, users would be stuck on the old package forever if they don't know to install the other one

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (4 preceding siblings ...)
  2024-08-24 17:41 ` classabbyamp
@ 2024-08-25 14:57 ` bugcrazy
  2024-08-25 14:59 ` [PR REVIEW] " bugcrazy
                   ` (17 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-08-25 14:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-21
https://github.com/void-linux/void-packages/pull/51964

oils: renamed old names
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51964.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-21-51964.patch --]
[-- Type: text/x-diff, Size: 2001 bytes --]

From ed38a9b45c943e16b58a235ab931e23be867f875 Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Sun, 25 Aug 2024 11:59:32 -0300
Subject: [PATCH] oils: renamed old names

---
 srcpkgs/oil                    |  1 +
 srcpkgs/{oil => oils}/template | 19 +++++++++++++------
 2 files changed, 14 insertions(+), 6 deletions(-)
 create mode 120000 srcpkgs/oil
 rename srcpkgs/{oil => oils}/template (71%)

diff --git a/srcpkgs/oil b/srcpkgs/oil
new file mode 120000
index 00000000000000..fd2981096626b0
--- /dev/null
+++ b/srcpkgs/oil
@@ -0,0 +1 @@
+oils
\ No newline at end of file
diff --git a/srcpkgs/oil/template b/srcpkgs/oils/template
similarity index 71%
rename from srcpkgs/oil/template
rename to srcpkgs/oils/template
index c1a9bd148a279d..cfc1bf0c1807f4 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oils/template
@@ -1,18 +1,19 @@
-# Template file for 'oil'
-pkgname=oil
+# Template file for 'oils'
+pkgname=oils
 version=0.22.0
 revision=1
 build_style=configure
 configure_args="--prefix=/usr"
 hostmakedepends="$(vopt_if readline readline-devel)"
 makedepends="$hostmakedepends"
-short_desc="Oil, a new unix shell"
+short_desc="Oils, a new unix shell"
 maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
 license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="https://www.oilshell.org/download/oil-${version}.tar.xz"
 checksum=452e7fd428b686aa752cfeb9be2b94f9fcf7ba9ab22e0ae570a87cdcf782242e
-register_shell="/usr/bin/osh /usr/bin/oil"
+replaces="oil<=0.23.0"
+register_shell="/usr/bin/osh /usr/bin/ysh"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -28,8 +29,14 @@ do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
 	vman doc/osh.1
-	# Symlink osh, oil to oil.ovm.
+	# Symlink osh, ysh to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oil
+	ln -s oil.ovm ysh
+}
+
+oil_package() {
+	build_style=meta
+	depends="${sourcepkg}"
+	short_desc+=" - transitional dummy package"
 }

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (5 preceding siblings ...)
  2024-08-25 14:57 ` [PR PATCH] [Updated] " bugcrazy
@ 2024-08-25 14:59 ` bugcrazy
  2024-08-26  9:48 ` [PR PATCH] [Updated] " bugcrazy
                   ` (16 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-08-25 14:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#discussion_r1730376828

Comment:
Done!

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] oils: renamed old names
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (6 preceding siblings ...)
  2024-08-25 14:59 ` [PR REVIEW] " bugcrazy
@ 2024-08-26  9:48 ` bugcrazy
  2024-09-11 12:51 ` oils: renamed old names and update leahneukirchen
                   ` (15 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-08-26  9:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-21
https://github.com/void-linux/void-packages/pull/51964

oils: renamed old names
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51964.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-21-51964.patch --]
[-- Type: text/x-diff, Size: 2107 bytes --]

From db3fb66674865a3292802a62abc2af60b2f40bb0 Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Mon, 26 Aug 2024 06:52:53 -0300
Subject: [PATCH] oils: renamed old names and update

---
 srcpkgs/oil                    |  1 +
 srcpkgs/{oil => oils}/template | 23 +++++++++++++++--------
 2 files changed, 16 insertions(+), 8 deletions(-)
 create mode 120000 srcpkgs/oil
 rename srcpkgs/{oil => oils}/template (63%)

diff --git a/srcpkgs/oil b/srcpkgs/oil
new file mode 120000
index 00000000000000..fd2981096626b0
--- /dev/null
+++ b/srcpkgs/oil
@@ -0,0 +1 @@
+oils
\ No newline at end of file
diff --git a/srcpkgs/oil/template b/srcpkgs/oils/template
similarity index 63%
rename from srcpkgs/oil/template
rename to srcpkgs/oils/template
index c1a9bd148a279d..8d0ff45223b0e8 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oils/template
@@ -1,18 +1,19 @@
-# Template file for 'oil'
-pkgname=oil
-version=0.22.0
+# Template file for 'oils'
+pkgname=oils
+version=0.23.0
 revision=1
 build_style=configure
 configure_args="--prefix=/usr"
 hostmakedepends="$(vopt_if readline readline-devel)"
 makedepends="$hostmakedepends"
-short_desc="Oil, a new unix shell"
+short_desc="Oils, a new unix shell"
 maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
 license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="https://www.oilshell.org/download/oil-${version}.tar.xz"
-checksum=452e7fd428b686aa752cfeb9be2b94f9fcf7ba9ab22e0ae570a87cdcf782242e
-register_shell="/usr/bin/osh /usr/bin/oil"
+checksum=7fdc680e1afb5a110e5f87b4b93a8d3b0f3be0146c515c6ef1a3d01a9aada99c
+replaces="oil<=0.24.0"
+register_shell="/usr/bin/osh /usr/bin/ysh"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -28,8 +29,14 @@ do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
 	vman doc/osh.1
-	# Symlink osh, oil to oil.ovm.
+	# Symlink osh, ysh to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oil
+	ln -s oil.ovm ysh
+}
+
+oil_package() {
+	build_style=meta
+	depends="${sourcepkg}"
+	short_desc+=" - transitional dummy package"
 }

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (7 preceding siblings ...)
  2024-08-26  9:48 ` [PR PATCH] [Updated] " bugcrazy
@ 2024-09-11 12:51 ` leahneukirchen
  2024-09-11 19:31 ` bugcrazy
                   ` (14 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: leahneukirchen @ 2024-09-11 12:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2343585365

Comment:
So, while we are renaming the package, should we do it like upstream suggests? https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (8 preceding siblings ...)
  2024-09-11 12:51 ` oils: renamed old names and update leahneukirchen
@ 2024-09-11 19:31 ` bugcrazy
  2024-09-11 19:44 ` leahneukirchen
                   ` (13 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-09-11 19:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2344547485

Comment:
> So, while we are renaming the package, should we do it like upstream suggests? https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines

The definition itself is confusing, as there are two packages, one Python and one C, we should adopt more logical standards, this oils standard for package, is more correct.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (9 preceding siblings ...)
  2024-09-11 19:31 ` bugcrazy
@ 2024-09-11 19:44 ` leahneukirchen
  2024-09-11 19:44 ` leahneukirchen
                   ` (12 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: leahneukirchen @ 2024-09-11 19:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2344567736

Comment:
Okay, so this is the old Python-version, but there upstream says:

> The oil tarball is the slow reference interpreter based on CPython.
>
>    Don't rename old distro packages. They can remain oil.
>    It's not worth packaging oil in new distros. It may be removed at some point.

So let's keep this (just adding the link is fine), and perhaps someone can contribute `oils-for-unix` instead?

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (10 preceding siblings ...)
  2024-09-11 19:44 ` leahneukirchen
@ 2024-09-11 19:44 ` leahneukirchen
  2024-09-12 12:43 ` bugcrazy
                   ` (11 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: leahneukirchen @ 2024-09-11 19:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2344567736

Comment:
Okay, so this is the old Python-version, but there upstream says: https://www.oilshell.org/release/0.23.0/

> The oil tarball is the slow reference interpreter based on CPython.
>
>    Don't rename old distro packages. They can remain oil.
>    It's not worth packaging oil in new distros. It may be removed at some point.

So let's keep this (just adding the link is fine), and perhaps someone can contribute `oils-for-unix` instead?

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (11 preceding siblings ...)
  2024-09-11 19:44 ` leahneukirchen
@ 2024-09-12 12:43 ` bugcrazy
  2024-09-12 14:36 ` ahesford
                   ` (10 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-09-12 12:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2346181164

Comment:
> So, while we are renaming the package, should we do it like upstream suggests? https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines

The definition itself is confusing, as there are two packages, one Python and one C, we should adopt more logical standards, this oils standard for package, is more correct.

> Okay, so this is the old Python-version, but there upstream says: https://www.oilshell.org/release/0.23.0/
> 
> > The oil tarball is the slow reference interpreter based on CPython.
> > Don't rename old distro packages. They can remain oil.
> > It's not worth packaging oil in new distros. It may be removed at some point.
> 
> So let's keep this (just adding the link is fine), and perhaps someone can contribute `oils-for-unix` instead?

Python version is slow, a few seconds, C++ version is slower than bash version.

Python version is more stable and tested, has a history of having fewer bugs.

Here is a speed test and some bugs of the C++ version:

https://github.com/oils-for-unix/oils/issues/1069




^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (12 preceding siblings ...)
  2024-09-12 12:43 ` bugcrazy
@ 2024-09-12 14:36 ` ahesford
  2024-09-12 15:05 ` leahneukirchen
                   ` (9 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: ahesford @ 2024-09-12 14:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2346483806

Comment:
We don't need multiple versions of this package in Void, and the project author notes that the "reference" implementation might go away at some point, so just pick one to be the version packaged by Void.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (13 preceding siblings ...)
  2024-09-12 14:36 ` ahesford
@ 2024-09-12 15:05 ` leahneukirchen
  2024-09-14 17:19 ` meator
                   ` (8 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: leahneukirchen @ 2024-09-12 15:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2346558224

Comment:
@ahesford doesnt matter, the new version should have a new package name anyway (and conflict, I guess)

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (14 preceding siblings ...)
  2024-09-12 15:05 ` leahneukirchen
@ 2024-09-14 17:19 ` meator
  2024-09-14 19:01 ` meator
                   ` (7 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: meator @ 2024-09-14 17:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2351067155

Comment:
> and perhaps someone can contribute `oils-for-unix` instead?

I've tried to package `oils-for-unix`: #52218

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (15 preceding siblings ...)
  2024-09-14 17:19 ` meator
@ 2024-09-14 19:01 ` meator
  2024-09-30 15:50 ` bugcrazy
                   ` (6 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: meator @ 2024-09-14 19:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2351108333

Comment:
Also, I vote for keeping `oil` as is and not renaming it to `oils`. This is what upstream recommends.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (16 preceding siblings ...)
  2024-09-14 19:01 ` meator
@ 2024-09-30 15:50 ` bugcrazy
  2024-09-30 18:32 ` leahneukirchen
                   ` (5 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-09-30 15:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2383575630

Comment:
I keep the old name oil or rename it to oils, @meator  voted to keep the old name, because I need to know what procedure I do, the package needs to be updated too!

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (17 preceding siblings ...)
  2024-09-30 15:50 ` bugcrazy
@ 2024-09-30 18:32 ` leahneukirchen
  2024-09-30 22:49 ` [PR PATCH] [Updated] " bugcrazy
                   ` (4 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: leahneukirchen @ 2024-09-30 18:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2383897649

Comment:
yes, please keep the old name.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] oils: renamed old names and update
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (18 preceding siblings ...)
  2024-09-30 18:32 ` leahneukirchen
@ 2024-09-30 22:49 ` bugcrazy
  2024-09-30 22:52 ` oil: update to 0.23.0 bugcrazy
                   ` (3 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-09-30 22:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-21
https://github.com/void-linux/void-packages/pull/51964

oils: renamed old names and update
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/51964.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-21-51964.patch --]
[-- Type: text/x-diff, Size: 1366 bytes --]

From 80cdbeb1bccfc370c6a6ec32eae876ee2b3b4254 Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Mon, 30 Sep 2024 19:53:59 -0300
Subject: [PATCH] oil: update to  0.23.0

---
 srcpkgs/oil/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index c1a9bd148a279d..839120cea17e4a 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,6 +1,6 @@
 # Template file for 'oil'
 pkgname=oil
-version=0.22.0
+version=0.23.0
 revision=1
 build_style=configure
 configure_args="--prefix=/usr"
@@ -11,8 +11,8 @@ maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
 license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="https://www.oilshell.org/download/oil-${version}.tar.xz"
-checksum=452e7fd428b686aa752cfeb9be2b94f9fcf7ba9ab22e0ae570a87cdcf782242e
-register_shell="/usr/bin/osh /usr/bin/oil"
+checksum=7fdc680e1afb5a110e5f87b4b93a8d3b0f3be0146c515c6ef1a3d01a9aada99c
+register_shell="/usr/bin/osh /usr/bin/ysh"
 nocross="Build systems gets confused with host and cross toolchains/headers"
 nostrip=yes
 
@@ -28,8 +28,8 @@ do_install() {
 	# Install binaries
 	vbin _bin/oil.ovm
 	vman doc/osh.1
-	# Symlink osh, oil to oil.ovm.
+	# Symlink osh, ysh to oil.ovm.
 	cd "${DESTDIR}"/usr/bin
 	ln -s oil.ovm osh
-	ln -s oil.ovm oil
+	ln -s oil.ovm ysh
 }

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oil: update to 0.23.0
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (19 preceding siblings ...)
  2024-09-30 22:49 ` [PR PATCH] [Updated] " bugcrazy
@ 2024-09-30 22:52 ` bugcrazy
  2024-10-01  1:33 ` classabbyamp
                   ` (2 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-09-30 22:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2384313375

Comment:
> yes, please keep the old name.

Done!

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oil: update to 0.23.0
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (20 preceding siblings ...)
  2024-09-30 22:52 ` oil: update to 0.23.0 bugcrazy
@ 2024-10-01  1:33 ` classabbyamp
  2024-10-01 16:02 ` [PR PATCH] [Merged]: " leahneukirchen
  2024-10-01 17:44 ` bugcrazy
  23 siblings, 0 replies; 25+ messages in thread
From: classabbyamp @ 2024-10-01  1:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2384606667

Comment:
what will happen for anyone using `oil` as login shell? 

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Merged]: oil: update to 0.23.0
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (21 preceding siblings ...)
  2024-10-01  1:33 ` classabbyamp
@ 2024-10-01 16:02 ` leahneukirchen
  2024-10-01 17:44 ` bugcrazy
  23 siblings, 0 replies; 25+ messages in thread
From: leahneukirchen @ 2024-10-01 16:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

There's a merged pull request on the void-packages repository

oil: update to 0.23.0
https://github.com/void-linux/void-packages/pull/51964

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: oil: update to 0.23.0
  2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
                   ` (22 preceding siblings ...)
  2024-10-01 16:02 ` [PR PATCH] [Merged]: " leahneukirchen
@ 2024-10-01 17:44 ` bugcrazy
  23 siblings, 0 replies; 25+ messages in thread
From: bugcrazy @ 2024-10-01 17:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/51964#issuecomment-2386599735

Comment:
> what will happen for anyone using `oil` as login shell?
It will work normally.


^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2024-10-01 17:44 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-24  4:58 [PR PATCH] oils: renamed old names bugcrazy
2024-08-24  5:17 ` [PR PATCH] [Updated] " bugcrazy
2024-08-24  5:48 ` [PR REVIEW] " classabbyamp
2024-08-24 14:35 ` ahesford
2024-08-24 17:32 ` bugcrazy
2024-08-24 17:41 ` classabbyamp
2024-08-25 14:57 ` [PR PATCH] [Updated] " bugcrazy
2024-08-25 14:59 ` [PR REVIEW] " bugcrazy
2024-08-26  9:48 ` [PR PATCH] [Updated] " bugcrazy
2024-09-11 12:51 ` oils: renamed old names and update leahneukirchen
2024-09-11 19:31 ` bugcrazy
2024-09-11 19:44 ` leahneukirchen
2024-09-11 19:44 ` leahneukirchen
2024-09-12 12:43 ` bugcrazy
2024-09-12 14:36 ` ahesford
2024-09-12 15:05 ` leahneukirchen
2024-09-14 17:19 ` meator
2024-09-14 19:01 ` meator
2024-09-30 15:50 ` bugcrazy
2024-09-30 18:32 ` leahneukirchen
2024-09-30 22:49 ` [PR PATCH] [Updated] " bugcrazy
2024-09-30 22:52 ` oil: update to 0.23.0 bugcrazy
2024-10-01  1:33 ` classabbyamp
2024-10-01 16:02 ` [PR PATCH] [Merged]: " leahneukirchen
2024-10-01 17:44 ` bugcrazy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).