Github messages for voidlinux
 help / color / mirror / Atom feed
From: alerque <alerque@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Sile update to 0.15.4
Date: Sat, 31 Aug 2024 10:54:48 +0200	[thread overview]
Message-ID: <20240831085448.2012F2DEFA@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-51222@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

New review comment by alerque on void-packages repository

https://github.com/void-linux/void-packages/pull/51222#discussion_r1739641960

Comment:
I see what's going on. We're assuming Cargo output in `target/release` but when cross compiling the target host gets added in there, `target/x86_64-unknown-linux-gnu/release`. We have a way to override the target dir that you could probably overload to address this just a touch easier:

```console
$ sed -i '/^RUST_TARGET_SUBDIR/s#= #= x86_64-unknown-linux-gnu/#' Makefile.in
```

Note you would have to specify the full host identifier, not use a wildcard like in your current hack.

This is just stuffing the host info in as a path segment before the "target" part. It's still a hack, and as far as I see we don't have a way to catch that right now. I'll look into it from our side.

  parent reply	other threads:[~2024-08-31  8:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 13:06 [PR PATCH] " Luciogi
2024-07-12 14:33 ` [PR PATCH] [Updated] " Luciogi
2024-07-12 15:40 ` Luciogi
2024-07-12 17:33 ` Luciogi
2024-07-13  6:01 ` Luciogi
2024-07-13  6:17 ` Luciogi
2024-07-13  8:03 ` Luciogi
2024-07-13  8:34 ` Luciogi
2024-07-13  8:34 ` Luciogi
2024-07-13  9:36 ` Luciogi
2024-07-13  9:39 ` Luciogi
2024-07-13  9:41 ` Luciogi
2024-07-13 10:20 ` [PR PATCH] [Updated] " Luciogi
2024-07-13 10:20 ` Luciogi
2024-07-13 10:20 ` Luciogi
2024-07-13 15:09 ` [PR PATCH] [Updated] " Luciogi
2024-07-13 15:10 ` Luciogi
2024-07-13 15:47 ` [PR PATCH] [Updated] " Luciogi
2024-08-30 11:54 ` Luciogi
2024-08-30 11:55 ` Luciogi
2024-08-30 14:07 ` Luciogi
2024-08-30 15:13 ` Luciogi
2024-08-30 20:51 ` [PR REVIEW] " alerque
2024-08-30 20:52 ` alerque
2024-08-31  7:03 ` [PR REVIEW] " Luciogi
2024-08-31  7:05 ` Luciogi
2024-08-31  8:54 ` alerque [this message]
2024-08-31  8:58 ` alerque
2024-09-04 17:41 ` [PR PATCH] [Updated] Sile update to 0.15.5 Luciogi
2024-09-04 17:42 ` [PR REVIEW] " Luciogi
2024-09-05  9:48 ` alerque
2024-09-05  9:54 ` alerque
2024-09-05  9:54 ` alerque
2024-09-05 16:37 ` [PR PATCH] [Updated] " Luciogi
2024-09-05 16:38 ` [PR REVIEW] " Luciogi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240831085448.2012F2DEFA@inbox.vuxu.org \
    --to=alerque@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).