Github messages for voidlinux
 help / color / mirror / Atom feed
From: MouadCharradi <MouadCharradi@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Signal-Desktop: update to 7.23.0.
Date: Mon, 16 Sep 2024 07:12:27 +0200	[thread overview]
Message-ID: <20240916051227.7322E2BED2@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-52141@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New review comment by MouadCharradi on void-packages repository

https://github.com/void-linux/void-packages/pull/52141#discussion_r1760540637

Comment:
Thank you for point that out, I managed to make the script use the upstream `.desktop` file.
Also the package is now at the latest version, so hopefully the build passes.

Thanks

  parent reply	other threads:[~2024-09-16  5:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-07 23:06 [PR PATCH] " MouadCharradi
2024-09-15 18:02 ` classabbyamp
2024-09-15 18:04 ` [PR REVIEW] " classabbyamp
2024-09-15 18:57 ` lawmanuk
2024-09-15 19:10 ` classabbyamp
2024-09-16  5:10 ` [PR PATCH] [Updated] " MouadCharradi
2024-09-16  5:12 ` MouadCharradi [this message]
2024-09-16  5:18 ` MouadCharradi
2024-09-18  2:10 ` [PR PATCH] [Merged]: Signal-Desktop: update to 7.24.1 classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240916051227.7322E2BED2@inbox.vuxu.org \
    --to=mouadcharradi@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).