Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libavif: fix usage of system codecs.
@ 2024-09-19  0:41 ericonr
  2024-09-20  4:53 ` [PR PATCH] [Merged]: " classabbyamp
  0 siblings, 1 reply; 2+ messages in thread
From: ericonr @ 2024-09-19  0:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages libavif-extra
https://github.com/void-linux/void-packages/pull/52270

libavif: fix usage of system codecs.
The options to enable additional codecs require either LOCAL for the vendored copy, or SYSTEM for the system libraries. Our version of libavif was getting built without any support for dav1d, rav1e or svt.

---

Noticed this when running `xbps-remove -o`.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** (only at build time, and it does add the dependencies which were previously missing)

A patch file from https://github.com/void-linux/void-packages/pull/52270.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libavif-extra-52270.patch --]
[-- Type: text/x-diff, Size: 1321 bytes --]

From 6d231e9816d64b96a9259f437b45030f702dcfaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Wed, 18 Sep 2024 21:38:28 -0300
Subject: [PATCH] libavif: fix usage of system codecs.

The options to enable additional codecs require either LOCAL for the
vendored copy, or SYSTEM for the system libraries. Our version of
libavif was getting built without any support for dav1d, rav1e or svt.
---
 srcpkgs/libavif/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libavif/template b/srcpkgs/libavif/template
index 76010e30ea3d16..2115ff9831f61f 100644
--- a/srcpkgs/libavif/template
+++ b/srcpkgs/libavif/template
@@ -1,12 +1,12 @@
 # Template file for 'libavif'
 pkgname=libavif
 version=1.1.1
-revision=1
+revision=2
 build_style=cmake
 configure_args="-DAVIF_BUILD_APPS=ON -DAVIF_BUILD_GDK_PIXBUF=ON
  -DAVIF_LIBYUV=OFF -DAVIF_CODEC_AOM=SYSTEM
- $(vopt_bool dav1d AVIF_CODEC_DAV1D) $(vopt_bool rav1e AVIF_CODEC_RAV1E)
- $(vopt_bool svt AVIF_CODEC_SVT)"
+ $(vopt_if dav1d -DAVIF_CODEC_DAV1D=SYSTEM) $(vopt_if rav1e -DAVIF_CODEC_RAV1E=SYSTEM)
+ $(vopt_if svt -DAVIF_CODEC_SVT=SYSTEM)"
 hostmakedepends="gdk-pixbuf-devel pkg-config"
 makedepends="gdk-pixbuf-devel libaom-devel libsharpyuv-devel
  libjpeg-turbo-devel libpng-devel zlib-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: libavif: fix usage of system codecs.
  2024-09-19  0:41 [PR PATCH] libavif: fix usage of system codecs ericonr
@ 2024-09-20  4:53 ` classabbyamp
  0 siblings, 0 replies; 2+ messages in thread
From: classabbyamp @ 2024-09-20  4:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

There's a merged pull request on the void-packages repository

libavif: fix usage of system codecs.
https://github.com/void-linux/void-packages/pull/52270

Description:
The options to enable additional codecs require either LOCAL for the vendored copy, or SYSTEM for the system libraries. Our version of libavif was getting built without any support for dav1d, rav1e or svt.

---

Noticed this when running `xbps-remove -o`.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** (only at build time, and it does add the dependencies which were previously missing)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-20  4:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-19  0:41 [PR PATCH] libavif: fix usage of system codecs ericonr
2024-09-20  4:53 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).