[PR PATCH] python3-Faker: update to 29.0.0, adopt.

[PR PATCH] python3-Faker: update to 29.0.0, adopt.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

There is a new pull request by Vinfall against master on the void-packages repository

https://github.com/Vinfall/void-packages python3-Faker-update
https://github.com/void-linux/void-packages/pull/52304

python3-Faker: update to 29.0.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Notes:
- Tests are broken for a while, finally bothered me enough to do the fix
- I've been updating this for a while so maybe adopting it makes checking updates easier via `xcheckmypkgs`

A patch file from https://github.com/void-linux/void-packages/pull/52304.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-Faker-update-52304.patch --]
[-- Type: text/x-diff, Size: 1570 bytes --]

From f5fda881350ac17a3c772c86363ff43596dc6dcf Mon Sep 17 00:00:00 2001
From: Vinfall <neptuniahuai0tc@riseup.net>
Date: Sun, 22 Sep 2024 10:01:34 +0800
Subject: [PATCH] python3-Faker: update to 29.0.0, adopt.

---
 srcpkgs/python3-Faker/template | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-Faker/template b/srcpkgs/python3-Faker/template
index 3959650f12c324..82a672a69e668d 100644
--- a/srcpkgs/python3-Faker/template
+++ b/srcpkgs/python3-Faker/template
@@ -1,18 +1,22 @@
 # Template file for 'python3-Faker'
 pkgname=python3-Faker
-version=26.2.0
+version=29.0.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-dateutil"
-checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-pytest"
+checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-pytest tox"
 short_desc="Python package for generating fake data"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Vinfall <neptuniahuai0tc@riseup.net>"
 license="MIT"
 homepage="https://faker.readthedocs.io/en/master/"
 changelog="https://github.com/joke2k/faker/raw/master/CHANGELOG.md"
-distfiles="${PYPI_SITE}/F/Faker/Faker-${version}.tar.gz"
-checksum=81768de19012147521140f0d8bf5353e501ac42c1065d25e0cac455d3615c0a7
+distfiles="https://github.com/joke2k/faker/archive/refs/tags/v${version}.tar.gz"
+checksum=f67422623f88e52380e5375ecef682135a1608c9aac4efbf97a1c0284dcf7a10
+
+do_check() {
+	tox -e py
+}
 
 post_install() {
 	vlicense LICENSE.txt

Re: python3-Faker: update to 29.0.0, adopt.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/52304#issuecomment-2365420866

Comment:
Tests failed because of [a missing dep (zlib)](https://pillow.readthedocs.io/en/latest/installation/building-from-source.html#external-libraries) for python3-Pillow, I guess it's caused by zlib template in void missing `zlib-devel`, but `-C zlib=disable` is also missing from the template.

Any idea? @ahesford 

Re: python3-Faker: update to 29.0.0, adopt.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/52304#issuecomment-2365438591

Comment:
Tox checks are not relevant for us because they just deploy wheels in a virtual environment. Tests in `xbps-src` should include `python3-pytest` and use Void packages in `checkdepends` to actually test our built version against our built dependencies.

Also, you should move this to the `python3-pep517` build style.

Re: [PR PATCH] [Updated] python3-Faker: update to 29.0.0, adopt.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

There is an updated pull request by Vinfall against master on the void-packages repository

https://github.com/Vinfall/void-packages python3-Faker-update
https://github.com/void-linux/void-packages/pull/52304

python3-Faker: update to 29.0.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Notes:
- Tests are broken for a while, finally bothered me enough to do the fix
- I've been updating this for a while so maybe adopting it makes checking updates easier via `xcheckmypkgs`

A patch file from https://github.com/void-linux/void-packages/pull/52304.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-Faker-update-52304.patch --]
[-- Type: text/x-diff, Size: 1549 bytes --]

From c6cb29096027e5076da6c01dd943f789983c52fb Mon Sep 17 00:00:00 2001
From: Vinfall <neptuniahuai0tc@riseup.net>
Date: Sun, 22 Sep 2024 10:01:34 +0800
Subject: [PATCH] python3-Faker: update to 29.0.0, adopt.

---
 srcpkgs/python3-Faker/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-Faker/template b/srcpkgs/python3-Faker/template
index 3959650f12c324..390042f689ad01 100644
--- a/srcpkgs/python3-Faker/template
+++ b/srcpkgs/python3-Faker/template
@@ -1,18 +1,18 @@
 # Template file for 'python3-Faker'
 pkgname=python3-Faker
-version=26.2.0
+version=29.0.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-dateutil"
-checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-pytest"
+checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-xmltodict python3-pytest"
 short_desc="Python package for generating fake data"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Vinfall <neptuniahuai0tc@riseup.net>"
 license="MIT"
 homepage="https://faker.readthedocs.io/en/master/"
 changelog="https://github.com/joke2k/faker/raw/master/CHANGELOG.md"
-distfiles="${PYPI_SITE}/F/Faker/Faker-${version}.tar.gz"
-checksum=81768de19012147521140f0d8bf5353e501ac42c1065d25e0cac455d3615c0a7
+distfiles="https://github.com/joke2k/faker/archive/refs/tags/v${version}.tar.gz"
+checksum=f67422623f88e52380e5375ecef682135a1608c9aac4efbf97a1c0284dcf7a10
 
 post_install() {
 	vlicense LICENSE.txt

Re: python3-Faker: update to 29.0.0, adopt.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 2418 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/52304#issuecomment-2365593854

Comment:
~~Tox is used as pytest by default fails many tests so I just referred to their [test CI](https://github.com/joke2k/faker/blob/master/.github/workflows/ci.yml#L187-L198).~~ I'll use pytest instead now that I figured out the issue.

<details><summary>Truncated log</summary>
<p>


```python
/builddir/python3-Faker-29.0.0/tests/providers/conftest.py:27
__________________ ERROR at setup of TestUkUA.test_start_ssn ___________________
file /builddir/python3-Faker-29.0.0/tests/providers/test_ssn.py, line 1379
      def test_start_ssn(self):
file /builddir/python3-Faker-29.0.0/tests/providers/conftest.py, line 27
  @pytest.fixture(autouse=True)
  def faker(_class_locale_faker, faker):
E       recursive dependency involving fixture 'faker' detected
>       available fixtures: LineMatcher, _class_locale_faker, _config_for_test, _pytest, _sys_snapshot, _unittest_setUpClass_fixture_TestUkUA, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, faker, linecomp, monkeypatch, num_samples, pytestconfig, pytester, record_property, record_testsuite_property, record_xml_attribute, recwarn, testdir, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

...
ERROR tests/test_passport.py::TestEnUS::testDates
ERROR tests/test_passport.py::TestEnUS::testGender
ERROR tests/test_passport.py::TestEnUS::testfull
==== 1 failed, 337 passed, 10 skipped, 531 warnings, 1645 errors in 11.30s =====
=> ERROR: python3-Faker-29.0.0_1: do_check: 'PYTHONPATH="$(cd build/lib* && pwd)" PY_IGNORE_IMPORTMISMATCH=1 ${make_check_pre} python3 -m pytest ${testjobs} ${make_check_args} ${make_check_target}' exited with 1                                         
=> ERROR:   in do_check() at common/build-style/python3-module.sh:15 
```

</p>
</details> 

It happens because `Faker` includes a [`faker` fixture for `pytest`](https://faker.readthedocs.io/en/master/pytest-fixtures.html) but that does not seem to work with on CI (from what I read on other PR comments and the results of `grep "fixtures" srcpkgs/*/template`). I'm not sure what to do about it, can I just mark `make_check=no`? Local tests still work fine.

As for the PEP517 comment, I think upstream does not support it.

Re: python3-Faker: update to 29.0.0, adopt.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/52304#issuecomment-2366735651

Comment:
My mistake; I could have sworn I was saw a `pyproject.toml`.

Re: python3-Faker: update to 29.0.0, adopt.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/52304#issuecomment-2366735651

Comment:
My mistake; I could have sworn I saw a `pyproject.toml`.

Re: python3-Faker: update to 29.0.0, adopt.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/52304#issuecomment-2366840475

Comment:
You can still apply the pep517 build-style, which "installs" the project before running the tests. This patch works for me locally:

```patch
diff --git a/srcpkgs/python3-Faker/template b/srcpkgs/python3-Faker/template
index 3959650f1..4a1491844 100644
--- a/srcpkgs/python3-Faker/template
+++ b/srcpkgs/python3-Faker/template
@@ -1,18 +1,18 @@
 # Template file for 'python3-Faker'
 pkgname=python3-Faker
-version=26.2.0
+version=29.0.0
 revision=1
-build_style=python3-module
-hostmakedepends="python3-setuptools"
+build_style=python3-pep517
+hostmakedepends="python3-wheel python3-setuptools"
 depends="python3-dateutil"
-checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-pytest"
+checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-xmltodict python3-pytest"
 short_desc="Python package for generating fake data"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://faker.readthedocs.io/en/master/"
 changelog="https://github.com/joke2k/faker/raw/master/CHANGELOG.md"
-distfiles="${PYPI_SITE}/F/Faker/Faker-${version}.tar.gz"
-checksum=81768de19012147521140f0d8bf5353e501ac42c1065d25e0cac455d3615c0a7
+distfiles="${PYPI_SITE}/f/faker/faker-${version}.tar.gz"
+checksum=34e89aec594cad9773431ca479ee95c7ce03dd9f22fda2524e2373b880a2fa77
 
 post_install() {
 	vlicense LICENSE.txt
```

Re: python3-Faker: update to 29.0.0, adopt.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/52304#issuecomment-2367166421

Comment:
The patch works for me too. I was thinking about skipping other tests that require fixtures but using pep517 build style solves the issue and I'll use this instead.

Re: [PR PATCH] [Updated] python3-Faker: update to 29.0.0, adopt.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

There is an updated pull request by Vinfall against master on the void-packages repository

https://github.com/Vinfall/void-packages python3-Faker-update
https://github.com/void-linux/void-packages/pull/52304

python3-Faker: update to 29.0.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Notes:
- Tests are broken for a while, finally bothered me enough to do the fix
- I've been updating this for a while so maybe adopting it makes checking updates easier via `xcheckmypkgs`

A patch file from https://github.com/void-linux/void-packages/pull/52304.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-Faker-update-52304.patch --]
[-- Type: text/x-diff, Size: 1609 bytes --]

From 446f8b19b66e0fc7381f516f34033dd7556bc14e Mon Sep 17 00:00:00 2001
From: Vinfall <neptuniahuai0tc@riseup.net>
Date: Sun, 22 Sep 2024 10:01:34 +0800
Subject: [PATCH] python3-Faker: update to 29.0.0, adopt.

---
 srcpkgs/python3-Faker/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/python3-Faker/template b/srcpkgs/python3-Faker/template
index 3959650f12c324..de2d11289c6dea 100644
--- a/srcpkgs/python3-Faker/template
+++ b/srcpkgs/python3-Faker/template
@@ -1,18 +1,18 @@
 # Template file for 'python3-Faker'
 pkgname=python3-Faker
-version=26.2.0
+version=29.0.0
 revision=1
-build_style=python3-module
-hostmakedepends="python3-setuptools"
+build_style=python3-pep517
+hostmakedepends="python3-wheel python3-setuptools"
 depends="python3-dateutil"
-checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-pytest"
+checkdepends="${depends} python3-freezegun python3-validators python3-Pillow python3-xmltodict python3-pytest"
 short_desc="Python package for generating fake data"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Vinfall <neptuniahuai0tc@riseup.net>"
 license="MIT"
 homepage="https://faker.readthedocs.io/en/master/"
 changelog="https://github.com/joke2k/faker/raw/master/CHANGELOG.md"
-distfiles="${PYPI_SITE}/F/Faker/Faker-${version}.tar.gz"
-checksum=81768de19012147521140f0d8bf5353e501ac42c1065d25e0cac455d3615c0a7
+distfiles="${PYPI_SITE}/f/faker/faker-${version}.tar.gz"
+checksum=34e89aec594cad9773431ca479ee95c7ce03dd9f22fda2524e2373b880a2fa77
 
 post_install() {
 	vlicense LICENSE.txt

Re: [PR PATCH] [Merged]: python3-Faker: update to 29.0.0, adopt.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

There's a merged pull request on the void-packages repository

python3-Faker: update to 29.0.0, adopt.
https://github.com/void-linux/void-packages/pull/52304

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Notes:
- Tests are broken for a while, finally bothered me enough to do the fix
- I've been updating this for a while so maybe adopting it makes checking updates easier via `xcheckmypkgs`