[PR PATCH] Fix deprecated GitHub /downloads/ downloads

[PR PATCH] Fix deprecated GitHub /downloads/ downloads

[meator]

[-- Attachment #1: Type: text/plain, Size: 2335 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages fix-github-downloads
https://github.com/void-linux/void-packages/pull/52319

Fix deprecated GitHub /downloads/ downloads
<!-- Uncomment relevant sections and delete options which are not applicable -->
`mash`'s latest available tag is [`0.2.0`](https://github.com/clutter-project/mash/releases/tag/0.2.0), which is on par with Void linux's package

`wmfs` latest available tag is [`201003`](https://github.com/xorg62/wmfs/releases/tag/201003), which is `< 201104`

`pidgin-window-merge` doesn't have any tags or releases.

`pidgin-gpg`'s latest available tag is [`0.5`](https://github.com/segler-alex/Pidgin-GPG/releases/tag/0.5), which is `< 0.9` (`pidgin-gpg` appears to be a fork of some other project, releases `>=0.9` were created by the forker).

I personally believe that many of these projects deserve to be removed (at least `pidgin-window-merge` does, because it has no releases and therefore no longer meets quality requirements). I have not done so because you (Void maintainers) were reluctant to removing packages before.

The only remaining package using GitHub's deprecated `/downloads/` API is `xinput_calibrator`. I am having a discussion with maintainers about this: https://gitlab.freedesktop.org/xorg/app/xinput-calibrator/-/issues/85

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52319.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-github-downloads-52319.patch --]
[-- Type: text/x-diff, Size: 4286 bytes --]

From ac61e271da64db4055cbba4ebf968d517ba8a126 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 11:21:13 +0200
Subject: [PATCH 1/4] mash: fix deprecated GitHub /downloads/ distfile

---
 srcpkgs/mash/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/mash/template b/srcpkgs/mash/template
index 26e7c877718680..287b0e9d538d8b 100644
--- a/srcpkgs/mash/template
+++ b/srcpkgs/mash/template
@@ -4,7 +4,8 @@ version=0.2.0
 revision=9
 build_style=gnu-configure
 build_helper="gir"
-configure_args="--disable-static $(vopt_enable gir introspection)"
+configure_args="--disable-static $(vopt_enable gir introspection)
+ --enable-gtk-doc"
 hostmakedepends="automake glib-devel intltool libtool pkg-config
  $(vopt_if gir gobject-introspection) gtk-doc"
 makedepends="clutter-devel"
@@ -13,8 +14,8 @@ short_desc="Small library for using 3D models within a Clutter scene"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://clutter-project.github.io/mash/"
-distfiles="https://github.com/downloads/clutter-project/mash/mash-${version}.tar.xz"
-checksum=fd4089e2974a1a57f9ba209a0a47924ed157da9fc9a3d65f68a6b9fdca353ccc
+distfiles="https://github.com/clutter-project/mash/archive/refs/tags/${version}.tar.gz"
+checksum=a5f91f0828c3c63a845800443ab347417cb34882db3b6672b42f6d68355ddab8
 
 build_options="gir"
 build_options_default="gir"

From fb49583734d4cf48d4f15d4e45ebfb6aabd81c57 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 16:21:08 +0200
Subject: [PATCH 2/4] wmfs: fix deprecated GitHub /downloads/ distfile

---
 srcpkgs/wmfs/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/wmfs/template b/srcpkgs/wmfs/template
index cf10d345e8a6f9..5f96fe4ebd15e7 100644
--- a/srcpkgs/wmfs/template
+++ b/srcpkgs/wmfs/template
@@ -11,7 +11,7 @@ short_desc="Window Manager From Scratch"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/xorg62/wmfs"
-distfiles="https://github.com/downloads/xorg62/wmfs/wmfs-${version}.tar.gz"
+distfiles="https://sources.voidlinux.org/wmfs-201104/wmfs-201104.tar.gz"
 checksum=c28b7cec28a6e3f2bc38a136fb1773bab8ec8f48c69ebe25c24192f96e782d64
 
 CFLAGS="-I${XBPS_CROSS_BASE}/usr/include/freetype2 -fcommon"

From c86b43e1163f558ed4172c2f325adff5d2f807da Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 16:24:43 +0200
Subject: [PATCH 3/4] pidgin-window-merge: fix dead distfile

---
 srcpkgs/pidgin-window-merge/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pidgin-window-merge/template b/srcpkgs/pidgin-window-merge/template
index d557b223665789..1d907769d8dd61 100644
--- a/srcpkgs/pidgin-window-merge/template
+++ b/srcpkgs/pidgin-window-merge/template
@@ -9,5 +9,5 @@ short_desc="Pidgin plugin that merges the Buddy List and the conversation window
 maintainer="chinarulezzz <s.alex08@mail.ru>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/dm0-/window_merge"
-distfiles="https://github.com/downloads/dm0-/window_merge/window_merge-${version}.tar.gz"
+distfiles="https://sources.voidlinux.org/pidgin-window-merge-0.3/window_merge-0.3.tar.gz"
 checksum=e890c829f8f074ca0bbf32a0bd3c9b8008802f2795d6f40a19756379e2ce6531

From e247d5d4c83d187af6592e3556d3f7e358c8cf20 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 16:26:14 +0200
Subject: [PATCH 4/4] pidgin-gpg: fix deprecated /downloads/ distfile

---
 srcpkgs/pidgin-gpg/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pidgin-gpg/template b/srcpkgs/pidgin-gpg/template
index f23c33e0fb4aff..44a82b98ca5794 100644
--- a/srcpkgs/pidgin-gpg/template
+++ b/srcpkgs/pidgin-gpg/template
@@ -9,5 +9,5 @@ short_desc="GnuPG plug-in for the Pidgin IM"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="http://github.com/segler-alex/Pidgin-GPG"
-distfiles="http://github.com/downloads/segler-alex/Pidgin-GPG/${pkgname}-${version}.tar.gz"
+distfiles="https://sources.voidlinux.org/pidgin-gpg-0.9/pidgin-gpg-0.9.tar.gz"
 checksum=736681cb25da31eb8ced96055d4150d649fe6ef6e523b6f65846c3446ac09a96

Re: Fix deprecated GitHub /downloads/ downloads

[meator]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/52319#issuecomment-2368568197

Comment:
Please merge #52321 before this to propagate maintainer update to `pidgin-window-merge`.

Re: [PR PATCH] [Updated] Fix deprecated GitHub /downloads/ downloads

[meator]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages fix-github-downloads
https://github.com/void-linux/void-packages/pull/52319

Fix deprecated GitHub /downloads/ downloads
<!-- Uncomment relevant sections and delete options which are not applicable -->
`mash`'s latest available tag is [`0.2.0`](https://github.com/clutter-project/mash/releases/tag/0.2.0), which is on par with Void linux's package

`wmfs` latest available tag is [`201003`](https://github.com/xorg62/wmfs/releases/tag/201003), which is `< 201104`

`pidgin-window-merge` doesn't have any tags or releases.

`pidgin-gpg`'s latest available tag is [`0.5`](https://github.com/segler-alex/Pidgin-GPG/releases/tag/0.5), which is `< 0.9` (`pidgin-gpg` appears to be a fork of some other project, releases `>=0.9` were created by the forker).

I personally believe that many of these projects deserve to be removed (at least `pidgin-window-merge` does, because it has no releases and therefore no longer meets quality requirements). I have not done so because you (Void maintainers) were reluctant to removing packages before.

The only remaining package using GitHub's deprecated `/downloads/` API is `xinput_calibrator`. I am having a discussion with maintainers about this: https://gitlab.freedesktop.org/xorg/app/xinput-calibrator/-/issues/85

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52319.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-github-downloads-52319.patch --]
[-- Type: text/x-diff, Size: 4616 bytes --]

From 5f2ba57d00943fd3a371aa1585ca8dba725c5654 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 11:21:13 +0200
Subject: [PATCH 1/4] mash: fix deprecated GitHub /downloads/ distfile

---
 srcpkgs/mash/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/mash/template b/srcpkgs/mash/template
index 26e7c877718680..e0ec2cfd0db573 100644
--- a/srcpkgs/mash/template
+++ b/srcpkgs/mash/template
@@ -4,7 +4,8 @@ version=0.2.0
 revision=9
 build_style=gnu-configure
 build_helper="gir"
-configure_args="--disable-static $(vopt_enable gir introspection)"
+configure_args="--disable-static $(vopt_enable gir introspection)
+ --enable-gtk-doc"
 hostmakedepends="automake glib-devel intltool libtool pkg-config
  $(vopt_if gir gobject-introspection) gtk-doc"
 makedepends="clutter-devel"
@@ -13,8 +14,9 @@ short_desc="Small library for using 3D models within a Clutter scene"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://clutter-project.github.io/mash/"
-distfiles="https://github.com/downloads/clutter-project/mash/mash-${version}.tar.xz"
-checksum=fd4089e2974a1a57f9ba209a0a47924ed157da9fc9a3d65f68a6b9fdca353ccc
+distfiles="https://github.com/clutter-project/mash/archive/refs/tags/${version}.tar.gz"
+checksum=a5f91f0828c3c63a845800443ab347417cb34882db3b6672b42f6d68355ddab8
+nocross="Build system executes what it builds"
 
 build_options="gir"
 build_options_default="gir"
@@ -30,9 +32,7 @@ mash-devel_package() {
 		vmove usr/include
 		vmove usr/lib/pkgconfig
 		vmove usr/share/gtk-doc
-		if [ -z "$CROSS_BUILD" ]; then
-			vmove usr/share/gir-1.0
-		fi
+		vmove usr/share/gir-1.0
 		vmove usr/lib/*.so
 	}
 }

From 8433b8ce1206066fb5ac71590b7269b1584ee440 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 16:21:08 +0200
Subject: [PATCH 2/4] wmfs: fix deprecated GitHub /downloads/ distfile

---
 srcpkgs/wmfs/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/wmfs/template b/srcpkgs/wmfs/template
index cf10d345e8a6f9..1cc9221e26680c 100644
--- a/srcpkgs/wmfs/template
+++ b/srcpkgs/wmfs/template
@@ -11,7 +11,7 @@ short_desc="Window Manager From Scratch"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/xorg62/wmfs"
-distfiles="https://github.com/downloads/xorg62/wmfs/wmfs-${version}.tar.gz"
+distfiles="https://sources.voidlinux.org/wmfs-${version}/wmfs-${version}.tar.gz"
 checksum=c28b7cec28a6e3f2bc38a136fb1773bab8ec8f48c69ebe25c24192f96e782d64
 
 CFLAGS="-I${XBPS_CROSS_BASE}/usr/include/freetype2 -fcommon"

From 7e0f88aab78fbd485dd37b051ddac56df9ac24b5 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 16:24:43 +0200
Subject: [PATCH 3/4] pidgin-window-merge: fix dead distfile

---
 srcpkgs/pidgin-window-merge/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pidgin-window-merge/template b/srcpkgs/pidgin-window-merge/template
index d557b223665789..9ef30b341074ef 100644
--- a/srcpkgs/pidgin-window-merge/template
+++ b/srcpkgs/pidgin-window-merge/template
@@ -9,5 +9,5 @@ short_desc="Pidgin plugin that merges the Buddy List and the conversation window
 maintainer="chinarulezzz <s.alex08@mail.ru>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/dm0-/window_merge"
-distfiles="https://github.com/downloads/dm0-/window_merge/window_merge-${version}.tar.gz"
+distfiles="https://sources.voidlinux.org/pidgin-window-merge-${version}/window_merge-${version}.tar.gz"
 checksum=e890c829f8f074ca0bbf32a0bd3c9b8008802f2795d6f40a19756379e2ce6531

From 12ccd6636a2665004c8a6e018d0cfecbca6430ac Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 23 Sep 2024 16:26:14 +0200
Subject: [PATCH 4/4] pidgin-gpg: fix deprecated /downloads/ distfile

---
 srcpkgs/pidgin-gpg/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pidgin-gpg/template b/srcpkgs/pidgin-gpg/template
index f23c33e0fb4aff..0cd00bc4c045ac 100644
--- a/srcpkgs/pidgin-gpg/template
+++ b/srcpkgs/pidgin-gpg/template
@@ -9,5 +9,5 @@ short_desc="GnuPG plug-in for the Pidgin IM"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="http://github.com/segler-alex/Pidgin-GPG"
-distfiles="http://github.com/downloads/segler-alex/Pidgin-GPG/${pkgname}-${version}.tar.gz"
+distfiles="https://sources.voidlinux.org/pidgin-gpg-${version}/pidgin-gpg-${version}.tar.gz"
 checksum=736681cb25da31eb8ced96055d4150d649fe6ef6e523b6f65846c3446ac09a96

Re: Fix deprecated GitHub /downloads/ downloads

[meator]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/52319#issuecomment-2368679073

Comment:
I have marked `mash` `nocross`. It is strange that the same version (with different binary contents and `SHA256SUM`, but I assume that the content is similar) produces such different results. I don't think it is that important to fix cross compiling, because the latest version will still be in the index for all supported architectures from the previous build.

Re: Fix deprecated GitHub /downloads/ downloads

[meator]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/52319#issuecomment-2368568197

Comment:
~Please merge #52321 before this to propagate maintainer update to `pidgin-window-merge`.~ I'm dumb, this PR will not cause a bump, so it doesn't matter.

Re: [PR PATCH] [Merged]: Fix deprecated GitHub /downloads/ downloads

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]

There's a merged pull request on the void-packages repository

Fix deprecated GitHub /downloads/ downloads
https://github.com/void-linux/void-packages/pull/52319

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
`mash`'s latest available tag is [`0.2.0`](https://github.com/clutter-project/mash/releases/tag/0.2.0), which is on par with Void linux's package

`wmfs` latest available tag is [`201003`](https://github.com/xorg62/wmfs/releases/tag/201003), which is `< 201104`

`pidgin-window-merge` doesn't have any tags or releases.

`pidgin-gpg`'s latest available tag is [`0.5`](https://github.com/segler-alex/Pidgin-GPG/releases/tag/0.5), which is `< 0.9` (`pidgin-gpg` appears to be a fork of some other project, releases `>=0.9` were created by the forker).

I personally believe that many of these projects deserve to be removed (at least `pidgin-window-merge` does, because it has no releases and therefore no longer meets quality requirements). I have not done so because you (Void maintainers) were reluctant to removing packages before.

The only remaining package using GitHub's deprecated `/downloads/` API is `xinput_calibrator`. I am having a discussion with maintainers about this: https://gitlab.freedesktop.org/xorg/app/xinput-calibrator/-/issues/85

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->