* [PR PATCH] New package: libXaw3dXft-1.6.2h
@ 2024-09-24 12:31 xeroxslayer
2024-09-24 13:26 ` [PR REVIEW] " meator
` (17 more replies)
0 siblings, 18 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-24 12:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
There is a new pull request by xeroxslayer against master on the void-packages repository
https://github.com/xeroxslayer/void-packages libXaw3dXft
https://github.com/void-linux/void-packages/pull/52336
New package: libXaw3dXft-1.6.2h
#### Testing the changes
- I tested the changes in this PR: **YES** (I built XPaint with it)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64
- aarch64-musl
- aarch64
- i686-musl
- i686
- armv7l-musl
- armv7l
A patch file from https://github.com/void-linux/void-packages/pull/52336.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libXaw3dXft-52336.patch --]
[-- Type: text/x-diff, Size: 1959 bytes --]
From a660524cedc1a2e704aac4e692ff61b0c4d74a61 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 14:24:23 +0200
Subject: [PATCH] New package: libXaw3dXft-1.6.2h
---
srcpkgs/libXaw3dXft-devel | 1 +
srcpkgs/libXaw3dXft/template | 30 ++++++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
create mode 120000 srcpkgs/libXaw3dXft-devel
create mode 100644 srcpkgs/libXaw3dXft/template
diff --git a/srcpkgs/libXaw3dXft-devel b/srcpkgs/libXaw3dXft-devel
new file mode 120000
index 00000000000000..af766a81fe74d9
--- /dev/null
+++ b/srcpkgs/libXaw3dXft-devel
@@ -0,0 +1 @@
+libXaw3dXft
\ No newline at end of file
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
new file mode 100644
index 00000000000000..b6f1c8e6b7282a
--- /dev/null
+++ b/srcpkgs/libXaw3dXft/template
@@ -0,0 +1,30 @@
+# Template file for 'libXaw3dXft'
+pkgname=libXaw3dXft
+version=1.6.2h
+revision=1
+build_style=gnu-configure
+configure_args="--prefix=/usr --disable-static --enable-internationalization
+ --enable-multiplane-bitmaps --enable-gray-stipples --enable-arrow-scrollbars
+ --with-pic --with-gnu-ld"
+hostmakedepends="automake libtool bison pkg-config"
+makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
+short_desc="An extended version of Xaw3d with support for UTF-8"
+maintainer="xeroxslayer <xeroxslayer@proton.me>"
+license="MIT, X11"
+homepage="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/"
+distfiles="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/${pkgname}-${version}.tar.bz2"
+checksum="5d749e3d682d2fb60959ebc3bce3228ca5c949a46aafc349e89a77f6c6ed830b"
+
+post_install() {
+ vlicense COPYING
+}
+
+libXaw3dXft-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
\ No newline at end of file
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
@ 2024-09-24 13:26 ` meator
2024-09-24 13:43 ` xeroxslayer
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: meator @ 2024-09-24 13:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#discussion_r1773348491
Comment:
`--prefix=/usr` is specified by `xbps-src` by default, please remove.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
2024-09-24 13:26 ` [PR REVIEW] " meator
@ 2024-09-24 13:43 ` xeroxslayer
2024-09-24 13:46 ` [PR PATCH] [Updated] " xeroxslayer
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-24 13:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New review comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#discussion_r1773378153
Comment:
OK, will do.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
2024-09-24 13:26 ` [PR REVIEW] " meator
2024-09-24 13:43 ` xeroxslayer
@ 2024-09-24 13:46 ` xeroxslayer
2024-09-24 13:51 ` xeroxslayer
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-24 13:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
There is an updated pull request by xeroxslayer against master on the void-packages repository
https://github.com/xeroxslayer/void-packages libXaw3dXft
https://github.com/void-linux/void-packages/pull/52336
New package: libXaw3dXft-1.6.2h
#### Testing the changes
- I tested the changes in this PR: **YES** (I built XPaint with it)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64
- aarch64-musl
- aarch64
- i686-musl
- i686
- armv7l-musl
- armv7l
A patch file from https://github.com/void-linux/void-packages/pull/52336.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libXaw3dXft-52336.patch --]
[-- Type: text/x-diff, Size: 3109 bytes --]
From a660524cedc1a2e704aac4e692ff61b0c4d74a61 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 14:24:23 +0200
Subject: [PATCH 1/2] New package: libXaw3dXft-1.6.2h
---
srcpkgs/libXaw3dXft-devel | 1 +
srcpkgs/libXaw3dXft/template | 30 ++++++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
create mode 120000 srcpkgs/libXaw3dXft-devel
create mode 100644 srcpkgs/libXaw3dXft/template
diff --git a/srcpkgs/libXaw3dXft-devel b/srcpkgs/libXaw3dXft-devel
new file mode 120000
index 00000000000000..af766a81fe74d9
--- /dev/null
+++ b/srcpkgs/libXaw3dXft-devel
@@ -0,0 +1 @@
+libXaw3dXft
\ No newline at end of file
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
new file mode 100644
index 00000000000000..b6f1c8e6b7282a
--- /dev/null
+++ b/srcpkgs/libXaw3dXft/template
@@ -0,0 +1,30 @@
+# Template file for 'libXaw3dXft'
+pkgname=libXaw3dXft
+version=1.6.2h
+revision=1
+build_style=gnu-configure
+configure_args="--prefix=/usr --disable-static --enable-internationalization
+ --enable-multiplane-bitmaps --enable-gray-stipples --enable-arrow-scrollbars
+ --with-pic --with-gnu-ld"
+hostmakedepends="automake libtool bison pkg-config"
+makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
+short_desc="An extended version of Xaw3d with support for UTF-8"
+maintainer="xeroxslayer <xeroxslayer@proton.me>"
+license="MIT, X11"
+homepage="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/"
+distfiles="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/${pkgname}-${version}.tar.bz2"
+checksum="5d749e3d682d2fb60959ebc3bce3228ca5c949a46aafc349e89a77f6c6ed830b"
+
+post_install() {
+ vlicense COPYING
+}
+
+libXaw3dXft-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
\ No newline at end of file
From ca06a199e21457155d0c81b1b41c61151edc858a Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 15:44:54 +0200
Subject: [PATCH 2/2] New package: libXaw3dXft-1.6.2h - removed configure arg
---
srcpkgs/libXaw3dXft/template | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
index b6f1c8e6b7282a..0fa715d53c2872 100644
--- a/srcpkgs/libXaw3dXft/template
+++ b/srcpkgs/libXaw3dXft/template
@@ -3,9 +3,8 @@ pkgname=libXaw3dXft
version=1.6.2h
revision=1
build_style=gnu-configure
-configure_args="--prefix=/usr --disable-static --enable-internationalization
- --enable-multiplane-bitmaps --enable-gray-stipples --enable-arrow-scrollbars
- --with-pic --with-gnu-ld"
+configure_args="--disable-static --enable-internationalization --enable-multiplane-bitmaps
+ --enable-gray-stipples --enable-arrow-scrollbars --with-pic --with-gnu-ld"
hostmakedepends="automake libtool bison pkg-config"
makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
short_desc="An extended version of Xaw3d with support for UTF-8"
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (2 preceding siblings ...)
2024-09-24 13:46 ` [PR PATCH] [Updated] " xeroxslayer
@ 2024-09-24 13:51 ` xeroxslayer
2024-09-25 6:26 ` xeroxslayer
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-24 13:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
There is an updated pull request by xeroxslayer against master on the void-packages repository
https://github.com/xeroxslayer/void-packages libXaw3dXft
https://github.com/void-linux/void-packages/pull/52336
New package: libXaw3dXft-1.6.2h
#### Testing the changes
- I tested the changes in this PR: **YES** (I built XPaint with it)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64
- aarch64-musl
- aarch64
- i686-musl
- i686
- armv7l-musl
- armv7l
A patch file from https://github.com/void-linux/void-packages/pull/52336.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libXaw3dXft-52336.patch --]
[-- Type: text/x-diff, Size: 4343 bytes --]
From a660524cedc1a2e704aac4e692ff61b0c4d74a61 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 14:24:23 +0200
Subject: [PATCH 1/3] New package: libXaw3dXft-1.6.2h
---
srcpkgs/libXaw3dXft-devel | 1 +
srcpkgs/libXaw3dXft/template | 30 ++++++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
create mode 120000 srcpkgs/libXaw3dXft-devel
create mode 100644 srcpkgs/libXaw3dXft/template
diff --git a/srcpkgs/libXaw3dXft-devel b/srcpkgs/libXaw3dXft-devel
new file mode 120000
index 00000000000000..af766a81fe74d9
--- /dev/null
+++ b/srcpkgs/libXaw3dXft-devel
@@ -0,0 +1 @@
+libXaw3dXft
\ No newline at end of file
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
new file mode 100644
index 00000000000000..b6f1c8e6b7282a
--- /dev/null
+++ b/srcpkgs/libXaw3dXft/template
@@ -0,0 +1,30 @@
+# Template file for 'libXaw3dXft'
+pkgname=libXaw3dXft
+version=1.6.2h
+revision=1
+build_style=gnu-configure
+configure_args="--prefix=/usr --disable-static --enable-internationalization
+ --enable-multiplane-bitmaps --enable-gray-stipples --enable-arrow-scrollbars
+ --with-pic --with-gnu-ld"
+hostmakedepends="automake libtool bison pkg-config"
+makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
+short_desc="An extended version of Xaw3d with support for UTF-8"
+maintainer="xeroxslayer <xeroxslayer@proton.me>"
+license="MIT, X11"
+homepage="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/"
+distfiles="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/${pkgname}-${version}.tar.bz2"
+checksum="5d749e3d682d2fb60959ebc3bce3228ca5c949a46aafc349e89a77f6c6ed830b"
+
+post_install() {
+ vlicense COPYING
+}
+
+libXaw3dXft-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
\ No newline at end of file
From ca06a199e21457155d0c81b1b41c61151edc858a Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 15:44:54 +0200
Subject: [PATCH 2/3] New package: libXaw3dXft-1.6.2h - removed configure arg
---
srcpkgs/libXaw3dXft/template | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
index b6f1c8e6b7282a..0fa715d53c2872 100644
--- a/srcpkgs/libXaw3dXft/template
+++ b/srcpkgs/libXaw3dXft/template
@@ -3,9 +3,8 @@ pkgname=libXaw3dXft
version=1.6.2h
revision=1
build_style=gnu-configure
-configure_args="--prefix=/usr --disable-static --enable-internationalization
- --enable-multiplane-bitmaps --enable-gray-stipples --enable-arrow-scrollbars
- --with-pic --with-gnu-ld"
+configure_args="--disable-static --enable-internationalization --enable-multiplane-bitmaps
+ --enable-gray-stipples --enable-arrow-scrollbars --with-pic --with-gnu-ld"
hostmakedepends="automake libtool bison pkg-config"
makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
short_desc="An extended version of Xaw3d with support for UTF-8"
From 8e3d276d0e323644f8b647a4483daa0d7452ffa2 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 15:49:17 +0200
Subject: [PATCH 3/3] New package: libXaw3dXft-1.6.2h - fix compliance with
lints
---
srcpkgs/libXaw3dXft/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
index 0fa715d53c2872..06b83e8660fb0c 100644
--- a/srcpkgs/libXaw3dXft/template
+++ b/srcpkgs/libXaw3dXft/template
@@ -7,7 +7,7 @@ configure_args="--disable-static --enable-internationalization --enable-multipla
--enable-gray-stipples --enable-arrow-scrollbars --with-pic --with-gnu-ld"
hostmakedepends="automake libtool bison pkg-config"
makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
-short_desc="An extended version of Xaw3d with support for UTF-8"
+short_desc="This is an extended version of Xaw3d with support for UTF-8"
maintainer="xeroxslayer <xeroxslayer@proton.me>"
license="MIT, X11"
homepage="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/"
@@ -26,4 +26,4 @@ libXaw3dXft-devel_package() {
vmove usr/lib/pkgconfig
vmove "usr/lib/*.so"
}
-}
\ No newline at end of file
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (3 preceding siblings ...)
2024-09-24 13:51 ` xeroxslayer
@ 2024-09-25 6:26 ` xeroxslayer
2024-09-25 8:23 ` [PR REVIEW] " meator
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-25 6:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2373137493
Comment:
Should I just squash or more corrections are needed?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (5 preceding siblings ...)
2024-09-25 8:23 ` [PR REVIEW] " meator
@ 2024-09-25 8:23 ` meator
2024-09-25 10:19 ` xeroxslayer
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: meator @ 2024-09-25 8:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
New review comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#discussion_r1774777896
Comment:
```suggestion
short_desc="Extended version of Xaw3d with support for UTF-8"
```
The description should be terse. I know that lints complained about the article before, but simply removing it is enough to make the lint error go away.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (4 preceding siblings ...)
2024-09-25 6:26 ` xeroxslayer
@ 2024-09-25 8:23 ` meator
2024-09-25 8:23 ` meator
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: meator @ 2024-09-25 8:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
New review comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#discussion_r1774781310
Comment:
This isn't that important, but I'd expand `${pkgname}` here.
```suggestion
distfiles="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/libXaw3dXft-${version}.tar.bz2"
```
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (6 preceding siblings ...)
2024-09-25 8:23 ` meator
@ 2024-09-25 10:19 ` xeroxslayer
2024-09-25 10:24 ` xeroxslayer
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-25 10:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
New review comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#discussion_r1774966975
Comment:
I don't think I follow. The corrected part fits `${pkgname}` perfectly, but other parts of the URL don't. I should expand this var to also cater to other parts of the URL?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (7 preceding siblings ...)
2024-09-25 10:19 ` xeroxslayer
@ 2024-09-25 10:24 ` xeroxslayer
2024-09-25 10:32 ` xeroxslayer
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-25 10:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New review comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#discussion_r1774974388
Comment:
OK, I'll correct this as well.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (8 preceding siblings ...)
2024-09-25 10:24 ` xeroxslayer
@ 2024-09-25 10:32 ` xeroxslayer
2024-09-25 10:44 ` [PR PATCH] [Updated] " xeroxslayer
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-25 10:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
New comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2373705220
Comment:
> By the way, are you packaging this library because it is a dependency of some other program that you'd like to package? If that is the case, you can include all dependencies of the target programs (that aren't packaged) in a single pull request including the program itself.
Yes, I'd like to add XPaint to the repo, but I had to edit `shlibs` as well because this lib wasn't in repo, so I thought it would be better if the lib was already in repo and indexed, then add XPaint to repo and in that case, there will be no reason to edit `shlibs`. Thank you for the suggestion though :). How would that go though? I just don't commit the edited `shlibs` and commit everything else? But then the CI would have to build the libs first, then the application, because it would otherwise fail to build the app because of unresolved deps... is there a rule like that in the builder, first build libs, then apps?
Also, I wanted to ask if it's better to name the application `XPaint`, or `xpaint`. The source package is named `xpaint-<version>`, but the application's name is `XPaint`. Which would be better? If this is a question for that PR, please ignore this question.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (9 preceding siblings ...)
2024-09-25 10:32 ` xeroxslayer
@ 2024-09-25 10:44 ` xeroxslayer
2024-09-25 11:01 ` meator
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-25 10:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
There is an updated pull request by xeroxslayer against master on the void-packages repository
https://github.com/xeroxslayer/void-packages libXaw3dXft
https://github.com/void-linux/void-packages/pull/52336
New package: libXaw3dXft-1.6.2h
#### Testing the changes
- I tested the changes in this PR: **YES** (I built XPaint with it)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64
- aarch64-musl
- aarch64
- i686-musl
- i686
- armv7l-musl
- armv7l
A patch file from https://github.com/void-linux/void-packages/pull/52336.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libXaw3dXft-52336.patch --]
[-- Type: text/x-diff, Size: 5433 bytes --]
From a660524cedc1a2e704aac4e692ff61b0c4d74a61 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 14:24:23 +0200
Subject: [PATCH 1/4] New package: libXaw3dXft-1.6.2h
---
srcpkgs/libXaw3dXft-devel | 1 +
srcpkgs/libXaw3dXft/template | 30 ++++++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
create mode 120000 srcpkgs/libXaw3dXft-devel
create mode 100644 srcpkgs/libXaw3dXft/template
diff --git a/srcpkgs/libXaw3dXft-devel b/srcpkgs/libXaw3dXft-devel
new file mode 120000
index 00000000000000..af766a81fe74d9
--- /dev/null
+++ b/srcpkgs/libXaw3dXft-devel
@@ -0,0 +1 @@
+libXaw3dXft
\ No newline at end of file
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
new file mode 100644
index 00000000000000..b6f1c8e6b7282a
--- /dev/null
+++ b/srcpkgs/libXaw3dXft/template
@@ -0,0 +1,30 @@
+# Template file for 'libXaw3dXft'
+pkgname=libXaw3dXft
+version=1.6.2h
+revision=1
+build_style=gnu-configure
+configure_args="--prefix=/usr --disable-static --enable-internationalization
+ --enable-multiplane-bitmaps --enable-gray-stipples --enable-arrow-scrollbars
+ --with-pic --with-gnu-ld"
+hostmakedepends="automake libtool bison pkg-config"
+makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
+short_desc="An extended version of Xaw3d with support for UTF-8"
+maintainer="xeroxslayer <xeroxslayer@proton.me>"
+license="MIT, X11"
+homepage="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/"
+distfiles="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/${pkgname}-${version}.tar.bz2"
+checksum="5d749e3d682d2fb60959ebc3bce3228ca5c949a46aafc349e89a77f6c6ed830b"
+
+post_install() {
+ vlicense COPYING
+}
+
+libXaw3dXft-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
\ No newline at end of file
From ca06a199e21457155d0c81b1b41c61151edc858a Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 15:44:54 +0200
Subject: [PATCH 2/4] New package: libXaw3dXft-1.6.2h - removed configure arg
---
srcpkgs/libXaw3dXft/template | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
index b6f1c8e6b7282a..0fa715d53c2872 100644
--- a/srcpkgs/libXaw3dXft/template
+++ b/srcpkgs/libXaw3dXft/template
@@ -3,9 +3,8 @@ pkgname=libXaw3dXft
version=1.6.2h
revision=1
build_style=gnu-configure
-configure_args="--prefix=/usr --disable-static --enable-internationalization
- --enable-multiplane-bitmaps --enable-gray-stipples --enable-arrow-scrollbars
- --with-pic --with-gnu-ld"
+configure_args="--disable-static --enable-internationalization --enable-multiplane-bitmaps
+ --enable-gray-stipples --enable-arrow-scrollbars --with-pic --with-gnu-ld"
hostmakedepends="automake libtool bison pkg-config"
makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
short_desc="An extended version of Xaw3d with support for UTF-8"
From 8e3d276d0e323644f8b647a4483daa0d7452ffa2 Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Tue, 24 Sep 2024 15:49:17 +0200
Subject: [PATCH 3/4] New package: libXaw3dXft-1.6.2h - fix compliance with
lints
---
srcpkgs/libXaw3dXft/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
index 0fa715d53c2872..06b83e8660fb0c 100644
--- a/srcpkgs/libXaw3dXft/template
+++ b/srcpkgs/libXaw3dXft/template
@@ -7,7 +7,7 @@ configure_args="--disable-static --enable-internationalization --enable-multipla
--enable-gray-stipples --enable-arrow-scrollbars --with-pic --with-gnu-ld"
hostmakedepends="automake libtool bison pkg-config"
makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
-short_desc="An extended version of Xaw3d with support for UTF-8"
+short_desc="This is an extended version of Xaw3d with support for UTF-8"
maintainer="xeroxslayer <xeroxslayer@proton.me>"
license="MIT, X11"
homepage="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/"
@@ -26,4 +26,4 @@ libXaw3dXft-devel_package() {
vmove usr/lib/pkgconfig
vmove "usr/lib/*.so"
}
-}
\ No newline at end of file
+}
From 94fbb90498fa91fb9e0cbf1c3a2b254c08da509b Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Wed, 25 Sep 2024 12:42:08 +0200
Subject: [PATCH 4/4] New package: libXaw3dXft-1.6.2h - fixed package
description
---
srcpkgs/libXaw3dXft/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/libXaw3dXft/template b/srcpkgs/libXaw3dXft/template
index 06b83e8660fb0c..2aa59b69fc6adb 100644
--- a/srcpkgs/libXaw3dXft/template
+++ b/srcpkgs/libXaw3dXft/template
@@ -7,7 +7,7 @@ configure_args="--disable-static --enable-internationalization --enable-multipla
--enable-gray-stipples --enable-arrow-scrollbars --with-pic --with-gnu-ld"
hostmakedepends="automake libtool bison pkg-config"
makedepends="libXft-devel libXmu-devel libXpm-devel xorg-util-macros"
-short_desc="This is an extended version of Xaw3d with support for UTF-8"
+short_desc="Extended version of Xaw3d with support for UTF-8"
maintainer="xeroxslayer <xeroxslayer@proton.me>"
license="MIT, X11"
homepage="https://sourceforge.net/projects/sf-xpaint/files/libxaw3dxft/"
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (10 preceding siblings ...)
2024-09-25 10:44 ` [PR PATCH] [Updated] " xeroxslayer
@ 2024-09-25 11:01 ` meator
2024-09-25 14:20 ` xeroxslayer
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: meator @ 2024-09-25 11:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2373762021
Comment:
`xbps-src` can handle building multiple packages at once. You shouldn't really worry about that. Include the `shlib` change.
Also, this is a duplicate of #50161 You can review it [and test it](https://xbps-src-tutorials.github.io/pr-testing-tutorial.html) if you want to.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (11 preceding siblings ...)
2024-09-25 11:01 ` meator
@ 2024-09-25 14:20 ` xeroxslayer
2024-09-25 14:22 ` meator
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-25 14:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2374231735
Comment:
OK, so if I review and test that PR, I continue working on that one and abandon/close this PR, correct?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (12 preceding siblings ...)
2024-09-25 14:20 ` xeroxslayer
@ 2024-09-25 14:22 ` meator
2024-09-25 14:23 ` xeroxslayer
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: meator @ 2024-09-25 14:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2374237679
Comment:
Yes, the other pull request is older and it appears to be more complete, so attention should be directed to #50161 instead.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (13 preceding siblings ...)
2024-09-25 14:22 ` meator
@ 2024-09-25 14:23 ` xeroxslayer
2024-09-25 14:27 ` meator
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-25 14:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
New comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2374241511
Comment:
OK, will do that.
I'll close this one after that one gest merged.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (14 preceding siblings ...)
2024-09-25 14:23 ` xeroxslayer
@ 2024-09-25 14:27 ` meator
2024-09-26 10:18 ` [PR PATCH] [Closed]: " xeroxslayer
2024-09-26 10:18 ` xeroxslayer
17 siblings, 0 replies; 19+ messages in thread
From: meator @ 2024-09-25 14:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2374252004
Comment:
You should close this immediately. It doesn't make sense to have two or more pull requests for the same package.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Closed]: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (15 preceding siblings ...)
2024-09-25 14:27 ` meator
@ 2024-09-26 10:18 ` xeroxslayer
2024-09-26 10:18 ` xeroxslayer
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-26 10:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
There's a closed pull request on the void-packages repository
New package: libXaw3dXft-1.6.2h
https://github.com/void-linux/void-packages/pull/52336
Description:
#### Testing the changes
- I tested the changes in this PR: **YES** (I built XPaint with it)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64
- aarch64-musl
- aarch64
- i686-musl
- i686
- armv7l-musl
- armv7l
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New package: libXaw3dXft-1.6.2h
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
` (16 preceding siblings ...)
2024-09-26 10:18 ` [PR PATCH] [Closed]: " xeroxslayer
@ 2024-09-26 10:18 ` xeroxslayer
17 siblings, 0 replies; 19+ messages in thread
From: xeroxslayer @ 2024-09-26 10:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New comment by xeroxslayer on void-packages repository
https://github.com/void-linux/void-packages/pull/52336#issuecomment-2376540285
Comment:
OK, closing now.
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2024-09-26 10:18 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-24 12:31 [PR PATCH] New package: libXaw3dXft-1.6.2h xeroxslayer
2024-09-24 13:26 ` [PR REVIEW] " meator
2024-09-24 13:43 ` xeroxslayer
2024-09-24 13:46 ` [PR PATCH] [Updated] " xeroxslayer
2024-09-24 13:51 ` xeroxslayer
2024-09-25 6:26 ` xeroxslayer
2024-09-25 8:23 ` [PR REVIEW] " meator
2024-09-25 8:23 ` meator
2024-09-25 10:19 ` xeroxslayer
2024-09-25 10:24 ` xeroxslayer
2024-09-25 10:32 ` xeroxslayer
2024-09-25 10:44 ` [PR PATCH] [Updated] " xeroxslayer
2024-09-25 11:01 ` meator
2024-09-25 14:20 ` xeroxslayer
2024-09-25 14:22 ` meator
2024-09-25 14:23 ` xeroxslayer
2024-09-25 14:27 ` meator
2024-09-26 10:18 ` [PR PATCH] [Closed]: " xeroxslayer
2024-09-26 10:18 ` xeroxslayer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).