* Re: [PR REVIEW] sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
@ 2024-10-01 13:18 ` abenson
2024-10-01 13:20 ` tsndqst
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-10-01 13:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/52430#discussion_r1782780028
Comment:
Wouldn't this go in `makedepends`, not `hostmakdepends`?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
2024-10-01 13:18 ` [PR REVIEW] " abenson
@ 2024-10-01 13:20 ` tsndqst
2024-10-01 13:46 ` abenson
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tsndqst @ 2024-10-01 13:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
New review comment by tsndqst on void-packages repository
https://github.com/void-linux/void-packages/pull/52430#discussion_r1782786654
Comment:
To tell you the truth I don't understand the difference. It works in both places.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
2024-10-01 13:18 ` [PR REVIEW] " abenson
2024-10-01 13:20 ` tsndqst
@ 2024-10-01 13:46 ` abenson
2024-10-01 14:37 ` [PR PATCH] [Updated] " tsndqst
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: abenson @ 2024-10-01 13:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/52430#discussion_r1782879080
Comment:
`hostmakedepends` is for things that need to run on the host, `makedepends` is libraries on the target host; this matters most for cross-builds. So your fix would work (though not intentionally) for native builds, but not cross-builds like we do for ARM.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
` (2 preceding siblings ...)
2024-10-01 13:46 ` abenson
@ 2024-10-01 14:37 ` tsndqst
2024-10-01 14:38 ` tsndqst
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tsndqst @ 2024-10-01 14:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]
There is an updated pull request by tsndqst against master on the void-packages repository
https://github.com/tsndqst/void-packages sysstat
https://github.com/void-linux/void-packages/pull/52430
sysstat: fix sensors support
<!-- Uncomment relevant sections and delete options which are not applicable -->
Prior to this change the `sar` command would not show temperature values. When running `sar -m TEMP` the following message would be displayed:
```
Requested activities not available in file /var/log/sa/sa30
```
After this change and running the following commands `sar` reported temperature values.
```
sudo rm /var/log/sa/sa30
sudo /usr/lib/sa/sa1 1 1
sudo /usr/lib/sa/sa1 1 1
sar -m TEMP
```
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/52430.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sysstat-52430.patch --]
[-- Type: text/x-diff, Size: 989 bytes --]
From 82af7475cb348e22365174676bde141dfc754c5c Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Mon, 30 Sep 2024 16:57:07 -0500
Subject: [PATCH] sysstat: fix sensors support
---
srcpkgs/sysstat/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/sysstat/template b/srcpkgs/sysstat/template
index 2bc011fc7e2f0b..68105f44c8b4fc 100644
--- a/srcpkgs/sysstat/template
+++ b/srcpkgs/sysstat/template
@@ -1,11 +1,12 @@
# Template file for 'sysstat'
pkgname=sysstat
version=12.7.6
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--enable-copy-only --disable-file-attr
- --with-systemdsystemunitdir= --enable-install-cron"
+ --with-systemdsystemunitdir= --enable-install-cron --enable-sensors"
conf_files="/etc/default/sysstat /etc/default/sysstat.ioconf"
+makedepends="libsensors-devel"
hostmakedepends="pkg-config gettext"
depends="lm_sensors"
short_desc="Collection of performance monitoring tools"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
` (3 preceding siblings ...)
2024-10-01 14:37 ` [PR PATCH] [Updated] " tsndqst
@ 2024-10-01 14:38 ` tsndqst
2024-10-01 14:39 ` [PR PATCH] [Updated] " tsndqst
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tsndqst @ 2024-10-01 14:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
New comment by tsndqst on void-packages repository
https://github.com/void-linux/void-packages/pull/52430#issuecomment-2386170702
Comment:
Thanks @abenson I updated it. I'll try to cross-compile and test later today to confirm it works.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
` (4 preceding siblings ...)
2024-10-01 14:38 ` tsndqst
@ 2024-10-01 14:39 ` tsndqst
2024-10-01 19:34 ` [PR REVIEW] " tsndqst
2024-10-02 12:18 ` [PR PATCH] [Merged]: " leahneukirchen
7 siblings, 0 replies; 9+ messages in thread
From: tsndqst @ 2024-10-01 14:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]
There is an updated pull request by tsndqst against master on the void-packages repository
https://github.com/tsndqst/void-packages sysstat
https://github.com/void-linux/void-packages/pull/52430
sysstat: fix sensors support
<!-- Uncomment relevant sections and delete options which are not applicable -->
Prior to this change the `sar` command would not show temperature values. When running `sar -m TEMP` the following message would be displayed:
```
Requested activities not available in file /var/log/sa/sa30
```
After this change and running the following commands `sar` reported temperature values.
```
sudo rm /var/log/sa/sa30
sudo /usr/lib/sa/sa1 1 1
sudo /usr/lib/sa/sa1 1 1
sar -m TEMP
```
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/52430.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sysstat-52430.patch --]
[-- Type: text/x-diff, Size: 1035 bytes --]
From 367cf5d19b511913a1ad987aea35e58381df3f3d Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Mon, 30 Sep 2024 16:57:07 -0500
Subject: [PATCH] sysstat: fix sensors support
---
srcpkgs/sysstat/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/sysstat/template b/srcpkgs/sysstat/template
index 2bc011fc7e2f0b..166b7b8340ca14 100644
--- a/srcpkgs/sysstat/template
+++ b/srcpkgs/sysstat/template
@@ -1,12 +1,13 @@
# Template file for 'sysstat'
pkgname=sysstat
version=12.7.6
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--enable-copy-only --disable-file-attr
- --with-systemdsystemunitdir= --enable-install-cron"
+ --with-systemdsystemunitdir= --enable-install-cron --enable-sensors"
conf_files="/etc/default/sysstat /etc/default/sysstat.ioconf"
hostmakedepends="pkg-config gettext"
+makedepends="libsensors-devel"
depends="lm_sensors"
short_desc="Collection of performance monitoring tools"
maintainer="Leah Neukirchen <leah@vuxu.org>"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
` (5 preceding siblings ...)
2024-10-01 14:39 ` [PR PATCH] [Updated] " tsndqst
@ 2024-10-01 19:34 ` tsndqst
2024-10-02 12:18 ` [PR PATCH] [Merged]: " leahneukirchen
7 siblings, 0 replies; 9+ messages in thread
From: tsndqst @ 2024-10-01 19:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by tsndqst on void-packages repository
https://github.com/void-linux/void-packages/pull/52430#discussion_r1783397412
Comment:
I tested cross compiling and running on aarch64. It works as expected with the current config. Thanks for catching the `depends` issue @abenson.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: sysstat: fix sensors support
2024-09-30 22:08 [PR PATCH] sysstat: fix sensors support tsndqst
` (6 preceding siblings ...)
2024-10-01 19:34 ` [PR REVIEW] " tsndqst
@ 2024-10-02 12:18 ` leahneukirchen
7 siblings, 0 replies; 9+ messages in thread
From: leahneukirchen @ 2024-10-02 12:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]
There's a merged pull request on the void-packages repository
sysstat: fix sensors support
https://github.com/void-linux/void-packages/pull/52430
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
Prior to this change the `sar` command would not show temperature values. When running `sar -m TEMP` the following message would be displayed:
```
Requested activities not available in file /var/log/sa/sa30
```
After this change and running the following commands `sar` reported temperature values.
```
sudo rm /var/log/sa/sa30
sudo /usr/lib/sa/sa1 1 1
sudo /usr/lib/sa/sa1 1 1
sar -m TEMP
```
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-glibc
^ permalink raw reply [flat|nested] 9+ messages in thread