[PR PATCH] Add warning about a custom binary name for xq

[PR PATCH] Add warning about a custom binary name for xq

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

There is a new pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages xq
https://github.com/void-linux/void-packages/pull/51462

Add warning about a custom binary name for xq
[ci skip]
No template change.

A patch file from https://github.com/void-linux/void-packages/pull/51462.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xq-51462.patch --]
[-- Type: text/x-diff, Size: 578 bytes --]

From da33bee2db7566909fbf183441dedbe259cb4f0e Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Fri, 26 Jul 2024 07:37:02 +0200
Subject: [PATCH] Add warning about a custom binary name for xq

---
 srcpkgs/xq/INSTALL.msg | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 srcpkgs/xq/INSTALL.msg

diff --git a/srcpkgs/xq/INSTALL.msg b/srcpkgs/xq/INSTALL.msg
new file mode 100644
index 00000000000000..0baa1e1b04af14
--- /dev/null
+++ b/srcpkgs/xq/INSTALL.msg
@@ -0,0 +1,2 @@
+Due to conflicting binary names, the `xq` binary is renamed to `qx-go`
+by default.

Re: [PR PATCH] [Updated] Add warning about a custom binary name for xq

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages xq
https://github.com/void-linux/void-packages/pull/51462

Add warning about a custom binary name for xq
[ci skip]
No template change.

A patch file from https://github.com/void-linux/void-packages/pull/51462.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xq-51462.patch --]
[-- Type: text/x-diff, Size: 575 bytes --]

From 02db2b33646658eeaa688344dba2b3cd31f0ae03 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Fri, 26 Jul 2024 07:37:02 +0200
Subject: [PATCH] xq: Add warning about a custom binary name

---
 srcpkgs/xq/INSTALL.msg | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 srcpkgs/xq/INSTALL.msg

diff --git a/srcpkgs/xq/INSTALL.msg b/srcpkgs/xq/INSTALL.msg
new file mode 100644
index 00000000000000..0baa1e1b04af14
--- /dev/null
+++ b/srcpkgs/xq/INSTALL.msg
@@ -0,0 +1,2 @@
+Due to conflicting binary names, the `xq` binary is renamed to `qx-go`
+by default.

Re: xq: Add warning about a custom binary name

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51462#issuecomment-2252088449

Comment:
hm i'm not sure that's necessary

Re: xq: Add warning about a custom binary name

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

New comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/51462#issuecomment-2252118398

Comment:
I disagree. People and existing scripts will expect the binary to be `xq` by default, not `xq-go`. This might and likely will break scripts, workflows and introduce unnecessary debugging by users. This has already happened to my friend who used the package and I had to explain what's up. You'd normally parse a file, pipe it to xq and nothing would happen, because it would run the default `/usr/sbin/xq`, which gives absolutely no output in such case, not even when running `xq --help`.
This message, if anything, might prevent such scenarios.

Re: [PR REVIEW] xq: Add warning about a custom binary name

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/51462#discussion_r1692886145

Comment:
`qx-go` or `xq-go` ?

Re: [PR PATCH] [Updated] xq: Add warning about a custom binary name

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages xq
https://github.com/void-linux/void-packages/pull/51462

xq: Add warning about a custom binary name
[ci skip]
No template change.

A patch file from https://github.com/void-linux/void-packages/pull/51462.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xq-51462.patch --]
[-- Type: text/x-diff, Size: 575 bytes --]

From 3836cd8e16321189fa0e6c988bfb618977eb8dc6 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Fri, 26 Jul 2024 07:37:02 +0200
Subject: [PATCH] xq: Add warning about a custom binary name

---
 srcpkgs/xq/INSTALL.msg | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 srcpkgs/xq/INSTALL.msg

diff --git a/srcpkgs/xq/INSTALL.msg b/srcpkgs/xq/INSTALL.msg
new file mode 100644
index 00000000000000..f1346eae4daf9e
--- /dev/null
+++ b/srcpkgs/xq/INSTALL.msg
@@ -0,0 +1,2 @@
+Due to conflicting binary names, the `xq` binary is renamed to `xq-go`
+by default.

Re: [PR REVIEW] xq: Add warning about a custom binary name

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/51462#discussion_r1693405669

Comment:
Oops, thanks for catching this. Fixed.

Re: xq: Add warning about a custom binary name

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51462#issuecomment-2253216834

Comment:
the other notable example of something like this is `yq-go`. maybe instead the package should be renamed to `xq-go`

Re: [PR PATCH] [Updated] xq: Add warning about a custom binary name

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages xq
https://github.com/void-linux/void-packages/pull/51462

xq: Add warning about a custom binary name
[ci skip]
No template change.

A patch file from https://github.com/void-linux/void-packages/pull/51462.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xq-51462.patch --]
[-- Type: text/x-diff, Size: 1611 bytes --]

From 8f4254bb991cdc558dd32b7d462123d059eab3a4 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Fri, 26 Jul 2024 07:37:02 +0200
Subject: [PATCH 1/2] xq: Add warning about a custom binary name

---
 srcpkgs/xq/INSTALL.msg | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 srcpkgs/xq/INSTALL.msg

diff --git a/srcpkgs/xq/INSTALL.msg b/srcpkgs/xq/INSTALL.msg
new file mode 100644
index 00000000000000..f1346eae4daf9e
--- /dev/null
+++ b/srcpkgs/xq/INSTALL.msg
@@ -0,0 +1,2 @@
+Due to conflicting binary names, the `xq` binary is renamed to `xq-go`
+by default.

From 7d7366f12eb93df34a4a5ec8493950b962760c97 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Mon, 7 Oct 2024 12:59:07 +0200
Subject: [PATCH 2/2] xq: update to 1.2.5

---
 srcpkgs/xq/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/xq/template b/srcpkgs/xq/template
index d8a0bf349be1c6..bd2edf9c29fb72 100644
--- a/srcpkgs/xq/template
+++ b/srcpkgs/xq/template
@@ -1,7 +1,7 @@
 # Template file for 'xq'
 pkgname=xq
-version=1.2.4
-revision=2
+version=1.2.5
+revision=1
 build_style=go
 go_import_path=github.com/sibprogrammer/xq
 make_check_args="-covermode=atomic"
@@ -10,7 +10,7 @@ maintainer="Emil Miler <em@0x45.cz>"
 license="MIT"
 homepage="https://github.com/sibprogrammer/xq"
 distfiles="https://github.com/sibprogrammer/xq/archive/refs/tags/v${version}.tar.gz"
-checksum=5044de231d2426c236618e52d3d2e59cd45b008e55d5dfa8df97c3269c64354d
+checksum=9432a992d2f0ab82a7350da6317e27f835713c340177518dd08581bd0e918365
 
 post_install() {
 	mv "$DESTDIR/usr/bin/"{xq,xq-go}

Re: xq: update to 1.2.5, add INSTALL.msg

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/51462#issuecomment-2396604839

Comment:
Updated to `1.2.5`.

Re: [PR PATCH] [Closed]: xq: update to 1.2.5, add INSTALL.msg

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

There's a closed pull request on the void-packages repository

xq: update to 1.2.5, add INSTALL.msg
https://github.com/void-linux/void-packages/pull/51462

Description:
[ci skip]
No template change.

Re: xq: update to 1.2.5, add INSTALL.msg

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/52542#issuecomment-2396742545

Comment:
Commits squashed.

Re: xq: update to 1.2.5, add INSTALL.msg

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/52542#issuecomment-2396738632

Comment:
Sorry, I recreated the PR because I wasn't sure how to restart the CI jobs, since they were blocked by the first comment.

Re: xq: update to 1.2.5, add INSTALL.msg

[abenson]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/52542#issuecomment-2396718498

Comment:
Please don't open/close PRs; it makes it harder for us to track progress and history. If you need to make changes, just amend the commit and force push to your branch.

Please [squash](https://www.git-tower.com/learn/git/faq/git-squash) the two commits together.