Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [NOT TESTED] runit: update to 2.2.0.
@ 2024-09-29 14:24 sgn
  2024-09-30  3:36 ` [PR PATCH] [Updated] " sgn
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: sgn @ 2024-09-29 14:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages runit-2.2.0
https://github.com/void-linux/void-packages/pull/52408

[NOT TESTED] runit: update to 2.2.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-runit-2.2.0-52408.patch --]
[-- Type: text/x-diff, Size: 16357 bytes --]

From c653cb76a7280d09de7739281840eca9d6b4d45b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sun, 29 Sep 2024 21:23:35 +0700
Subject: [PATCH] runit: update to 2.2.0.

---
 srcpkgs/runit/patches/chpst-pwd.patch      | 77 ----------------------
 srcpkgs/runit/patches/chpst.patch          | 14 ----
 srcpkgs/runit/patches/clearmem.patch       | 15 +++--
 srcpkgs/runit/patches/cross.patch          | 70 ++++++++++++++------
 srcpkgs/runit/patches/default_svdir.patch  | 26 ++++----
 srcpkgs/runit/patches/sigcont.patch        |  6 +-
 srcpkgs/runit/patches/svlogd.patch         | 13 ----
 srcpkgs/runit/patches/utmpset-time_t.patch | 56 ----------------
 srcpkgs/runit/template                     | 23 ++++---
 9 files changed, 90 insertions(+), 210 deletions(-)
 delete mode 100644 srcpkgs/runit/patches/chpst-pwd.patch
 delete mode 100644 srcpkgs/runit/patches/chpst.patch
 delete mode 100644 srcpkgs/runit/patches/svlogd.patch
 delete mode 100644 srcpkgs/runit/patches/utmpset-time_t.patch

diff --git a/srcpkgs/runit/patches/chpst-pwd.patch b/srcpkgs/runit/patches/chpst-pwd.patch
deleted file mode 100644
index c8ee7ed893cac4..00000000000000
--- a/srcpkgs/runit/patches/chpst-pwd.patch
+++ /dev/null
@@ -1,77 +0,0 @@
-From 2b8000f1ebd07fd68ee0e3c32737d97bcd1687fb Mon Sep 17 00:00:00 2001
-From: "Andrew J. Hesford" <ajh@sideband.org>
-Date: Mon, 14 Feb 2022 14:25:22 -0500
-Subject: [PATCH] chpst: add -C to change working directory
-
----
- man/chpst.8 | 8 ++++++++
- src/chpst.c | 9 +++++++--
- 2 files changed, 15 insertions(+), 2 deletions(-)
-
-diff --git runit-2.1.2/man/chpst.8 runit-2.1.2/man/chpst.8
-index 43c0b8d..e0829b6 100644
---- runit-2.1.2/man/chpst.8
-+++ runit-2.1.2/man/chpst.8
-@@ -146,6 +146,14 @@ Change the root directory to
- before starting
- .IR prog .
- .TP
-+.B \-C \fIpwd
-+chdir.
-+Change the working directory to
-+.I pwd
-+before starting
-+.IR prog .
-+When combined with \-/, the working directory is changed after the chroot.
-+.TP
- .B \-n \fIinc
- nice.
- Add
-diff --git runit-2.1.2/src/chpst.c runit-2.1.2/src/chpst.c
-index 1cca5f4..d597b68 100644
---- runit-2.1.2/src/chpst.c
-+++ runit-2.1.2/src/chpst.c
-@@ -20,7 +20,7 @@
- #include "openreadclose.h"
- #include "direntry.h"
- 
--#define USAGE_MAIN " [-vP012] [-u user[:group]] [-U user[:group]] [-b argv0] [-e dir] [-/ root] [-n nice] [-l|-L lock] [-m n] [-d n] [-o n] [-p n] [-f n] [-c n] prog"
-+#define USAGE_MAIN " [-vP012] [-u user[:group]] [-U user[:group]] [-b argv0] [-e dir] [-/ root] [-C pwd] [-n nice] [-l|-L lock] [-m n] [-d n] [-o n] [-p n] [-f n] [-c n] prog"
- #define FATAL "chpst: fatal: "
- #define WARNING "chpst: warning: "
- 
-@@ -60,6 +60,7 @@ long limitt =-2;
- long nicelvl =0;
- const char *lock =0;
- const char *root =0;
-+const char *pwd =0;
- unsigned int lockdelay;
- 
- void suidgid(char *user, unsigned int ext) {
-@@ -286,7 +287,7 @@ int main(int argc, const char **argv) {
-   if (str_equal(progname, "setlock")) setlock(argc, argv);
-   if (str_equal(progname, "softlimit")) softlimit(argc, argv);
- 
--  while ((opt =getopt(argc, argv, "u:U:b:e:m:d:o:p:f:c:r:t:/:n:l:L:vP012V"))
-+  while ((opt =getopt(argc, argv, "u:U:b:e:m:d:o:p:f:c:r:t:/:C:n:l:L:vP012V"))
-          != opteof)
-     switch(opt) {
-     case 'u': set_user =(char*)optarg; break;
-@@ -305,6 +306,7 @@ int main(int argc, const char **argv) {
-     case 'r': if (optarg[scan_ulong(optarg, &ul)]) usage(); limitr =ul; break;
-     case 't': if (optarg[scan_ulong(optarg, &ul)]) usage(); limitt =ul; break;
-     case '/': root =optarg; break;
-+    case 'C': pwd =optarg; break;
-     case 'n':
-       switch (*optarg) {
-         case '-':
-@@ -337,6 +339,9 @@ int main(int argc, const char **argv) {
-     if (chdir(root) == -1) fatal2("unable to change directory", root);
-     if (chroot(".") == -1) fatal("unable to change root directory");
-   }
-+  if (pwd) {
-+    if (chdir(pwd) == -1) fatal2("unable to change directory", pwd);
-+  }
-   if (nicelvl) {
-     errno =0;
-     if (nice(nicelvl) == -1) if (errno) fatal("unable to set nice level");
diff --git a/srcpkgs/runit/patches/chpst.patch b/srcpkgs/runit/patches/chpst.patch
deleted file mode 100644
index 988c731c4be999..00000000000000
--- a/srcpkgs/runit/patches/chpst.patch
+++ /dev/null
@@ -1,14 +0,0 @@
-Fix UB which breaks -n with negative values.
-Ensure optarg is incremented strictly before it is read from.
-
---- runit-2.1.2/src/chpst.c.orig
-+++ runit-2.1.2/src/chpst.c
-@@ -308,7 +308,7 @@
-     case 'n':
-       switch (*optarg) {
-         case '-':
--          if (optarg[scan_ulong(++optarg, &ul)]) usage(); nicelvl =ul;
-+          ++optarg; if (optarg[scan_ulong(optarg, &ul)]) usage(); nicelvl =ul;
-           nicelvl *=-1;
-           break;
-         case '+': ++optarg;
diff --git a/srcpkgs/runit/patches/clearmem.patch b/srcpkgs/runit/patches/clearmem.patch
index 1a061eee0fa701..c244c81bfb34f7 100644
--- a/srcpkgs/runit/patches/clearmem.patch
+++ b/srcpkgs/runit/patches/clearmem.patch
@@ -1,7 +1,14 @@
-diff -Naur runit-2.1.2/src/svlogd.c runit-2.1.2/src/svlogd.c
---- runit-2.1.2/src/svlogd.c	2014-08-10 11:22:34.000000000 -0700
-+++ runit-2.1.2/src/svlogd.c	2018-03-03 03:28:08.243085845 -0800
-@@ -705,6 +705,7 @@
+--- a/src/svlogd.c
++++ b/src/svlogd.c
+@@ -8,6 +8,7 @@
+ #include <dirent.h>
+ #include <unistd.h>
+ #include <stdio.h>
++#include <string.h>
+ #include "pmatch.h"
+ #include "fmt_ptime.h"
+ #include "alloc.h"
+@@ -706,6 +707,7 @@ int main(int argc, char **argv) {
    coe(fdwdir);
    dir =(struct logdir*)alloc(dirn *sizeof(struct logdir));
    if (! dir) die_nomem();
diff --git a/srcpkgs/runit/patches/cross.patch b/srcpkgs/runit/patches/cross.patch
index cb5c279c7913b9..e3a614c7aa27a9 100644
--- a/srcpkgs/runit/patches/cross.patch
+++ b/srcpkgs/runit/patches/cross.patch
@@ -1,24 +1,8 @@
 chskshsgr must be built for the host.
 
---- runit-2.1.2/src/Makefile.orig	2014-02-11 02:03:33.904789349 +0100
-+++ runit-2.1.2/src/Makefile	2014-02-11 02:19:28.968055164 +0100
-@@ -170,11 +170,11 @@ byte_diff.o: byte.h byte_diff.c compile
- byte_rchr.o: byte.h byte_rchr.c compile
- 	./compile byte_rchr.c
- 
--chkshsgr: chkshsgr.o load
--	./load chkshsgr 
-+chkshsgr: chkshsgr.o loadhost
-+	./loadhost chkshsgr 
- 
--chkshsgr.o: chkshsgr.c compile
--	./compile chkshsgr.c
-+chkshsgr.o: chkshsgr.c compilehost
-+	./compilehost chkshsgr.c
- 
- choose: choose.sh warn-auto.sh
- 	rm -f choose
-@@ -185,6 +185,11 @@ choose: choose.sh warn-auto.sh
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -179,6 +179,11 @@ choose: choose.sh warn-auto.sh
  coe.o: coe.c coe.h compile
  	./compile coe.c
  
@@ -30,7 +14,34 @@ chskshsgr must be built for the host.
  compile: conf-cc print-cc.sh systype warn-auto.sh
  	rm -f compile
  	sh print-cc.sh > compile
-@@ -246,6 +251,15 @@ iopause.h: choose compile iopause.h1 iop
+@@ -214,27 +219,36 @@ fmt_uint0.o: compile fmt.h fmt_uint0.c
+ fmt_ulong.o: compile fmt.h fmt_ulong.c
+ 	./compile fmt_ulong.c
+ 
+-hasflock.h: choose compile hasflock.h1 hasflock.h2 load tryflock.c
++hasflock.h: choose compilehost hasflock.h1 hasflock.h2 loadhost tryflock.c
+ 	./choose cl tryflock hasflock.h1 hasflock.h2 > hasflock.h
+ 
+-hasmkffo.h: choose compile hasmkffo.h1 hasmkffo.h2 load trymkffo.c
++hasmkffo.h: choose compilehost hasmkffo.h1 hasmkffo.h2 loadhost trymkffo.c
+ 	./choose cl trymkffo hasmkffo.h1 hasmkffo.h2 > hasmkffo.h
+ 
+-hassgact.h: choose compile hassgact.h1 hassgact.h2 load trysgact.c
++hassgact.h: choose compilehost hassgact.h1 hassgact.h2 loadhost trysgact.c
+ 	./choose cl trysgact hassgact.h1 hassgact.h2 > hassgact.h
+ 
+-hassgprm.h: choose compile hassgprm.h1 hassgprm.h2 load trysgprm.c
++hassgprm.h: choose compilehost hassgprm.h1 hassgprm.h2 loadhost trysgprm.c
+ 	./choose cl trysgprm hassgprm.h1 hassgprm.h2 > hassgprm.h
+ 
+-haswaitp.h: choose compile haswaitp.h1 haswaitp.h2 load trywaitp.c
++haswaitp.h: choose compilehost haswaitp.h1 haswaitp.h2 loadhost trywaitp.c
+ 	./choose cl trywaitp haswaitp.h1 haswaitp.h2 > haswaitp.h
+ 
+-iopause.h: choose compile iopause.h1 iopause.h2 load trypoll.c
++iopause.h: choose compilehost iopause.h1 iopause.h2 loadhost trypoll.c
+ 	./choose clr trypoll iopause.h1 iopause.h2 > iopause.h
+ 
  iopause.o: compile iopause.c iopause.h select.h tai.h taia.h uint64.h
  	./compile iopause.c
  
@@ -46,3 +57,22 @@ chskshsgr must be built for the host.
  load: conf-ld print-ld.sh systype warn-auto.sh
  	rm -f load
  	sh print-ld.sh > load
+@@ -421,7 +435,7 @@ taia_pack.o taia_sub.o taia_uint.o
+ 	tai_unpack.o taia_add.o taia_approx.o taia_frac.o taia_less.o \
+ 	taia_now.o taia_pack.o taia_sub.o taia_uint.o
+ 
+-uint64.h: choose compile load tryulong64.c uint64.h1 uint64.h2
++uint64.h: choose compile compilehost loadhost tryulong64.c uint64.h1 uint64.h2
+ 	./choose clr tryulong64 uint64.h1 uint64.h2 > uint64.h
+ 
+ unix.a: alloc.o alloc_re.o buffer.o buffer_0.o buffer_1.o buffer_2.o \
+--- a/src/choose.sh
++++ b/src/choose.sh
+@@ -2,6 +2,7 @@
+ result="$4"
+ 
+ case "$1" in
++  *cl*) ./compilehost $2.c >/dev/null 2>&1 || result="$3" ;;
+   *c*) ./compile $2.c >/dev/null 2>&1 || result="$3" ;;
+ esac
+ 
diff --git a/srcpkgs/runit/patches/default_svdir.patch b/srcpkgs/runit/patches/default_svdir.patch
index 0273d1a9f0b51f..a87185490c1ea3 100644
--- a/srcpkgs/runit/patches/default_svdir.patch
+++ b/srcpkgs/runit/patches/default_svdir.patch
@@ -1,8 +1,8 @@
 Fix default service path in man pages
 
---- runit-2.1.2/man/sv.8
-+++ runit-2.1.2/man/sv.8
-@@ -30,7 +30,7 @@
+--- a/man/sv.8
++++ b/man/sv.8
+@@ -30,7 +30,7 @@ If
  .I service
  doesn't start with a dot or slash and doesn't end with a slash, it is
  searched in the default services directory
@@ -11,7 +11,7 @@ Fix default service path in man pages
  otherwise relative to the current directory.
  .P
  .I command
-@@ -232,7 +232,7 @@
+@@ -232,7 +232,7 @@ This option implies
  .TP
  .B SVDIR
  The environment variable $SVDIR overrides the default services directory
@@ -20,9 +20,9 @@ Fix default service path in man pages
  .TP
  .B SVWAIT
  The environment variable $SVWAIT overrides the default 7 seconds to wait
---- runit-2.1.2/man/runsvchdir.8
-+++ runit-2.1.2/man/runsvchdir.8
-@@ -27,13 +27,13 @@
+--- a/man/runsvchdir.8
++++ b/man/runsvchdir.8
+@@ -27,13 +27,13 @@ with a symlink pointing to
  .IR dir .
  .P
  Normally 
@@ -38,9 +38,9 @@ Fix default service path in man pages
  .SH EXIT CODES
  .B runsvchdir
  prints an error message and exits 111 on error.
---- runit-2.1.2/man/utmpset.8
-+++ runit-2.1.2/man/utmpset.8
-@@ -34,7 +34,7 @@
+--- a/man/utmpset.8
++++ b/man/utmpset.8
+@@ -34,7 +34,7 @@ to the
  .I finish
  scripts, e.g.:
  .P
@@ -49,9 +49,9 @@ Fix default service path in man pages
   #!/bin/sh
   exec utmpset \-w tty5
   $
---- runit-2.1.2/man/runsv.8
-+++ runit-2.1.2/man/runsv.8
-@@ -157,9 +157,9 @@
+--- a/man/runsv.8
++++ b/man/runsv.8
+@@ -155,9 +155,9 @@ This command is ignored if it is given t
  .IR service /log/supervise/control.
  .P
  Example: to send a TERM signal to the socklog-unix service, either do
diff --git a/srcpkgs/runit/patches/sigcont.patch b/srcpkgs/runit/patches/sigcont.patch
index 60ea85d3938bb7..7763d48d1e8995 100644
--- a/srcpkgs/runit/patches/sigcont.patch
+++ b/srcpkgs/runit/patches/sigcont.patch
@@ -3,9 +3,9 @@ runit(8): don't leak SIGCONT SIG_IGN into all child processes
 https://inbox.vuxu.org/supervision/87tug3vzex.fsf@vuxu.org/
 https://github.com/ksh93/ksh/issues/301
 
---- runit-2.1.2/src/runit.c.orig
-+++ runit-2.1.2/src/runit.c
-@@ -125,7 +125,7 @@
+--- a/src/runit.c
++++ b/src/runit.c
+@@ -130,7 +130,7 @@ int main (int argc, const char * const *
        sig_unblock(sig_child);
        sig_uncatch(sig_child);
        sig_unblock(sig_cont);
diff --git a/srcpkgs/runit/patches/svlogd.patch b/srcpkgs/runit/patches/svlogd.patch
deleted file mode 100644
index 2166821100264b..00000000000000
--- a/srcpkgs/runit/patches/svlogd.patch
+++ /dev/null
@@ -1,13 +0,0 @@
-Initialize all fields of sockaddr_in.
-http://skarnet.org/cgi-bin/archive.cgi?2:mss:1163:201602:gpiglpbjdemlioaeabbn
-
---- runit-2.1.2/src/svlogd.c 2014-08-10 15:22:34.000000000 -0300
-+++ runit-2.1.2/src/svlogd.c 2016-02-04 22:53:52.910965361 -0300
-@@ -430,6 +430,7 @@
-   ld->name =(char*)fn;
-   ld->ppid =0;
-   ld->match ='+';
-+  ld->udpaddr.sin_family =AF_INET;
-   ld->udpaddr.sin_port =0;
-   ld->udponly =0;
-   while (! stralloc_copys(&ld->prefix, "")) pause_nomem();
diff --git a/srcpkgs/runit/patches/utmpset-time_t.patch b/srcpkgs/runit/patches/utmpset-time_t.patch
deleted file mode 100644
index fabf8539009988..00000000000000
--- a/srcpkgs/runit/patches/utmpset-time_t.patch
+++ /dev/null
@@ -1,56 +0,0 @@
-From 20a0afcd367666efc17c59cf121a0d991ff1bd09 Mon Sep 17 00:00:00 2001
-From: Gerrit Pape <pape@smarden.org>
-Date: Thu, 31 Jul 2014 12:25:49 +0000
-Subject: [PATCH] utmpset.c: mixes "int32_t *" and "time_t *"
-
-Don't pass int32_t to time(), thx Lorenzo Beretta,
-https://bugs.debian.org/754849
----
- runit-2.1.2/src/utmpset.c | 8 ++++++--
- 1 file changed, 6 insertions(+), 2 deletions(-)
-
-diff --git a/runit-2.1.2/src/utmpset.c b/runit-2.1.2/src/utmpset.c
-index eea41a5..2e8a525 100644
---- runit-2.1.2/src/utmpset.c
-+++ runit-2.1.2/src/utmpset.c
-@@ -24,6 +24,7 @@ void usage(void) { strerr_die4x(1, "usage: ", progname, USAGE, "\n"); }
- int utmp_logout(const char *line) {
-   int fd;
-   uw_tmp ut;
-+  time_t t;
-   int ok =-1;
-
-   if ((fd =open(UW_TMP_UFILE, O_RDWR, 0)) < 0)
-@@ -35,7 +36,8 @@ int utmp_logout(const char *line) {
-     if (!ut.ut_name[0] || (str_diff(ut.ut_line, line) != 0)) continue;
-     memset(ut.ut_name, 0, sizeof ut.ut_name);
-     memset(ut.ut_host, 0, sizeof ut.ut_host);
--    if (time(&ut.ut_time) == -1) break;
-+    if (time(&t) == -1) break;
-+    ut.ut_time = t;
- #ifdef DEAD_PROCESS
-     ut.ut_type =DEAD_PROCESS;
- #endif
-@@ -52,6 +54,7 @@ int wtmp_logout(const char *line) {
-   int len;
-   struct stat st;
-   uw_tmp ut;
-+  time_t t;
-
-   if ((fd = open_append(UW_TMP_WFILE)) == -1)
-     strerr_die4sys(111, FATAL, "unable to open ", UW_TMP_WFILE, ": ");
-@@ -65,10 +68,11 @@ int wtmp_logout(const char *line) {
-   memset(&ut, 0, sizeof(uw_tmp));
-   if ((len =str_len(line)) > sizeof ut.ut_line) len =sizeof ut.ut_line -2;
-   byte_copy(ut.ut_line, len, line);
--  if (time(&ut.ut_time) == -1) {
-+  if (time(&t) == -1) {
-     close(fd);
-     return(-1);
-   }
-+  ut.ut_time = t;
- #ifdef DEAD_PROCESS
-   ut.ut_type =DEAD_PROCESS;
- #endif
---
-2.0.1
diff --git a/srcpkgs/runit/template b/srcpkgs/runit/template
index eb436f5bae0b95..69e4da585dc892 100644
--- a/srcpkgs/runit/template
+++ b/srcpkgs/runit/template
@@ -1,16 +1,14 @@
 # Template file for 'runit'
 pkgname=runit
-version=2.1.2
-revision=15
-build_wrksrc="${pkgname}-${version}/src"
+version=2.2.0
+revision=1
 build_style="gnu-makefile"
 short_desc="UNIX init scheme with service supervision"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://smarden.org/runit/"
 distfiles="http://smarden.org/runit/runit-${version}.tar.gz"
-checksum=6fd0160cb0cf1207de4e66754b6d39750cff14bb0aa66ab49490992c0c47ba18
-patch_args=-Np0
+checksum=95ef4d2868b978c7179fe47901e5c578e11cf273d292bd6208bd3a7ccb029290
 # FIXME: this is caused by some bonk tests that should be fixed in void-linux/runit at some point
 make_check=no
 
@@ -21,7 +19,12 @@ if [ "$build_option_static" ]; then
 	LDFLAGS="-static"
 fi
 
-pre_build() {
+post_extract() {
+	mv runit-${version}/* .
+}
+
+do_build() {
+	cd src
 	vsed -e 's,sbin/runit,usr/bin/runit,g' -i runit.h
 
 	echo "$CC -D_GNU_SOURCE $CFLAGS" >conf-cc
@@ -29,11 +32,12 @@ pre_build() {
 	# set default service path to /var/service
 	vsed -e 's:^char \*varservice ="/service/";$:char \*varservice ="/var/service/";:' -i sv.c
 	# change type short to gid_t for getgroups(2) and setgroups(2)
-	vsed -e 's:short x\[4\];$:gid_t x[4];:' -i chkshsgr.c
+	# vsed -e 's:short x\[4\];$:gid_t x[4];:' -i chkshsgr.c
+	make ${makejobs}
 }
 
 do_install() {
-	vlicense ../package/COPYING
+	vlicense package/COPYING
 
 	# default services
 	vmkdir var
@@ -42,10 +46,9 @@ do_install() {
 	local f
 	for f in chpst runit runit-init runsv runsvchdir runsvdir \
 		sv svlogd utmpset; do
-		vbin $f
+		vbin src/$f
 	done
 
-	cd ..
 	for f in man/*; do
 		vman $f
 	done

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] [NOT TESTED] runit: update to 2.2.0.
  2024-09-29 14:24 [PR PATCH] [NOT TESTED] runit: update to 2.2.0 sgn
@ 2024-09-30  3:36 ` sgn
  2024-10-03  8:05 ` [PR REVIEW] " classabbyamp
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2024-09-30  3:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages runit-2.2.0
https://github.com/void-linux/void-packages/pull/52408

[NOT TESTED] runit: update to 2.2.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-runit-2.2.0-52408.patch --]
[-- Type: text/x-diff, Size: 16240 bytes --]

From 86f7a132a44d386181083fe64715c0f43692abda Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sun, 29 Sep 2024 21:23:35 +0700
Subject: [PATCH] runit: update to 2.2.0.

---
 srcpkgs/runit/patches/chpst-pwd.patch      | 77 ---------------------
 srcpkgs/runit/patches/chpst.patch          | 14 ----
 srcpkgs/runit/patches/clearmem.patch       | 15 +++--
 srcpkgs/runit/patches/cross.patch          | 78 ++++++++++++++++------
 srcpkgs/runit/patches/default_svdir.patch  | 26 ++++----
 srcpkgs/runit/patches/sigcont.patch        |  6 +-
 srcpkgs/runit/patches/svlogd.patch         | 13 ----
 srcpkgs/runit/patches/utmpset-time_t.patch | 56 ----------------
 srcpkgs/runit/template                     | 27 +++++---
 9 files changed, 100 insertions(+), 212 deletions(-)
 delete mode 100644 srcpkgs/runit/patches/chpst-pwd.patch
 delete mode 100644 srcpkgs/runit/patches/chpst.patch
 delete mode 100644 srcpkgs/runit/patches/svlogd.patch
 delete mode 100644 srcpkgs/runit/patches/utmpset-time_t.patch

diff --git a/srcpkgs/runit/patches/chpst-pwd.patch b/srcpkgs/runit/patches/chpst-pwd.patch
deleted file mode 100644
index c8ee7ed893cac4..00000000000000
--- a/srcpkgs/runit/patches/chpst-pwd.patch
+++ /dev/null
@@ -1,77 +0,0 @@
-From 2b8000f1ebd07fd68ee0e3c32737d97bcd1687fb Mon Sep 17 00:00:00 2001
-From: "Andrew J. Hesford" <ajh@sideband.org>
-Date: Mon, 14 Feb 2022 14:25:22 -0500
-Subject: [PATCH] chpst: add -C to change working directory
-
----
- man/chpst.8 | 8 ++++++++
- src/chpst.c | 9 +++++++--
- 2 files changed, 15 insertions(+), 2 deletions(-)
-
-diff --git runit-2.1.2/man/chpst.8 runit-2.1.2/man/chpst.8
-index 43c0b8d..e0829b6 100644
---- runit-2.1.2/man/chpst.8
-+++ runit-2.1.2/man/chpst.8
-@@ -146,6 +146,14 @@ Change the root directory to
- before starting
- .IR prog .
- .TP
-+.B \-C \fIpwd
-+chdir.
-+Change the working directory to
-+.I pwd
-+before starting
-+.IR prog .
-+When combined with \-/, the working directory is changed after the chroot.
-+.TP
- .B \-n \fIinc
- nice.
- Add
-diff --git runit-2.1.2/src/chpst.c runit-2.1.2/src/chpst.c
-index 1cca5f4..d597b68 100644
---- runit-2.1.2/src/chpst.c
-+++ runit-2.1.2/src/chpst.c
-@@ -20,7 +20,7 @@
- #include "openreadclose.h"
- #include "direntry.h"
- 
--#define USAGE_MAIN " [-vP012] [-u user[:group]] [-U user[:group]] [-b argv0] [-e dir] [-/ root] [-n nice] [-l|-L lock] [-m n] [-d n] [-o n] [-p n] [-f n] [-c n] prog"
-+#define USAGE_MAIN " [-vP012] [-u user[:group]] [-U user[:group]] [-b argv0] [-e dir] [-/ root] [-C pwd] [-n nice] [-l|-L lock] [-m n] [-d n] [-o n] [-p n] [-f n] [-c n] prog"
- #define FATAL "chpst: fatal: "
- #define WARNING "chpst: warning: "
- 
-@@ -60,6 +60,7 @@ long limitt =-2;
- long nicelvl =0;
- const char *lock =0;
- const char *root =0;
-+const char *pwd =0;
- unsigned int lockdelay;
- 
- void suidgid(char *user, unsigned int ext) {
-@@ -286,7 +287,7 @@ int main(int argc, const char **argv) {
-   if (str_equal(progname, "setlock")) setlock(argc, argv);
-   if (str_equal(progname, "softlimit")) softlimit(argc, argv);
- 
--  while ((opt =getopt(argc, argv, "u:U:b:e:m:d:o:p:f:c:r:t:/:n:l:L:vP012V"))
-+  while ((opt =getopt(argc, argv, "u:U:b:e:m:d:o:p:f:c:r:t:/:C:n:l:L:vP012V"))
-          != opteof)
-     switch(opt) {
-     case 'u': set_user =(char*)optarg; break;
-@@ -305,6 +306,7 @@ int main(int argc, const char **argv) {
-     case 'r': if (optarg[scan_ulong(optarg, &ul)]) usage(); limitr =ul; break;
-     case 't': if (optarg[scan_ulong(optarg, &ul)]) usage(); limitt =ul; break;
-     case '/': root =optarg; break;
-+    case 'C': pwd =optarg; break;
-     case 'n':
-       switch (*optarg) {
-         case '-':
-@@ -337,6 +339,9 @@ int main(int argc, const char **argv) {
-     if (chdir(root) == -1) fatal2("unable to change directory", root);
-     if (chroot(".") == -1) fatal("unable to change root directory");
-   }
-+  if (pwd) {
-+    if (chdir(pwd) == -1) fatal2("unable to change directory", pwd);
-+  }
-   if (nicelvl) {
-     errno =0;
-     if (nice(nicelvl) == -1) if (errno) fatal("unable to set nice level");
diff --git a/srcpkgs/runit/patches/chpst.patch b/srcpkgs/runit/patches/chpst.patch
deleted file mode 100644
index 988c731c4be999..00000000000000
--- a/srcpkgs/runit/patches/chpst.patch
+++ /dev/null
@@ -1,14 +0,0 @@
-Fix UB which breaks -n with negative values.
-Ensure optarg is incremented strictly before it is read from.
-
---- runit-2.1.2/src/chpst.c.orig
-+++ runit-2.1.2/src/chpst.c
-@@ -308,7 +308,7 @@
-     case 'n':
-       switch (*optarg) {
-         case '-':
--          if (optarg[scan_ulong(++optarg, &ul)]) usage(); nicelvl =ul;
-+          ++optarg; if (optarg[scan_ulong(optarg, &ul)]) usage(); nicelvl =ul;
-           nicelvl *=-1;
-           break;
-         case '+': ++optarg;
diff --git a/srcpkgs/runit/patches/clearmem.patch b/srcpkgs/runit/patches/clearmem.patch
index 1a061eee0fa701..c244c81bfb34f7 100644
--- a/srcpkgs/runit/patches/clearmem.patch
+++ b/srcpkgs/runit/patches/clearmem.patch
@@ -1,7 +1,14 @@
-diff -Naur runit-2.1.2/src/svlogd.c runit-2.1.2/src/svlogd.c
---- runit-2.1.2/src/svlogd.c	2014-08-10 11:22:34.000000000 -0700
-+++ runit-2.1.2/src/svlogd.c	2018-03-03 03:28:08.243085845 -0800
-@@ -705,6 +705,7 @@
+--- a/src/svlogd.c
++++ b/src/svlogd.c
+@@ -8,6 +8,7 @@
+ #include <dirent.h>
+ #include <unistd.h>
+ #include <stdio.h>
++#include <string.h>
+ #include "pmatch.h"
+ #include "fmt_ptime.h"
+ #include "alloc.h"
+@@ -706,6 +707,7 @@ int main(int argc, char **argv) {
    coe(fdwdir);
    dir =(struct logdir*)alloc(dirn *sizeof(struct logdir));
    if (! dir) die_nomem();
diff --git a/srcpkgs/runit/patches/cross.patch b/srcpkgs/runit/patches/cross.patch
index cb5c279c7913b9..b7ac53b8e5f0e1 100644
--- a/srcpkgs/runit/patches/cross.patch
+++ b/srcpkgs/runit/patches/cross.patch
@@ -1,36 +1,27 @@
 chskshsgr must be built for the host.
 
---- runit-2.1.2/src/Makefile.orig	2014-02-11 02:03:33.904789349 +0100
-+++ runit-2.1.2/src/Makefile	2014-02-11 02:19:28.968055164 +0100
-@@ -170,11 +170,11 @@ byte_diff.o: byte.h byte_diff.c compile
- byte_rchr.o: byte.h byte_rchr.c compile
- 	./compile byte_rchr.c
- 
--chkshsgr: chkshsgr.o load
--	./load chkshsgr 
-+chkshsgr: chkshsgr.o loadhost
-+	./loadhost chkshsgr 
- 
--chkshsgr.o: chkshsgr.c compile
--	./compile chkshsgr.c
-+chkshsgr.o: chkshsgr.c compilehost
-+	./compilehost chkshsgr.c
- 
- choose: choose.sh warn-auto.sh
- 	rm -f choose
-@@ -185,6 +185,11 @@ choose: choose.sh warn-auto.sh
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -179,6 +179,11 @@ choose: choose.sh warn-auto.sh
  coe.o: coe.c coe.h compile
  	./compile coe.c
  
 +compilehost:
 +	cat warn-auto.sh > compilehost
-+	@echo 'exec cc -c $${1+"$$@"}' >> compilehost
++	@echo 'exec cc -D_GNU_SOURCE -c $${1+"$$@"}' >> compilehost
 +	chmod 555 compilehost
 +
  compile: conf-cc print-cc.sh systype warn-auto.sh
  	rm -f compile
  	sh print-cc.sh > compile
-@@ -246,6 +251,15 @@ iopause.h: choose compile iopause.h1 iop
+@@ -229,12 +234,21 @@ hassgprm.h: choose compile hassgprm.h1 h
+ haswaitp.h: choose compile haswaitp.h1 haswaitp.h2 load trywaitp.c
+ 	./choose cl trywaitp haswaitp.h1 haswaitp.h2 > haswaitp.h
+ 
+-iopause.h: choose compile iopause.h1 iopause.h2 load trypoll.c
++iopause.h: choose compilehost iopause.h1 iopause.h2 loadhost trypoll.c
+ 	./choose clr trypoll iopause.h1 iopause.h2 > iopause.h
+ 
  iopause.o: compile iopause.c iopause.h select.h tai.h taia.h uint64.h
  	./compile iopause.c
  
@@ -46,3 +37,48 @@ chskshsgr must be built for the host.
  load: conf-ld print-ld.sh systype warn-auto.sh
  	rm -f load
  	sh print-ld.sh > load
+@@ -422,7 +436,7 @@ taia_pack.o taia_sub.o taia_uint.o
+ 	taia_now.o taia_pack.o taia_sub.o taia_uint.o
+ 
+ uint64.h: choose compile load tryulong64.c uint64.h1 uint64.h2
+-	./choose clr tryulong64 uint64.h1 uint64.h2 > uint64.h
++	./choose cl tryulong64 uint64.h1 uint64.h2 > uint64.h
+ 
+ unix.a: alloc.o alloc_re.o buffer.o buffer_0.o buffer_1.o buffer_2.o \
+ buffer_get.o buffer_put.o buffer_read.o buffer_write.o coe.o env.o \
+--- a/src/choose.sh
++++ b/src/choose.sh
+@@ -2,10 +2,12 @@
+ result="$4"
+ 
+ case "$1" in
++  *c*r*) ./compilehost $2.c >/dev/null 2>&1 || result="$3" ;;
+   *c*) ./compile $2.c >/dev/null 2>&1 || result="$3" ;;
+ esac
+ 
+ case "$1" in
++  *l*r*) ./loadhost $2 >/dev/null 2>&1 || result="$3" ;;
+   *l*) ./load $2 >/dev/null 2>&1 || result="$3" ;;
+ esac
+ 
+--- a/src/tryulong64.c
++++ b/src/tryulong64.c
+@@ -1,15 +1,10 @@
+ /* Public domain. */
+ 
+ #include <unistd.h>
++#include <stdint.h>
+ 
+ int main()
+ {
+-  unsigned long u;
+-  u = 1;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  if (!u) _exit(1);
+-  _exit(0);
++  char u[(sizeof(unsigned long) == sizeof(uint64_t)) * 2 - 1] = { 0 };
++  return u[0];
+ }
diff --git a/srcpkgs/runit/patches/default_svdir.patch b/srcpkgs/runit/patches/default_svdir.patch
index 0273d1a9f0b51f..a87185490c1ea3 100644
--- a/srcpkgs/runit/patches/default_svdir.patch
+++ b/srcpkgs/runit/patches/default_svdir.patch
@@ -1,8 +1,8 @@
 Fix default service path in man pages
 
---- runit-2.1.2/man/sv.8
-+++ runit-2.1.2/man/sv.8
-@@ -30,7 +30,7 @@
+--- a/man/sv.8
++++ b/man/sv.8
+@@ -30,7 +30,7 @@ If
  .I service
  doesn't start with a dot or slash and doesn't end with a slash, it is
  searched in the default services directory
@@ -11,7 +11,7 @@ Fix default service path in man pages
  otherwise relative to the current directory.
  .P
  .I command
-@@ -232,7 +232,7 @@
+@@ -232,7 +232,7 @@ This option implies
  .TP
  .B SVDIR
  The environment variable $SVDIR overrides the default services directory
@@ -20,9 +20,9 @@ Fix default service path in man pages
  .TP
  .B SVWAIT
  The environment variable $SVWAIT overrides the default 7 seconds to wait
---- runit-2.1.2/man/runsvchdir.8
-+++ runit-2.1.2/man/runsvchdir.8
-@@ -27,13 +27,13 @@
+--- a/man/runsvchdir.8
++++ b/man/runsvchdir.8
+@@ -27,13 +27,13 @@ with a symlink pointing to
  .IR dir .
  .P
  Normally 
@@ -38,9 +38,9 @@ Fix default service path in man pages
  .SH EXIT CODES
  .B runsvchdir
  prints an error message and exits 111 on error.
---- runit-2.1.2/man/utmpset.8
-+++ runit-2.1.2/man/utmpset.8
-@@ -34,7 +34,7 @@
+--- a/man/utmpset.8
++++ b/man/utmpset.8
+@@ -34,7 +34,7 @@ to the
  .I finish
  scripts, e.g.:
  .P
@@ -49,9 +49,9 @@ Fix default service path in man pages
   #!/bin/sh
   exec utmpset \-w tty5
   $
---- runit-2.1.2/man/runsv.8
-+++ runit-2.1.2/man/runsv.8
-@@ -157,9 +157,9 @@
+--- a/man/runsv.8
++++ b/man/runsv.8
+@@ -155,9 +155,9 @@ This command is ignored if it is given t
  .IR service /log/supervise/control.
  .P
  Example: to send a TERM signal to the socklog-unix service, either do
diff --git a/srcpkgs/runit/patches/sigcont.patch b/srcpkgs/runit/patches/sigcont.patch
index 60ea85d3938bb7..7763d48d1e8995 100644
--- a/srcpkgs/runit/patches/sigcont.patch
+++ b/srcpkgs/runit/patches/sigcont.patch
@@ -3,9 +3,9 @@ runit(8): don't leak SIGCONT SIG_IGN into all child processes
 https://inbox.vuxu.org/supervision/87tug3vzex.fsf@vuxu.org/
 https://github.com/ksh93/ksh/issues/301
 
---- runit-2.1.2/src/runit.c.orig
-+++ runit-2.1.2/src/runit.c
-@@ -125,7 +125,7 @@
+--- a/src/runit.c
++++ b/src/runit.c
+@@ -130,7 +130,7 @@ int main (int argc, const char * const *
        sig_unblock(sig_child);
        sig_uncatch(sig_child);
        sig_unblock(sig_cont);
diff --git a/srcpkgs/runit/patches/svlogd.patch b/srcpkgs/runit/patches/svlogd.patch
deleted file mode 100644
index 2166821100264b..00000000000000
--- a/srcpkgs/runit/patches/svlogd.patch
+++ /dev/null
@@ -1,13 +0,0 @@
-Initialize all fields of sockaddr_in.
-http://skarnet.org/cgi-bin/archive.cgi?2:mss:1163:201602:gpiglpbjdemlioaeabbn
-
---- runit-2.1.2/src/svlogd.c 2014-08-10 15:22:34.000000000 -0300
-+++ runit-2.1.2/src/svlogd.c 2016-02-04 22:53:52.910965361 -0300
-@@ -430,6 +430,7 @@
-   ld->name =(char*)fn;
-   ld->ppid =0;
-   ld->match ='+';
-+  ld->udpaddr.sin_family =AF_INET;
-   ld->udpaddr.sin_port =0;
-   ld->udponly =0;
-   while (! stralloc_copys(&ld->prefix, "")) pause_nomem();
diff --git a/srcpkgs/runit/patches/utmpset-time_t.patch b/srcpkgs/runit/patches/utmpset-time_t.patch
deleted file mode 100644
index fabf8539009988..00000000000000
--- a/srcpkgs/runit/patches/utmpset-time_t.patch
+++ /dev/null
@@ -1,56 +0,0 @@
-From 20a0afcd367666efc17c59cf121a0d991ff1bd09 Mon Sep 17 00:00:00 2001
-From: Gerrit Pape <pape@smarden.org>
-Date: Thu, 31 Jul 2014 12:25:49 +0000
-Subject: [PATCH] utmpset.c: mixes "int32_t *" and "time_t *"
-
-Don't pass int32_t to time(), thx Lorenzo Beretta,
-https://bugs.debian.org/754849
----
- runit-2.1.2/src/utmpset.c | 8 ++++++--
- 1 file changed, 6 insertions(+), 2 deletions(-)
-
-diff --git a/runit-2.1.2/src/utmpset.c b/runit-2.1.2/src/utmpset.c
-index eea41a5..2e8a525 100644
---- runit-2.1.2/src/utmpset.c
-+++ runit-2.1.2/src/utmpset.c
-@@ -24,6 +24,7 @@ void usage(void) { strerr_die4x(1, "usage: ", progname, USAGE, "\n"); }
- int utmp_logout(const char *line) {
-   int fd;
-   uw_tmp ut;
-+  time_t t;
-   int ok =-1;
-
-   if ((fd =open(UW_TMP_UFILE, O_RDWR, 0)) < 0)
-@@ -35,7 +36,8 @@ int utmp_logout(const char *line) {
-     if (!ut.ut_name[0] || (str_diff(ut.ut_line, line) != 0)) continue;
-     memset(ut.ut_name, 0, sizeof ut.ut_name);
-     memset(ut.ut_host, 0, sizeof ut.ut_host);
--    if (time(&ut.ut_time) == -1) break;
-+    if (time(&t) == -1) break;
-+    ut.ut_time = t;
- #ifdef DEAD_PROCESS
-     ut.ut_type =DEAD_PROCESS;
- #endif
-@@ -52,6 +54,7 @@ int wtmp_logout(const char *line) {
-   int len;
-   struct stat st;
-   uw_tmp ut;
-+  time_t t;
-
-   if ((fd = open_append(UW_TMP_WFILE)) == -1)
-     strerr_die4sys(111, FATAL, "unable to open ", UW_TMP_WFILE, ": ");
-@@ -65,10 +68,11 @@ int wtmp_logout(const char *line) {
-   memset(&ut, 0, sizeof(uw_tmp));
-   if ((len =str_len(line)) > sizeof ut.ut_line) len =sizeof ut.ut_line -2;
-   byte_copy(ut.ut_line, len, line);
--  if (time(&ut.ut_time) == -1) {
-+  if (time(&t) == -1) {
-     close(fd);
-     return(-1);
-   }
-+  ut.ut_time = t;
- #ifdef DEAD_PROCESS
-   ut.ut_type =DEAD_PROCESS;
- #endif
---
-2.0.1
diff --git a/srcpkgs/runit/template b/srcpkgs/runit/template
index eb436f5bae0b95..fd01b4ec469ffa 100644
--- a/srcpkgs/runit/template
+++ b/srcpkgs/runit/template
@@ -1,16 +1,14 @@
 # Template file for 'runit'
 pkgname=runit
-version=2.1.2
-revision=15
-build_wrksrc="${pkgname}-${version}/src"
+version=2.2.0
+revision=1
 build_style="gnu-makefile"
 short_desc="UNIX init scheme with service supervision"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="http://smarden.org/runit/"
 distfiles="http://smarden.org/runit/runit-${version}.tar.gz"
-checksum=6fd0160cb0cf1207de4e66754b6d39750cff14bb0aa66ab49490992c0c47ba18
-patch_args=-Np0
+checksum=95ef4d2868b978c7179fe47901e5c578e11cf273d292bd6208bd3a7ccb029290
 # FIXME: this is caused by some bonk tests that should be fixed in void-linux/runit at some point
 make_check=no
 
@@ -21,19 +19,27 @@ if [ "$build_option_static" ]; then
 	LDFLAGS="-static"
 fi
 
-pre_build() {
+post_extract() {
+	mv runit-${version}/* .
+}
+
+do_configure() {
+	cd src
 	vsed -e 's,sbin/runit,usr/bin/runit,g' -i runit.h
 
 	echo "$CC -D_GNU_SOURCE $CFLAGS" >conf-cc
 	echo "$CC $LDFLAGS -Wl,-z -Wl,noexecstack" >conf-ld
 	# set default service path to /var/service
 	vsed -e 's:^char \*varservice ="/service/";$:char \*varservice ="/var/service/";:' -i sv.c
-	# change type short to gid_t for getgroups(2) and setgroups(2)
-	vsed -e 's:short x\[4\];$:gid_t x[4];:' -i chkshsgr.c
+	make ${makejobs} sysdeps
+}
+
+do_build() {
+	make -C src ${makejobs}
 }
 
 do_install() {
-	vlicense ../package/COPYING
+	vlicense package/COPYING
 
 	# default services
 	vmkdir var
@@ -42,10 +48,9 @@ do_install() {
 	local f
 	for f in chpst runit runit-init runsv runsvchdir runsvdir \
 		sv svlogd utmpset; do
-		vbin $f
+		vbin src/$f
 	done
 
-	cd ..
 	for f in man/*; do
 		vman $f
 	done

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] [NOT TESTED] runit: update to 2.2.0.
  2024-09-29 14:24 [PR PATCH] [NOT TESTED] runit: update to 2.2.0 sgn
  2024-09-30  3:36 ` [PR PATCH] [Updated] " sgn
@ 2024-10-03  8:05 ` classabbyamp
  2024-10-04  4:01 ` [PR PATCH] [Updated] " sgn
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-10-03  8:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52408#discussion_r1785802664

Comment:
https

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] [NOT TESTED] runit: update to 2.2.0.
  2024-09-29 14:24 [PR PATCH] [NOT TESTED] runit: update to 2.2.0 sgn
  2024-09-30  3:36 ` [PR PATCH] [Updated] " sgn
  2024-10-03  8:05 ` [PR REVIEW] " classabbyamp
@ 2024-10-04  4:01 ` sgn
  2024-10-08 10:38 ` slymattz
  2024-10-08 10:39 ` slymattz
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2024-10-04  4:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages runit-2.2.0
https://github.com/void-linux/void-packages/pull/52408

[NOT TESTED] runit: update to 2.2.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-runit-2.2.0-52408.patch --]
[-- Type: text/x-diff, Size: 16343 bytes --]

From 5a6e1c834dca5d41e0040e9080e3be06081e73f8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sun, 29 Sep 2024 21:23:35 +0700
Subject: [PATCH] runit: update to 2.2.0.

---
 srcpkgs/runit/patches/chpst-pwd.patch      | 77 ---------------------
 srcpkgs/runit/patches/chpst.patch          | 14 ----
 srcpkgs/runit/patches/clearmem.patch       | 15 +++--
 srcpkgs/runit/patches/cross.patch          | 78 ++++++++++++++++------
 srcpkgs/runit/patches/default_svdir.patch  | 26 ++++----
 srcpkgs/runit/patches/sigcont.patch        |  6 +-
 srcpkgs/runit/patches/svlogd.patch         | 13 ----
 srcpkgs/runit/patches/utmpset-time_t.patch | 56 ----------------
 srcpkgs/runit/template                     | 31 +++++----
 9 files changed, 102 insertions(+), 214 deletions(-)
 delete mode 100644 srcpkgs/runit/patches/chpst-pwd.patch
 delete mode 100644 srcpkgs/runit/patches/chpst.patch
 delete mode 100644 srcpkgs/runit/patches/svlogd.patch
 delete mode 100644 srcpkgs/runit/patches/utmpset-time_t.patch

diff --git a/srcpkgs/runit/patches/chpst-pwd.patch b/srcpkgs/runit/patches/chpst-pwd.patch
deleted file mode 100644
index c8ee7ed893cac4..00000000000000
--- a/srcpkgs/runit/patches/chpst-pwd.patch
+++ /dev/null
@@ -1,77 +0,0 @@
-From 2b8000f1ebd07fd68ee0e3c32737d97bcd1687fb Mon Sep 17 00:00:00 2001
-From: "Andrew J. Hesford" <ajh@sideband.org>
-Date: Mon, 14 Feb 2022 14:25:22 -0500
-Subject: [PATCH] chpst: add -C to change working directory
-
----
- man/chpst.8 | 8 ++++++++
- src/chpst.c | 9 +++++++--
- 2 files changed, 15 insertions(+), 2 deletions(-)
-
-diff --git runit-2.1.2/man/chpst.8 runit-2.1.2/man/chpst.8
-index 43c0b8d..e0829b6 100644
---- runit-2.1.2/man/chpst.8
-+++ runit-2.1.2/man/chpst.8
-@@ -146,6 +146,14 @@ Change the root directory to
- before starting
- .IR prog .
- .TP
-+.B \-C \fIpwd
-+chdir.
-+Change the working directory to
-+.I pwd
-+before starting
-+.IR prog .
-+When combined with \-/, the working directory is changed after the chroot.
-+.TP
- .B \-n \fIinc
- nice.
- Add
-diff --git runit-2.1.2/src/chpst.c runit-2.1.2/src/chpst.c
-index 1cca5f4..d597b68 100644
---- runit-2.1.2/src/chpst.c
-+++ runit-2.1.2/src/chpst.c
-@@ -20,7 +20,7 @@
- #include "openreadclose.h"
- #include "direntry.h"
- 
--#define USAGE_MAIN " [-vP012] [-u user[:group]] [-U user[:group]] [-b argv0] [-e dir] [-/ root] [-n nice] [-l|-L lock] [-m n] [-d n] [-o n] [-p n] [-f n] [-c n] prog"
-+#define USAGE_MAIN " [-vP012] [-u user[:group]] [-U user[:group]] [-b argv0] [-e dir] [-/ root] [-C pwd] [-n nice] [-l|-L lock] [-m n] [-d n] [-o n] [-p n] [-f n] [-c n] prog"
- #define FATAL "chpst: fatal: "
- #define WARNING "chpst: warning: "
- 
-@@ -60,6 +60,7 @@ long limitt =-2;
- long nicelvl =0;
- const char *lock =0;
- const char *root =0;
-+const char *pwd =0;
- unsigned int lockdelay;
- 
- void suidgid(char *user, unsigned int ext) {
-@@ -286,7 +287,7 @@ int main(int argc, const char **argv) {
-   if (str_equal(progname, "setlock")) setlock(argc, argv);
-   if (str_equal(progname, "softlimit")) softlimit(argc, argv);
- 
--  while ((opt =getopt(argc, argv, "u:U:b:e:m:d:o:p:f:c:r:t:/:n:l:L:vP012V"))
-+  while ((opt =getopt(argc, argv, "u:U:b:e:m:d:o:p:f:c:r:t:/:C:n:l:L:vP012V"))
-          != opteof)
-     switch(opt) {
-     case 'u': set_user =(char*)optarg; break;
-@@ -305,6 +306,7 @@ int main(int argc, const char **argv) {
-     case 'r': if (optarg[scan_ulong(optarg, &ul)]) usage(); limitr =ul; break;
-     case 't': if (optarg[scan_ulong(optarg, &ul)]) usage(); limitt =ul; break;
-     case '/': root =optarg; break;
-+    case 'C': pwd =optarg; break;
-     case 'n':
-       switch (*optarg) {
-         case '-':
-@@ -337,6 +339,9 @@ int main(int argc, const char **argv) {
-     if (chdir(root) == -1) fatal2("unable to change directory", root);
-     if (chroot(".") == -1) fatal("unable to change root directory");
-   }
-+  if (pwd) {
-+    if (chdir(pwd) == -1) fatal2("unable to change directory", pwd);
-+  }
-   if (nicelvl) {
-     errno =0;
-     if (nice(nicelvl) == -1) if (errno) fatal("unable to set nice level");
diff --git a/srcpkgs/runit/patches/chpst.patch b/srcpkgs/runit/patches/chpst.patch
deleted file mode 100644
index 988c731c4be999..00000000000000
--- a/srcpkgs/runit/patches/chpst.patch
+++ /dev/null
@@ -1,14 +0,0 @@
-Fix UB which breaks -n with negative values.
-Ensure optarg is incremented strictly before it is read from.
-
---- runit-2.1.2/src/chpst.c.orig
-+++ runit-2.1.2/src/chpst.c
-@@ -308,7 +308,7 @@
-     case 'n':
-       switch (*optarg) {
-         case '-':
--          if (optarg[scan_ulong(++optarg, &ul)]) usage(); nicelvl =ul;
-+          ++optarg; if (optarg[scan_ulong(optarg, &ul)]) usage(); nicelvl =ul;
-           nicelvl *=-1;
-           break;
-         case '+': ++optarg;
diff --git a/srcpkgs/runit/patches/clearmem.patch b/srcpkgs/runit/patches/clearmem.patch
index 1a061eee0fa701..c244c81bfb34f7 100644
--- a/srcpkgs/runit/patches/clearmem.patch
+++ b/srcpkgs/runit/patches/clearmem.patch
@@ -1,7 +1,14 @@
-diff -Naur runit-2.1.2/src/svlogd.c runit-2.1.2/src/svlogd.c
---- runit-2.1.2/src/svlogd.c	2014-08-10 11:22:34.000000000 -0700
-+++ runit-2.1.2/src/svlogd.c	2018-03-03 03:28:08.243085845 -0800
-@@ -705,6 +705,7 @@
+--- a/src/svlogd.c
++++ b/src/svlogd.c
+@@ -8,6 +8,7 @@
+ #include <dirent.h>
+ #include <unistd.h>
+ #include <stdio.h>
++#include <string.h>
+ #include "pmatch.h"
+ #include "fmt_ptime.h"
+ #include "alloc.h"
+@@ -706,6 +707,7 @@ int main(int argc, char **argv) {
    coe(fdwdir);
    dir =(struct logdir*)alloc(dirn *sizeof(struct logdir));
    if (! dir) die_nomem();
diff --git a/srcpkgs/runit/patches/cross.patch b/srcpkgs/runit/patches/cross.patch
index cb5c279c7913b9..b7ac53b8e5f0e1 100644
--- a/srcpkgs/runit/patches/cross.patch
+++ b/srcpkgs/runit/patches/cross.patch
@@ -1,36 +1,27 @@
 chskshsgr must be built for the host.
 
---- runit-2.1.2/src/Makefile.orig	2014-02-11 02:03:33.904789349 +0100
-+++ runit-2.1.2/src/Makefile	2014-02-11 02:19:28.968055164 +0100
-@@ -170,11 +170,11 @@ byte_diff.o: byte.h byte_diff.c compile
- byte_rchr.o: byte.h byte_rchr.c compile
- 	./compile byte_rchr.c
- 
--chkshsgr: chkshsgr.o load
--	./load chkshsgr 
-+chkshsgr: chkshsgr.o loadhost
-+	./loadhost chkshsgr 
- 
--chkshsgr.o: chkshsgr.c compile
--	./compile chkshsgr.c
-+chkshsgr.o: chkshsgr.c compilehost
-+	./compilehost chkshsgr.c
- 
- choose: choose.sh warn-auto.sh
- 	rm -f choose
-@@ -185,6 +185,11 @@ choose: choose.sh warn-auto.sh
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -179,6 +179,11 @@ choose: choose.sh warn-auto.sh
  coe.o: coe.c coe.h compile
  	./compile coe.c
  
 +compilehost:
 +	cat warn-auto.sh > compilehost
-+	@echo 'exec cc -c $${1+"$$@"}' >> compilehost
++	@echo 'exec cc -D_GNU_SOURCE -c $${1+"$$@"}' >> compilehost
 +	chmod 555 compilehost
 +
  compile: conf-cc print-cc.sh systype warn-auto.sh
  	rm -f compile
  	sh print-cc.sh > compile
-@@ -246,6 +251,15 @@ iopause.h: choose compile iopause.h1 iop
+@@ -229,12 +234,21 @@ hassgprm.h: choose compile hassgprm.h1 h
+ haswaitp.h: choose compile haswaitp.h1 haswaitp.h2 load trywaitp.c
+ 	./choose cl trywaitp haswaitp.h1 haswaitp.h2 > haswaitp.h
+ 
+-iopause.h: choose compile iopause.h1 iopause.h2 load trypoll.c
++iopause.h: choose compilehost iopause.h1 iopause.h2 loadhost trypoll.c
+ 	./choose clr trypoll iopause.h1 iopause.h2 > iopause.h
+ 
  iopause.o: compile iopause.c iopause.h select.h tai.h taia.h uint64.h
  	./compile iopause.c
  
@@ -46,3 +37,48 @@ chskshsgr must be built for the host.
  load: conf-ld print-ld.sh systype warn-auto.sh
  	rm -f load
  	sh print-ld.sh > load
+@@ -422,7 +436,7 @@ taia_pack.o taia_sub.o taia_uint.o
+ 	taia_now.o taia_pack.o taia_sub.o taia_uint.o
+ 
+ uint64.h: choose compile load tryulong64.c uint64.h1 uint64.h2
+-	./choose clr tryulong64 uint64.h1 uint64.h2 > uint64.h
++	./choose cl tryulong64 uint64.h1 uint64.h2 > uint64.h
+ 
+ unix.a: alloc.o alloc_re.o buffer.o buffer_0.o buffer_1.o buffer_2.o \
+ buffer_get.o buffer_put.o buffer_read.o buffer_write.o coe.o env.o \
+--- a/src/choose.sh
++++ b/src/choose.sh
+@@ -2,10 +2,12 @@
+ result="$4"
+ 
+ case "$1" in
++  *c*r*) ./compilehost $2.c >/dev/null 2>&1 || result="$3" ;;
+   *c*) ./compile $2.c >/dev/null 2>&1 || result="$3" ;;
+ esac
+ 
+ case "$1" in
++  *l*r*) ./loadhost $2 >/dev/null 2>&1 || result="$3" ;;
+   *l*) ./load $2 >/dev/null 2>&1 || result="$3" ;;
+ esac
+ 
+--- a/src/tryulong64.c
++++ b/src/tryulong64.c
+@@ -1,15 +1,10 @@
+ /* Public domain. */
+ 
+ #include <unistd.h>
++#include <stdint.h>
+ 
+ int main()
+ {
+-  unsigned long u;
+-  u = 1;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  u += u; u += u; u += u; u += u; u += u; u += u; u += u; u += u;
+-  if (!u) _exit(1);
+-  _exit(0);
++  char u[(sizeof(unsigned long) == sizeof(uint64_t)) * 2 - 1] = { 0 };
++  return u[0];
+ }
diff --git a/srcpkgs/runit/patches/default_svdir.patch b/srcpkgs/runit/patches/default_svdir.patch
index 0273d1a9f0b51f..a87185490c1ea3 100644
--- a/srcpkgs/runit/patches/default_svdir.patch
+++ b/srcpkgs/runit/patches/default_svdir.patch
@@ -1,8 +1,8 @@
 Fix default service path in man pages
 
---- runit-2.1.2/man/sv.8
-+++ runit-2.1.2/man/sv.8
-@@ -30,7 +30,7 @@
+--- a/man/sv.8
++++ b/man/sv.8
+@@ -30,7 +30,7 @@ If
  .I service
  doesn't start with a dot or slash and doesn't end with a slash, it is
  searched in the default services directory
@@ -11,7 +11,7 @@ Fix default service path in man pages
  otherwise relative to the current directory.
  .P
  .I command
-@@ -232,7 +232,7 @@
+@@ -232,7 +232,7 @@ This option implies
  .TP
  .B SVDIR
  The environment variable $SVDIR overrides the default services directory
@@ -20,9 +20,9 @@ Fix default service path in man pages
  .TP
  .B SVWAIT
  The environment variable $SVWAIT overrides the default 7 seconds to wait
---- runit-2.1.2/man/runsvchdir.8
-+++ runit-2.1.2/man/runsvchdir.8
-@@ -27,13 +27,13 @@
+--- a/man/runsvchdir.8
++++ b/man/runsvchdir.8
+@@ -27,13 +27,13 @@ with a symlink pointing to
  .IR dir .
  .P
  Normally 
@@ -38,9 +38,9 @@ Fix default service path in man pages
  .SH EXIT CODES
  .B runsvchdir
  prints an error message and exits 111 on error.
---- runit-2.1.2/man/utmpset.8
-+++ runit-2.1.2/man/utmpset.8
-@@ -34,7 +34,7 @@
+--- a/man/utmpset.8
++++ b/man/utmpset.8
+@@ -34,7 +34,7 @@ to the
  .I finish
  scripts, e.g.:
  .P
@@ -49,9 +49,9 @@ Fix default service path in man pages
   #!/bin/sh
   exec utmpset \-w tty5
   $
---- runit-2.1.2/man/runsv.8
-+++ runit-2.1.2/man/runsv.8
-@@ -157,9 +157,9 @@
+--- a/man/runsv.8
++++ b/man/runsv.8
+@@ -155,9 +155,9 @@ This command is ignored if it is given t
  .IR service /log/supervise/control.
  .P
  Example: to send a TERM signal to the socklog-unix service, either do
diff --git a/srcpkgs/runit/patches/sigcont.patch b/srcpkgs/runit/patches/sigcont.patch
index 60ea85d3938bb7..7763d48d1e8995 100644
--- a/srcpkgs/runit/patches/sigcont.patch
+++ b/srcpkgs/runit/patches/sigcont.patch
@@ -3,9 +3,9 @@ runit(8): don't leak SIGCONT SIG_IGN into all child processes
 https://inbox.vuxu.org/supervision/87tug3vzex.fsf@vuxu.org/
 https://github.com/ksh93/ksh/issues/301
 
---- runit-2.1.2/src/runit.c.orig
-+++ runit-2.1.2/src/runit.c
-@@ -125,7 +125,7 @@
+--- a/src/runit.c
++++ b/src/runit.c
+@@ -130,7 +130,7 @@ int main (int argc, const char * const *
        sig_unblock(sig_child);
        sig_uncatch(sig_child);
        sig_unblock(sig_cont);
diff --git a/srcpkgs/runit/patches/svlogd.patch b/srcpkgs/runit/patches/svlogd.patch
deleted file mode 100644
index 2166821100264b..00000000000000
--- a/srcpkgs/runit/patches/svlogd.patch
+++ /dev/null
@@ -1,13 +0,0 @@
-Initialize all fields of sockaddr_in.
-http://skarnet.org/cgi-bin/archive.cgi?2:mss:1163:201602:gpiglpbjdemlioaeabbn
-
---- runit-2.1.2/src/svlogd.c 2014-08-10 15:22:34.000000000 -0300
-+++ runit-2.1.2/src/svlogd.c 2016-02-04 22:53:52.910965361 -0300
-@@ -430,6 +430,7 @@
-   ld->name =(char*)fn;
-   ld->ppid =0;
-   ld->match ='+';
-+  ld->udpaddr.sin_family =AF_INET;
-   ld->udpaddr.sin_port =0;
-   ld->udponly =0;
-   while (! stralloc_copys(&ld->prefix, "")) pause_nomem();
diff --git a/srcpkgs/runit/patches/utmpset-time_t.patch b/srcpkgs/runit/patches/utmpset-time_t.patch
deleted file mode 100644
index fabf8539009988..00000000000000
--- a/srcpkgs/runit/patches/utmpset-time_t.patch
+++ /dev/null
@@ -1,56 +0,0 @@
-From 20a0afcd367666efc17c59cf121a0d991ff1bd09 Mon Sep 17 00:00:00 2001
-From: Gerrit Pape <pape@smarden.org>
-Date: Thu, 31 Jul 2014 12:25:49 +0000
-Subject: [PATCH] utmpset.c: mixes "int32_t *" and "time_t *"
-
-Don't pass int32_t to time(), thx Lorenzo Beretta,
-https://bugs.debian.org/754849
----
- runit-2.1.2/src/utmpset.c | 8 ++++++--
- 1 file changed, 6 insertions(+), 2 deletions(-)
-
-diff --git a/runit-2.1.2/src/utmpset.c b/runit-2.1.2/src/utmpset.c
-index eea41a5..2e8a525 100644
---- runit-2.1.2/src/utmpset.c
-+++ runit-2.1.2/src/utmpset.c
-@@ -24,6 +24,7 @@ void usage(void) { strerr_die4x(1, "usage: ", progname, USAGE, "\n"); }
- int utmp_logout(const char *line) {
-   int fd;
-   uw_tmp ut;
-+  time_t t;
-   int ok =-1;
-
-   if ((fd =open(UW_TMP_UFILE, O_RDWR, 0)) < 0)
-@@ -35,7 +36,8 @@ int utmp_logout(const char *line) {
-     if (!ut.ut_name[0] || (str_diff(ut.ut_line, line) != 0)) continue;
-     memset(ut.ut_name, 0, sizeof ut.ut_name);
-     memset(ut.ut_host, 0, sizeof ut.ut_host);
--    if (time(&ut.ut_time) == -1) break;
-+    if (time(&t) == -1) break;
-+    ut.ut_time = t;
- #ifdef DEAD_PROCESS
-     ut.ut_type =DEAD_PROCESS;
- #endif
-@@ -52,6 +54,7 @@ int wtmp_logout(const char *line) {
-   int len;
-   struct stat st;
-   uw_tmp ut;
-+  time_t t;
-
-   if ((fd = open_append(UW_TMP_WFILE)) == -1)
-     strerr_die4sys(111, FATAL, "unable to open ", UW_TMP_WFILE, ": ");
-@@ -65,10 +68,11 @@ int wtmp_logout(const char *line) {
-   memset(&ut, 0, sizeof(uw_tmp));
-   if ((len =str_len(line)) > sizeof ut.ut_line) len =sizeof ut.ut_line -2;
-   byte_copy(ut.ut_line, len, line);
--  if (time(&ut.ut_time) == -1) {
-+  if (time(&t) == -1) {
-     close(fd);
-     return(-1);
-   }
-+  ut.ut_time = t;
- #ifdef DEAD_PROCESS
-   ut.ut_type =DEAD_PROCESS;
- #endif
---
-2.0.1
diff --git a/srcpkgs/runit/template b/srcpkgs/runit/template
index eb436f5bae0b95..4dea2ce2b117dd 100644
--- a/srcpkgs/runit/template
+++ b/srcpkgs/runit/template
@@ -1,16 +1,14 @@
 # Template file for 'runit'
 pkgname=runit
-version=2.1.2
-revision=15
-build_wrksrc="${pkgname}-${version}/src"
+version=2.2.0
+revision=1
 build_style="gnu-makefile"
 short_desc="UNIX init scheme with service supervision"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
-homepage="http://smarden.org/runit/"
-distfiles="http://smarden.org/runit/runit-${version}.tar.gz"
-checksum=6fd0160cb0cf1207de4e66754b6d39750cff14bb0aa66ab49490992c0c47ba18
-patch_args=-Np0
+homepage="https://smarden.org/runit/"
+distfiles="https://smarden.org/runit/runit-${version}.tar.gz"
+checksum=95ef4d2868b978c7179fe47901e5c578e11cf273d292bd6208bd3a7ccb029290
 # FIXME: this is caused by some bonk tests that should be fixed in void-linux/runit at some point
 make_check=no
 
@@ -21,19 +19,27 @@ if [ "$build_option_static" ]; then
 	LDFLAGS="-static"
 fi
 
-pre_build() {
+post_extract() {
+	mv runit-${version}/* .
+}
+
+do_configure() {
+	cd src
 	vsed -e 's,sbin/runit,usr/bin/runit,g' -i runit.h
 
 	echo "$CC -D_GNU_SOURCE $CFLAGS" >conf-cc
 	echo "$CC $LDFLAGS -Wl,-z -Wl,noexecstack" >conf-ld
 	# set default service path to /var/service
 	vsed -e 's:^char \*varservice ="/service/";$:char \*varservice ="/var/service/";:' -i sv.c
-	# change type short to gid_t for getgroups(2) and setgroups(2)
-	vsed -e 's:short x\[4\];$:gid_t x[4];:' -i chkshsgr.c
+	make ${makejobs} sysdeps
+}
+
+do_build() {
+	make -C src ${makejobs}
 }
 
 do_install() {
-	vlicense ../package/COPYING
+	vlicense package/COPYING
 
 	# default services
 	vmkdir var
@@ -42,10 +48,9 @@ do_install() {
 	local f
 	for f in chpst runit runit-init runsv runsvchdir runsvdir \
 		sv svlogd utmpset; do
-		vbin $f
+		vbin src/$f
 	done
 
-	cd ..
 	for f in man/*; do
 		vman $f
 	done

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: runit: update to 2.2.0.
  2024-09-29 14:24 [PR PATCH] [NOT TESTED] runit: update to 2.2.0 sgn
                   ` (2 preceding siblings ...)
  2024-10-04  4:01 ` [PR PATCH] [Updated] " sgn
@ 2024-10-08 10:38 ` slymattz
  2024-10-08 10:39 ` slymattz
  4 siblings, 0 replies; 6+ messages in thread
From: slymattz @ 2024-10-08 10:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2031 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/52408#issuecomment-2399487995

Comment:
My setup:
- ZFS on ROOT
- network mounts (NFS) - client side
- elogind

ls -la /var/service/*
```
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty1 -> /etc/sv/agetty-tty1
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty2 -> /etc/sv/agetty-tty2
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty3 -> /etc/sv/agetty-tty3
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty4 -> /etc/sv/agetty-tty4
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty5 -> /etc/sv/agetty-tty5
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty6 -> /etc/sv/agetty-tty6
lrwxrwxrwx 1 root root 20 Jul 28 19:24 /var/service/avahi-daemon -> /etc/sv/avahi-daemon
lrwxrwxrwx 1 root root 18 Jul 28 19:24 /var/service/bluetoothd -> /etc/sv/bluetoothd
lrwxrwxrwx 1 root root 15 Jul 28 19:17 /var/service/chronyd -> /etc/sv/chronyd
lrwxrwxrwx 1 root root 14 Jul 28 19:17 /var/service/cronie -> /etc/sv/cronie
lrwxrwxrwx 1 root root 13 Jul 28 19:24 /var/service/cupsd -> /etc/sv/cupsd
lrwxrwxrwx 1 root root 12 Jul 28 19:21 /var/service/dbus -> /etc/sv/dbus
lrwxrwxrwx 1 root root 14 Jul 28 19:16 /var/service/dhcpcd -> /etc/sv/dhcpcd
lrwxrwxrwx 1 root root 17 Jul 28 19:17 /var/service/nanoklogd -> /etc/sv/nanoklogd
lrwxrwxrwx 1 root root 16 Jul 28 19:16 /var/service/netmount -> /etc/sv/netmount
lrwxrwxrwx 1 root root 13 Jul 28 19:25 /var/service/pcscd -> /etc/sv/pcscd
lrwxrwxrwx 1 root root 15 Jul 28 19:16 /var/service/rpcbind -> /etc/sv/rpcbind
lrwxrwxrwx 1 root root 20 Jul 28 19:17 /var/service/socklog-unix -> /etc/sv/socklog-unix
lrwxrwxrwx 1 root root 13 Jul 28 19:16 /var/service/udevd -> /etc/sv/udevd
```
What I've tested so far:
- booting
- powering off / rebooting / putting to sleep
- the network mounts unmount fine while powering off

If anyone has got any idea what else I could test, ping me. 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: runit: update to 2.2.0.
  2024-09-29 14:24 [PR PATCH] [NOT TESTED] runit: update to 2.2.0 sgn
                   ` (3 preceding siblings ...)
  2024-10-08 10:38 ` slymattz
@ 2024-10-08 10:39 ` slymattz
  4 siblings, 0 replies; 6+ messages in thread
From: slymattz @ 2024-10-08 10:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]

New comment by slymattz on void-packages repository

https://github.com/void-linux/void-packages/pull/52408#issuecomment-2399487995

Comment:
My setup:
uname -a
`Linux void-KC1TB 6.6.54_1 #1 SMP PREEMPT_DYNAMIC Fri Oct  4 21:30:04 UTC 2024 x86_64 GNU/Linux`
- ZFS on ROOT
- network mounts (NFS) - client side
- elogind

ls -la /var/service/*
```
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty1 -> /etc/sv/agetty-tty1
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty2 -> /etc/sv/agetty-tty2
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty3 -> /etc/sv/agetty-tty3
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty4 -> /etc/sv/agetty-tty4
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty5 -> /etc/sv/agetty-tty5
lrwxrwxrwx 1 root root 19 Jul 28 19:16 /var/service/agetty-tty6 -> /etc/sv/agetty-tty6
lrwxrwxrwx 1 root root 20 Jul 28 19:24 /var/service/avahi-daemon -> /etc/sv/avahi-daemon
lrwxrwxrwx 1 root root 18 Jul 28 19:24 /var/service/bluetoothd -> /etc/sv/bluetoothd
lrwxrwxrwx 1 root root 15 Jul 28 19:17 /var/service/chronyd -> /etc/sv/chronyd
lrwxrwxrwx 1 root root 14 Jul 28 19:17 /var/service/cronie -> /etc/sv/cronie
lrwxrwxrwx 1 root root 13 Jul 28 19:24 /var/service/cupsd -> /etc/sv/cupsd
lrwxrwxrwx 1 root root 12 Jul 28 19:21 /var/service/dbus -> /etc/sv/dbus
lrwxrwxrwx 1 root root 14 Jul 28 19:16 /var/service/dhcpcd -> /etc/sv/dhcpcd
lrwxrwxrwx 1 root root 17 Jul 28 19:17 /var/service/nanoklogd -> /etc/sv/nanoklogd
lrwxrwxrwx 1 root root 16 Jul 28 19:16 /var/service/netmount -> /etc/sv/netmount
lrwxrwxrwx 1 root root 13 Jul 28 19:25 /var/service/pcscd -> /etc/sv/pcscd
lrwxrwxrwx 1 root root 15 Jul 28 19:16 /var/service/rpcbind -> /etc/sv/rpcbind
lrwxrwxrwx 1 root root 20 Jul 28 19:17 /var/service/socklog-unix -> /etc/sv/socklog-unix
lrwxrwxrwx 1 root root 13 Jul 28 19:16 /var/service/udevd -> /etc/sv/udevd
```
What I've tested so far:
- booting
- powering off / rebooting / putting to sleep
- the network mounts unmount fine while powering off

If anyone has got any idea what else I could test, ping me. 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-10-08 10:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-29 14:24 [PR PATCH] [NOT TESTED] runit: update to 2.2.0 sgn
2024-09-30  3:36 ` [PR PATCH] [Updated] " sgn
2024-10-03  8:05 ` [PR REVIEW] " classabbyamp
2024-10-04  4:01 ` [PR PATCH] [Updated] " sgn
2024-10-08 10:38 ` slymattz
2024-10-08 10:39 ` slymattz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).