From: chasinglogic <chasinglogic@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: talosctl-1.8.1
Date: Thu, 10 Oct 2024 18:21:45 +0200 [thread overview]
Message-ID: <20241010162145.1F9512670D@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-52593@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]
New comment by chasinglogic on void-packages repository
https://github.com/void-linux/void-packages/pull/52593#issuecomment-2405548455
Comment:
The tests fail locally and I assume they will in CI as well because they apparently need to be run as root. You can see this easily on any void linux install if you're brave (/ dumb) enough like me to run the tests directly:
```
~/Code/foss/talos main λ go test ./pkg/archiver/
--- FAIL: TestTarSuite (0.00s)
--- FAIL: TestTarSuite/TestArchiveProcfs (0.00s)
tar_test.go:146:
Error Trace: /home/chasinglogic/Code/foss/talos/pkg/archiver/tar_test.go:146
Error: Should not be zero, but was 0
Test: TestTarSuite/TestArchiveProcfs
FAIL
FAIL github.com/siderolabs/talos/pkg/archiver 0.011s
FAIL
~/Code/foss/talos main λ sudo go test ./pkg/archiver/
Password:
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/stretchr/testify v1.9.0
go: downloading github.com/hashicorp/errwrap v1.1.0
go: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2
go: downloading github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
go: downloading github.com/unix4ever/yaml v0.0.0-20220527175918-f17b0f05cf2c
ok github.com/siderolabs/talos/pkg/archiver 0.010s
~/Code/foss/talos main λ
```
The problem is the tests are trying to archive /proc/self/ as a test but it seems to run into permission issues. I'm not entirely sure what the best solution is. `talosctl` doesn't use this archiver package (only the talos server does).
They get around this in their CI etc because it's all dockerized running as root it seems.
next prev parent reply other threads:[~2024-10-10 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 15:53 [PR PATCH] " chasinglogic
2024-10-10 16:21 ` chasinglogic
2024-10-10 16:21 ` chasinglogic [this message]
2024-10-11 16:53 ` [PR PATCH] [Updated] " chasinglogic
2025-01-10 2:01 ` github-actions
2025-01-25 1:54 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010162145.1F9512670D@inbox.vuxu.org \
--to=chasinglogic@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).