Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] elvish: update to 0.21.0
@ 2024-10-18 17:24 voidisnull
  2024-10-18 17:27 ` [PR PATCH] [Closed]: " classabbyamp
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: voidisnull @ 2024-10-18 17:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

There is a new pull request by voidisnull against master on the void-packages repository

https://github.com/voidisnull/void-packages elvish
https://github.com/void-linux/void-packages/pull/52677

elvish: update to 0.21.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures:
  - x86_64-glibc
  - i686



A patch file from https://github.com/void-linux/void-packages/pull/52677.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-elvish-52677.patch --]
[-- Type: text/x-diff, Size: 1075 bytes --]

From b51ec2e63b8f415744bd3ff10ce679d28ff7f9a4 Mon Sep 17 00:00:00 2001
From: Saksham Verma <voidisnull@duck.com>
Date: Fri, 18 Oct 2024 22:52:49 +0530
Subject: [PATCH] elvish: update to 0.21.0

---
 srcpkgs/elvish/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/elvish/template b/srcpkgs/elvish/template
index 2862fb29f00d72..0f6bb953af2b67 100644
--- a/srcpkgs/elvish/template
+++ b/srcpkgs/elvish/template
@@ -1,7 +1,7 @@
 # Template file for 'elvish'
 pkgname=elvish
-version=0.20.1
-revision=2
+version=0.21.0
+revision=1
 build_style=go
 go_import_path="src.elv.sh"
 go_package="./cmd/elvish"
@@ -11,7 +11,7 @@ license="BSD-2-Clause"
 homepage="https://elv.sh/"
 changelog="https://elv.sh/blog/${version}-release-notes.html"
 distfiles="https://github.com/elves/elvish/archive/v${version}.tar.gz"
-checksum=6a6006015f44def98676eaed611702b000d66838c0e76da572d517d9bde5c388
+checksum=3a4b93c3c99fe2f9847de35d64be24e2d4b9c12d429cd9831b4571993a66bb7a
 register_shell="/bin/elvish"
 
 # fix: collect2: fatal error: cannot find 'ld'

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: elvish: update to 0.21.0
  2024-10-18 17:24 [PR PATCH] elvish: update to 0.21.0 voidisnull
@ 2024-10-18 17:27 ` classabbyamp
  2024-10-18 17:27 ` classabbyamp
  2024-10-18 17:53 ` voidisnull
  2 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-10-18 17:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

There's a closed pull request on the void-packages repository

elvish: update to 0.21.0
https://github.com/void-linux/void-packages/pull/52677

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures:
  - x86_64-glibc
  - i686



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: elvish: update to 0.21.0
  2024-10-18 17:24 [PR PATCH] elvish: update to 0.21.0 voidisnull
  2024-10-18 17:27 ` [PR PATCH] [Closed]: " classabbyamp
@ 2024-10-18 17:27 ` classabbyamp
  2024-10-18 17:53 ` voidisnull
  2 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-10-18 17:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52677#issuecomment-2422928621

Comment:
please check for existing PRs: #52472

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: elvish: update to 0.21.0
  2024-10-18 17:24 [PR PATCH] elvish: update to 0.21.0 voidisnull
  2024-10-18 17:27 ` [PR PATCH] [Closed]: " classabbyamp
  2024-10-18 17:27 ` classabbyamp
@ 2024-10-18 17:53 ` voidisnull
  2 siblings, 0 replies; 7+ messages in thread
From: voidisnull @ 2024-10-18 17:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by voidisnull on void-packages repository

https://github.com/void-linux/void-packages/pull/52677#issuecomment-2422965601

Comment:
I'm so sorry.

I will now definitely remember to check for PRs first

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: elvish: update to 0.21.0.
  2024-10-03  8:25 [PR PATCH] " john-gold
  2024-10-03 10:13 ` john-gold
  2024-10-06 16:27 ` john-gold
@ 2024-10-25  7:14 ` john-gold
  2 siblings, 0 replies; 7+ messages in thread
From: john-gold @ 2024-10-25  7:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by john-gold on void-packages repository

https://github.com/void-linux/void-packages/pull/52472#issuecomment-2437066516

Comment:
@classabbyamp is anything missing?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: elvish: update to 0.21.0.
  2024-10-03  8:25 [PR PATCH] " john-gold
  2024-10-03 10:13 ` john-gold
@ 2024-10-06 16:27 ` john-gold
  2024-10-25  7:14 ` john-gold
  2 siblings, 0 replies; 7+ messages in thread
From: john-gold @ 2024-10-06 16:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

New comment by john-gold on void-packages repository

https://github.com/void-linux/void-packages/pull/52472#issuecomment-2395498438

Comment:
Turns out these unit tests have been enabled with go build style just two months ago (with 332756ed0859dd6a1d2c45532642e1bc55f908c4). Before that commit they have never been executed with this template.

I locally ran `xbps-src check elvish` with enabled unit tests in previous versions like 0.20.1 (2a2940e317d99b2e3c9505e936b6ad80d5e5a2a1) and the same tests are failing. Therefore, I suspect that this problem has not been noticed until now because the tests were deactivated.

I suggest disabling the tests temporarily until a solution to the issue is found (as mentioned the test fail only when run via xbps-src.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: elvish: update to 0.21.0.
  2024-10-03  8:25 [PR PATCH] " john-gold
@ 2024-10-03 10:13 ` john-gold
  2024-10-06 16:27 ` john-gold
  2024-10-25  7:14 ` john-gold
  2 siblings, 0 replies; 7+ messages in thread
From: john-gold @ 2024-10-03 10:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New comment by john-gold on void-packages repository

https://github.com/void-linux/void-packages/pull/52472#issuecomment-2391034036

Comment:
When running `./xbps-src check elvish` the same tests fail as in the CI pipeline.

But running `go test ./...` locally in the [elvish repository](https://github.com/elves/elvish/tree/v0.21.0) succeeds.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-10-25  7:14 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-18 17:24 [PR PATCH] elvish: update to 0.21.0 voidisnull
2024-10-18 17:27 ` [PR PATCH] [Closed]: " classabbyamp
2024-10-18 17:27 ` classabbyamp
2024-10-18 17:53 ` voidisnull
  -- strict thread matches above, loose matches on Subject: below --
2024-10-03  8:25 [PR PATCH] " john-gold
2024-10-03 10:13 ` john-gold
2024-10-06 16:27 ` john-gold
2024-10-25  7:14 ` john-gold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).