Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] Enhancement request: Add Jack support in SDL2
@ 2024-10-23 17:43 fdziarmagowski
  2024-10-23 18:01 ` classabbyamp
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: fdziarmagowski @ 2024-10-23 17:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

New issue by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/issues/52753

Description:
Please consider adding Jack audio back-end to SDL2 and enable it by default. This is required for environments where Jack server is running and providing an audio interface for applications. Without it SDL2 applications fail to provide sound output to Jack
(_SDL audio device opening...failed (Audio subsystem is not initialized)_)

Proposed patch:
```diff --git a/srcpkgs/SDL2/template b/srcpkgs/SDL2/template
index e7b19fdee97..ed34eba7911 100644
--- a/srcpkgs/SDL2/template
+++ b/srcpkgs/SDL2/template
@@ -18,8 +18,8 @@ distfiles="https://www.libsdl.org/release/SDL2-${version}.tar.gz"
 checksum=2508c80438cd5ff3bbeb8fe36b8f3ce7805018ff30303010b61b03bb83ab9694
 
 # Package build options
-build_options="gles opengl pulseaudio pipewire sndio vulkan wayland x11"
-build_options_default="gles opengl pulseaudio sndio vulkan wayland x11"
+build_options="gles jack opengl pulseaudio pipewire sndio vulkan wayland x11"
+build_options_default="gles jack opengl pulseaudio sndio vulkan wayland x11"
 
 case "$XBPS_TARGET_MACHINE" in
 	ppcle*) ;;
@@ -58,6 +58,13 @@ if [ "$build_option_opengl" -o "$build_option_gles" ]; then
 	makedepends+=" glu-devel"
 fi
 
+if [ "$build_option_pipewire" ]; then
+       configure_args+=" -DSDL_JACK=ON"
+       makedepends+=" jack-devel"
+else
+       configure_args+=" -DSDL_JACK=OFF"
+fi
+
 if [ "$build_option_pulseaudio" ]; then
 	configure_args+=" -DSDL_PULSEAUDIO=ON"
 	makedepends+=" pulseaudio-devel"
```
Thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Enhancement request: Add Jack support in SDL2
  2024-10-23 17:43 [ISSUE] Enhancement request: Add Jack support in SDL2 fdziarmagowski
@ 2024-10-23 18:01 ` classabbyamp
  2024-11-24 13:33 ` fdziarmagowski
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-10-23 18:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/52753#issuecomment-2433028251

Comment:
please make a PR for this

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Enhancement request: Add Jack support in SDL2
  2024-10-23 17:43 [ISSUE] Enhancement request: Add Jack support in SDL2 fdziarmagowski
  2024-10-23 18:01 ` classabbyamp
@ 2024-11-24 13:33 ` fdziarmagowski
  2024-11-24 22:27 ` classabbyamp
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: fdziarmagowski @ 2024-11-24 13:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/issues/52753#issuecomment-2496005126

Comment:
Isn't the PR meant for new packages? I'm confused.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Enhancement request: Add Jack support in SDL2
  2024-10-23 17:43 [ISSUE] Enhancement request: Add Jack support in SDL2 fdziarmagowski
  2024-10-23 18:01 ` classabbyamp
  2024-11-24 13:33 ` fdziarmagowski
@ 2024-11-24 22:27 ` classabbyamp
  2024-12-26  7:14 ` [ISSUE] [CLOSED] " fdziarmagowski
  2024-12-26  7:14 ` fdziarmagowski
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-11-24 22:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/52753#issuecomment-2496278575

Comment:
all changes are made via pull request

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [ISSUE] [CLOSED] Enhancement request: Add Jack support in SDL2
  2024-10-23 17:43 [ISSUE] Enhancement request: Add Jack support in SDL2 fdziarmagowski
                   ` (2 preceding siblings ...)
  2024-11-24 22:27 ` classabbyamp
@ 2024-12-26  7:14 ` fdziarmagowski
  2024-12-26  7:14 ` fdziarmagowski
  4 siblings, 0 replies; 6+ messages in thread
From: fdziarmagowski @ 2024-12-26  7:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

Closed issue by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/issues/52753

Description:
Please consider adding Jack audio back-end to SDL2 and enable it by default. This is required for environments where Jack server is running and providing an audio interface for applications. Without it SDL2 applications fail to provide sound output to Jack
(_SDL audio device opening...failed (Audio subsystem is not initialized)_)

Proposed patch:
```diff --git a/srcpkgs/SDL2/template b/srcpkgs/SDL2/template
index e7b19fdee97..ed34eba7911 100644
--- a/srcpkgs/SDL2/template
+++ b/srcpkgs/SDL2/template
@@ -18,8 +18,8 @@ distfiles="https://www.libsdl.org/release/SDL2-${version}.tar.gz"
 checksum=2508c80438cd5ff3bbeb8fe36b8f3ce7805018ff30303010b61b03bb83ab9694
 
 # Package build options
-build_options="gles opengl pulseaudio pipewire sndio vulkan wayland x11"
-build_options_default="gles opengl pulseaudio sndio vulkan wayland x11"
+build_options="gles jack opengl pulseaudio pipewire sndio vulkan wayland x11"
+build_options_default="gles jack opengl pulseaudio sndio vulkan wayland x11"
 
 case "$XBPS_TARGET_MACHINE" in
 	ppcle*) ;;
@@ -58,6 +58,13 @@ if [ "$build_option_opengl" -o "$build_option_gles" ]; then
 	makedepends+=" glu-devel"
 fi
 
+if [ "$build_option_pipewire" ]; then
+       configure_args+=" -DSDL_JACK=ON"
+       makedepends+=" jack-devel"
+else
+       configure_args+=" -DSDL_JACK=OFF"
+fi
+
 if [ "$build_option_pulseaudio" ]; then
 	configure_args+=" -DSDL_PULSEAUDIO=ON"
 	makedepends+=" pulseaudio-devel"
```
Thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Enhancement request: Add Jack support in SDL2
  2024-10-23 17:43 [ISSUE] Enhancement request: Add Jack support in SDL2 fdziarmagowski
                   ` (3 preceding siblings ...)
  2024-12-26  7:14 ` [ISSUE] [CLOSED] " fdziarmagowski
@ 2024-12-26  7:14 ` fdziarmagowski
  4 siblings, 0 replies; 6+ messages in thread
From: fdziarmagowski @ 2024-12-26  7:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/issues/52753#issuecomment-2562241484

Comment:
Closing, I will open a PR for that.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-12-26  7:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-23 17:43 [ISSUE] Enhancement request: Add Jack support in SDL2 fdziarmagowski
2024-10-23 18:01 ` classabbyamp
2024-11-24 13:33 ` fdziarmagowski
2024-11-24 22:27 ` classabbyamp
2024-12-26  7:14 ` [ISSUE] [CLOSED] " fdziarmagowski
2024-12-26  7:14 ` fdziarmagowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).