Re: Add Printer Support: Brother DCP-L8410CDW

[shahab-vahedi <shahab-vahedi@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2348 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/51608#issuecomment-2436193837

Comment:
> I'm not inclined to accept these packages. At best, this ought to be considered for inclusion as a restricted package

I can add `restricted=yes` to the `template`. HOWEVER, if the community doesn't want this package, then I keep it to myself. I just wanted to share it with other Void users to save them some time.

> The EULAs and wrapper script should not be vendored...
For the EULA, my point of reference was the [agree.html](https://github.com/void-linux/void-packages/commits/master/srcpkgs/brother-brscan4/files/agree.html) already existing in `bother-brscan4` package.

Regarding the _wrapper script_, If you're referring to `cupswrapperdcpl8410cdw.void`, it's a trimmed down version of the original script in the `*.deb` file to suit a Void Linux system. The alternative would be to have the original one installed and apply a _patch_ on top of it. For ease of maintenance, I chose the former approach. For the record, the [brother-dcp197c-cupswarpper](https://github.com/void-linux/void-packages/blob/master/srcpkgs/brother-dcp197c-cupswrapper/files/cupswrapper.void), as it is in `master` branch of 24-Oct-2024, was my inspiration.

> ...Fetch them from the deb archive or the web at build time.

I find nothing in the `*.deb` file. As for the _web_, I neither am sure where that would be nor have I the will to locate it. Maybe I should just remove the `agree.html`.

> The INSTALL and REMOVE scripts are inappropriate and should be removed.
> Our packages don't restart users' services just by virtue of installation or removal.
> Users can restart their own services when appropriate.

This was a mimic of the `*.deb` package itself, but sure, I can remove them. Keep in mind, one of them, `brother-dcp8410-lpr/INSTALL`, is creating a directory and has nothing to do with the services.

I appreciate that someone has finally taken a peek at this. Whatever the outcome of this discussion will be, it will inherently be the same for my other [PR](https://github.com/void-linux/void-packages/pull/51636) which upgrades (and fixes) the (broken) existing package of [brother-brscan4](https://github.com/void-linux/void-packages/commits/master/srcpkgs/brother-brscan4/).