Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] tailscale: Add env to exec line in run script
@ 2024-10-25  4:50 lethedata
  2024-10-25  4:53 ` internet-catte
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: lethedata @ 2024-10-25  4:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

There is a new pull request by lethedata against master on the void-packages repository

https://github.com/lethedata/void-packages tailscale
https://github.com/void-linux/void-packages/pull/52771

tailscale: Add env to exec line in run script
Adds conf sourced variable that allows tailscaled environment variables to be set adjusting functionality.

#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/52771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tailscale-52771.patch --]
[-- Type: text/x-diff, Size: 971 bytes --]

From 43ad9c6533c27955d4352411fc831d9c588431c5 Mon Sep 17 00:00:00 2001
From: Echo Nar <echo@lethedata.com>
Date: Thu, 24 Oct 2024 23:43:11 -0500
Subject: [PATCH] tailscale: Add env to exec line in run script

Adds conf sourced variable that allows tailscaled environment variables to be set adjusting functionality.
---
 srcpkgs/tailscale/files/tailscaled/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/tailscale/files/tailscaled/run b/srcpkgs/tailscale/files/tailscaled/run
index ee512f66d3eded..f66459516fe08b 100644
--- a/srcpkgs/tailscale/files/tailscaled/run
+++ b/srcpkgs/tailscale/files/tailscaled/run
@@ -3,7 +3,7 @@
 [ -r conf ] && . ./conf
 
 exec 2>&1
-exec /usr/bin/tailscaled                            \
+exec env ${ENV_VARS} /usr/bin/tailscaled            \
         --state=/var/lib/tailscale/tailscaled.state \
         --socket=/var/run/tailscale/tailscaled.sock \
         --port "${PORT:-41641}"                     \

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: tailscale: Add env to exec line in run script
  2024-10-25  4:50 [PR PATCH] tailscale: Add env to exec line in run script lethedata
@ 2024-10-25  4:53 ` internet-catte
  2024-10-25  4:56 ` lethedata
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: internet-catte @ 2024-10-25  4:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by internet-catte on void-packages repository

https://github.com/void-linux/void-packages/pull/52771#issuecomment-2436829140

Comment:
I don't think this should be necessary? just `export` the variables in `/etc/sv/tailscaled/conf`

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: tailscale: Add env to exec line in run script
  2024-10-25  4:50 [PR PATCH] tailscale: Add env to exec line in run script lethedata
  2024-10-25  4:53 ` internet-catte
  2024-10-25  4:56 ` lethedata
@ 2024-10-25  4:56 ` lethedata
  2024-10-25  4:56 ` lethedata
  3 siblings, 0 replies; 5+ messages in thread
From: lethedata @ 2024-10-25  4:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

There's a closed pull request on the void-packages repository

tailscale: Add env to exec line in run script
https://github.com/void-linux/void-packages/pull/52771

Description:
Adds conf sourced variable that allows tailscaled environment variables to be set adjusting functionality.

#### Testing the changes
- I tested the changes in this PR: **YES**

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: tailscale: Add env to exec line in run script
  2024-10-25  4:50 [PR PATCH] tailscale: Add env to exec line in run script lethedata
  2024-10-25  4:53 ` internet-catte
@ 2024-10-25  4:56 ` lethedata
  2024-10-25  4:56 ` [PR PATCH] [Closed]: " lethedata
  2024-10-25  4:56 ` lethedata
  3 siblings, 0 replies; 5+ messages in thread
From: lethedata @ 2024-10-25  4:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by lethedata on void-packages repository

https://github.com/void-linux/void-packages/pull/52771#issuecomment-2436831707

Comment:
> I don't think this should be necessary? just `export` the variables in `/etc/sv/tailscaled/conf`

Oh... *Major face palm*

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: tailscale: Add env to exec line in run script
  2024-10-25  4:50 [PR PATCH] tailscale: Add env to exec line in run script lethedata
                   ` (2 preceding siblings ...)
  2024-10-25  4:56 ` [PR PATCH] [Closed]: " lethedata
@ 2024-10-25  4:56 ` lethedata
  3 siblings, 0 replies; 5+ messages in thread
From: lethedata @ 2024-10-25  4:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by lethedata on void-packages repository

https://github.com/void-linux/void-packages/pull/52771#issuecomment-2436831707

Comment:
> I don't think this should be necessary? just `export` the variables in `/etc/sv/tailscaled/conf`

Oh... Right. *Major face palm*

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-10-25  4:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-25  4:50 [PR PATCH] tailscale: Add env to exec line in run script lethedata
2024-10-25  4:53 ` internet-catte
2024-10-25  4:56 ` lethedata
2024-10-25  4:56 ` [PR PATCH] [Closed]: " lethedata
2024-10-25  4:56 ` lethedata

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).