Re: Add Printer Support: Brother DCP-L8410CDW

[ahesford <ahesford@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/51608#issuecomment-2444149512

Comment:
I think you misinterpreted my comments:
- Marking the package restricted is a precondition for consideration, without consideration for terms of service that may allow redistribution. It should be restricted because the build process is fragile. A precompiled deb offered by a corporate sponsor may disappear at any time, or may break and be unfixable becuase of other Void updates. We do not need to accept the possibility that officially repacking this software may break our repository at an inopportune moment.
- The `README.maintainer` does not belong in our repository. As I noted, users are expected to familiarize themselves with the maintenance of printers in CUPS should they wish to use it. Void is not a repository for general-purpose documentation.
- The INSTALL and REMOVE scripts remain inappropriate. Void does not alter general system configuration just by virtue of package installation or removal. Removing or adding printers when this package is installed or removed is not appropriate; users may wish to install or remove packages without rewriting printcap. This is especially true because the `-lpr` package is a dependency of the `-cups` package, but CUPS tends to own `/etc/printcap`; other packages shouldn't be modifying that file at all.

In addition:
- In the `-lpr` package, why are you rearranging the executable structure? If the package installs executables in `x86_64` and `i686` subdirectories, you should leave them where they are, but remove the unnecessary arch for each of the `i686` and `x86_64` packages.
- The wrapper script in `-cups` is poorly written (it doesn't even spell `lpdwrapper` correctly) and isn't really suitable for Void at all. The script should **never** copy files into the `/usr/share` or `/usr/lib*` trees, because those are owned by the package manager. The attempt to start, stop or restart services is also poorly conceived. The Void template should just symlink the PPD file(s) as appropriate, so that the package manager can manage those links.
- There is no need for `curl` or fetching the license file at runtime; you can just add the EULA URL to the `distfiles` array in each case, using the following construct:
    ```sh
    distfiles="<regular-distfile>
     https://support.brother.com/g/s/agreement/English_lpr/agree.html>eula-${version}.html"
    skip_extraction="eula-${version}.html"

    post_extract() {
        sed -n -e <...> "${XBPS_SRCDISTDIR}/${pkgname}-${version}/eula-${version}.html" > LICENSE
    }
    ```