* [PR PATCH] New package: cyme-1.8.4.
@ 2024-10-09 21:55 klardotsh
2024-10-09 22:06 ` klardotsh
` (14 more replies)
0 siblings, 15 replies; 16+ messages in thread
From: klardotsh @ 2024-10-09 21:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
There is a new pull request by klardotsh against master on the void-packages repository
https://github.com/klardotsh/void-packages klardotsh/cyme
https://github.com/void-linux/void-packages/pull/52588
New package: cyme-1.8.4.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
(I ran the binary plain, and saw my USB devices and their speeds enumerated. I then ran it as `cyme --lsusb` and saw similar output to the stock `lsusb`, so the "drop in replacement ish" mode seems sane too)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/52588.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/cyme-52588.patch --]
[-- Type: text/x-diff, Size: 1299 bytes --]
From bee83c3fded6a28b54a71f6b62216325250dd209 Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Wed, 9 Oct 2024 14:53:34 -0700
Subject: [PATCH] New package: cyme-1.8.4.
---
srcpkgs/cyme/template | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/cyme/template
diff --git a/srcpkgs/cyme/template b/srcpkgs/cyme/template
new file mode 100644
index 00000000000000..04eb711e3e5fe9
--- /dev/null
+++ b/srcpkgs/cyme/template
@@ -0,0 +1,25 @@
+# Template file for 'cyme'
+pkgname=cyme
+version=1.8.4
+revision=1
+build_style=cargo
+#hostmakedepends="pkg-config"
+makedepends="libusb-devel"
+short_desc="List system USB buses and devices"
+maintainer="klardotsh <josh@klar.sh>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/tuna-f1sh/cyme"
+changelog="https://raw.githubusercontent.com/tuna-f1sh/cyme/main/CHANGELOG.md"
+distfiles="https://github.com/tuna-f1sh/cyme/archive/refs/tags/v${version}.tar.gz"
+checksum=f9136c5794c4d199ee3d7745b82e901de4a15e4626f3bb4c9269e67c6e31885a
+
+post_install() {
+ vcompletion doc/cyme.bash bash
+ vcompletion doc/_cyme bash
+ vcompletion doc/cyme.fish fish
+
+ vman doc/cyme.1
+
+ vmkdir usr/share/examples/${pkgname}/
+ vcopy doc/cyme_example_config.json usr/share/examples/${pkgname}/config.json
+}
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: cyme-1.8.4.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
@ 2024-10-09 22:06 ` klardotsh
2024-10-11 22:18 ` [PR PATCH] [Updated] " klardotsh
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-09 22:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
New comment by klardotsh on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#issuecomment-2403513205
Comment:
I suspect the CI failures relate to running in the highly containerized and locked down GHA environment, but I can't be completely sure. I especially suspect this due to the `rusb` error code member being "Other". I don't appear to be missing any rdeps for the resulting binary, for example:
```
(snowcone) ~ » ldd $(which cyme)
linux-vdso.so.1 (0x00007f2523f53000)
libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f2523f14000)
libc.so.6 => /usr/lib/libc.so.6 (0x00007f2523616000)
/lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007f2523f55000)
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] New package: cyme-1.8.4.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
2024-10-09 22:06 ` klardotsh
@ 2024-10-11 22:18 ` klardotsh
2024-10-21 19:56 ` [PR PATCH] [Updated] New package: cyme-1.8.5 klardotsh
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-11 22:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
There is an updated pull request by klardotsh against master on the void-packages repository
https://github.com/klardotsh/void-packages klardotsh/cyme
https://github.com/void-linux/void-packages/pull/52588
New package: cyme-1.8.4.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
(I ran the binary plain, and saw my USB devices and their speeds enumerated. I then ran it as `cyme --lsusb` and saw similar output to the stock `lsusb`, so the "drop in replacement ish" mode seems sane too)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/52588.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/cyme-52588.patch --]
[-- Type: text/x-diff, Size: 1299 bytes --]
From b81afa416587459711af8fd43b39cec5f36ccc12 Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Wed, 9 Oct 2024 14:53:34 -0700
Subject: [PATCH] New package: cyme-1.8.5.
---
srcpkgs/cyme/template | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/cyme/template
diff --git a/srcpkgs/cyme/template b/srcpkgs/cyme/template
new file mode 100644
index 00000000000000..2d463a3ddfd9e6
--- /dev/null
+++ b/srcpkgs/cyme/template
@@ -0,0 +1,25 @@
+# Template file for 'cyme'
+pkgname=cyme
+version=1.8.5
+revision=1
+build_style=cargo
+#hostmakedepends="pkg-config"
+makedepends="libusb-devel"
+short_desc="List system USB buses and devices"
+maintainer="klardotsh <josh@klar.sh>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/tuna-f1sh/cyme"
+changelog="https://raw.githubusercontent.com/tuna-f1sh/cyme/main/CHANGELOG.md"
+distfiles="https://github.com/tuna-f1sh/cyme/archive/refs/tags/v${version}.tar.gz"
+checksum=f3b7f71e52fd29809f25aadff4d949aafe0ff088d514ca587e7103d5b4171d5b
+
+post_install() {
+ vcompletion doc/cyme.bash bash
+ vcompletion doc/_cyme bash
+ vcompletion doc/cyme.fish fish
+
+ vman doc/cyme.1
+
+ vmkdir usr/share/examples/${pkgname}/
+ vcopy doc/cyme_example_config.json usr/share/examples/${pkgname}/config.json
+}
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] New package: cyme-1.8.5.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
2024-10-09 22:06 ` klardotsh
2024-10-11 22:18 ` [PR PATCH] [Updated] " klardotsh
@ 2024-10-21 19:56 ` klardotsh
2024-10-30 0:04 ` [PR REVIEW] New package: cyme-2.0.0 tranzystorekk
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-21 19:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
There is an updated pull request by klardotsh against master on the void-packages repository
https://github.com/klardotsh/void-packages klardotsh/cyme
https://github.com/void-linux/void-packages/pull/52588
New package: cyme-1.8.5.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
(I ran the binary plain, and saw my USB devices and their speeds enumerated. I then ran it as `cyme --lsusb` and saw similar output to the stock `lsusb`, so the "drop in replacement ish" mode seems sane too)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/52588.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/cyme-52588.patch --]
[-- Type: text/x-diff, Size: 1238 bytes --]
From 81ea342f376190b4d1a15828184c13e948297d18 Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Wed, 9 Oct 2024 14:53:34 -0700
Subject: [PATCH] New package: cyme-2.0.0.
---
srcpkgs/cyme/template | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 srcpkgs/cyme/template
diff --git a/srcpkgs/cyme/template b/srcpkgs/cyme/template
new file mode 100644
index 00000000000000..5a65cfa2b4a0e8
--- /dev/null
+++ b/srcpkgs/cyme/template
@@ -0,0 +1,23 @@
+# Template file for 'cyme'
+pkgname=cyme
+version=2.0.0
+revision=1
+build_style=cargo
+short_desc="List system USB buses and devices"
+maintainer="klardotsh <josh@klar.sh>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/tuna-f1sh/cyme"
+changelog="https://raw.githubusercontent.com/tuna-f1sh/cyme/main/CHANGELOG.md"
+distfiles="https://github.com/tuna-f1sh/cyme/archive/refs/tags/v${version}.tar.gz"
+checksum=2b97ac1560ec96d28be21c1dfda62802c0149fc445fa64bd9df4da9bee8c9f16
+
+post_install() {
+ vcompletion doc/cyme.bash bash
+ vcompletion doc/_cyme bash
+ vcompletion doc/cyme.fish fish
+
+ vman doc/cyme.1
+
+ vmkdir usr/share/examples/${pkgname}/
+ vcopy doc/cyme_example_config.json usr/share/examples/${pkgname}/config.json
+}
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (2 preceding siblings ...)
2024-10-21 19:56 ` [PR PATCH] [Updated] New package: cyme-1.8.5 klardotsh
@ 2024-10-30 0:04 ` tranzystorekk
2024-10-30 0:06 ` tranzystorekk
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: tranzystorekk @ 2024-10-30 0:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New review comment by tranzystorekk on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#discussion_r1821678702
Comment:
```suggestion
vsconf doc/cyme_example_config.json config.json
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (3 preceding siblings ...)
2024-10-30 0:04 ` [PR REVIEW] New package: cyme-2.0.0 tranzystorekk
@ 2024-10-30 0:06 ` tranzystorekk
2024-10-30 16:58 ` klardotsh
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: tranzystorekk @ 2024-10-30 0:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New review comment by tranzystorekk on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#discussion_r1821679781
Comment:
```suggestion
build_style=cargo
checkdepends="eudev"
```
The failing test is missing the database provided by this
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (4 preceding siblings ...)
2024-10-30 0:06 ` tranzystorekk
@ 2024-10-30 16:58 ` klardotsh
2024-10-30 16:59 ` klardotsh
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-30 16:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New review comment by klardotsh on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#discussion_r1823047349
Comment:
That's a crafty alias I didn't know we had, thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (5 preceding siblings ...)
2024-10-30 16:58 ` klardotsh
@ 2024-10-30 16:59 ` klardotsh
2024-10-30 17:04 ` [PR PATCH] [Updated] " klardotsh
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-30 16:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
New review comment by klardotsh on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#discussion_r1823049097
Comment:
That would explain why I can't reproduce locally! (and maybe why aarch64 mysteriously passed, but none of the others did - something different about those runners?)
Thanks a ton, I'm glad my hunch about this being a GitHub Actions issue was wrong.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (6 preceding siblings ...)
2024-10-30 16:59 ` klardotsh
@ 2024-10-30 17:04 ` klardotsh
2024-10-30 17:27 ` [PR REVIEW] " tranzystorekk
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-30 17:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
There is an updated pull request by klardotsh against master on the void-packages repository
https://github.com/klardotsh/void-packages klardotsh/cyme
https://github.com/void-linux/void-packages/pull/52588
New package: cyme-2.0.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
(I ran the binary plain, and saw my USB devices and their speeds enumerated. I then ran it as `cyme --lsusb` and saw similar output to the stock `lsusb`, so the "drop in replacement ish" mode seems sane too)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/52588.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/cyme-52588.patch --]
[-- Type: text/x-diff, Size: 1232 bytes --]
From ce13bbcf6f076ffb08328b664ae8be229aaaf9f9 Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Wed, 9 Oct 2024 14:53:34 -0700
Subject: [PATCH] New package: cyme-2.0.0.
---
srcpkgs/cyme/template | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 srcpkgs/cyme/template
diff --git a/srcpkgs/cyme/template b/srcpkgs/cyme/template
new file mode 100644
index 00000000000000..6822da63a2ed81
--- /dev/null
+++ b/srcpkgs/cyme/template
@@ -0,0 +1,24 @@
+# Template file for 'cyme'
+pkgname=cyme
+version=2.0.0
+revision=1
+build_style=cargo
+checkdepends="eudev"
+short_desc="List system USB buses and devices"
+maintainer="klardotsh <josh@klar.sh>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/tuna-f1sh/cyme"
+changelog="https://raw.githubusercontent.com/tuna-f1sh/cyme/main/CHANGELOG.md"
+distfiles="https://github.com/tuna-f1sh/cyme/archive/refs/tags/v${version}.tar.gz"
+checksum=2b97ac1560ec96d28be21c1dfda62802c0149fc445fa64bd9df4da9bee8c9f16
+
+post_install() {
+ vcompletion doc/cyme.bash bash
+ vcompletion doc/_cyme bash
+ vcompletion doc/cyme.fish fish
+
+ vman doc/cyme.1
+
+ vmkdir usr/share/examples/${pkgname}/
+ vsconf doc/cyme_example_config.json config.json
+}
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (7 preceding siblings ...)
2024-10-30 17:04 ` [PR PATCH] [Updated] " klardotsh
@ 2024-10-30 17:27 ` tranzystorekk
2024-10-30 18:24 ` klardotsh
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: tranzystorekk @ 2024-10-30 17:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by tranzystorekk on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#discussion_r1823094085
Comment:
tests are only run on host archs, not on cross such as aarch64
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (8 preceding siblings ...)
2024-10-30 17:27 ` [PR REVIEW] " tranzystorekk
@ 2024-10-30 18:24 ` klardotsh
2024-10-30 19:06 ` tranzystorekk
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-30 18:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
New comment by klardotsh on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#issuecomment-2448018240
Comment:
The missing `udevrs` dependency issue I can repro locally on x86_64-musl. Not yet sure why this is the case, but I'll poke at it a bit.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (9 preceding siblings ...)
2024-10-30 18:24 ` klardotsh
@ 2024-10-30 19:06 ` tranzystorekk
2024-10-30 19:16 ` klardotsh
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: tranzystorekk @ 2024-10-30 19:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
New comment by tranzystorekk on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#issuecomment-2448121834
Comment:
Upstream made a bizarre decision to declare the dependency only for manually selected targets: https://github.com/tuna-f1sh/cyme/blob/c64fc0f66494202f67007f3dabfd244d5ce54fef/Cargo.toml#L47-L61
we'd probably have to patch it to include it on all unixes, or even just in the main dependency section
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (10 preceding siblings ...)
2024-10-30 19:06 ` tranzystorekk
@ 2024-10-30 19:16 ` klardotsh
2024-10-30 19:17 ` klardotsh
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-30 19:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]
New comment by klardotsh on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#issuecomment-2448143660
Comment:
It gets worse, actually: even overriding features to force the use of the C FFI bindings to udev/hwdb/etc., fails:
```diff
diff --git a/srcpkgs/cyme/template b/srcpkgs/cyme/template
index 6822da63a2e..58ce77a6240 100644
--- a/srcpkgs/cyme/template
+++ b/srcpkgs/cyme/template
@@ -3,7 +3,12 @@ pkgname=cyme
version=2.0.0
revision=1
build_style=cargo
-checkdepends="eudev"
+# The default udevrs dependency is, for whatever reason, not found on Musl, but
+# falling back to the C FFI dependency works. If we're already using system
+# udev anyway, we'll also use the system udev HWDB rather than the crate
+# dependency which might be of a different version than what the system ships.
+configure_args="--no-default-features --features=regex_icon,ffi,udev_hwdb"
+makedepends="eudev-libudev-devel"
short_desc="List system USB buses and devices"
maintainer="klardotsh <josh@klar.sh>"
license="GPL-3.0-or-later"
```
```
error[E0432]: unresolved import `udevlib`
--> src/udev_ffi.rs:3:5
|
3 | use udevlib;
| ^^^^^^^ no external crate `udevlib`
For more information about this error, try `rustc --explain E0432`.
error: could not compile `cyme` (lib) due to 1 previous error
=> ERROR: cyme-2.0.0_1: do_build: '${make_cmd} build --release --locked --target ${RUST_TARGET} ${configure_args} ${make_build_args}' exited with 101
=> ERROR: in do_build() at common/build-style/cargo.sh:8
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (11 preceding siblings ...)
2024-10-30 19:16 ` klardotsh
@ 2024-10-30 19:17 ` klardotsh
2024-10-30 19:46 ` tranzystorekk
2024-10-30 19:50 ` [PR REVIEW] " tranzystorekk
14 siblings, 0 replies; 16+ messages in thread
From: klardotsh @ 2024-10-30 19:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]
New comment by klardotsh on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#issuecomment-2448143660
Comment:
It gets worse, actually: even overriding features to force the use of the C FFI bindings to udev/hwdb/etc., fails:
```diff
diff --git a/srcpkgs/cyme/template b/srcpkgs/cyme/template
index 6822da63a2e..58ce77a6240 100644
--- a/srcpkgs/cyme/template
+++ b/srcpkgs/cyme/template
@@ -3,7 +3,12 @@ pkgname=cyme
version=2.0.0
revision=1
build_style=cargo
-checkdepends="eudev"
+# The default udevrs dependency is, for whatever reason, not found on Musl, but
+# falling back to the C FFI dependency works. If we're already using system
+# udev anyway, we'll also use the system udev HWDB rather than the crate
+# dependency which might be of a different version than what the system ships.
+configure_args="--no-default-features --features=regex_icon,ffi,udev_hwdb"
+makedepends="eudev-libudev-devel"
short_desc="List system USB buses and devices"
maintainer="klardotsh <josh@klar.sh>"
license="GPL-3.0-or-later"
```
```
error[E0432]: unresolved import `udevlib`
--> src/udev_ffi.rs:3:5
|
3 | use udevlib;
| ^^^^^^^ no external crate `udevlib`
For more information about this error, try `rustc --explain E0432`.
error: could not compile `cyme` (lib) due to 1 previous error
=> ERROR: cyme-2.0.0_1: do_build: '${make_cmd} build --release --locked --target ${RUST_TARGET} ${configure_args} ${make_build_args}' exited with 101
=> ERROR: in do_build() at common/build-style/cargo.sh:8
```
EDIT: Extrapolating from your comment (which, I had also looked at Cargo.toml and pondered a bit), I'm assuming Cargo considers Musl to be a non-Linux. I know it's a different triplet as far as LLVM was concerned, but I was hoping Cargo/Rust would at least understand it to be a Linux still?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (12 preceding siblings ...)
2024-10-30 19:17 ` klardotsh
@ 2024-10-30 19:46 ` tranzystorekk
2024-10-30 19:50 ` [PR REVIEW] " tranzystorekk
14 siblings, 0 replies; 16+ messages in thread
From: tranzystorekk @ 2024-10-30 19:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]
New comment by tranzystorekk on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#issuecomment-2448216460
Comment:
the following patches seem to work on musl for me:
```diff
diff --git a/srcpkgs/cyme/template b/srcpkgs/cyme/template
index 6822da63a2e..ab67215cd12 100644
--- a/srcpkgs/cyme/template
+++ b/srcpkgs/cyme/template
@@ -3,6 +3,9 @@ pkgname=cyme
version=2.0.0
revision=1
build_style=cargo
+configure_args="--no-default-features --features=regex_icon,nusb,udevlib,udev_hwdb"
+hostmakedepends="pkg-config"
+makedepends="eudev-libudev-devel"
checkdepends="eudev"
short_desc="List system USB buses and devices"
maintainer="klardotsh <josh@klar.sh>"
```
(no need to also disable native rust usb support IMO)
```diff
diff --git a/Cargo.toml b/Cargo.toml
index 6e80771..53fe0af 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -36,6 +36,8 @@ regex = { version = "1.10.5", optional = true }
uuid = { version = "1.9.1", features = ["serde"] }
pci-ids = "0.2.5"
unicode-width = "0.2.0"
+udevrs = { version = "^0.3.0", optional = true }
+udevlib = { package = "udev", version = "^0.8.0", optional = true }
[patch.crates-io]
nusb = { git = "https://github.com/tuna-f1sh/nusb", branch = "cyme" }
@@ -44,22 +46,6 @@ nusb = { git = "https://github.com/tuna-f1sh/nusb", branch = "cyme" }
diff = "0.1"
assert-json-diff = "2.0.2"
-[target.x86_64-unknown-linux-gnu.dependencies]
-udevrs = { version = "^0.3.0", optional = true }
-udevlib = { package = "udev", version = "^0.8.0", optional = true }
-
-[target.arm-unknown-linux-gnueabihf.dependencies]
-udevrs = { version = "^0.3.0", optional = true }
-udevlib = { package = "udev", version = "^0.8.0", optional = true }
-
-[target.aarch64-unknown-linux-gnu.dependencies]
-udevrs = { version = "^0.3.0", optional = true }
-udevlib = { package = "udev", version = "^0.8.0", optional = true }
-
-[target.riscv64gc-unknown-linux-gnu.dependencies]
-udevrs = { version = "^0.3.0", optional = true }
-udevlib = { package = "udev", version = "^0.8.0", optional = true }
-
[features]
libusb = ["dep:rusb"]
udev = ["dep:udevrs"]
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New package: cyme-2.0.0.
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
` (13 preceding siblings ...)
2024-10-30 19:46 ` tranzystorekk
@ 2024-10-30 19:50 ` tranzystorekk
14 siblings, 0 replies; 16+ messages in thread
From: tranzystorekk @ 2024-10-30 19:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New review comment by tranzystorekk on void-packages repository
https://github.com/void-linux/void-packages/pull/52588#discussion_r1823298396
Comment:
```suggestion
vcompletion doc/_cyme zsh
```
😛
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2024-10-30 19:50 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-09 21:55 [PR PATCH] New package: cyme-1.8.4 klardotsh
2024-10-09 22:06 ` klardotsh
2024-10-11 22:18 ` [PR PATCH] [Updated] " klardotsh
2024-10-21 19:56 ` [PR PATCH] [Updated] New package: cyme-1.8.5 klardotsh
2024-10-30 0:04 ` [PR REVIEW] New package: cyme-2.0.0 tranzystorekk
2024-10-30 0:06 ` tranzystorekk
2024-10-30 16:58 ` klardotsh
2024-10-30 16:59 ` klardotsh
2024-10-30 17:04 ` [PR PATCH] [Updated] " klardotsh
2024-10-30 17:27 ` [PR REVIEW] " tranzystorekk
2024-10-30 18:24 ` klardotsh
2024-10-30 19:06 ` tranzystorekk
2024-10-30 19:16 ` klardotsh
2024-10-30 19:17 ` klardotsh
2024-10-30 19:46 ` tranzystorekk
2024-10-30 19:50 ` [PR REVIEW] " tranzystorekk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).