[PR PATCH] PyInstaller: Fix changelog URL.

[PR PATCH] PyInstaller: Fix changelog URL.

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

There is a new pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages PyInstaller
https://github.com/void-linux/void-packages/pull/51587

PyInstaller: Fix changelog URL.
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, ( - )


A patch file from https://github.com/void-linux/void-packages/pull/51587.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PyInstaller-51587.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]

From 4b9006aa8858970b9564a2e48df6ef6e1da6af31 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 1 Aug 2024 11:15:09 +0200
Subject: [PATCH] PyInstaller: Fix changelog URL.

---
 srcpkgs/PyInstaller/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/PyInstaller/template b/srcpkgs/PyInstaller/template
index baebb65246ac8a..52e231feacc80a 100644
--- a/srcpkgs/PyInstaller/template
+++ b/srcpkgs/PyInstaller/template
@@ -1,7 +1,7 @@
 # Template file for 'PyInstaller'
 pkgname=PyInstaller
 version=4.1
-revision=4
+revision=5
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="zlib-devel"
@@ -10,7 +10,7 @@ short_desc="Bundles a Python application and dependencies into one package"
 maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="GPL-2.0-only"
 homepage="http://www.pyinstaller.org"
-changelog="https://pyinstaller.readthedocs.io/en/v4.0/CHANGES.html"
+changelog="https://pyinstaller.readthedocs.io/en/stable/CHANGES.html"
 distfiles="https://github.com/pyinstaller/pyinstaller/releases/download/v${version}/pyinstaller-${version}.tar.gz"
 checksum=954ae81de9a4bc096ff02433b3e245b9272fe53f27cac319e71fe7540952bd3d
 

Re: PyInstaller: Fix changelog URL.

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2262579586

Comment:
I tried to update it and when running it I got:
```
  File "/usr/lib/python3.12/site-packages/pkg_resources/__init__.py", line 937, in _resolve_dist
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pyinstaller-hooks-contrib>=2024.7' distribution was not found and is required by pyinstaller
error: Recipe `build-exe` failed on line 16 with exit code 1
```

I'll not update it soon.

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2267243913

Comment:
I think the correct url should be `https://pyinstaller.org/en/stable/CHANGES.html` (instead of `readthedocs.io`). I have no idea why it's still 4.1 (released in 2020!), the latest is already 6.9.0. does any package depends on old releases?

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2267243913

Comment:
I think the correct url should be `https://pyinstaller.org/en/stable/CHANGES.html` (instead of `readthedocs.io`). ~~I have no idea why it's still 4.1 (released in 2020!), the latest is already 6.9.0. does any package depends on old releases?~~nvm, did not release you're testing it.

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2267243913

Comment:
I think the correct url should be `https://pyinstaller.org/en/stable/CHANGES.html` (instead of `readthedocs.io`). ~~I have no idea why it's still 4.1 (released in 2020!), the latest is already 6.9.0. does any package depends on old releases?~~ nvm, did not release you're testing it.

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2267251860

Comment:
Quoted from [installation docs](https://pyinstaller.org/en/v6.9.0/installation.html#):

> PyInstaller is split into two packages `pyinstaller` and `pyinstaller-hooks-contrib`. These should be kept approximately (roughly within a year of each other) in sync. To that end, if you choose to pin your `pyinstaller` version, please also pin `pyinstaller-hooks-contrib`. If you upgrade `pyinstaller`, you will also need to upgrade `pyinstaller-hooks-contrib`.

and it's required indeed in [setup.cfg](https://github.com/pyinstaller/pyinstaller/blob/v6.9.0/setup.cfg#L68), I'm not sure why it builds successfully w/o it...Basically you just need to package https://github.com/pyinstaller/pyinstaller-hooks-contrib, mark it as a dep, then rebuild pyinstaller should work.

Re: [PR PATCH] [Updated] PyInstaller: Fix changelog URL.

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages PyInstaller
https://github.com/void-linux/void-packages/pull/51587

PyInstaller: Fix changelog URL.
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, ( - )


A patch file from https://github.com/void-linux/void-packages/pull/51587.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PyInstaller-51587.patch --]
[-- Type: text/x-diff, Size: 2678 bytes --]

From a0800de83ce3cca8e65deb1faaf7ca0394986bf1 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Sun, 4 Aug 2024 12:43:50 +0200
Subject: [PATCH 1/2] New package: python3-pyinstaller-hooks-contrib-2024.7

---
 srcpkgs/python3-pyinstaller-hooks-contrib/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/python3-pyinstaller-hooks-contrib/template

diff --git a/srcpkgs/python3-pyinstaller-hooks-contrib/template b/srcpkgs/python3-pyinstaller-hooks-contrib/template
new file mode 100644
index 00000000000000..2ee3afe00b2942
--- /dev/null
+++ b/srcpkgs/python3-pyinstaller-hooks-contrib/template
@@ -0,0 +1,13 @@
+# Template file for 'python3-pyinstaller-hooks-contrib'
+pkgname=python3-pyinstaller-hooks-contrib
+version=2024.7
+revision=1
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="Community maintained hooks for PyInstaller"
+maintainer="Eloi Torrents <eloitor@duck.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/pyinstaller/pyinstaller-hooks-contrib"
+changelog="https://raw.githubusercontent.com/pyinstaller/pyinstaller-hooks-contrib/master/CHANGELOG.rst"
+distfiles="${PYPI_SITE}/p/pyinstaller_hooks_contrib/pyinstaller_hooks_contrib-${version}.tar.gz"
+checksum=fd5f37dcf99bece184e40642af88be16a9b89613ecb958a8bd1136634fc9fac5

From 8035ae86a722cf95c020cee9dc147df3a745cf36 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 1 Aug 2024 11:15:09 +0200
Subject: [PATCH 2/2] PyInstaller: Fix changelog URL, add community hooks.

---
 srcpkgs/PyInstaller/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/PyInstaller/template b/srcpkgs/PyInstaller/template
index baebb65246ac8a..474d44d0e9a18b 100644
--- a/srcpkgs/PyInstaller/template
+++ b/srcpkgs/PyInstaller/template
@@ -1,16 +1,16 @@
 # Template file for 'PyInstaller'
 pkgname=PyInstaller
 version=4.1
-revision=4
+revision=5
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="zlib-devel"
-depends="python3 python3-altgraph"
+depends="python3 python3-altgraph python3-pyinstaller-hooks-contrib"
 short_desc="Bundles a Python application and dependencies into one package"
 maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="GPL-2.0-only"
 homepage="http://www.pyinstaller.org"
-changelog="https://pyinstaller.readthedocs.io/en/v4.0/CHANGES.html"
+changelog="https://pyinstaller.org/en/stable/CHANGES.html"
 distfiles="https://github.com/pyinstaller/pyinstaller/releases/download/v${version}/pyinstaller-${version}.tar.gz"
 checksum=954ae81de9a4bc096ff02433b3e245b9272fe53f27cac319e71fe7540952bd3d
 

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2267243913

Comment:
I think the correct url should be `https://pyinstaller.org/en/stable/CHANGES.html` (instead of `readthedocs.io`). ~~I have no idea why it's still 4.1 (released in 2020!), the latest is already 6.9.0. does any package depends on old releases?~~ nvm, did not realize you're testing it.

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2267243913

Comment:
I think the correct url should be `https://pyinstaller.org/en/stable/CHANGES.html` (instead of `readthedocs.io`). ~~I have no idea why it's still 4.1 (released in 2020!), the latest is already 6.9.0. does any package depends on old releases?~~ nvm, did not realize you've tested that.

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2272592679

Comment:
I think it's better to update PyInstaller since installation docs mentioned these two should be in sync. 2022 vs 2024 is definitely not the case. I can build and run it successfully with the new subpackage.

You may find this patch useful (I have to use `${PYPI_SITE}` as GitHub URL does not work after updating, did not check changes in build system as it still builds):
```diff
Subject: [PATCH] PyInstaller: update to 6.9.0.

---
 srcpkgs/PyInstaller/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/PyInstaller/template b/srcpkgs/PyInstaller/template
index 474d44d0..14ea950e 100644
--- a/srcpkgs/PyInstaller/template
+++ b/srcpkgs/PyInstaller/template
@@ -1,7 +1,7 @@
 # Template file for 'PyInstaller'
 pkgname=PyInstaller
-version=4.1
-revision=5
+version=6.9.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="zlib-devel"
@@ -11,8 +11,8 @@ maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="GPL-2.0-only"
 homepage="http://www.pyinstaller.org"
 changelog="https://pyinstaller.org/en/stable/CHANGES.html"
-distfiles="https://github.com/pyinstaller/pyinstaller/releases/download/v${version}/pyinstaller-${version}.tar.gz"
-checksum=954ae81de9a4bc096ff02433b3e245b9272fe53f27cac319e71fe7540952bd3d
+distfiles="${PYPI_SITE}/p/pyinstaller/pyinstaller-${version}.tar.gz"
+checksum=f4a75c552facc2e2a370f1e422b971b5e5cdb4058ff38cea0235aa21fc0b378f
 
 CFLAGS="-Wno-stringop-truncation"
 
-- 
2.46.0
```

And running checks return this:
```
=> PyInstaller-6.9.0_1: running do_check ...
=> WARNING: No command 'test' defined by setup.py.
```

Re: PyInstaller: Fix changelog URL.

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2272592679

Comment:
I think it's better to update PyInstaller since installation docs mentioned these two should be in sync. 2020 vs 2024 is definitely not the case. I can build and run it successfully with the new subpackage.

You may find this patch useful (I have to use `${PYPI_SITE}` as GitHub URL does not work after updating, did not check changes in build system as it still builds):
```diff
Subject: [PATCH] PyInstaller: update to 6.9.0.

---
 srcpkgs/PyInstaller/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/PyInstaller/template b/srcpkgs/PyInstaller/template
index 474d44d0..14ea950e 100644
--- a/srcpkgs/PyInstaller/template
+++ b/srcpkgs/PyInstaller/template
@@ -1,7 +1,7 @@
 # Template file for 'PyInstaller'
 pkgname=PyInstaller
-version=4.1
-revision=5
+version=6.9.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="zlib-devel"
@@ -11,8 +11,8 @@ maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="GPL-2.0-only"
 homepage="http://www.pyinstaller.org"
 changelog="https://pyinstaller.org/en/stable/CHANGES.html"
-distfiles="https://github.com/pyinstaller/pyinstaller/releases/download/v${version}/pyinstaller-${version}.tar.gz"
-checksum=954ae81de9a4bc096ff02433b3e245b9272fe53f27cac319e71fe7540952bd3d
+distfiles="${PYPI_SITE}/p/pyinstaller/pyinstaller-${version}.tar.gz"
+checksum=f4a75c552facc2e2a370f1e422b971b5e5cdb4058ff38cea0235aa21fc0b378f
 
 CFLAGS="-Wno-stringop-truncation"
 
-- 
2.46.0
```

And running checks return this:
```
=> PyInstaller-6.9.0_1: running do_check ...
=> WARNING: No command 'test' defined by setup.py.
```

Re: [PR REVIEW] PyInstaller: Fix changelog URL.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#discussion_r1706403700

Comment:
https

Re: PyInstaller: Fix changelog URL.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2272652944

Comment:
it's better to use the git source tarball, because the pypi ones often exclude tests

Re: [PR PATCH] [Updated] PyInstaller: Fix changelog URL.

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages PyInstaller
https://github.com/void-linux/void-packages/pull/51587

PyInstaller: Fix changelog URL.
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, ( - )


A patch file from https://github.com/void-linux/void-packages/pull/51587.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PyInstaller-51587.patch --]
[-- Type: text/x-diff, Size: 2924 bytes --]

From efac9e3b0ac60eba253068b338fe4a646f7d965d Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Sun, 4 Aug 2024 12:43:50 +0200
Subject: [PATCH 1/2] New package: python3-pyinstaller-hooks-contrib-2024.7

---
 srcpkgs/python3-pyinstaller-hooks-contrib/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/python3-pyinstaller-hooks-contrib/template

diff --git a/srcpkgs/python3-pyinstaller-hooks-contrib/template b/srcpkgs/python3-pyinstaller-hooks-contrib/template
new file mode 100644
index 00000000000000..2ee3afe00b2942
--- /dev/null
+++ b/srcpkgs/python3-pyinstaller-hooks-contrib/template
@@ -0,0 +1,13 @@
+# Template file for 'python3-pyinstaller-hooks-contrib'
+pkgname=python3-pyinstaller-hooks-contrib
+version=2024.7
+revision=1
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="Community maintained hooks for PyInstaller"
+maintainer="Eloi Torrents <eloitor@duck.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/pyinstaller/pyinstaller-hooks-contrib"
+changelog="https://raw.githubusercontent.com/pyinstaller/pyinstaller-hooks-contrib/master/CHANGELOG.rst"
+distfiles="${PYPI_SITE}/p/pyinstaller_hooks_contrib/pyinstaller_hooks_contrib-${version}.tar.gz"
+checksum=fd5f37dcf99bece184e40642af88be16a9b89613ecb958a8bd1136634fc9fac5

From 0687a6276f67e32d7e682ebd928fcd513bc4db71 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 1 Aug 2024 11:15:09 +0200
Subject: [PATCH 2/2] PyInstaller: update to 6.9.0.

---
 srcpkgs/PyInstaller/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/PyInstaller/template b/srcpkgs/PyInstaller/template
index baebb65246ac8a..d15a6a31ab61c9 100644
--- a/srcpkgs/PyInstaller/template
+++ b/srcpkgs/PyInstaller/template
@@ -1,18 +1,18 @@
 # Template file for 'PyInstaller'
 pkgname=PyInstaller
-version=4.1
-revision=4
+version=6.9.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="zlib-devel"
-depends="python3 python3-altgraph"
+depends="python3 python3-altgraph python3-pyinstaller-hooks-contrib"
 short_desc="Bundles a Python application and dependencies into one package"
 maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="GPL-2.0-only"
-homepage="http://www.pyinstaller.org"
-changelog="https://pyinstaller.readthedocs.io/en/v4.0/CHANGES.html"
-distfiles="https://github.com/pyinstaller/pyinstaller/releases/download/v${version}/pyinstaller-${version}.tar.gz"
-checksum=954ae81de9a4bc096ff02433b3e245b9272fe53f27cac319e71fe7540952bd3d
+homepage="https://www.pyinstaller.org"
+changelog="https://pyinstaller.org/en/stable/CHANGES.html"
+distfiles="https://github.com/pyinstaller/pyinstaller/archive/refs/tags/v${version}.tar.gz"
+checksum=716a011358c113a1df80fbcbc206df42f901126a558980d2fd687dfe343646b8
 
 CFLAGS="-Wno-stringop-truncation"
 

Re: PyInstaller: update to 6.9.0.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/51587#issuecomment-2461159256

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.