Github messages for voidlinux
 help / color / mirror / Atom feed
From: voidisnull <voidisnull@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Signal-Desktop: update to 7.33.0
Date: Wed, 20 Nov 2024 23:24:03 +0100	[thread overview]
Message-ID: <20241120222403.BF26C21563@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-53122@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

There is an updated pull request by voidisnull against master on the void-packages repository

https://github.com/voidisnull/void-packages Signal-Desktop
https://github.com/void-linux/void-packages/pull/53122

Signal-Desktop: update to 7.33.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

As the the new package do not have hicolor icons present I have modified the post_extract script.
Please correct me if I'm wrong

A patch file from https://github.com/void-linux/void-packages/pull/53122.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Signal-Desktop-53122.patch --]
[-- Type: text/x-diff, Size: 1456 bytes --]

From 3ec478a448d1e93c59a3d9abfd7b848ddbd08979 Mon Sep 17 00:00:00 2001
From: Saksham Verma <voidisnull@duck.com>
Date: Mon, 18 Nov 2024 17:10:11 +0530
Subject: [PATCH] Signal-Desktop: update to 7.34.0

---
 srcpkgs/Signal-Desktop/template | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index c14a13ebe71279..e1ba0710ed2204 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -1,6 +1,6 @@
 # Template file for 'Signal-Desktop'
 pkgname=Signal-Desktop
-version=7.32.0
+version=7.34.0
 revision=1
 # Signal officially only supports x86_64
 # x86_64-musl could potentially work based on the Alpine port:
@@ -14,7 +14,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="AGPL-3.0-only"
 homepage="https://github.com/signalapp/Signal-Desktop"
 distfiles="https://github.com/signalapp/Signal-Desktop/archive/v${version}.tar.gz"
-checksum=e6d51ff1b90bd39090057cdee56476e074e8708e021294cd5ed6b865cb5e3c4a
+checksum=0119578e90afc4e3421682beef0cc6cbe373f13126fad40568a08492d4088a28
 nostrip_files="signal-desktop"
 
 post_extract() {
@@ -64,10 +64,5 @@ do_install() {
 
 	vinstall signal-desktop.desktop 644 usr/share/applications
 
-	vmkdir usr/share/icons/hicolor
-	for size in 16 32 256; do
-		vinstall images/icon_${size}.png 644 usr/share/icons/hicolor/${size}x${size}/apps/ signal-desktop.png
-	done
-
 	vlicense LICENSE
 }

      reply	other threads:[~2024-11-20 22:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 11:42 [PR PATCH] " voidisnull
2024-11-20 22:24 ` voidisnull [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241120222403.BF26C21563@inbox.vuxu.org \
    --to=voidisnull@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).