[PR PATCH] thefuck: move setuptools to depends

[PR PATCH] thefuck: move setuptools to depends

[Trickyni-V56]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

There is a new pull request by Trickyni-V56 against master on the void-packages repository

https://github.com/Trickyni-V56/void-packages patch-1
https://github.com/void-linux/void-packages/pull/53393

thefuck: move setuptools to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/53393.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-53393.patch --]
[-- Type: text/x-diff, Size: 929 bytes --]

From eb06d3c8855ee511be9ec48f2507e125ad0081b5 Mon Sep 17 00:00:00 2001
From: Trickyni <108625844+Trickyni-V56@users.noreply.github.com>
Date: Sat, 7 Dec 2024 15:11:25 +0200
Subject: [PATCH] thefuck: move setuptools to depends

---
 srcpkgs/thefuck/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/thefuck/template b/srcpkgs/thefuck/template
index dd7f1356e28f5f..e127365388ffa1 100644
--- a/srcpkgs/thefuck/template
+++ b/srcpkgs/thefuck/template
@@ -3,9 +3,9 @@ pkgname=thefuck
 version=3.32
 revision=4
 build_style=python3-module
-hostmakedepends="python3-setuptools"
+hostmakedepends=""
 depends="python3-colorama python3-decorator python3-psutil python3-pyte
- python3-requests"
+ python3-requests python3-setuptools"
 checkdepends="python3-pytest-mock $depends"
 short_desc="Magnificent app which corrects your previous console command"
 maintainer="Orphaned <orphan@voidlinux.org>"

Re: thefuck: move setuptools to depends

[abenson]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/53393#issuecomment-2529431474

Comment:
What's the reasoning?

Re: [PR REVIEW] thefuck: move setuptools to depends

[abenson]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/53393#discussion_r1876746438

Comment:
This should just be removed if its not being set.

Re: thefuck: move setuptools to depends

[Trickyni-V56]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

New comment by Trickyni-V56 on void-packages repository

https://github.com/void-linux/void-packages/pull/53393#issuecomment-2530591755

Comment:
Without python3-setuptools installed, I'm getting this error:

```Traceback (most recent call last):
  File "/usr/bin/thefuck", line 9, in <module>
    from thefuck.entrypoints.main import main
  File "/usr/lib/python3.12/site-packages/thefuck/entrypoints/main.py", line 2, in <module>
    from ..system import init_output
  File "/usr/lib/python3.12/site-packages/thefuck/system/__init__.py", line 7, in <module>
    from .unix import *  # noqa: F401,F403
    ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/thefuck/system/unix.py", line 6, in <module>
    from distutils.spawn import find_executable
ModuleNotFoundError: No module named 'distutils'
```

After reinstalling python3-setuptools thefuck works properly.

Re: [PR PATCH] [Updated] thefuck: move setuptools to depends

[Trickyni-V56]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

There is an updated pull request by Trickyni-V56 against master on the void-packages repository

https://github.com/Trickyni-V56/void-packages patch-1
https://github.com/void-linux/void-packages/pull/53393

thefuck: move setuptools to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/53393.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-53393.patch --]
[-- Type: text/x-diff, Size: 907 bytes --]

From 2df08660ee87f6ee49f45057676c8f69e54b1c1b Mon Sep 17 00:00:00 2001
From: Trickyni <108625844+Trickyni-V56@users.noreply.github.com>
Date: Sat, 7 Dec 2024 15:11:25 +0200
Subject: [PATCH] thefuck: move setuptools to depends

---
 srcpkgs/thefuck/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/thefuck/template b/srcpkgs/thefuck/template
index dd7f1356e28f5f..0cb4fe653ce3c7 100644
--- a/srcpkgs/thefuck/template
+++ b/srcpkgs/thefuck/template
@@ -3,9 +3,8 @@ pkgname=thefuck
 version=3.32
 revision=4
 build_style=python3-module
-hostmakedepends="python3-setuptools"
 depends="python3-colorama python3-decorator python3-psutil python3-pyte
- python3-requests"
+ python3-requests python3-setuptools"
 checkdepends="python3-pytest-mock $depends"
 short_desc="Magnificent app which corrects your previous console command"
 maintainer="Orphaned <orphan@voidlinux.org>"

Re: [PR PATCH] [Updated] thefuck: move setuptools to depends

[Trickyni-V56]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

There is an updated pull request by Trickyni-V56 against master on the void-packages repository

https://github.com/Trickyni-V56/void-packages patch-1
https://github.com/void-linux/void-packages/pull/53393

thefuck: move setuptools to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/53393.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-53393.patch --]
[-- Type: text/x-diff, Size: 886 bytes --]

From 866e6dbf66e9553389d28f039f985d6b3a531140 Mon Sep 17 00:00:00 2001
From: Trickyni-V56 <trickyniv56@gmail.com>
Date: Tue, 10 Dec 2024 23:42:36 +0200
Subject: [PATCH] thefuck: move setuptools to depends

---
 srcpkgs/thefuck/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/thefuck/template b/srcpkgs/thefuck/template
index dd7f1356e28f5f..0cb4fe653ce3c7 100644
--- a/srcpkgs/thefuck/template
+++ b/srcpkgs/thefuck/template
@@ -3,9 +3,8 @@ pkgname=thefuck
 version=3.32
 revision=4
 build_style=python3-module
-hostmakedepends="python3-setuptools"
 depends="python3-colorama python3-decorator python3-psutil python3-pyte
- python3-requests"
+ python3-requests python3-setuptools"
 checkdepends="python3-pytest-mock $depends"
 short_desc="Magnificent app which corrects your previous console command"
 maintainer="Orphaned <orphan@voidlinux.org>"

Re: thefuck: move setuptools to depends

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/53393#issuecomment-2537580963

Comment:
setuptools does bring back the distutils module, but as mentioned in https://github.com/nvbn/thefuck/pull/1473, the correct fix is to replace `distutils.spawn.find_executable` with `shutil.which`

Re: thefuck: move setuptools to depends

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/53393#issuecomment-2537580963

Comment:
setuptools does bring back the distutils module, but as mentioned in https://github.com/nvbn/thefuck/pull/1473, the correct fix is instead to replace `distutils.spawn.find_executable` with `shutil.which`

Re: thefuck: move setuptools to depends

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/53393#issuecomment-2554014402

Comment:
As upstream has gone [unmaintained](https://github.com/nvbn/thefuck/issues/1466), I'd be extremely wary of taking on the task of backporting fixes to the ever-growing list of issues. Maybe we should revisit the topic once there is an acknowledged maintained fork.

Re: [PR PATCH] [Closed]: thefuck: move setuptools to depends

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

There's a closed pull request on the void-packages repository

thefuck: move setuptools to depends
https://github.com/void-linux/void-packages/pull/53393

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->