Github messages for voidlinux
 help / color / mirror / Atom feed
From: fdziarmagowski <fdziarmagowski@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [ISSUE] [CLOSED] Enhancement request: Add Jack support in SDL2
Date: Thu, 26 Dec 2024 08:14:27 +0100	[thread overview]
Message-ID: <20241226071428.0FEA120F4C@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-52753@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

Closed issue by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/issues/52753

Description:
Please consider adding Jack audio back-end to SDL2 and enable it by default. This is required for environments where Jack server is running and providing an audio interface for applications. Without it SDL2 applications fail to provide sound output to Jack
(_SDL audio device opening...failed (Audio subsystem is not initialized)_)

Proposed patch:
```diff --git a/srcpkgs/SDL2/template b/srcpkgs/SDL2/template
index e7b19fdee97..ed34eba7911 100644
--- a/srcpkgs/SDL2/template
+++ b/srcpkgs/SDL2/template
@@ -18,8 +18,8 @@ distfiles="https://www.libsdl.org/release/SDL2-${version}.tar.gz"
 checksum=2508c80438cd5ff3bbeb8fe36b8f3ce7805018ff30303010b61b03bb83ab9694
 
 # Package build options
-build_options="gles opengl pulseaudio pipewire sndio vulkan wayland x11"
-build_options_default="gles opengl pulseaudio sndio vulkan wayland x11"
+build_options="gles jack opengl pulseaudio pipewire sndio vulkan wayland x11"
+build_options_default="gles jack opengl pulseaudio sndio vulkan wayland x11"
 
 case "$XBPS_TARGET_MACHINE" in
 	ppcle*) ;;
@@ -58,6 +58,13 @@ if [ "$build_option_opengl" -o "$build_option_gles" ]; then
 	makedepends+=" glu-devel"
 fi
 
+if [ "$build_option_pipewire" ]; then
+       configure_args+=" -DSDL_JACK=ON"
+       makedepends+=" jack-devel"
+else
+       configure_args+=" -DSDL_JACK=OFF"
+fi
+
 if [ "$build_option_pulseaudio" ]; then
 	configure_args+=" -DSDL_PULSEAUDIO=ON"
 	makedepends+=" pulseaudio-devel"
```
Thanks!

  parent reply	other threads:[~2024-12-26  7:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 17:43 [ISSUE] " fdziarmagowski
2024-10-23 18:01 ` classabbyamp
2024-11-24 13:33 ` fdziarmagowski
2024-11-24 22:27 ` classabbyamp
2024-12-26  7:14 ` fdziarmagowski [this message]
2024-12-26  7:14 ` fdziarmagowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241226071428.0FEA120F4C@inbox.vuxu.org \
    --to=fdziarmagowski@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).