* [PR PATCH] tealdeer: add alternative group for fish completions
@ 2024-12-29 21:30 tranzystorekk
2024-12-30 1:43 ` [PR REVIEW] " classabbyamp
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: tranzystorekk @ 2024-12-29 21:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]
There is a new pull request by tranzystorekk against master on the void-packages repository
https://github.com/tranzystorekk/void-packages tldr-fish-comp
https://github.com/void-linux/void-packages/pull/53754
tealdeer: add alternative group for fish completions
<!-- Uncomment relevant sections and delete options which are not applicable -->
Without this, fish shell doesn't automatically load completions for the `tldr` symlink.
#### Testing the changes
- I tested the changes in this PR: **YES**
cc @filiprojek
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/53754.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tldr-fish-comp-53754.patch --]
[-- Type: text/x-diff, Size: 1250 bytes --]
From 943eb23c5b17205ef543b67f1499b9231ec9e4c5 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Sun, 29 Dec 2024 19:39:45 +0100
Subject: [PATCH] tealdeer: add alternative group for fish completions
---
srcpkgs/tealdeer/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/tealdeer/template b/srcpkgs/tealdeer/template
index adc626dd59d0b2..0715f10dad7919 100644
--- a/srcpkgs/tealdeer/template
+++ b/srcpkgs/tealdeer/template
@@ -1,7 +1,7 @@
# Template file for 'tealdeer'
pkgname=tealdeer
version=1.7.1
-revision=1
+revision=2
# uses rustls/ring
archs="x86_64* aarch64* i686* armv[67]*"
build_style=cargo
@@ -12,7 +12,9 @@ homepage="https://github.com/dbrgn/tealdeer"
changelog="https://raw.githubusercontent.com/dbrgn/tealdeer/main/CHANGELOG.md"
distfiles="https://github.com/dbrgn/tealdeer/archive/refs/tags/v${version}.tar.gz"
checksum=2b10e141774d2a50d25a1d3ca3d911dedc0e1313366ce0a364068c7a686300d8
-alternatives="tldr:/usr/bin/tldr:/usr/bin/tealdeer"
+alternatives="
+ tldr:/usr/bin/tldr:/usr/bin/tealdeer
+ tldr.fish:/usr/share/fish/vendor_completions.d/tldr.fish:/usr/share/fish/vendor_completions.d/tealdeer.fish"
post_install() {
vlicense LICENSE-MIT
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] tealdeer: add alternative group for fish completions
2024-12-29 21:30 [PR PATCH] tealdeer: add alternative group for fish completions tranzystorekk
@ 2024-12-30 1:43 ` classabbyamp
2024-12-30 1:44 ` classabbyamp
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-12-30 1:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/53754#discussion_r1899234926
Comment:
```suggestion
tldr:/usr/share/fish/vendor_completions.d/tldr.fish:/usr/share/fish/vendor_completions.d/tealdeer.fish"
```
these should be in the same group so they are synced
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] tealdeer: add alternative group for fish completions
2024-12-29 21:30 [PR PATCH] tealdeer: add alternative group for fish completions tranzystorekk
2024-12-30 1:43 ` [PR REVIEW] " classabbyamp
@ 2024-12-30 1:44 ` classabbyamp
2024-12-30 2:00 ` [PR PATCH] [Updated] " tranzystorekk
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-12-30 1:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/53754#discussion_r1899234996
Comment:
also we should be able to remove the `conflicts` for `tealdeer` on `tldr`
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] tealdeer: add alternative group for fish completions
2024-12-29 21:30 [PR PATCH] tealdeer: add alternative group for fish completions tranzystorekk
2024-12-30 1:43 ` [PR REVIEW] " classabbyamp
2024-12-30 1:44 ` classabbyamp
@ 2024-12-30 2:00 ` tranzystorekk
2024-12-30 3:50 ` [PR REVIEW] tealdeer: add alternative symlink " classabbyamp
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: tranzystorekk @ 2024-12-30 2:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]
There is an updated pull request by tranzystorekk against master on the void-packages repository
https://github.com/tranzystorekk/void-packages tldr-fish-comp
https://github.com/void-linux/void-packages/pull/53754
tealdeer: add alternative group for fish completions
<!-- Uncomment relevant sections and delete options which are not applicable -->
Without this, fish shell doesn't automatically load completions for the `tldr` symlink.
#### Testing the changes
- I tested the changes in this PR: **YES**
cc @filiprojek
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/53754.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tldr-fish-comp-53754.patch --]
[-- Type: text/x-diff, Size: 2002 bytes --]
From 296b4e6e1f048010ae322ddf715b57ad22500dcd Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Sun, 29 Dec 2024 19:39:45 +0100
Subject: [PATCH 1/2] tealdeer: add alternative symlink for fish completions
---
srcpkgs/tealdeer/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/tealdeer/template b/srcpkgs/tealdeer/template
index adc626dd59d0b2..1cfed58265105a 100644
--- a/srcpkgs/tealdeer/template
+++ b/srcpkgs/tealdeer/template
@@ -1,7 +1,7 @@
# Template file for 'tealdeer'
pkgname=tealdeer
version=1.7.1
-revision=1
+revision=2
# uses rustls/ring
archs="x86_64* aarch64* i686* armv[67]*"
build_style=cargo
@@ -12,7 +12,9 @@ homepage="https://github.com/dbrgn/tealdeer"
changelog="https://raw.githubusercontent.com/dbrgn/tealdeer/main/CHANGELOG.md"
distfiles="https://github.com/dbrgn/tealdeer/archive/refs/tags/v${version}.tar.gz"
checksum=2b10e141774d2a50d25a1d3ca3d911dedc0e1313366ce0a364068c7a686300d8
-alternatives="tldr:/usr/bin/tldr:/usr/bin/tealdeer"
+alternatives="
+ tldr:tldr:/usr/bin/tealdeer
+ tldr:tldr.fish:/usr/share/fish/vendor_completions.d/tealdeer.fish"
post_install() {
vlicense LICENSE-MIT
From 144b8034de70d189222a191658dfb0d35662f366 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Mon, 30 Dec 2024 02:59:42 +0100
Subject: [PATCH 2/2] tldr: remove conflict with tealdeer
---
srcpkgs/tldr/template | 1 -
1 file changed, 1 deletion(-)
diff --git a/srcpkgs/tldr/template b/srcpkgs/tldr/template
index a0d62b5c7b818c..1b3937315802cb 100644
--- a/srcpkgs/tldr/template
+++ b/srcpkgs/tldr/template
@@ -14,7 +14,6 @@ homepage="https://isacikgoz.me/tldr/"
distfiles="https://github.com/isacikgoz/tldr/archive/v${_version}.tar.gz"
checksum=d40e1c602d84acc67cdee3b9bed001fb8ec198c7049c1d05eb071ab05af66c19
alternatives="tldr:tldr:/usr/bin/gtldr"
-conflicts="tealdeer<=1.2.0_1"
post_install() {
mv ${DESTDIR}/usr/bin/tldr ${DESTDIR}/usr/bin/gtldr
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] tealdeer: add alternative symlink for fish completions
2024-12-29 21:30 [PR PATCH] tealdeer: add alternative group for fish completions tranzystorekk
` (2 preceding siblings ...)
2024-12-30 2:00 ` [PR PATCH] [Updated] " tranzystorekk
@ 2024-12-30 3:50 ` classabbyamp
2024-12-30 11:04 ` [PR PATCH] [Updated] " tranzystorekk
2024-12-30 12:35 ` [PR PATCH] [Merged]: " tranzystorekk
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2024-12-30 3:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/53754#discussion_r1899258287
Comment:
revbump this but otherwise lgtm
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] tealdeer: add alternative symlink for fish completions
2024-12-29 21:30 [PR PATCH] tealdeer: add alternative group for fish completions tranzystorekk
` (3 preceding siblings ...)
2024-12-30 3:50 ` [PR REVIEW] tealdeer: add alternative symlink " classabbyamp
@ 2024-12-30 11:04 ` tranzystorekk
2024-12-30 12:35 ` [PR PATCH] [Merged]: " tranzystorekk
5 siblings, 0 replies; 7+ messages in thread
From: tranzystorekk @ 2024-12-30 11:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
There is an updated pull request by tranzystorekk against master on the void-packages repository
https://github.com/tranzystorekk/void-packages tldr-fish-comp
https://github.com/void-linux/void-packages/pull/53754
tealdeer: add alternative symlink for fish completions
<!-- Uncomment relevant sections and delete options which are not applicable -->
Without this, fish shell doesn't automatically load completions for the `tldr` symlink.
#### Testing the changes
- I tested the changes in this PR: **YES**
cc @filiprojek
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/53754.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tldr-fish-comp-53754.patch --]
[-- Type: text/x-diff, Size: 2219 bytes --]
From 296b4e6e1f048010ae322ddf715b57ad22500dcd Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Sun, 29 Dec 2024 19:39:45 +0100
Subject: [PATCH 1/2] tealdeer: add alternative symlink for fish completions
---
srcpkgs/tealdeer/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/tealdeer/template b/srcpkgs/tealdeer/template
index adc626dd59d0b2..1cfed58265105a 100644
--- a/srcpkgs/tealdeer/template
+++ b/srcpkgs/tealdeer/template
@@ -1,7 +1,7 @@
# Template file for 'tealdeer'
pkgname=tealdeer
version=1.7.1
-revision=1
+revision=2
# uses rustls/ring
archs="x86_64* aarch64* i686* armv[67]*"
build_style=cargo
@@ -12,7 +12,9 @@ homepage="https://github.com/dbrgn/tealdeer"
changelog="https://raw.githubusercontent.com/dbrgn/tealdeer/main/CHANGELOG.md"
distfiles="https://github.com/dbrgn/tealdeer/archive/refs/tags/v${version}.tar.gz"
checksum=2b10e141774d2a50d25a1d3ca3d911dedc0e1313366ce0a364068c7a686300d8
-alternatives="tldr:/usr/bin/tldr:/usr/bin/tealdeer"
+alternatives="
+ tldr:tldr:/usr/bin/tealdeer
+ tldr:tldr.fish:/usr/share/fish/vendor_completions.d/tealdeer.fish"
post_install() {
vlicense LICENSE-MIT
From 78c7bf1bf65797cc2a7df3754acc58bd1219f388 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Mon, 30 Dec 2024 02:59:42 +0100
Subject: [PATCH 2/2] tldr: remove conflict with tealdeer
---
srcpkgs/tldr/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/tldr/template b/srcpkgs/tldr/template
index a0d62b5c7b818c..8be3692e80fbab 100644
--- a/srcpkgs/tldr/template
+++ b/srcpkgs/tldr/template
@@ -1,7 +1,7 @@
# Template file for 'tldr'
pkgname=tldr
version=1.0.0.alpha
-revision=4
+revision=5
_version=${version/.alpha/-alpha}
build_style=go
go_import_path="github.com/isacikgoz/tldr"
@@ -14,7 +14,6 @@ homepage="https://isacikgoz.me/tldr/"
distfiles="https://github.com/isacikgoz/tldr/archive/v${_version}.tar.gz"
checksum=d40e1c602d84acc67cdee3b9bed001fb8ec198c7049c1d05eb071ab05af66c19
alternatives="tldr:tldr:/usr/bin/gtldr"
-conflicts="tealdeer<=1.2.0_1"
post_install() {
mv ${DESTDIR}/usr/bin/tldr ${DESTDIR}/usr/bin/gtldr
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Merged]: tealdeer: add alternative symlink for fish completions
2024-12-29 21:30 [PR PATCH] tealdeer: add alternative group for fish completions tranzystorekk
` (4 preceding siblings ...)
2024-12-30 11:04 ` [PR PATCH] [Updated] " tranzystorekk
@ 2024-12-30 12:35 ` tranzystorekk
5 siblings, 0 replies; 7+ messages in thread
From: tranzystorekk @ 2024-12-30 12:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
There's a merged pull request on the void-packages repository
tealdeer: add alternative symlink for fish completions
https://github.com/void-linux/void-packages/pull/53754
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
Without this, fish shell doesn't automatically load completions for the `tldr` symlink.
#### Testing the changes
- I tested the changes in this PR: **YES**
cc @filiprojek
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-12-30 12:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-29 21:30 [PR PATCH] tealdeer: add alternative group for fish completions tranzystorekk
2024-12-30 1:43 ` [PR REVIEW] " classabbyamp
2024-12-30 1:44 ` classabbyamp
2024-12-30 2:00 ` [PR PATCH] [Updated] " tranzystorekk
2024-12-30 3:50 ` [PR REVIEW] tealdeer: add alternative symlink " classabbyamp
2024-12-30 11:04 ` [PR PATCH] [Updated] " tranzystorekk
2024-12-30 12:35 ` [PR PATCH] [Merged]: " tranzystorekk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).