Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mixxx: update to 2.5.0
@ 2025-01-06 18:03 zlice
  2025-01-06 18:05 ` [PR PATCH] [Updated] " zlice
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: zlice @ 2025-01-06 18:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

There is a new pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages mixxx250
https://github.com/void-linux/void-packages/pull/53868

mixxx: update to 2.5.0
#### Testing the changes
- I tested the changes in this PR: **BRIEF**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64**
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - **aarch64-musl**

#### Comments

`msgsl` is just a dev package. for some reason requires `-Wno-ctor-dtor-privacy` no void, though arch and alpine do not seem to mention this. figured it may be compiler?

`mixxx` started using qt6 but tries to provide `QML`, which runs a binary and fails on aarch64 crossbuild. i don't think the build was using QML anyway.

`mixxx` also tries to download `libdjinterop` through cmake, which i was told is not supported in void. it wasn't in the previous version so it should be fine to ditch in 2.5.0

![mixxx](https://github.com/user-attachments/assets/25b93c2c-3f83-48bb-b277-6bf8dff66e52)

A patch file from https://github.com/void-linux/void-packages/pull/53868.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mixxx250-53868.patch --]
[-- Type: text/x-diff, Size: 4432 bytes --]

From d8a2dedd1ae8d5b2f0f4e59d14708e6b523c2d22 Mon Sep 17 00:00:00 2001
From: zlice <zlice555@gmail.com>
Date: Mon, 6 Jan 2025 12:44:53 -0500
Subject: [PATCH 1/2] New package: msgsl-4.1.0

---
 srcpkgs/msgsl/patches/ctorprivacy.patch | 13 +++++++++++++
 srcpkgs/msgsl/template                  | 13 +++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 srcpkgs/msgsl/patches/ctorprivacy.patch
 create mode 100644 srcpkgs/msgsl/template

diff --git a/srcpkgs/msgsl/patches/ctorprivacy.patch b/srcpkgs/msgsl/patches/ctorprivacy.patch
new file mode 100644
index 00000000000000..444c9282bd2e74
--- /dev/null
+++ b/srcpkgs/msgsl/patches/ctorprivacy.patch
@@ -0,0 +1,13 @@
+# not sure what this is about, other distros don't seem to have it
+# may be newer compilers?
+--- a/tests/CMakeLists.txt
++++ b/tests/CMakeLists.txt
+@@ -129,7 +129,7 @@
+         -Wall
+         -Wcast-align
+         -Wconversion
+-        -Wctor-dtor-privacy
++        -Wno-ctor-dtor-privacy
+         -Werror
+         -Wextra
+         -Wpedantic
diff --git a/srcpkgs/msgsl/template b/srcpkgs/msgsl/template
new file mode 100644
index 00000000000000..1a0e5c38b7a9a9
--- /dev/null
+++ b/srcpkgs/msgsl/template
@@ -0,0 +1,13 @@
+# Template file for 'msgsl'
+pkgname=msgsl
+version=4.1.0
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON"
+hostmakedepends="git"
+short_desc="Microsoft C++ Core Guidelines Support Library"
+maintainer="zlice <zlice555@gmail.com>"
+license="MIT"
+homepage="https://github.com/microsoft/GSL"
+distfiles="https://github.com/microsoft/GSL/archive/refs/tags/v${version}.tar.gz"
+checksum=0a227fc9c8e0bf25115f401b9a46c2a68cd28f299d24ab195284eb3f1d7794bd

From 2b1fd8e2a052eedf109acdedc6992f63c50863a2 Mon Sep 17 00:00:00 2001
From: zlice <zlice555@gmail.com>
Date: Mon, 6 Jan 2025 12:45:05 -0500
Subject: [PATCH 2/2] mixxx: update to 2.5.0

---
 srcpkgs/mixxx/template | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/mixxx/template b/srcpkgs/mixxx/template
index 3568315470a260..9aed6a733f6737 100644
--- a/srcpkgs/mixxx/template
+++ b/srcpkgs/mixxx/template
@@ -1,22 +1,27 @@
 # Template file for 'mixxx'
 pkgname=mixxx
-version=2.3.3
-revision=8
+version=2.5.0
+revision=1
 build_style=cmake
-configure_args="-DCMAKE_BUILD_TYPE=Release"
-hostmakedepends="extra-cmake-modules pkg-config protobuf qt5-host-tools qt5-qmake"
+# ENGINEPRIME is for libdjinterop which mixxx's cmake tries to download
+# void's cmake is not built with openssl support to do this
+# QML is trying to run qmlimportscanner which fails on aarch64 cross build
+configure_args="-DCMAKE_BUILD_TYPE=Release -DENGINEPRIME=OFF -DQML=OFF"
+hostmakedepends="extra-cmake-modules pkg-config protobuf qt6-base qt6-declarative"
 makedepends="chromaprint-devel faad2-devel ffmpeg6-devel libkeyfinder-devel glu-devel
  lame-devel libid3tag-devel libmad-devel libmodplug-devel libusb-devel
  opusfile-devel libflac-devel libogg-devel libsndfile-devel libvorbis-devel
- wavpack-devel portaudio-devel portmidi-devel protobuf-devel qt5-script-devel
- qt5-svg-devel qt5-xmlpatterns-devel rubberband-devel taglib-devel upower-devel
- vamp-plugin-sdk-devel lv2 lilv-devel qt5-x11extras-devel hidapi-devel libtheora-devel
- speex-devel soundtouch-devel qtkeychain-qt5-devel qt5-plugin-mysql qt5-plugin-odbc
- qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds libebur128-devel"
-depends="qt5-plugin-sqlite"
+ wavpack-devel portaudio-devel portmidi-devel protobuf-devel qt6-base-devel
+ qt6-base-private-devel qt6-declarative-devel qt6-declarative-private-devel
+ qt6-tools-devel qt6-qt5compat-devel qt6-shadertools-devel qt6-svg-devel
+ rubberband-devel taglib-devel upower-devel vamp-plugin-sdk-devel lv2 lilv-devel
+ hidapi-devel libtheora-devel speex-devel soundtouch-devel qtkeychain-qt6-devel
+ qt6-plugin-mysql qt6-plugin-odbc qt6-plugin-pgsql qt6-plugin-sqlite libebur128-devel
+ benchmark-devel gtest-devel msgsl"
+depends="qt6-plugin-sqlite"
 short_desc="Open source digital DJing software that allows mixing music"
 maintainer="prez <prez@national.shitposting.agency>"
 license="GPL-2.0-or-later"
 homepage="https://www.mixxx.org"
 distfiles="https://github.com/mixxxdj/mixxx/archive/${version}.tar.gz"
-checksum=8e3a5a545175982336bb07c81a3839897a007c43689b93641242db662f6beb9c
+checksum=95ad113f1988abaa4fabc2e19027d5456a6ba9cb0f6366a386a2239030f41089

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-01-10  2:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-06 18:03 [PR PATCH] mixxx: update to 2.5.0 zlice
2025-01-06 18:05 ` [PR PATCH] [Updated] " zlice
2025-01-06 18:07 ` zlice
2025-01-06 19:25 ` zlice
2025-01-06 19:27 ` zlice
2025-01-07  1:22 ` 0x5c
2025-01-09 23:58 ` [PR REVIEW] " Johnnynator
2025-01-09 23:58 ` Johnnynator
2025-01-10  2:57 ` [PR PATCH] [Updated] " zlice

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).