[PR PATCH] cmake: update to 3.31.3

[PR PATCH] cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

There is a new pull request by bvdeenen against master on the void-packages repository

https://github.com/bvdeenen/void-packages master
https://github.com/void-linux/void-packages/pull/53766

cmake: update to 3.31.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**
- a warning with FetchContent that shows with the previous cmake 3.30 version no longer shows. I've tested with CPM and a lot of dependencies and includes and it seems to work fine.

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) x86-84, libc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - none



A patch file from https://github.com/void-linux/void-packages/pull/53766.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-53766.patch --]
[-- Type: text/x-diff, Size: 1098 bytes --]

From bea62273439392c19ca8389a5dfcea5599fa9f9c Mon Sep 17 00:00:00 2001
From: Bart van Deenen <bartvandeenen@streammachine.io>
Date: Mon, 30 Dec 2024 19:54:05 +0100
Subject: [PATCH] cmake: update to 3.31.3

---
 srcpkgs/cmake/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cmake/template b/srcpkgs/cmake/template
index 1b6b23cf3dc8cc..20ba23b0289df7 100644
--- a/srcpkgs/cmake/template
+++ b/srcpkgs/cmake/template
@@ -1,6 +1,6 @@
 # Template file for 'cmake'
 pkgname=cmake
-version=3.30.1
+version=3.31.3
 revision=1
 build_style=cmake
 configure_args="-DCMAKE_DOC_DIR=/share/doc/cmake
@@ -17,7 +17,7 @@ maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
 license="BSD-3-Clause, ICU"
 homepage="https://www.cmake.org"
 distfiles="https://www.cmake.org/files/v${version%.*}/${pkgname}-${version}.tar.gz"
-checksum=df9b3c53e3ce84c3c1b7c253e5ceff7d8d1f084ff0673d048f260e04ccb346e1
+checksum=fac45bc6d410b49b3113ab866074888d6c9e9dc81a141874446eb239ac38cb87
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	configure_args+=" -DCMake_NO_SELF_BACKTRACE=1"

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2565897231

Comment:
The github action that fails seems to be a simple reformatting of an error message:

```
CMake Error at /builddir/cmake-3.31.3/Tests/RunCMake/RunCMake.cmake:286 (message):
  Stub-fail - FAILED:

  stderr does not match that expected.

  Command was:

   command> "/builddir/cmake-3.31.3/build/bin/cmake" "-E" "env" "LANG=C" "/builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/StubExe"

  Actual stdout:

   actual-stdout> 

  Expected stderr to match:

   expect-stderr> (error while loading shared libraries: libStub\.so\.1|Library not loaded: '?@rpath/libStub\.1\.dylib'?|(Cannot|Could not) load module libStub\.a\(libStub\.so\.1\)|fatal: libStub\.so\.1: open failed|Shared object "libStub\.so\.1" not found)

  Actual stderr:

   actual-stderr> Error loading shared library libStub.so.1: No such file or directory (needed by /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so)
   actual-stderr> Error relocating /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so: Stub: symbol not found

```
I don't even know where these github actions come from, otherwise I'd have a look at solving the issue.

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2565897231

Comment:
The github action that fails seems to be a simple reformatting of an error message:

```
CMake Error at /builddir/cmake-3.31.3/Tests/RunCMake/RunCMake.cmake:286 (message):
  Stub-fail - FAILED:

  stderr does not match that expected.

  Command was:

   command> "/builddir/cmake-3.31.3/build/bin/cmake" "-E" "env" "LANG=C" "/builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/StubExe"

  Actual stdout:

   actual-stdout> 

  Expected stderr to match:

   expect-stderr> (error while loading shared libraries: libStub\.so\.1|Library not loaded: '?@rpath/libStub\.1\.dylib'?|(Cannot|Could not) load module libStub\.a\(libStub\.so\.1\)|fatal: libStub\.so\.1: open failed|Shared object "libStub\.so\.1" not found)

  Actual stderr:

   actual-stderr> Error loading shared library libStub.so.1: No such file or directory (needed by /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so)
   actual-stderr> Error relocating /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so: Stub: symbol not found

```

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2565897231

Comment:
The github action that fails seems to be a simple reformatting of an error message:

```
CMake Error at /builddir/cmake-3.31.3/Tests/RunCMake/RunCMake.cmake:286 (message):
  Stub-fail - FAILED:

  stderr does not match that expected.

  Command was:

   command> "/builddir/cmake-3.31.3/build/bin/cmake" "-E" "env" "LANG=C" "/builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/StubExe"

  Actual stdout:

   actual-stdout> 

  Expected stderr to match:

   expect-stderr> (error while loading shared libraries: libStub\.so\.1|Library not loaded: '?@rpath/libStub\.1\.dylib'?|(Cannot|Could not) load module libStub\.a\(libStub\.so\.1\)|fatal: libStub\.so\.1: open failed|Shared object "libStub\.so\.1" not found)

  Actual stderr:

   actual-stderr> Error loading shared library libStub.so.1: No such file or directory (needed by /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so)
   actual-stderr> Error relocating /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so: Stub: symbol not found

```
I think this failing test is in the cmake Tests suite, and triggers something musl specific. I have no idea how to continue.

Re: cmake: update to 3.31.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2566103664

Comment:
cc @sgn 

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2566328406

Comment:
I've created an issue on the cmake bugtracker: (issue-26565)[https://gitlab.kitware.com/cmake/cmake/-/issues/26565].
We could probably patch [the regex](https://github.com/Kitware/CMake/blob/master/Tests/RunCMake/RuntimePath/Stub-fail-stderr.txt) that checks the stderr, but maybe they'll fix it quickly. 

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2566328406

Comment:
I've created an issue on the [cmake bugtracker](https://gitlab.kitware.com/cmake/cmake/-/issues/26565).
We could probably patch [the regex](https://github.com/Kitware/CMake/blob/master/Tests/RunCMake/RuntimePath/Stub-fail-stderr.txt) that checks the stderr, but maybe they'll fix it quickly. 

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2566328406

Comment:
I've created an issue on the [cmake bugtracker](https://gitlab.kitware.com/cmake/cmake/-/issues/26565).
We could probably patch [the regex](https://github.com/Kitware/CMake/blob/master/Tests/RunCMake/RuntimePath/Stub-fail-stderr.txt) that checks the stderr, but maybe they'll fix it quickly. 
@sgn 

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2565897231

Comment:
The github action that fails seems to be a simple reformatting of an error message:

```
CMake Error at /builddir/cmake-3.31.3/Tests/RunCMake/RunCMake.cmake:286 (message):
  Stub-fail - FAILED:

  stderr does not match that expected.

  Command was:

   command> "/builddir/cmake-3.31.3/build/bin/cmake" "-E" "env" "LANG=C" "/builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/StubExe"

  Actual stdout:

   actual-stdout> 

  Expected stderr to match:

   expect-stderr> (error while loading shared libraries: libStub\.so\.1|Library not loaded: '?@rpath/libStub\.1\.dylib'?|(Cannot|Could not) load module libStub\.a\(libStub\.so\.1\)|fatal: libStub\.so\.1: open failed|Shared object "libStub\.so\.1" not found)

  Actual stderr:

   actual-stderr> Error loading shared library libStub.so.1: No such file or directory (needed by /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so)
   actual-stderr> Error relocating /builddir/cmake-3.31.3/build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so: Stub: symbol not found

```

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2577649369

Comment:
I'm picking up this issue upstream on cmake. I've just set up a musl build environment.

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2577649369

Comment:
@sgn @classabbyamp  I'm picking up this issue upstream on cmake. I've just set up a musl build environment. I've recreated the issue with a local Void musl vm, fixed the test and have created a [MR](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/10150) with the CMake team.

Re: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/53766#issuecomment-2580741048

Comment:
My [MR at cmake](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/10150) has been merged, and will go in the next minor release of cmake (3.32.0) that should take a few weeks. For now, I'll leave it at that, I don't need this patch release that much that I want to take the time to also patch void-packages. I'd like close the MR for now, and pick it up when the next cmake minor version is released.

Re: [PR PATCH] [Closed]: cmake: update to 3.31.3

[bvdeenen]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

There's a closed pull request on the void-packages repository

cmake: update to 3.31.3
https://github.com/void-linux/void-packages/pull/53766

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**
- a warning with FetchContent that shows with the previous cmake 3.30 version no longer shows. I've tested with CPM and a lot of dependencies and includes and it seems to work fine.

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC) x86-84, libc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - none