Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] enchant2: update to 2.8.2.
@ 2025-01-10 19:57 icp1994
  2025-01-10 20:15 ` icp1994
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: icp1994 @ 2025-01-10 19:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages enchant2
https://github.com/void-linux/void-packages/pull/53920

enchant2: update to 2.8.2.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/53920.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-enchant2-53920.patch --]
[-- Type: text/x-diff, Size: 4734 bytes --]

From 3565b517e82bb3d82a1df3dc4d8c5760740dd80e Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 5 Nov 2024 12:42:00 +0530
Subject: [PATCH] enchant2: update to 2.8.2.

split respective bindings into separate subpackages
---
 srcpkgs/enchant2-aspell   |  1 +
 srcpkgs/enchant2-hunspell |  1 +
 srcpkgs/enchant2-nuspell  |  1 +
 srcpkgs/enchant2-voikko   |  1 +
 srcpkgs/enchant2/template | 63 +++++++++++++++++++++++++++++----------
 srcpkgs/libenchant2       |  1 +
 6 files changed, 53 insertions(+), 15 deletions(-)
 create mode 120000 srcpkgs/enchant2-aspell
 create mode 120000 srcpkgs/enchant2-hunspell
 create mode 120000 srcpkgs/enchant2-nuspell
 create mode 120000 srcpkgs/enchant2-voikko
 create mode 120000 srcpkgs/libenchant2

diff --git a/srcpkgs/enchant2-aspell b/srcpkgs/enchant2-aspell
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-aspell
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2-hunspell b/srcpkgs/enchant2-hunspell
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-hunspell
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2-nuspell b/srcpkgs/enchant2-nuspell
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-nuspell
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2-voikko b/srcpkgs/enchant2-voikko
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-voikko
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2/template b/srcpkgs/enchant2/template
index 8055c1c7bb3954..5e584ac87c2b04 100644
--- a/srcpkgs/enchant2/template
+++ b/srcpkgs/enchant2/template
@@ -1,31 +1,64 @@
 # Template file for 'enchant2'
 pkgname=enchant2
-version=2.6.4
+version=2.8.2
 revision=1
 build_style=gnu-configure
-# tests need --enable-relocatable
-configure_args="--enable-relocatable"
+configure_args="--disable-static"
 hostmakedepends="pkg-config groff"
-makedepends="libglib-devel hunspell-devel aspell-devel libvoikko-devel
- libnuspell-devel icu-devel"
-checkdepends="unittest-cpp"
+makedepends="libglib-devel hunspell-devel aspell-devel libnuspell-devel libvoikko-devel"
 short_desc="Generic spell checking library"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
-homepage="https://abiword.github.io/enchant/"
-changelog="https://raw.githubusercontent.com/AbiWord/enchant/master/NEWS"
-distfiles="https://github.com/AbiWord/enchant/releases/download/v${version}/enchant-${version}.tar.gz"
-checksum=833b4d5600dbe9ac867e543aac6a7a40ad145351495ca41223d4499d3ddbbd2c
+homepage="https://rrthomas.github.io/enchant/"
+changelog="https://raw.githubusercontent.com/rrthomas/enchant/refs/heads/master/NEWS"
+distfiles="https://github.com/rrthomas/enchant/releases/download/v${version}/enchant-${version}.tar.gz"
+checksum=8f19535adb5577b83b00e02f330fe9b9eb40dd21f19e2899636fc4d3a7696375
 make_check=no # tests broken
 
-enchant2-devel_package() {
-	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+libenchant2_package() {
+	depends="libglib-devel"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/enchant-2/*.a"
-		vmove "usr/lib/*.so"
+		vmove "usr/lib/libenchant-2.*"
 		vmove usr/lib/pkgconfig
 	}
 }
+
+enchant2-hunspell_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - hunspell provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_hunspell.so"
+	}
+}
+
+enchant2-aspell_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - aspell provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_aspell.so"
+	}
+}
+
+enchant2-nuspell_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - nuspell provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_nuspell.so"
+	}
+}
+
+enchant2-voikko_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - voikko provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_voikko.so"
+	}
+}
+
+enchant2-devel_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - transitional meta package"
+	build_style=meta
+}
diff --git a/srcpkgs/libenchant2 b/srcpkgs/libenchant2
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/libenchant2
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
@ 2025-01-10 20:15 ` icp1994
  2025-01-12 18:29 ` leahneukirchen
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: icp1994 @ 2025-01-10 20:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#issuecomment-2583968676

Comment:
This is somewhat of a moderate size refactor but the package doesn't have a maintainer to ping. @leahneukirchen if you are interested ...

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
  2025-01-10 20:15 ` icp1994
@ 2025-01-12 18:29 ` leahneukirchen
  2025-04-14  2:09 ` github-actions
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: leahneukirchen @ 2025-01-12 18:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#issuecomment-2585861134

Comment:
sgtm

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
  2025-01-10 20:15 ` icp1994
  2025-01-12 18:29 ` leahneukirchen
@ 2025-04-14  2:09 ` github-actions
  2025-04-18 18:55 ` [PR PATCH] [Updated] " icp1994
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2025-04-14  2:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#issuecomment-2800298771

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (2 preceding siblings ...)
  2025-04-14  2:09 ` github-actions
@ 2025-04-18 18:55 ` icp1994
  2025-05-24 16:50 ` [PR PATCH] [Merged]: " leahneukirchen
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: icp1994 @ 2025-04-18 18:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages enchant2
https://github.com/void-linux/void-packages/pull/53920

enchant2: update to 2.8.2.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/53920.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-enchant2-53920.patch --]
[-- Type: text/x-diff, Size: 4584 bytes --]

From 29abc85fbade524af6af63e31e0f9b8a37fe52c0 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 5 Nov 2024 12:42:00 +0530
Subject: [PATCH] enchant2: update to 2.8.2.

split respective bindings into separate subpackages
---
 srcpkgs/enchant2-aspell   |  1 +
 srcpkgs/enchant2-hunspell |  1 +
 srcpkgs/enchant2-nuspell  |  1 +
 srcpkgs/enchant2-voikko   |  1 +
 srcpkgs/enchant2/template | 59 ++++++++++++++++++++++++++++++---------
 srcpkgs/libenchant2       |  1 +
 6 files changed, 51 insertions(+), 13 deletions(-)
 create mode 120000 srcpkgs/enchant2-aspell
 create mode 120000 srcpkgs/enchant2-hunspell
 create mode 120000 srcpkgs/enchant2-nuspell
 create mode 120000 srcpkgs/enchant2-voikko
 create mode 120000 srcpkgs/libenchant2

diff --git a/srcpkgs/enchant2-aspell b/srcpkgs/enchant2-aspell
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-aspell
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2-hunspell b/srcpkgs/enchant2-hunspell
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-hunspell
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2-nuspell b/srcpkgs/enchant2-nuspell
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-nuspell
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2-voikko b/srcpkgs/enchant2-voikko
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/enchant2-voikko
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file
diff --git a/srcpkgs/enchant2/template b/srcpkgs/enchant2/template
index 11f1183c9947be..5e584ac87c2b04 100644
--- a/srcpkgs/enchant2/template
+++ b/srcpkgs/enchant2/template
@@ -1,31 +1,64 @@
 # Template file for 'enchant2'
 pkgname=enchant2
-version=2.6.4
+version=2.8.2
 revision=1
 build_style=gnu-configure
-# tests need --enable-relocatable
-configure_args="--enable-relocatable"
+configure_args="--disable-static"
 hostmakedepends="pkg-config groff"
-makedepends="libglib-devel hunspell-devel aspell-devel libvoikko-devel
- libnuspell-devel icu-devel"
-checkdepends="unittest-cpp"
+makedepends="libglib-devel hunspell-devel aspell-devel libnuspell-devel libvoikko-devel"
 short_desc="Generic spell checking library"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://rrthomas.github.io/enchant/"
-changelog="https://raw.githubusercontent.com/rrthomas/enchant/master/NEWS"
+changelog="https://raw.githubusercontent.com/rrthomas/enchant/refs/heads/master/NEWS"
 distfiles="https://github.com/rrthomas/enchant/releases/download/v${version}/enchant-${version}.tar.gz"
-checksum=833b4d5600dbe9ac867e543aac6a7a40ad145351495ca41223d4499d3ddbbd2c
+checksum=8f19535adb5577b83b00e02f330fe9b9eb40dd21f19e2899636fc4d3a7696375
 make_check=no # tests broken
 
-enchant2-devel_package() {
-	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+libenchant2_package() {
+	depends="libglib-devel"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/enchant-2/*.a"
-		vmove "usr/lib/*.so"
+		vmove "usr/lib/libenchant-2.*"
 		vmove usr/lib/pkgconfig
 	}
 }
+
+enchant2-hunspell_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - hunspell provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_hunspell.so"
+	}
+}
+
+enchant2-aspell_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - aspell provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_aspell.so"
+	}
+}
+
+enchant2-nuspell_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - nuspell provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_nuspell.so"
+	}
+}
+
+enchant2-voikko_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - voikko provider"
+	pkg_install() {
+		vmove "usr/lib/enchant-2/enchant_voikko.so"
+	}
+}
+
+enchant2-devel_package() {
+	depends="libenchant2>=${version}_${revision} ${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - transitional meta package"
+	build_style=meta
+}
diff --git a/srcpkgs/libenchant2 b/srcpkgs/libenchant2
new file mode 120000
index 00000000000000..de6f1dfe3aebb7
--- /dev/null
+++ b/srcpkgs/libenchant2
@@ -0,0 +1 @@
+enchant2
\ No newline at end of file

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Merged]: enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (3 preceding siblings ...)
  2025-04-18 18:55 ` [PR PATCH] [Updated] " icp1994
@ 2025-05-24 16:50 ` leahneukirchen
  2025-05-24 19:11 ` [PR REVIEW] " chrysos349
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: leahneukirchen @ 2025-05-24 16:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

There's a merged pull request on the void-packages repository

enchant2: update to 2.8.2.
https://github.com/void-linux/void-packages/pull/53920

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (4 preceding siblings ...)
  2025-05-24 16:50 ` [PR PATCH] [Merged]: " leahneukirchen
@ 2025-05-24 19:11 ` chrysos349
  2025-05-24 19:27 ` icp1994
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: chrysos349 @ 2025-05-24 19:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2105908564

Comment:
@icp1994, @leahneukirchen 

Why is `enchant2-devel` a transitional package now? Why was it approved?

Now the updated `libenchant2` pulls `libglib-devel` and other `-devel` packages I don't need in my system. It's not archlinux. `-devel ` stuff should be in a separate subpkg. I think you need to revert this change.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (5 preceding siblings ...)
  2025-05-24 19:11 ` [PR REVIEW] " chrysos349
@ 2025-05-24 19:27 ` icp1994
  2025-05-24 20:01 ` chrysos349
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: icp1994 @ 2025-05-24 19:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2105911364

Comment:
What is "updated `libenchant2`"? Previously there was only one `-devel` package which pulled in everything from `makedepends`. That was my motivation for this split since I did not want all the dependency tree of various providers when I only one one specific provider, enchant2-aspell.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (6 preceding siblings ...)
  2025-05-24 19:27 ` icp1994
@ 2025-05-24 20:01 ` chrysos349
  2025-05-24 20:02 ` chrysos349
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: chrysos349 @ 2025-05-24 20:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2105917722

Comment:
> What is "updated `libenchant2`"?

i meant the updated `enchant2`.

> since I did not want all the dependency tree of various providers

and then you created this bloated `libenchant2` pkg which includes both dynamic libs, and headers! at the very least separate them!

and why did you disable static libs? leave them be!

Here is the corrected template:

```sh
libenchant2_package() {
	depends="libglib-devel"
	short_desc+=" - development files"
	pkg_install() {
		vmove "usr/lib/libenchant-2.*"
	}
}

enchant2-devel_package() {
	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
	short_desc+=" - development files"
	pkg_install() {
		vmove usr/include
		vmove "usr/lib/*.a"
		vmove "usr/lib/enchant-2/*.a"
		vmove "usr/lib/*.so"
		vmove usr/lib/pkgconfig
	}
}
```

if you don't know what I'm talking about, please read here - https://github.com/void-linux/void-packages/blob/master/Manual.md#development-packages. Unfortunately, you clearly don't know this part of the manual.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (7 preceding siblings ...)
  2025-05-24 20:01 ` chrysos349
@ 2025-05-24 20:02 ` chrysos349
  2025-05-24 20:03 ` chrysos349
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: chrysos349 @ 2025-05-24 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2105917722

Comment:
> What is "updated `libenchant2`"?

i meant the updated `enchant2`.

> since I did not want all the dependency tree of various providers

and then you created this bloated `libenchant2` pkg which includes both dynamic libs, and headers! at the very least separate them!

and why did you disable static libs? leave them be!

Here is the corrected template:

```sh
libenchant2_package() {
	depends="libglib-devel"
	short_desc+=" - shared lib"
	pkg_install() {
		vmove "usr/lib/libenchant-2.*"
	}
}

enchant2-devel_package() {
	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
	short_desc+=" - development files"
	pkg_install() {
		vmove usr/include
		vmove "usr/lib/*.a"
		vmove "usr/lib/enchant-2/*.a"
		vmove "usr/lib/*.so"
		vmove usr/lib/pkgconfig
	}
}
```

if you don't know what I'm talking about, please read here - https://github.com/void-linux/void-packages/blob/master/Manual.md#development-packages. Unfortunately, you clearly don't know this part of the manual.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (8 preceding siblings ...)
  2025-05-24 20:02 ` chrysos349
@ 2025-05-24 20:03 ` chrysos349
  2025-05-24 20:15 ` leahneukirchen
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: chrysos349 @ 2025-05-24 20:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2105917722

Comment:
> What is "updated `libenchant2`"?

i meant the updated `enchant2`.

> since I did not want all the dependency tree of various providers

and then you created this bloated `libenchant2` pkg which includes both dynamic libs, and headers! at the very least separate them!

and why did you disable static libs? leave them be!

Here is the correct template:

```sh
libenchant2_package() {
	depends="libglib-devel"
	short_desc+=" - shared lib"
	pkg_install() {
		vmove "usr/lib/libenchant-2.*"
	}
}

enchant2-devel_package() {
	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
	short_desc+=" - development files"
	pkg_install() {
		vmove usr/include
		vmove "usr/lib/*.a"
		vmove "usr/lib/enchant-2/*.a"
		vmove "usr/lib/*.so"
		vmove usr/lib/pkgconfig
	}
}
```

if you don't know what I'm talking about, please read here - https://github.com/void-linux/void-packages/blob/master/Manual.md#development-packages. Unfortunately, you clearly don't know this part of the manual.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (9 preceding siblings ...)
  2025-05-24 20:03 ` chrysos349
@ 2025-05-24 20:15 ` leahneukirchen
  2025-05-24 20:48 ` leahneukirchen
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: leahneukirchen @ 2025-05-24 20:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2105919950

Comment:
@chrysos349 chill, you got your point across. i'll fix it later.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (10 preceding siblings ...)
  2025-05-24 20:15 ` leahneukirchen
@ 2025-05-24 20:48 ` leahneukirchen
  2025-05-25  7:13 ` icp1994
  2025-05-25 11:42 ` leahneukirchen
  13 siblings, 0 replies; 15+ messages in thread
From: leahneukirchen @ 2025-05-24 20:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2105924955

Comment:
fixed in af24ce37614

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (11 preceding siblings ...)
  2025-05-24 20:48 ` leahneukirchen
@ 2025-05-25  7:13 ` icp1994
  2025-05-25 11:42 ` leahneukirchen
  13 siblings, 0 replies; 15+ messages in thread
From: icp1994 @ 2025-05-25  7:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2106108896

Comment:
https://github.com/minad/jinx?tab=readme-ov-file#installation for Void should this still be `enchant2-devel` or just `enchant2`?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] enchant2: update to 2.8.2.
  2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
                   ` (12 preceding siblings ...)
  2025-05-25  7:13 ` icp1994
@ 2025-05-25 11:42 ` leahneukirchen
  13 siblings, 0 replies; 15+ messages in thread
From: leahneukirchen @ 2025-05-25 11:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/53920#discussion_r2106174859

Comment:
enchant2-devel, it needs the header file.

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2025-05-25 11:42 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-10 19:57 [PR PATCH] enchant2: update to 2.8.2 icp1994
2025-01-10 20:15 ` icp1994
2025-01-12 18:29 ` leahneukirchen
2025-04-14  2:09 ` github-actions
2025-04-18 18:55 ` [PR PATCH] [Updated] " icp1994
2025-05-24 16:50 ` [PR PATCH] [Merged]: " leahneukirchen
2025-05-24 19:11 ` [PR REVIEW] " chrysos349
2025-05-24 19:27 ` icp1994
2025-05-24 20:01 ` chrysos349
2025-05-24 20:02 ` chrysos349
2025-05-24 20:03 ` chrysos349
2025-05-24 20:15 ` leahneukirchen
2025-05-24 20:48 ` leahneukirchen
2025-05-25  7:13 ` icp1994
2025-05-25 11:42 ` leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).