[PR PATCH] tzutils: tzdata provides py3:tzdata

[PR PATCH] tzutils: tzdata provides py3:tzdata

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages py3-tzdata
https://github.com/void-linux/void-packages/pull/53607

tzutils: tzdata provides py3:tzdata
according to the [Python documentation][1], the `zoneinfo` module uses the system timezone data if available, and also provides an installable `tzdata` library on PyPi. Some Python packages (like pandas) spuriously always depend on this library. By having `tzdata` provide this py3: package, it would work around Python packages that make this mistake, and avoid needing to package `python3-tzdata` or set `noverifypydeps` (which would be overkill).

@sgn, this is your package, what do you think?

[1]: https://docs.python.org/3/library/zoneinfo.html

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**



A patch file from https://github.com/void-linux/void-packages/pull/53607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py3-tzdata-53607.patch --]
[-- Type: text/x-diff, Size: 1428 bytes --]

From 4e11a56dca91646f8dbfacb9f4e7e1f8a0c33b00 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Fri, 20 Dec 2024 22:47:26 -0500
Subject: [PATCH] tzutils: tzdata provides py3:tzdata

according to the Python documentation[1], the `zoneinfo` module uses the
system timezone data if available, and also provides an installable `tzdata`
library on PyPi. Some Python packages (like pandas) spuriously always
depend on this library. By having `tzdata` provide this py3: package,
it would work around Python packages that make this mistake, and avoid
needing to package `python3-tzdata` or set `noverifypydeps` (which would
be overkill).

[1]: https://docs.python.org/3/library/zoneinfo.html
---
 srcpkgs/tzutils/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/tzutils/template b/srcpkgs/tzutils/template
index 0f1c5e3009372c..08695ed42a350e 100644
--- a/srcpkgs/tzutils/template
+++ b/srcpkgs/tzutils/template
@@ -1,7 +1,7 @@
 # Template file for 'tzutils'
 pkgname=tzutils
 version=2024a
-revision=1
+revision=2
 bootstrap=yes
 short_desc="Time zone and daylight-saving time utilities"
 maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
@@ -52,6 +52,7 @@ do_install() {
 
 tzdata_package() {
 	short_desc="Time zone and daylight-saving time data"
+	provides="py3:tzdata-${version}"
 	pkg_install() {
 		vmove usr/share/man/man5
 		vmove "usr/share/zoneinfo*"

Re: tzutils: tzdata provides py3:tzdata

[sgn]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/53607#issuecomment-2557981472

Comment:
It doesn't matter anyway, since our python3-tzdata is almost empty and uses system zoneinfo.

Re: tzutils: tzdata provides py3:tzdata

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53607#issuecomment-2557981935

Comment:
oh, `python3-pytzdata`?

Re: tzutils: tzdata provides py3:tzdata

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53607#issuecomment-2557982108

Comment:
that's not the same thing as [tzdata](https://pypi.org/project/tzdata/) i think

Re: tzutils: tzdata provides py3:tzdata

[sgn]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/53607#issuecomment-2558085078

Comment:
Ah yes! Anyway, what is different between: `provides="python3-tzdata-${version}_1"` and `provides="py3:tzdata-${version}_1"`?

Re: tzutils: tzdata provides py3:tzdata

[sgn]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/53607#issuecomment-2558086116

Comment:
/me removes `pytzdata` too! https://github.com/void-linux/void-packages/pull/53609

Re: tzutils: tzdata provides py3:tzdata

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53607#issuecomment-2558115769

Comment:
> what is different between: `provides="python3-tzdata-${version}_1"` and `provides="py3:tzdata-${version}_1"`?

`py3:` will get used by the python dependency verification hook, but we could have it provide both

Re: [PR PATCH] [Updated] tzutils: tzdata provides py3:tzdata

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages py3-tzdata
https://github.com/void-linux/void-packages/pull/53607

tzutils: tzdata provides py3:tzdata
according to the [Python documentation][1], the `zoneinfo` module uses the system timezone data if available, and also provides an installable `tzdata` library on PyPi. Some Python packages (like pandas) spuriously always depend on this library. By having `tzdata` provide this py3: package, it would work around Python packages that make this mistake, and avoid needing to package `python3-tzdata` or set `noverifypydeps` (which would be overkill).

@sgn, this is your package, what do you think?

[1]: https://docs.python.org/3/library/zoneinfo.html

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**



A patch file from https://github.com/void-linux/void-packages/pull/53607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py3-tzdata-53607.patch --]
[-- Type: text/x-diff, Size: 1485 bytes --]

From a2252cdd491cad0b5e89d05ecc5f75b1b6ebdb68 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Fri, 20 Dec 2024 22:47:26 -0500
Subject: [PATCH] tzutils: tzdata provides python3-tzdata and py3:tzdata

according to the Python documentation[1], the `zoneinfo` module uses the
system timezone data if available, and also provides an installable `tzdata`
library on PyPi. Some Python packages (like pandas) spuriously always
depend on this library. By having `tzdata` provide this py3: package,
it would work around Python packages that make this mistake, and avoid
needing to package `python3-tzdata` or set `noverifypydeps` (which would
be overkill).

[1]: https://docs.python.org/3/library/zoneinfo.html
---
 srcpkgs/tzutils/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/tzutils/template b/srcpkgs/tzutils/template
index 0f1c5e3009372c..25b1bdbd0800ce 100644
--- a/srcpkgs/tzutils/template
+++ b/srcpkgs/tzutils/template
@@ -1,7 +1,7 @@
 # Template file for 'tzutils'
 pkgname=tzutils
 version=2024a
-revision=1
+revision=2
 bootstrap=yes
 short_desc="Time zone and daylight-saving time utilities"
 maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
@@ -52,6 +52,7 @@ do_install() {
 
 tzdata_package() {
 	short_desc="Time zone and daylight-saving time data"
+	provides="python3-tzdata-${version}_${revision} py3:tzdata-${version}"
 	pkg_install() {
 		vmove usr/share/man/man5
 		vmove "usr/share/zoneinfo*"

Re: [PR PATCH] [Updated] tzutils: tzdata provides py3:tzdata

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/classabbyamp/void-packages py3-tzdata
https://github.com/void-linux/void-packages/pull/53607

tzutils: tzdata provides py3:tzdata
according to the [Python documentation][1], the `zoneinfo` module uses the system timezone data if available, and also provides an installable `tzdata` library on PyPi. Some Python packages (like pandas) spuriously always depend on this library. By having `tzdata` provide this py3: package, it would work around Python packages that make this mistake, and avoid needing to package `python3-tzdata` or set `noverifypydeps` (which would be overkill).

@sgn, this is your package, what do you think?

[1]: https://docs.python.org/3/library/zoneinfo.html

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**



A patch file from https://github.com/void-linux/void-packages/pull/53607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py3-tzdata-53607.patch --]
[-- Type: text/x-diff, Size: 2738 bytes --]

From 52ee981f426f7a6cf33e55d9d5c578fb14ece94c Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Fri, 20 Dec 2024 22:47:26 -0500
Subject: [PATCH 1/2] tzutils: tzdata provides python3-tzdata and py3:tzdata

according to the Python documentation[1], the `zoneinfo` module uses the
system timezone data if available, and also provides an installable `tzdata`
library on PyPi. Some Python packages (like pandas) spuriously always
depend on this library. By having `tzdata` provide this py3: package,
it would work around Python packages that make this mistake, and avoid
needing to package `python3-tzdata` or set `noverifypydeps` (which would
be overkill).

[1]: https://docs.python.org/3/library/zoneinfo.html

Close: #53607
---
 srcpkgs/tzutils/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/tzutils/template b/srcpkgs/tzutils/template
index 0f1c5e3009372c..25b1bdbd0800ce 100644
--- a/srcpkgs/tzutils/template
+++ b/srcpkgs/tzutils/template
@@ -1,7 +1,7 @@
 # Template file for 'tzutils'
 pkgname=tzutils
 version=2024a
-revision=1
+revision=2
 bootstrap=yes
 short_desc="Time zone and daylight-saving time utilities"
 maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
@@ -52,6 +52,7 @@ do_install() {
 
 tzdata_package() {
 	short_desc="Time zone and daylight-saving time data"
+	provides="python3-tzdata-${version}_${revision} py3:tzdata-${version}"
 	pkg_install() {
 		vmove usr/share/man/man5
 		vmove "usr/share/zoneinfo*"

From 64774915e4994e2961a9a96b0406ef11a5b41d70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 23 Dec 2024 10:31:27 +0700
Subject: [PATCH 2/2] tzutils: ignore check_now

We don't care if 2 timezones provides same zoneinfo as of current time
being.
---
 srcpkgs/tzutils/patches/only-check-relevant.patch | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tzutils/patches/only-check-relevant.patch b/srcpkgs/tzutils/patches/only-check-relevant.patch
index d411f699d87169..3f0aadf08b25bc 100644
--- a/srcpkgs/tzutils/patches/only-check-relevant.patch
+++ b/srcpkgs/tzutils/patches/only-check-relevant.patch
@@ -1,8 +1,11 @@
 --- a/Makefile
 +++ b/Makefile
-@@ -827,7 +827,7 @@ check: check_back check_mild
+@@ -855,9 +855,9 @@ tzselect:	tzselect.ksh version
+ 
+ check: check_back check_mild
  check_mild:	check_character_set check_white_space check_links \
- 		  check_name_lengths check_now \
+-		  check_name_lengths check_now \
++		  check_name_lengths \
  		  check_slashed_abbrs check_sorted \
 -		  check_tables check_web check_ziguard check_zishrink check_tzs
 +		  check_tables check_ziguard check_zishrink check_tzs

Re: [PR PATCH] [Merged]: tzutils: tzdata provides py3:tzdata

[sgn]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

There's a merged pull request on the void-packages repository

tzutils: tzdata provides py3:tzdata
https://github.com/void-linux/void-packages/pull/53607

Description:
according to the [Python documentation][1], the `zoneinfo` module uses the system timezone data if available, and also provides an installable `tzdata` library on PyPi. Some Python packages (like pandas) spuriously always depend on this library. By having `tzdata` provide this py3: package, it would work around Python packages that make this mistake, and avoid needing to package `python3-tzdata` or set `noverifypydeps` (which would be overkill).

@sgn, this is your package, what do you think?

[1]: https://docs.python.org/3/library/zoneinfo.html

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

Re: tzutils: tzdata provides py3:tzdata

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/53607#issuecomment-2592918169

Comment:
this broke

```
./xbps-src show-build-deps python3-pandas
=> ERROR: python3-pandas-2.2.3_1: dependency 'python3-tzdata' does not exist!
```