[ISSUE] x2goserver doesn't recognize void as a supported operating system

[ISSUE] x2goserver doesn't recognize void as a supported operating system

[SirSputnikWiki]

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

New issue by SirSputnikWiki on void-packages repository

https://github.com/void-linux/void-packages/issues/54083

Description:
### Is this a new report?

Yes

### System Info

Void 6.1.114_2 x86_64 GenuineIntel/VM notuptodate F

### Package(s) Affected

x2goserver-4.1.0.6_1

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Starting an xsession that can be accessed remotely

### Actual behaviour

At lines 143 and 170-179 the /etc/x2go/Xsession script checks what operating system it's running on, and errors out if it's not one it recognizes. The check if fairly simple, and the server seems to run just fine if you satisfy the second condition by, for example, creating an empty file at /etc/gentoo-release. 

For comparison, the version of the package distributed by Alpine Linux (also not supported out of the box) patches in a check for /etc/alpine-release. Void should probably do something similar, otherwise this package doesn't work without pretending to be on a different distro.

https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/community/x2goserver/xsession-alpine-support.patch

### Steps to reproduce

1. Install x2goserver and a supported desktop environment.
2. Attempt to connect.
3. Observe the error message say 'Unknown operating system, XSession startup not implemented!'

Re: x2goserver doesn't recognize void as a supported operating system

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/54083#issuecomment-2612940898

Comment:
This shouldn't be fixed with a bunch of cheap patches and useless files, it should be fixed upstream by not making terrible assumptions about the distribution.

Re: x2goserver doesn't recognize void as a supported operating system

[SirSputnikWiki]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

New comment by SirSputnikWiki on void-packages repository

https://github.com/void-linux/void-packages/issues/54083#issuecomment-2613753610

Comment:
Hard disagree that this is an upstream problem. Sure, the code quality is not great here, but as far as upstream is concerned, what I've reported is the software working as intended. It's meant to work one way on Debian and Devuan, a slightly different way on other supported distros and error out elsewhere. Void is not one of those supported distros, so the fact that it errors out is not a bug. It does mean that the software, as packaged, doesn't work unless you resort to an undocumented hack.

Re: x2goserver doesn't recognize void as a supported operating system

[SirSputnikWiki]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

New comment by SirSputnikWiki on void-packages repository

https://github.com/void-linux/void-packages/issues/54083#issuecomment-2613753610

Comment:
Hard disagree that this is an upstream problem. Sure, the code quality is not great here, but as far as upstream is concerned, what I've reported is the software working as intended. It's meant to work one way on Debian and Devuan, a slightly different way on other supported distros and error out elsewhere. Void is not one of those supported distros, so the fact that it errors out is not a bug. It does mean that the software, as packaged, doesn't do anything useful unless you resort to an undocumented hack.

Re: x2goserver doesn't recognize void as a supported operating system

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/54083#issuecomment-2613754535

Comment:
The fact that they need distro-specific behaviour is a bug

Re: x2goserver doesn't recognize void as a supported operating system

[SirSputnikWiki]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New comment by SirSputnikWiki on void-packages repository

https://github.com/void-linux/void-packages/issues/54083#issuecomment-2613755745

Comment:
Not really. It's a design decision they made. Not a good one, but also not one they're likely change. The Alpine patch linked in the OP has been in place since 2017, and it's not like they don't know that Alpine is packaging they're software, the way the might not with Void.

Re: [ISSUE] [CLOSED] x2goserver doesn't recognize void as a supported operating system

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]

Closed issue by SirSputnikWiki on void-packages repository

https://github.com/void-linux/void-packages/issues/54083

Description:
### Is this a new report?

Yes

### System Info

Void 6.1.114_2 x86_64 GenuineIntel/VM notuptodate F

### Package(s) Affected

x2goserver-4.1.0.6_1

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Starting an xsession that can be accessed remotely

### Actual behaviour

At lines 143 and 170-179 the /etc/x2go/Xsession script checks what operating system it's running on, and errors out if it's not one it recognizes. The check if fairly simple, and the server seems to run just fine if you satisfy the second condition by, for example, creating an empty file at /etc/gentoo-release. 

For comparison, the version of the package distributed by Alpine Linux (also not supported out of the box) patches in a check for /etc/alpine-release. Void should probably do something similar, otherwise this package doesn't work without pretending to be on a different distro.

https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/community/x2goserver/xsession-alpine-support.patch

### Steps to reproduce

1. Install x2goserver and a supported desktop environment.
2. Attempt to connect.
3. Observe the error message say 'Unknown operating system, XSession startup not implemented!'

Re: x2goserver doesn't recognize void as a supported operating system

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/54083#issuecomment-2613770837

Comment:
You assert a lot about upstream intentions. If you're right, then the behavior you describe isn't a bug, but intended behavior. If you're wrong, then they should decide how to best broaden the scope of their distribution checks to achieve their intent.

The whole script is a horrible pile of hacks. We don't need to complicate things further with additional hacks that may or may not correctly address their intended behavior.

If masquerading as Gentoo gets the job done for you, I suggest you keep doing so until you can convince upstream to fix that script.