[PR PATCH] gst-plugins-bad1: enable build with nvcodec

[PR PATCH] gst-plugins-bad1: enable build with nvcodec

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

There is a new pull request by TorMFinn against master on the void-packages repository

https://github.com/TorMFinn/void-packages gstreamer_nvcodec
https://github.com/void-linux/void-packages/pull/54128

gst-plugins-bad1: enable build with nvcodec
This change adds the nv-codec-headers package as a build dependency to gst-plugins-bad1 enabling the build of the nvcodec plugins.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)



A patch file from https://github.com/void-linux/void-packages/pull/54128.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gstreamer_nvcodec-54128.patch --]
[-- Type: text/x-diff, Size: 1732 bytes --]

From cea9f48725674f530cba0d3b3d741c3b72171548 Mon Sep 17 00:00:00 2001
From: Tor Morten Finnesand <tmfinnesand@gmail.com>
Date: Mon, 27 Jan 2025 09:57:04 +0100
Subject: [PATCH] gst-plugins-bad1: enable build with nvcodec

---
 srcpkgs/gst-plugins-bad1/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gst-plugins-bad1/template b/srcpkgs/gst-plugins-bad1/template
index 8cbf2f4f541d51..975a5d81711bde 100644
--- a/srcpkgs/gst-plugins-bad1/template
+++ b/srcpkgs/gst-plugins-bad1/template
@@ -5,8 +5,8 @@ revision=1
 build_helper="gir"
 build_style=meson
 configure_args="-Dpackage-origin=https://voidlinux.org -Ddoc=disabled
- -Dopencv=disabled -Dmsdk=disabled -Dopensles=disabled -Dtinyalsa=disabled
- -Dwasapi=disabled -Dnvcodec=disabled -Ddc1394=disabled
+ -Dopencv=disabled -Dmsdk=disabled -Dopensles=disabled 
+ -Dtinyalsa=disabled -Dwasapi=disabled -Ddc1394=disabled
  -Diqa=disabled -Dlibde265=disabled -Dmpeg2enc=disabled
  -Dmplex=disabled -Dmusepack=disabled -Dopenexr=disabled
  -Dopenh264=disabled -Dopenmpt=disabled -Dopenni2=disabled -Dsctp=disabled
@@ -26,7 +26,7 @@ makedepends="alsa-lib-devel celt-devel openssl-devel exempi-devel
  libgudev-devel libusb-devel libaom-devel libbs2b-devel chromaprint-devel
  fdk-aac-devel flite-devel fluidsynth-devel liblrdf-devel ladspa-sdk
  lilv-devel lv2 libopenjpeg2-devel sbc-devel spandsp-devel vulkan-loader-devel
- webrtc-audio-processing-devel libzbar-devel ffmpeg6-devel
+ webrtc-audio-processing-devel libzbar-devel ffmpeg6-devel nv-codec-headers
  srt-devel libva-devel $(vopt_if onevpl oneVPL-devel) $(vopt_if gme libgme-devel)"
 depends="gst-plugins-base1>=${version}"
 short_desc="GStreamer plugins from the bad set (v1.x)"

Re: [PR PATCH] [Updated] gst-plugins-bad1: enable build with nvcodec

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

There is an updated pull request by TorMFinn against master on the void-packages repository

https://github.com/TorMFinn/void-packages gstreamer_nvcodec
https://github.com/void-linux/void-packages/pull/54128

gst-plugins-bad1: enable build with nvcodec
This change adds the nv-codec-headers package as a build dependency to gst-plugins-bad1 enabling the build of the nvcodec plugins.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)



A patch file from https://github.com/void-linux/void-packages/pull/54128.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gstreamer_nvcodec-54128.patch --]
[-- Type: text/x-diff, Size: 1831 bytes --]

From e55c3f100d92d6b5ddeb7bf0183e80e0e53c7cd8 Mon Sep 17 00:00:00 2001
From: Tor Morten Finnesand <tmfinnesand@gmail.com>
Date: Mon, 27 Jan 2025 09:57:04 +0100
Subject: [PATCH] gst-plugins-bad1: enable build with nvcodec

---
 srcpkgs/gst-plugins-bad1/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gst-plugins-bad1/template b/srcpkgs/gst-plugins-bad1/template
index 8cbf2f4f541d51..0595e3f01c80ef 100644
--- a/srcpkgs/gst-plugins-bad1/template
+++ b/srcpkgs/gst-plugins-bad1/template
@@ -1,12 +1,12 @@
 # Template file for 'gst-plugins-bad1'
 pkgname=gst-plugins-bad1
 version=1.24.10
-revision=1
+revision=2
 build_helper="gir"
 build_style=meson
 configure_args="-Dpackage-origin=https://voidlinux.org -Ddoc=disabled
- -Dopencv=disabled -Dmsdk=disabled -Dopensles=disabled -Dtinyalsa=disabled
- -Dwasapi=disabled -Dnvcodec=disabled -Ddc1394=disabled
+ -Dopencv=disabled -Dmsdk=disabled -Dopensles=disabled
+ -Dtinyalsa=disabled -Dwasapi=disabled -Ddc1394=disabled
  -Diqa=disabled -Dlibde265=disabled -Dmpeg2enc=disabled
  -Dmplex=disabled -Dmusepack=disabled -Dopenexr=disabled
  -Dopenh264=disabled -Dopenmpt=disabled -Dopenni2=disabled -Dsctp=disabled
@@ -26,7 +26,7 @@ makedepends="alsa-lib-devel celt-devel openssl-devel exempi-devel
  libgudev-devel libusb-devel libaom-devel libbs2b-devel chromaprint-devel
  fdk-aac-devel flite-devel fluidsynth-devel liblrdf-devel ladspa-sdk
  lilv-devel lv2 libopenjpeg2-devel sbc-devel spandsp-devel vulkan-loader-devel
- webrtc-audio-processing-devel libzbar-devel ffmpeg6-devel
+ webrtc-audio-processing-devel libzbar-devel ffmpeg6-devel nv-codec-headers
  srt-devel libva-devel $(vopt_if onevpl oneVPL-devel) $(vopt_if gme libgme-devel)"
 depends="gst-plugins-base1>=${version}"
 short_desc="GStreamer plugins from the bad set (v1.x)"

Re: gst-plugins-bad1: enable build with nvcodec

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2618389087

Comment:
Thanks! I have bumped the revision and fixed a trailing whitespace

Re: gst-plugins-bad1: enable build with nvcodec

[zlice]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2619985389

Comment:
fyi, update here https://github.com/void-linux/void-packages/pull/53936

Re: gst-plugins-bad1: enable build with nvcodec

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2621066542

Comment:
> fyi, update here #53936

Then I assume the correct way to merge this would be to wait till 1.24.11 gets merged and then rebase my branch?

Re: gst-plugins-bad1: enable build with nvcodec

[zlice]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2621557964

Comment:
just a heads up. similar thing happened with blender a bit back and theyre in limbo

Re: gst-plugins-bad1: enable build with nvcodec

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2621571465

Comment:
it's not in "limbo", both PRs had unaddressed feedback 

Re: [PR PATCH] [Merged]: gst-plugins-bad1: enable build with nvcodec

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

There's a merged pull request on the void-packages repository

gst-plugins-bad1: enable build with nvcodec
https://github.com/void-linux/void-packages/pull/54128

Description:
This change adds the nv-codec-headers package as a build dependency to gst-plugins-bad1 enabling the build of the nvcodec plugins.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Re: gst-plugins-bad1: enable build with nvcodec

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

New comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2668165051

Comment:
@classabbyamp I see this got merged, thanks! :) However something seems to have gone wrong. When I install the package from the official repository the plugin is still not available. The logs in this pull request shows that it is built and stripped but for some reason it is not in the repo yet even though the package I install is with the version and revision from this pull request.

If you check the build logs for x86_64 in this pull request on line 2686 it says:

> Stripped library: /usr/lib/gstreamer-1.0/libgstnvcodec.so

indicating that it did in fact get built as expected.

If we do `xbps-query -Rf gst-plugins-bad1` the package contents does not list libgstnvcodec.so
If I build this package locally the plugin is installed.

Re: gst-plugins-bad1: enable build with nvcodec

[zlice]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

New comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2668657440

Comment:
the last 2 revbumps have been `2`, which dropped the rev update from this

https://github.com/void-linux/void-packages/commit/000700b8d86fbfeb8a3d6d282c1fc7c9961b8195

https://github.com/void-linux/void-packages/commit/7e9cdec837ab17178a8971ce93ffa322819d6050


![revmissing](https://github.com/user-attachments/assets/73be795e-14f6-427b-9dc2-bd1fc1cfc774)

Re: gst-plugins-bad1: enable build with nvcodec

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2669107659

Comment:
0818f46e4b8b799184f21aba7f6bea27a46810e8

Re: gst-plugins-bad1: enable build with nvcodec

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/54128#issuecomment-2669616511

Comment:
Perfect! It's there now :)