[PR PATCH] ocaml: fix for i686-musl packaging

[PR PATCH] ocaml: fix for i686-musl packaging

[xeroxslayer]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

There is a new pull request by xeroxslayer against master on the void-packages repository

https://github.com/xeroxslayer/void-packages ocaml
https://github.com/void-linux/void-packages/pull/51793

ocaml: fix for i686-musl packaging
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64
  - i686-musl
  - i686
 
Can't crossbuild this package to other arches, only native building is supported, so I just tested these.


A patch file from https://github.com/void-linux/void-packages/pull/51793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ocaml-51793.patch --]
[-- Type: text/x-diff, Size: 827 bytes --]

From 18684efcc5677f75c55b1f3738c33af67f67e0db Mon Sep 17 00:00:00 2001
From: xeroxslayer <xeroxslayer@proton.me>
Date: Mon, 12 Aug 2024 10:27:18 +0200
Subject: [PATCH] ocaml: fix for i686-musl packaging

---
 srcpkgs/ocaml/template | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/srcpkgs/ocaml/template b/srcpkgs/ocaml/template
index 3dc3de418f4d70..b0224598fa41c7 100644
--- a/srcpkgs/ocaml/template
+++ b/srcpkgs/ocaml/template
@@ -14,6 +14,13 @@ distfiles="https://github.com/ocaml/ocaml/archive/refs/tags/${version}.tar.gz"
 checksum=48554abfd530fcdaa08f23f801b699e4f74c320ddf7d0bd56b0e8c24e55fc911
 nocross=yes
 
+case "${XBPS_TARGET_MACHINE}" in
+	i686-musl)
+		nopie_files="/usr/bin/ocamlrun /usr/bin/ocamlrund
+		 /usr/bin/ocamlruni /usr/bin/ocamlyacc"
+		;;
+esac
+
 export ASPP="cc -c"
 
 post_install() {

Re: ocaml: fix for i686-musl packaging

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/51793#issuecomment-2284295390

Comment:
Can you share the build log for i686-musl? There might be some config issue causing those files to be nopie.

Re: ocaml: fix for i686-musl packaging

[xeroxslayer]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/51793#issuecomment-2285686132

Comment:
OK, here they are, config and build.

[config+build.zip](https://github.com/user-attachments/files/16596698/config%2Bbuild.zip)

Re: ocaml: fix for i686-musl packaging

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/51793#issuecomment-2469435951

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: ocaml: fix for i686-musl packaging

[xeroxslayer]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/51793#issuecomment-2470565375

Comment:
Still relevant.

Re: ocaml: fix for i686-musl packaging

[xeroxslayer]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by xeroxslayer on void-packages repository

https://github.com/void-linux/void-packages/pull/51793#issuecomment-2624458577

Comment:
Bump.