Re: [PR PATCH] [Updated] xbps-src: improve update-check pattern for GitHub

[icp1994 <icp1994@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gh-update-check
https://github.com/void-linux/void-packages/pull/52894

xbps-src: improve update-check pattern for GitHub
#### Testing the changes
- I tested the changes in this PR: **YES**

This one catches tags of the form `<pkgname>-v<major>.<minor>.<patch>` which would get through the previous one. And possibly some other cursed patterns. But maybe there's some unintended side effects. I did check it against quite a few packages but GH sources are far too many to do an exhaustive testing.

A patch file from https://github.com/void-linux/void-packages/pull/52894.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gh-update-check-52894.patch --]
[-- Type: text/x-diff, Size: 1083 bytes --]

From e0e3a578f40057f2bba3449308bba58cdd33aee3 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 3 Nov 2024 12:32:47 +0530
Subject: [PATCH] xbps-src: improve update-check pattern for GitHub

---
 common/xbps-src/shutils/update_check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index e626b307b7c65f..7d971ba8744c0e 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -139,7 +139,7 @@ update_check() {
             *github.com*)
                 pkgurlname="$(printf %s "$url" | cut -d/ -f4,5)"
                 url="https://github.com/$pkgurlname/tags"
-                rx='/archive/refs/tags/(v?|\Q'"$pkgname"'\E[-_])?\K[\d.]+(?=\.tar\.gz")';;
+                rx='/archive/refs/tags/(\Q'"$pkgname"'\E|[-_v])*\K[\d.]+(?=\.tar\.gz")';;
             *//gitlab.*|*code.videolan.org*)
                 case "$url" in
                     */-/*) pkgurlname="$(printf %s "$url" | sed -e 's%/-/.*%%g; s%/$%%')";;