[PR PATCH] add manpage to the lsd package

[PR PATCH] add manpage to the lsd package

[bart9h]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is a new pull request by bart9h against master on the void-packages repository

https://github.com/bart9h/void-packages patch-1
https://github.com/void-linux/void-packages/pull/54229

add manpage to the lsd package
I noticed that the `lsd` tool was missing a manpage, so I edited the template file to use pandoc to generate a manpage from the doc/lsd.md that was already present in the sources.

A patch file from https://github.com/void-linux/void-packages/pull/54229.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-54229.patch --]
[-- Type: text/x-diff, Size: 1158 bytes --]

From 5314dce93dcfaef2b9c4c71e82fbf9e585c31904 Mon Sep 17 00:00:00 2001
From: Rodolfo Borges <rodolfo.borges@gmail.com>
Date: Wed, 5 Feb 2025 18:17:18 -0300
Subject: [PATCH] add manpage to the lsd package

I noticed that the `lsd` tool was missing a manpage, so I edited the template file to use pandoc to generate a manpage from the doc/lsd.md that was already present in the sources.
---
 srcpkgs/lsd/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/lsd/template b/srcpkgs/lsd/template
index 42edb68e8f0b86..df8cfb1bbc625c 100644
--- a/srcpkgs/lsd/template
+++ b/srcpkgs/lsd/template
@@ -3,7 +3,7 @@ pkgname=lsd
 version=1.1.5
 revision=1
 build_style=cargo
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config pandoc"
 makedepends="libgit2-devel"
 checkdepends="git"
 short_desc="Next gen ls command with lots of pretty colors and awesome icons"
@@ -24,8 +24,13 @@ fi
 
 export SHELL_COMPLETIONS_DIR="${wrksrc}"
 
+pre_configure() {
+	pandoc -s -f markdown-smart -t man doc/lsd.md -o lsd.1
+}
+
 post_install() {
 	vcompletion lsd.bash bash
 	vcompletion lsd.fish fish
 	vcompletion _lsd zsh
+	vman lsd.1
 }

Re: add manpage to the lsd package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/54229#issuecomment-2638287263

Comment:
commit message should be just `lsd: add manpage`, and the commit message body isn't necessary

Re: [PR REVIEW] add manpage to the lsd package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/54229#discussion_r1943835908

Comment:
revsion needs to be incremented so it will rebuild

Re: [PR REVIEW] add manpage to the lsd package

[bart9h]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New review comment by bart9h on void-packages repository

https://github.com/void-linux/void-packages/pull/54229#discussion_r1943893456

Comment:
I noticed that in the guidelines *after* I made the pull request. I know it is possible to add more commits to a PR, but could not find how in the github site.

Note: I am familiar with git, but not with github. I made the edit, commit and PR all via the github website.
Sorry for the inconvenience.

Re: [PR PATCH] [Updated] add manpage to the lsd package

[bart9h]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

There is an updated pull request by bart9h against master on the void-packages repository

https://github.com/bart9h/void-packages patch-1
https://github.com/void-linux/void-packages/pull/54229

add manpage to the lsd package
I noticed that the `lsd` tool was missing a manpage, so I edited the template file to use pandoc to generate a manpage from the doc/lsd.md that was already present in the sources.

A patch file from https://github.com/void-linux/void-packages/pull/54229.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-54229.patch --]
[-- Type: text/x-diff, Size: 1773 bytes --]

From 5314dce93dcfaef2b9c4c71e82fbf9e585c31904 Mon Sep 17 00:00:00 2001
From: Rodolfo Borges <rodolfo.borges@gmail.com>
Date: Wed, 5 Feb 2025 18:17:18 -0300
Subject: [PATCH 1/2] add manpage to the lsd package

I noticed that the `lsd` tool was missing a manpage, so I edited the template file to use pandoc to generate a manpage from the doc/lsd.md that was already present in the sources.
---
 srcpkgs/lsd/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/lsd/template b/srcpkgs/lsd/template
index 42edb68e8f0b86..df8cfb1bbc625c 100644
--- a/srcpkgs/lsd/template
+++ b/srcpkgs/lsd/template
@@ -3,7 +3,7 @@ pkgname=lsd
 version=1.1.5
 revision=1
 build_style=cargo
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config pandoc"
 makedepends="libgit2-devel"
 checkdepends="git"
 short_desc="Next gen ls command with lots of pretty colors and awesome icons"
@@ -24,8 +24,13 @@ fi
 
 export SHELL_COMPLETIONS_DIR="${wrksrc}"
 
+pre_configure() {
+	pandoc -s -f markdown-smart -t man doc/lsd.md -o lsd.1
+}
+
 post_install() {
 	vcompletion lsd.bash bash
 	vcompletion lsd.fish fish
 	vcompletion _lsd zsh
+	vman lsd.1
 }

From b61882cd2c7c3be662cebd26a366267dc03f28ea Mon Sep 17 00:00:00 2001
From: Rodolfo Borges <rodolfo.borges@gmail.com>
Date: Wed, 5 Feb 2025 22:19:53 -0300
Subject: [PATCH 2/2] revision update

---
 srcpkgs/lsd/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/lsd/template b/srcpkgs/lsd/template
index df8cfb1bbc625c..f450a870063231 100644
--- a/srcpkgs/lsd/template
+++ b/srcpkgs/lsd/template
@@ -1,7 +1,7 @@
 # Template file for 'lsd'
 pkgname=lsd
 version=1.1.5
-revision=1
+revision=2
 build_style=cargo
 hostmakedepends="pkg-config pandoc"
 makedepends="libgit2-devel"

Re: [PR REVIEW] add manpage to the lsd package

[bart9h]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New review comment by bart9h on void-packages repository

https://github.com/void-linux/void-packages/pull/54229#discussion_r1943893456

Comment:
I noticed that in the guidelines *after* I made the pull request. But I didn't know how to add a commit to an existing PR.

I just found out now. Sorry for the inconvenience.

Re: [PR REVIEW] add manpage to the lsd package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/54229#discussion_r1943946476

Comment:
you can do `git reset --soft HEAD~2` to get back to before your commits, then recommit with `git commit`

in the future, you can use `git commit --amend` to edit the message and contents of the commit

both of these actions require `git push --force` to update the PR

Re: [PR REVIEW] add manpage to the lsd package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/54229#discussion_r1943946476

Comment:
you can do `git reset --soft HEAD~2` to get back to before your commits, then recommit with `git commit`

in the future, you can use `git commit --amend` to edit the message and contents of the commit

both of these actions require `git push --force` to update the PR once done

Re: [PR PATCH] [Closed]: add manpage to the lsd package

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

There's a closed pull request on the void-packages repository

add manpage to the lsd package
https://github.com/void-linux/void-packages/pull/54229

Description:
I noticed that the `lsd` tool was missing a manpage, so I edited the template file to use pandoc to generate a manpage from the doc/lsd.md that was already present in the sources.

Re: add manpage to the lsd package

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/54229#issuecomment-2639502200

Comment:
Superseded by #54232, still, thank you for reporting and working on this