[PR PATCH] scid_vs_pc: update to 4.26

[PR PATCH] scid_vs_pc: update to 4.26

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

There is a new pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages scid_vs_pc-update
https://github.com/void-linux/void-packages/pull/54248

scid_vs_pc: update to 4.26
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/54248.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-scid_vs_pc-update-54248.patch --]
[-- Type: text/x-diff, Size: 1087 bytes --]

From ff489f24db3e1f67ec214fd4ee6e93d3787f650a Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Fri, 7 Feb 2025 20:02:26 +0100
Subject: [PATCH] scid_vs_pc: update to 4.26

---
 srcpkgs/scid_vs_pc/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/scid_vs_pc/template b/srcpkgs/scid_vs_pc/template
index 4551c49fe0b251..1b2cc9c26af280 100644
--- a/srcpkgs/scid_vs_pc/template
+++ b/srcpkgs/scid_vs_pc/template
@@ -1,6 +1,6 @@
 # Template file for 'scid_vs_pc'
 pkgname=scid_vs_pc
-version=4.23
+version=4.26
 revision=1
 build_style=configure
 hostmakedepends="tcl"
@@ -10,7 +10,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="http://scidvspc.sourceforge.net/"
 distfiles="${SOURCEFORGE_SITE}/scidvspc/source/scid_vs_pc-${version}.tgz"
-checksum=e182a4370adce21c579f5f93f4d56eec5c6e19c486bb893dc1f514ff2f070e89
+checksum=88ae21ed84bcf96da7af705b99a8b812bbedd185982a0910699e481fb43d1e41
 
 do_configure() {
 	./configure CC="${CC}" CXX="${CXX}" CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" \

Re: scid_vs_pc: update to 4.26

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/54248#issuecomment-2643813543

Comment:
Since version 4.24, upstream devs added "sanity checks for CC and CXX to configure".
The relevant code snippet is as follows in `configure`:
```sh
    if {[catch {exec /bin/sh -c "which $var(CC)"}]} {
      puts "\nC compiler \"$var(CC)\" not found/executable\n"
      exit 1
    }
    if {[catch {exec /bin/sh -c "which $var(CXX)"}]} {
      puts "\nC++ compiler \"$var(CXX)\" not found/executable\n"
      exit 1
    }
```
If anyone passes by, this fails if `which` isn’t installed, but what’s the best long-term solution here? 
Installing `which` with the template or creating a patch for `configure` ? Something else ?

Re: scid_vs_pc: update to 4.26

[Vinfall]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New comment by Vinfall on void-packages repository

https://github.com/void-linux/void-packages/pull/54248#issuecomment-2644444747

Comment:
I recall meeting which not installed issue on Debian (it's in debianutils) while in some shells (e.g. zsh) it is shell built-in command.

*Maybe* you can try replace it with `type` (which is shell built-in for bash, zsh and dash, which Void links `/bin/sh` against). But `which` is just a extra 42KB and required by `base-system`, I think either would just work fine.

Re: scid_vs_pc: update to 4.26

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/54248#issuecomment-2645864404

Comment:
just add which to hostmakedepends

Re: [PR PATCH] [Updated] scid_vs_pc: update to 4.26

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

There is an updated pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages scid_vs_pc-update
https://github.com/void-linux/void-packages/pull/54248

scid_vs_pc: update to 4.26
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/54248.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-scid_vs_pc-update-54248.patch --]
[-- Type: text/x-diff, Size: 1210 bytes --]

From 8fa56c1c953acb20f814504b94c5295cd27540fd Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Sat, 8 Feb 2025 19:09:31 +0100
Subject: [PATCH] scid_vs_pc: update to 4.26

---
 srcpkgs/scid_vs_pc/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/scid_vs_pc/template b/srcpkgs/scid_vs_pc/template
index 4551c49fe0b251..829543f968fe61 100644
--- a/srcpkgs/scid_vs_pc/template
+++ b/srcpkgs/scid_vs_pc/template
@@ -1,16 +1,16 @@
 # Template file for 'scid_vs_pc'
 pkgname=scid_vs_pc
-version=4.23
+version=4.26
 revision=1
 build_style=configure
-hostmakedepends="tcl"
+hostmakedepends="tcl which"
 makedepends="tk-devel"
 short_desc="Chess toolkit with extensive database, analysis and playing features"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="http://scidvspc.sourceforge.net/"
 distfiles="${SOURCEFORGE_SITE}/scidvspc/source/scid_vs_pc-${version}.tgz"
-checksum=e182a4370adce21c579f5f93f4d56eec5c6e19c486bb893dc1f514ff2f070e89
+checksum=88ae21ed84bcf96da7af705b99a8b812bbedd185982a0910699e481fb43d1e41
 
 do_configure() {
 	./configure CC="${CC}" CXX="${CXX}" CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" \

Re: scid_vs_pc: update to 4.26

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/54248#issuecomment-2645887765

Comment:
Thanks for the inputs. I followed classabbyamp's direction.

Re: [PR PATCH] [Merged]: scid_vs_pc: update to 4.26

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

There's a merged pull request on the void-packages repository

scid_vs_pc: update to 4.26
https://github.com/void-linux/void-packages/pull/54248

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64