Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: asusctl-6.0.11
@ 2024-08-11  9:46 hyperglue
  2024-08-11 10:05 ` [PR REVIEW] " classabbyamp
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: hyperglue @ 2024-08-11  9:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There is a new pull request by hyperglue against master on the void-packages repository

https://github.com/hyperglue/void-packages asusctl-v2
https://github.com/void-linux/void-packages/pull/51781

New package: asusctl-6.0.11
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture: x86_64

A patch file from https://github.com/void-linux/void-packages/pull/51781.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-asusctl-v2-51781.patch --]
[-- Type: text/x-diff, Size: 1998 bytes --]

From 452bef3d8b46c9313da5822d75d72d23b0fa2f65 Mon Sep 17 00:00:00 2001
From: hyperglue <hyperglue@autumnmail.org>
Date: Sun, 11 Aug 2024 13:40:33 +0200
Subject: [PATCH] New package: asusctl-6.0.11

---
 srcpkgs/asusctl/files/asusd/run |  3 +++
 srcpkgs/asusctl/template        | 30 ++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)
 create mode 100644 srcpkgs/asusctl/files/asusd/run
 create mode 100644 srcpkgs/asusctl/template

diff --git a/srcpkgs/asusctl/files/asusd/run b/srcpkgs/asusctl/files/asusd/run
new file mode 100644
index 00000000000000..94e48b1045c417
--- /dev/null
+++ b/srcpkgs/asusctl/files/asusd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+export IS_SERVICE=1
+exec asusd
diff --git a/srcpkgs/asusctl/template b/srcpkgs/asusctl/template
new file mode 100644
index 00000000000000..59369c3c234367
--- /dev/null
+++ b/srcpkgs/asusctl/template
@@ -0,0 +1,30 @@
+# Template file for 'asusctl'
+pkgname=asusctl
+version=6.0.11
+revision=1
+archs="x86_64* i686*" # fails to build on other archs, but this is utility for ROG laptops which are only x86_64
+build_style="gnu-makefile"
+hostmakedepends="cargo pkgconf clang"
+makedepends="eudev-libudev-devel gtk+3-devel pango-devel pangomm-devel gdk-pixbuf-devel cairo-devel glib-devel atkmm-devel freetype-devel expat-devel libseat-devel libinput-devel"
+depends="libayatana-appindicator"
+short_desc="ASUS ROG laptops control utilities"
+maintainer="hyperglue <hyperglue@autumnmail.org>"
+license="MPL-2.0"
+homepage="https://gitlab.com/asus-linux/asusctl"
+distfiles="https://gitlab.com/asus-linux/asusctl/-/archive/${version}/asusctl-${version}.tar.gz"
+checksum=a6249fd4429a9ee21407e2285ee0fbdbf44b9d3c5bd742988aba1bb3608c5ca4
+
+post_install() {
+	vsv asusd
+}
+
+asusctl-rog-gui_package() {
+	short_desc+=" - graphical interface"
+	depends="${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove /usr/share/applications
+		vmove /usr/share/icons
+		vmove /usr/share/rog-gui
+		vmove /usr/bin/rog-control-center
+	}
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
@ 2024-08-11 10:05 ` classabbyamp
  2024-08-11 10:05 ` classabbyamp
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2024-08-11 10:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51781#discussion_r1712952992

Comment:
use the cargo build style instead, probably

(you can do `make install-data` in post_install) 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
  2024-08-11 10:05 ` [PR REVIEW] " classabbyamp
@ 2024-08-11 10:05 ` classabbyamp
  2024-08-11 13:05 ` classabbyamp
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2024-08-11 10:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51781#discussion_r1712952925

Comment:
should this go on the gui package? 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
  2024-08-11 10:05 ` [PR REVIEW] " classabbyamp
  2024-08-11 10:05 ` classabbyamp
@ 2024-08-11 13:05 ` classabbyamp
  2024-11-10  2:01 ` github-actions
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2024-08-11 13:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51781#discussion_r1712983464

Comment:
wrap at ~80 chars

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
                   ` (2 preceding siblings ...)
  2024-08-11 13:05 ` classabbyamp
@ 2024-11-10  2:01 ` github-actions
  2024-11-10  2:16 ` hyperglue
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2024-11-10  2:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/51781#issuecomment-2466546127

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
                   ` (3 preceding siblings ...)
  2024-11-10  2:01 ` github-actions
@ 2024-11-10  2:16 ` hyperglue
  2024-11-10  3:47 ` classabbyamp
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 10+ messages in thread
From: hyperglue @ 2024-11-10  2:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by hyperglue on void-packages repository

https://github.com/void-linux/void-packages/pull/51781#issuecomment-2466550690

Comment:
bump

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
                   ` (4 preceding siblings ...)
  2024-11-10  2:16 ` hyperglue
@ 2024-11-10  3:47 ` classabbyamp
  2025-02-09  2:00 ` github-actions
  2025-02-23  2:04 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2024-11-10  3:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/51781#issuecomment-2466570234

Comment:
what's the point of bumping when you haven't responded to my review?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
                   ` (5 preceding siblings ...)
  2024-11-10  3:47 ` classabbyamp
@ 2025-02-09  2:00 ` github-actions
  2025-02-23  2:04 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2025-02-09  2:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/51781#issuecomment-2646024462

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: New package: asusctl-6.0.11
  2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
                   ` (6 preceding siblings ...)
  2025-02-09  2:00 ` github-actions
@ 2025-02-23  2:04 ` github-actions
  7 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2025-02-23  2:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

There's a closed pull request on the void-packages repository

New package: asusctl-6.0.11
https://github.com/void-linux/void-packages/pull/51781

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture: x86_64

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: asusctl-6.0.11
  2024-06-19 18:24 [PR PATCH] " hyperglue
@ 2024-06-20  2:29 ` abenson
  0 siblings, 0 replies; 10+ messages in thread
From: abenson @ 2024-06-20  2:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/50894#issuecomment-2179699490

Comment:
Please amend the email in the commit to use a real email. The one listed in the maintainer field is acceptable.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-02-23  2:04 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-11  9:46 [PR PATCH] New package: asusctl-6.0.11 hyperglue
2024-08-11 10:05 ` [PR REVIEW] " classabbyamp
2024-08-11 10:05 ` classabbyamp
2024-08-11 13:05 ` classabbyamp
2024-11-10  2:01 ` github-actions
2024-11-10  2:16 ` hyperglue
2024-11-10  3:47 ` classabbyamp
2025-02-09  2:00 ` github-actions
2025-02-23  2:04 ` [PR PATCH] [Closed]: " github-actions
  -- strict thread matches above, loose matches on Subject: below --
2024-06-19 18:24 [PR PATCH] " hyperglue
2024-06-20  2:29 ` abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).