Re: [PR PATCH] [Closed]: New package: bashdb-5.0+1.1.2

[github-actions [bot] <"github-actions [bot]"@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2902 bytes --]

There's a closed pull request on the void-packages repository

New package: bashdb-5.0+1.1.2
https://github.com/void-linux/void-packages/pull/53436

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl

#### Notes

- The upstream version is "5.0-1.1.2", but due to void's version naming rules not allowing for dashes, I changed the "-" to a "+"
- It is worth noting that the upstream is currently only released to support up to bash version 5.0, not including the current void-packages bash 5.2. However, bashdb still works just fine in bash 5.2, and this has not stopped other repos from packaging bashdb with patches applied to allow building for 5.2 (see `configure-bash-version.patch`). For instance, nixpkgs and gentoo are both on bash 5.2 and both package bashdb.
- Several other patches had to be made to get certain tests to pass, these seem benign and are likely due to version differences.
- There is a missing test in the packaged distribution (`test-file-with-spaces`), see https://sourceforge.net/p/bashdb/bugs/52. Gentoo deals with this by hosting the missing test files, and copying them in, see here: https://gitweb.gentoo.org/repo/gentoo.git/tree/app-shells/bashdb/bashdb-5.0.1.1.2.ebuild#n24. Personally I think it is fine to just skip this test, but I would be willing to add a similar fix to the gentoo one if it is deemed valuable. I'm unsure where to put the missing files exactly if I were to, add them via patches??
- A few unit tests are marked as failing, specifically `test_alias`, `test_cmd_info_variables`, and `test_get_source_line` Check still exits successfully without needing to disable these tests. I had spent some time trying to fix these but I gave up after some time. It is strange though because I can get them to pass if I run them individually (except `test_alias`), but some tests seem to depend on other tests running prior. That is, the results of each test are not idempotent of each other. I understand if this is unacceptable, but I'm reaching the extent of my ability to debug these.