Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: koi-0.5.1
@ 2025-04-28 17:20 arimelody
  2025-04-28 20:38 ` [PR REVIEW] " oreo639
                   ` (23 more replies)
  0 siblings, 24 replies; 25+ messages in thread
From: arimelody @ 2025-04-28 17:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

There is a new pull request by arimelody against master on the void-packages repository

https://github.com/arimelody/void-packages koi
https://github.com/void-linux/void-packages/pull/55206

New package: koi-0.5.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/55206.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-koi-55206.patch --]
[-- Type: text/x-diff, Size: 1154 bytes --]

From 63ffcb25260f99a961eabc1d76c6241eb36262a3 Mon Sep 17 00:00:00 2001
From: ari melody <ari@arimelody.me>
Date: Mon, 28 Apr 2025 18:11:56 +0100
Subject: [PATCH] new package: koi-0.5.1

---
 srcpkgs/koi/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/koi/template

diff --git a/srcpkgs/koi/template b/srcpkgs/koi/template
new file mode 100644
index 00000000000000..f4c7c4ec044104
--- /dev/null
+++ b/srcpkgs/koi/template
@@ -0,0 +1,13 @@
+# Template file for 'koi'
+pkgname=koi
+version=0.5.1
+revision=1
+build_style=cmake
+hostmakedepends="gcc cmake extra-cmake-modules qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
+depends="kf6-kcoreaddons kf6-kconfig kf6-kconfigwidgets kf6-kdbusaddons plasma-desktop plasma-integration plasma-workspace qt6-base qt6-core"
+short_desc="Automatic theme switcher for KDE Plasma"
+maintainer="ari melody <ari@arimelody.me>"
+license="LGPL-3.0"
+homepage="https://github.com/baduhai/Koi"
+distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
+checksum=af62bb621f78bd6c91872a1619e6829bbf3ea8b4b006da966445dba57edbb5d2

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
  2025-04-28 20:38 ` [PR REVIEW] " oreo639
@ 2025-04-28 20:38 ` oreo639
  2025-04-29 21:54 ` [PR PATCH] [Updated] " arimelody
                   ` (21 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-28 20:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2064558570

Comment:
gcc is an implicit hostmakedep (since the gcc that needs to be installed depends on if you are cross compiling)
cmake-bootstrap is added to hostmakedepends by `build_style=cmake` so you shouldn't need to add cmake to hostmakedepends.
In general, `-devel` packages should go in `makedepends`, not `hostmakedepends`.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
@ 2025-04-28 20:38 ` oreo639
  2025-04-28 20:38 ` oreo639
                   ` (22 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-28 20:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2064558771

Comment:
Depends don't need to be listed if they are pulled in though shlibs. (they get added automatically as needed)

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
  2025-04-28 20:38 ` [PR REVIEW] " oreo639
  2025-04-28 20:38 ` oreo639
@ 2025-04-29 21:54 ` arimelody
  2025-04-29 21:59 ` [PR REVIEW] " arimelody
                   ` (20 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-04-29 21:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

There is an updated pull request by arimelody against master on the void-packages repository

https://github.com/arimelody/void-packages koi
https://github.com/void-linux/void-packages/pull/55206

New package: koi-0.5.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/55206.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-koi-55206.patch --]
[-- Type: text/x-diff, Size: 2258 bytes --]

From 63ffcb25260f99a961eabc1d76c6241eb36262a3 Mon Sep 17 00:00:00 2001
From: ari melody <ari@arimelody.me>
Date: Mon, 28 Apr 2025 18:11:56 +0100
Subject: [PATCH 1/2] new package: koi-0.5.1

---
 srcpkgs/koi/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/koi/template

diff --git a/srcpkgs/koi/template b/srcpkgs/koi/template
new file mode 100644
index 00000000000000..f4c7c4ec044104
--- /dev/null
+++ b/srcpkgs/koi/template
@@ -0,0 +1,13 @@
+# Template file for 'koi'
+pkgname=koi
+version=0.5.1
+revision=1
+build_style=cmake
+hostmakedepends="gcc cmake extra-cmake-modules qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
+depends="kf6-kcoreaddons kf6-kconfig kf6-kconfigwidgets kf6-kdbusaddons plasma-desktop plasma-integration plasma-workspace qt6-base qt6-core"
+short_desc="Automatic theme switcher for KDE Plasma"
+maintainer="ari melody <ari@arimelody.me>"
+license="LGPL-3.0"
+homepage="https://github.com/baduhai/Koi"
+distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
+checksum=af62bb621f78bd6c91872a1619e6829bbf3ea8b4b006da966445dba57edbb5d2

From b0c385c19db75c2ff1b5f8dcfd8993cb6debce74 Mon Sep 17 00:00:00 2001
From: ari melody <ari@arimelody.me>
Date: Tue, 29 Apr 2025 22:54:18 +0100
Subject: [PATCH 2/2] koi: update makedepends and depends

---
 srcpkgs/koi/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/koi/template b/srcpkgs/koi/template
index f4c7c4ec044104..3b10e39181ff5c 100644
--- a/srcpkgs/koi/template
+++ b/srcpkgs/koi/template
@@ -3,8 +3,8 @@ pkgname=koi
 version=0.5.1
 revision=1
 build_style=cmake
-hostmakedepends="gcc cmake extra-cmake-modules qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
-depends="kf6-kcoreaddons kf6-kconfig kf6-kconfigwidgets kf6-kdbusaddons plasma-desktop plasma-integration plasma-workspace qt6-base qt6-core"
+makedepends="qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
+depends="kf6-kconfigwidgets kf6-kdbusaddons plasma-desktop plasma-integration plasma-workspace"
 short_desc="Automatic theme switcher for KDE Plasma"
 maintainer="ari melody <ari@arimelody.me>"
 license="LGPL-3.0"

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (2 preceding siblings ...)
  2025-04-29 21:54 ` [PR PATCH] [Updated] " arimelody
@ 2025-04-29 21:59 ` arimelody
  2025-04-29 21:59 ` arimelody
                   ` (19 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-04-29 21:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New review comment by arimelody on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067489802

Comment:
thanks for the tip! still getting familiar with the template format and got a little confused with the difference between `host` and `target`. re-reading the docs, i believe `target` at least refers to the system the package is ultimately installed to.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (3 preceding siblings ...)
  2025-04-29 21:59 ` [PR REVIEW] " arimelody
@ 2025-04-29 21:59 ` arimelody
  2025-04-29 22:57 ` oreo639
                   ` (18 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-04-29 21:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by arimelody on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067490153

Comment:
forgot about this- thanks!

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (4 preceding siblings ...)
  2025-04-29 21:59 ` arimelody
@ 2025-04-29 22:57 ` oreo639
  2025-04-29 23:00 ` oreo639
                   ` (17 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 22:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
`hostmakedepends` is the architecture you are cross compiling from.
`makedepends` is the architecture you are cross compiling to.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (5 preceding siblings ...)
  2025-04-29 22:57 ` oreo639
@ 2025-04-29 23:00 ` oreo639
  2025-04-29 23:00 ` oreo639
                   ` (16 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
`hostmakedepends` is the architecture you are cross compiling from.
`makedepends` is the architecture you are cross compiling to.

Executables that need to be run during the compile get installed through `hostmakedepends`, libraries get installed though `makedepends`

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (6 preceding siblings ...)
  2025-04-29 23:00 ` oreo639
@ 2025-04-29 23:00 ` oreo639
  2025-04-29 23:01 ` oreo639
                   ` (15 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
`hostmakedepends` is the architecture you are cross compiling from.
`makedepends` is the architecture you are cross compiling to.

Executables that need to be run during the compile get installed through `hostmakedepends`, libraries that get linked to get installed though `makedepends`

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (7 preceding siblings ...)
  2025-04-29 23:00 ` oreo639
@ 2025-04-29 23:01 ` oreo639
  2025-04-29 23:01 ` oreo639
                   ` (14 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#issuecomment-2840421954

Comment:
There should be on commit per package, btw: https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#review

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (8 preceding siblings ...)
  2025-04-29 23:01 ` oreo639
@ 2025-04-29 23:01 ` oreo639
  2025-04-29 23:03 ` [PR REVIEW] " oreo639
                   ` (13 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#issuecomment-2840421954

Comment:
There should be one commit per package, btw: https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#review

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (9 preceding siblings ...)
  2025-04-29 23:01 ` oreo639
@ 2025-04-29 23:03 ` oreo639
  2025-04-29 23:03 ` oreo639
                   ` (12 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
`hostmakedepends` is the architecture you are cross compiling from.
`makedepends` is the architecture you are cross compiling to.

Executables that need to be run during the compile get installed through `hostmakedepends`, libraries that get linked to get installed though `makedepends`

In this case, the libraries should be installed in `makedepends`, but the cmake files for those libraries depend on executables which are provided in the non-devel packages, like with the example template I linked.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (10 preceding siblings ...)
  2025-04-29 23:03 ` [PR REVIEW] " oreo639
@ 2025-04-29 23:03 ` oreo639
  2025-04-29 23:06 ` oreo639
                   ` (11 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
`hostmakedepends` is the architecture you are cross compiling from. (`-A <arch>`)
`makedepends` is the architecture you are cross compiling to. (`-a <arch>`)

Executables that need to be run during the compile get installed through `hostmakedepends`, libraries that get linked to get installed though `makedepends`

In this case, the libraries should be installed in `makedepends`, but the cmake files for those libraries depend on executables which are provided in the non-devel packages, like with the example template I linked.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (11 preceding siblings ...)
  2025-04-29 23:03 ` oreo639
@ 2025-04-29 23:06 ` oreo639
  2025-04-29 23:06 ` oreo639
                   ` (10 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
Yeah, in this case:
`hostmakedepends` is the architecture you are cross compiling from. (`-A <arch>`)
`makedepends` is the architecture you are cross compiling to. (`-a <arch>`)

Executables that need to be run during the compile get installed through `hostmakedepends`, libraries that get linked to should be installed though `makedepends`

In this case, the libraries should be installed in `makedepends`, but the cmake files for those libraries depend on executables which are provided in the non-devel packages, like with the example template I linked.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (12 preceding siblings ...)
  2025-04-29 23:06 ` oreo639
@ 2025-04-29 23:06 ` oreo639
  2025-04-29 23:09 ` [PR PATCH] [Updated] " arimelody
                   ` (9 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
Yeah, in this case:
`hostmakedepends` is the architecture you are cross compiling from. (`-A <arch>`)
`makedepends` is the architecture you are cross compiling to. (`-a <arch>`)

Executables that need to be run during the compile get installed through `hostmakedepends`, libraries that get linked to should be installed though `makedepends`

In this case, the libraries should be installed in `makedepends`, but the cmake files for those libraries depend on executables which are provided in the non-devel packages, you can see how that is handled in the example template I linked.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (13 preceding siblings ...)
  2025-04-29 23:06 ` oreo639
@ 2025-04-29 23:09 ` arimelody
  2025-04-29 23:10 ` arimelody
                   ` (8 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-04-29 23:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

There is an updated pull request by arimelody against master on the void-packages repository

https://github.com/arimelody/void-packages koi
https://github.com/void-linux/void-packages/pull/55206

New package: koi-0.5.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/55206.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-koi-55206.patch --]
[-- Type: text/x-diff, Size: 1074 bytes --]

From 1085ba7eaf4449c74ba101ec263d9e311d7a9084 Mon Sep 17 00:00:00 2001
From: ari melody <ari@arimelody.me>
Date: Wed, 30 Apr 2025 00:09:07 +0100
Subject: [PATCH] new package: koi-0.5.1

---
 srcpkgs/koi/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/koi/template

diff --git a/srcpkgs/koi/template b/srcpkgs/koi/template
new file mode 100644
index 00000000000000..3b10e39181ff5c
--- /dev/null
+++ b/srcpkgs/koi/template
@@ -0,0 +1,13 @@
+# Template file for 'koi'
+pkgname=koi
+version=0.5.1
+revision=1
+build_style=cmake
+makedepends="qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
+depends="kf6-kconfigwidgets kf6-kdbusaddons plasma-desktop plasma-integration plasma-workspace"
+short_desc="Automatic theme switcher for KDE Plasma"
+maintainer="ari melody <ari@arimelody.me>"
+license="LGPL-3.0"
+homepage="https://github.com/baduhai/Koi"
+distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
+checksum=af62bb621f78bd6c91872a1619e6829bbf3ea8b4b006da966445dba57edbb5d2

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (14 preceding siblings ...)
  2025-04-29 23:09 ` [PR PATCH] [Updated] " arimelody
@ 2025-04-29 23:10 ` arimelody
  2025-04-29 23:10 ` [PR REVIEW] " oreo639
                   ` (7 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-04-29 23:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by arimelody on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#issuecomment-2840432011

Comment:
commits should be squashed now :+1: 

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (15 preceding siblings ...)
  2025-04-29 23:10 ` arimelody
@ 2025-04-29 23:10 ` oreo639
  2025-04-29 23:17 ` oreo639
                   ` (6 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067554046

Comment:
Yeah, in this case:
`hostmakedepends` is the architecture you are cross compiling from. (`-A <arch>`)
`makedepends` is the architecture you are cross compiling to. (`-a <arch>`)

Executables that need to be run during the compile get installed through `hostmakedepends`, libraries that get linked to should be installed though `makedepends`

In this case, the libraries should be installed in `makedepends`, but the cmake files for those libraries depend on executables which are provided in the non-devel packages, you can see how that is handled in the example template I linked.

(e.g. `pkg-config`, `qt6-base`, and `qt6-tools` would be installed in hostmakedepends)

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (17 preceding siblings ...)
  2025-04-29 23:17 ` oreo639
@ 2025-04-29 23:17 ` oreo639
  2025-04-29 23:27 ` [PR PATCH] [Updated] " arimelody
                   ` (4 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067567100

Comment:
```suggestion
hostmakedepends="pkg-config qt6-base qt6-tools"
makedepends="qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
```

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR REVIEW] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (16 preceding siblings ...)
  2025-04-29 23:10 ` [PR REVIEW] " oreo639
@ 2025-04-29 23:17 ` oreo639
  2025-04-29 23:17 ` oreo639
                   ` (5 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: oreo639 @ 2025-04-29 23:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#discussion_r2067568189

Comment:
```suggestion
license="LGPL-3.0-only"
```

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (18 preceding siblings ...)
  2025-04-29 23:17 ` oreo639
@ 2025-04-29 23:27 ` arimelody
  2025-04-29 23:28 ` arimelody
                   ` (3 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-04-29 23:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

There is an updated pull request by arimelody against master on the void-packages repository

https://github.com/arimelody/void-packages koi
https://github.com/void-linux/void-packages/pull/55206

New package: koi-0.5.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/55206.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-koi-55206.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]

From 2ef4c0812bf9cdff28860f1229408ad8327a346d Mon Sep 17 00:00:00 2001
From: ari melody <ari@arimelody.me>
Date: Wed, 30 Apr 2025 00:09:07 +0100
Subject: [PATCH] new package: koi-0.5.1

---
 srcpkgs/koi/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/koi/template

diff --git a/srcpkgs/koi/template b/srcpkgs/koi/template
new file mode 100644
index 00000000000000..788a58595e7c73
--- /dev/null
+++ b/srcpkgs/koi/template
@@ -0,0 +1,14 @@
+# Template file for 'koi'
+pkgname=koi
+version=0.5.1
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt6-base"
+makedepends="qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
+depends="kf6-kconfigwidgets kf6-kdbusaddons plasma-desktop plasma-integration plasma-workspace"
+short_desc="Automatic theme switcher for KDE Plasma"
+maintainer="ari melody <ari@arimelody.me>"
+license="LGPL-3.0-only"
+homepage="https://github.com/baduhai/Koi"
+distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
+checksum=af62bb621f78bd6c91872a1619e6829bbf3ea8b4b006da966445dba57edbb5d2

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (19 preceding siblings ...)
  2025-04-29 23:27 ` [PR PATCH] [Updated] " arimelody
@ 2025-04-29 23:28 ` arimelody
  2025-05-05 23:45 ` arimelody
                   ` (2 subsequent siblings)
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-04-29 23:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by arimelody on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#issuecomment-2840452562

Comment:
actually tested an aarch64 build locally before pushing this one- should be okay now! :crossed_fingers: 

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (20 preceding siblings ...)
  2025-04-29 23:28 ` arimelody
@ 2025-05-05 23:45 ` arimelody
  2025-05-23  9:04 ` [PR PATCH] [Updated] " arimelody
  2025-05-26 12:47 ` [PR PATCH] [Closed]: " classabbyamp
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-05-05 23:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by arimelody on void-packages repository

https://github.com/void-linux/void-packages/pull/55206#issuecomment-2852717954

Comment:
checks seem to be passing! any chance we can merge this?

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Updated] New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (21 preceding siblings ...)
  2025-05-05 23:45 ` arimelody
@ 2025-05-23  9:04 ` arimelody
  2025-05-26 12:47 ` [PR PATCH] [Closed]: " classabbyamp
  23 siblings, 0 replies; 25+ messages in thread
From: arimelody @ 2025-05-23  9:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

There is an updated pull request by arimelody against master on the void-packages repository

https://github.com/arimelody/void-packages koi
https://github.com/void-linux/void-packages/pull/55206

New package: koi-0.5.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/55206.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-koi-55206.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]

From 2ef4c0812bf9cdff28860f1229408ad8327a346d Mon Sep 17 00:00:00 2001
From: ari melody <ari@arimelody.me>
Date: Wed, 30 Apr 2025 00:09:07 +0100
Subject: [PATCH] new package: koi-0.5.1

---
 srcpkgs/koi/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/koi/template

diff --git a/srcpkgs/koi/template b/srcpkgs/koi/template
new file mode 100644
index 00000000000000..788a58595e7c73
--- /dev/null
+++ b/srcpkgs/koi/template
@@ -0,0 +1,14 @@
+# Template file for 'koi'
+pkgname=koi
+version=0.5.1
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt6-base"
+makedepends="qt6-base-devel kf6-kcoreaddons-devel kf6-kconfig-devel kf6-kwidgetsaddons-devel"
+depends="kf6-kconfigwidgets kf6-kdbusaddons plasma-desktop plasma-integration plasma-workspace"
+short_desc="Automatic theme switcher for KDE Plasma"
+maintainer="ari melody <ari@arimelody.me>"
+license="LGPL-3.0-only"
+homepage="https://github.com/baduhai/Koi"
+distfiles="https://github.com/baduhai/Koi/archive/refs/tags/${version}.tar.gz"
+checksum=af62bb621f78bd6c91872a1619e6829bbf3ea8b4b006da966445dba57edbb5d2

^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [PR PATCH] [Closed]: New package: koi-0.5.1
  2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
                   ` (22 preceding siblings ...)
  2025-05-23  9:04 ` [PR PATCH] [Updated] " arimelody
@ 2025-05-26 12:47 ` classabbyamp
  23 siblings, 0 replies; 25+ messages in thread
From: classabbyamp @ 2025-05-26 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

There's a closed pull request on the void-packages repository

New package: koi-0.5.1
https://github.com/void-linux/void-packages/pull/55206

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2025-05-26 12:47 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-28 17:20 [PR PATCH] New package: koi-0.5.1 arimelody
2025-04-28 20:38 ` [PR REVIEW] " oreo639
2025-04-28 20:38 ` oreo639
2025-04-29 21:54 ` [PR PATCH] [Updated] " arimelody
2025-04-29 21:59 ` [PR REVIEW] " arimelody
2025-04-29 21:59 ` arimelody
2025-04-29 22:57 ` oreo639
2025-04-29 23:00 ` oreo639
2025-04-29 23:00 ` oreo639
2025-04-29 23:01 ` oreo639
2025-04-29 23:01 ` oreo639
2025-04-29 23:03 ` [PR REVIEW] " oreo639
2025-04-29 23:03 ` oreo639
2025-04-29 23:06 ` oreo639
2025-04-29 23:06 ` oreo639
2025-04-29 23:09 ` [PR PATCH] [Updated] " arimelody
2025-04-29 23:10 ` arimelody
2025-04-29 23:10 ` [PR REVIEW] " oreo639
2025-04-29 23:17 ` oreo639
2025-04-29 23:17 ` oreo639
2025-04-29 23:27 ` [PR PATCH] [Updated] " arimelody
2025-04-29 23:28 ` arimelody
2025-05-05 23:45 ` arimelody
2025-05-23  9:04 ` [PR PATCH] [Updated] " arimelody
2025-05-26 12:47 ` [PR PATCH] [Closed]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).